- 16 Jun, 2011 17 commits
-
-
Brad Fitzpatrick authored
Previously Request and Response had redundant fields for Referer, UserAgent, and cookies which caused confusion and bugs. It also didn't allow us to expand the package over time, since the way to access fields would be in the Headers one day and promoted to a field the next day. That would be hard to gofix, especially with code ranging over Headers. After a discussion on the mail package's design with a similar problem, we've designed to make the Headers be the source of truth and add accessors instead. Request: change: Referer -> Referer() change: UserAgent -> UserAgent() change: Cookie -> Cookies() new: Cookie(name) *Cookie new: AddCookie(*Cookie) Response: change: Cookie -> Cookies() Cookie: new: String() string R=rsc CC=golang-dev https://golang.org/cl/4620049
-
Volker Dobler authored
Attributes without value are commen in html and the xml parser will accept them in non-strict mode and use the attribute name as value. Thus parsing <p nowrap> as <p norwar="nowrap">. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4601053
-
Russ Cox authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/4589055
-
Brad Fitzpatrick authored
It was always a weird interface but I didn't know what I was doing at the time. rsc questioned me about it then but didn't press on it during review. Then adg bugged me about it too recently. So clean it up. It parallels the Writer struct too. R=golang-dev, r, rsc CC=golang-dev https://golang.org/cl/4602063
-
Russ Cox authored
Correct a few error messages (libcgo -> runtime/cgo) and delete old nacl_386.c file too. Fixes #1657. R=iant CC=golang-dev https://golang.org/cl/4603057
-
Rob Pike authored
I missed this before because I used the wrong regexp. What a moron. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4639041
-
Russ Cox authored
R=adg CC=golang-dev https://golang.org/cl/4638041
-
Russ Cox authored
R=adg CC=golang-dev https://golang.org/cl/4637042
-
Rob Pike authored
Communications op was listed as a binary; it isn't any more. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4637041
-
Russ Cox authored
R=adg, r CC=golang-dev https://golang.org/cl/4627042
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/4632041
-
Robert Griesemer authored
No impact on existing sources under src, misc. Fixes #1959. R=r, rsc, r CC=golang-dev https://golang.org/cl/4589056
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/4629042
-
Russ Cox authored
Avoids buggy version of egrep on some Macs. R=r, dsymonds CC=golang-dev https://golang.org/cl/4603056
-
Dave Cheney authored
See https://golang.org/cl/4572045/ R=adg, rsc CC=golang-dev https://golang.org/cl/4627041
-
Nigel Tao authored
R=r CC=golang-dev https://golang.org/cl/4622041
-
Yasuhiro Matsumoto authored
R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/4609047
-
- 15 Jun, 2011 11 commits
-
-
Russ Cox authored
I don't think we've discussed this API enough. ««« original CL description bike/shed: new package. It comes up often enough that it's time to provide the utility of a standard package. R=r, mirtchovski, adg, rsc, n13m3y3r, ality, go.peter.90, lstoakes, iant, jan.mercl, bsiegert, robert.hencke, rogpeppe, befelemepeseveze, kevlar CC=golang-dev https://golang.org/cl/4557047 »»» R=dsymonds, bradfitz, gri CC=golang-dev https://golang.org/cl/4576065
-
Robert Griesemer authored
of accesses via a FileSystem interface. Preparation for appengine version which gets its files via a snapshot or zip file and uses a corresponding FileSystem implementation. R=rsc, r CC=golang-dev https://golang.org/cl/4572065
-
Rob Pike authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/4609042
-
Rob Pike authored
Test output now looks like this: 2011/06/15 21:10:41 http: panic serving 127.0.0.1:59729: intentional death for testing $GOROOT/src/pkg/http/server.go:495 (0x3f9f8) _func_004: buf.Write(debug.Stack()) $GOROOT/src/pkg/runtime/proc.c:1041 (0x12367) panic: reflect·call(d->fn, d->args, d->siz); $GOROOT/src/pkg/http/serve_test.go:775 (0x5831b) _func_029: panic("intentional death for testing") $GOROOT/src/pkg/http/server.go:575 (0x26366) HandlerFunc.ServeHTTP: f(w, r) $GOROOT/src/pkg/http/server.go:541 (0x261a9) *conn.serve: c.handler.ServeHTTP(w, w.req) $GOROOT/src/pkg/runtime/proc.c:178 (0x10a83) goexit: runtime·goexit(void) with $GOROOT expanded, of course. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/4607051
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4576063
-
Scott Lawrence authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4572066
-
Dave Cheney authored
R=adg CC=golang-dev https://golang.org/cl/4584060
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/4620045
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/4613045
-
Andrew Gerrand authored
R=rsc, n13m3y3r, kevlar CC=golang-dev https://golang.org/cl/4515180
-
Yasuhiro Matsumoto authored
R=golang-dev, bradfitz, alex.brainman CC=golang-dev https://golang.org/cl/4601058
-
- 14 Jun, 2011 12 commits
-
-
David Symonds authored
R=rsc, gri CC=golang-dev https://golang.org/cl/4602062
-
Russ Cox authored
Still TODO: parsing optimizations make_perl_groups.pl is copied with minimal modifications (just to generate Go syntax instead of C++) from RE2. Google Inc is "The RE2 Author" of that file and is one of the Go Authors, so copyright changed to the Go Authors instead. R=sam.thorogood, r, fvbommel, robert.hencke CC=golang-dev https://golang.org/cl/4612041
-
Lucio De Re authored
The "elf.h" header changes involve only comments, the released Plan 9 C preprocessing function does not cope with multiline comments following the #define keyword. All multiline comments have been moved to the line above the associated definition. Sigh! Fixing the Plan 9 compiler is not an option. <time.h> does not exist in the Plan 9 Native library. I have moved it from src/cmd/ld/pe.h to include/u.h. RSC correctly points out that this copy of <u.h> is not the one used to compile the Go release on Plan 9 platforms. R=golang-dev CC=golang-dev, rsc https://golang.org/cl/4574042
-
Gustavo Niemeyer authored
Fixes the respective warning from elflint. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4607048
-
Gustavo Niemeyer authored
.o files are commonly found in default ignore lists by source management tools, including dpkg-source, bzr, etc. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4568078
-
Mikio Hara authored
Fixes #1942. R=fullung, rsc CC=golang-dev https://golang.org/cl/4602044
-
Jeff Hodges authored
The ptrace syscall remains gutted on darwin, but usable. This also makes the syscall addition process reproducible on darwin instead of relying on a file path in rsc's home directory. I've also removed an override of $PATH in env.bash that made tooling harder. R=rsc, dave, r CC=golang-dev https://golang.org/cl/4517147
-
Maxim Ushakov authored
R=kevlar, rsc CC=golang-dev https://golang.org/cl/4528114
-
Alex Brainman authored
R=golang-dev, mattn.jp CC=golang-dev https://golang.org/cl/4559062
-
William Chan authored
Create a new spdy.Error type that includes the enumerated error type and the associated stream id (0 if not associated with a specific stream). This will let users handle errors differently (RST_STREAM vs GOAWAY). R=bradfitz, rsc, rogpeppe CC=golang-dev https://golang.org/cl/4532131
-
Yuval Pavel Zholkover authored
Move mmapper from syscall.go to syscall_unix.go. Remove Sendfile from syscall_plan9.go. R=rsc, alex.brainman CC=golang-dev https://golang.org/cl/4368060
-
Mikio Hara authored
R=dave, rsc CC=golang-dev https://golang.org/cl/4589044
-