- 03 Dec, 2015 18 commits
-
-
Mohit Agarwal authored
Fix a typo in de5b3861; using `$ver` to determine linux major/minor versions would produce those for clang, use `$linuxver` instead. Updates #12898. Change-Id: I2c8e84ad02749fceaa958afd65e558bb0b08dddb Reviewed-on: https://go-review.googlesource.com/17323Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
Change-Id: I988d1b230ce516bf2997ec0932a854323b2bab7c Reviewed-on: https://go-review.googlesource.com/17395Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Austin Clements authored
This adds support for compressed ELF sections. This compression is treated as a framing issue and hence the package APIs all transparently decompress compressed sections. This requires some subtlety for (*Section).Open, which returns an io.ReadSeeker: since the decompressed data comes from an io.Reader, this commit introduces a Reader-to-ReadSeeker adapter that is efficient for common uses of Seek and does what it can otherwise. Fixes #11773. Change-Id: Ic0cb7255a85cadf4c1d15fb563d5a2e89dbd3c36 Reviewed-on: https://go-review.googlesource.com/17341Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Austin Clements <austin@google.com>
-
Austin Clements authored
GCC and LLVM support zlib-compressing DWARF debug sections (and there's some evidence that this may be happening by default in some circumstances now). Add support for reading compressed DWARF sections. Since ELF relocations apply to the decompressed data, decompression is done before applying relocations. Since relcations are applied by debug/elf, decompression must also be handled there. Note that this is different from compressed ELF sections, which is a more general mechanism used by very recent versions of GCC. Updates #11773. Change-Id: I3f4bf1b04d0802cc1e8fcb7c2a5fcf6c467c5089 Reviewed-on: https://go-review.googlesource.com/17340Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Russ Cox authored
Until now we've used ErrUnknownAlgorithm but that's a bit confusing when it is returned for obviously-known things like MD5. Fixes #10431. Change-Id: Ief8a8ef46e5b99bd4fd18e1acd7ae398a484bac3 Reviewed-on: https://go-review.googlesource.com/17380Reviewed-by: Adam Langley <agl@golang.org>
-
Brad Fitzpatrick authored
Fixes #12705 Change-Id: I69639d2b03777835b2697ff349a00ccab410aa49 Reviewed-on: https://go-review.googlesource.com/17318Reviewed-by: Burcu Dogan <jbd@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Benjamin Prosnitz authored
Change-Id: I17ef4e221e5cd0fb8dc553785248ccac59380c6f Reviewed-on: https://go-review.googlesource.com/17321Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
It was reverted. Change-Id: Ie30d8df9f2e5b14ff823fe81f5e538ee47064662 Reviewed-on: https://go-review.googlesource.com/17317Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Volker Dobler authored
The flags are used in OpenFile, not Open. Change-Id: I45c1639e36694529cb29c2b580c43a22e6fd10ac Reviewed-on: https://go-review.googlesource.com/17352Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
Fixes #12972. Change-Id: Id0611667e6149753c351c0c5e01211340a87d3fd Reviewed-on: https://go-review.googlesource.com/17230Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Russ Cox authored
These are simply incompatible. Clang fixed the bug but not in older versions. Fixes #12898. Change-Id: I74a3fd9134dadab6d0f074f8fd09e00d64558d7a Reviewed-on: https://go-review.googlesource.com/17254Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Russ Cox authored
Followup to CL 16047. For #12963. Change-Id: I596cd5109b25a4079b966427411860fde8b9b54a Reviewed-on: https://go-review.googlesource.com/17232Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Austin Clements authored
stackBarrier on amd64 sanity checks that it's unwinding the correct entry in the stack barrier array. However, this check is wrong in two ways that make it unlikely to catch anything, right or wrong: 1) It checks that savedLRPtr == SP, but, in fact, it should be that savedLRPtr+8 == SP because the RET that returned to stackBarrier popped the saved LR. However, we didn't notice this check was wrong because, 2) the sense of the conditional branch is also wrong. Fix both of these. Change-Id: I38ba1f652b0168b5b2c11b81637656241262af7c Reviewed-on: https://go-review.googlesource.com/17039Reviewed-by: Russ Cox <rsc@golang.org>
-
Shenghou Ma authored
Change-Id: Icce28fc4937cc73c0712c054161222f034381c2f Reviewed-on: https://go-review.googlesource.com/16876Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Austin Clements <austin@google.com>
-
Alex Brainman authored
This CL also changes windows LookupSRV to return _xmpp-server._tcp.google.com. as cname instead of google.com similar to linux. Otherwise TestLookupDots still fails. Updates #12193 (with plan9 still to do) Change-Id: Id225e15bee95037cdb4226803506cce690c5d341 Reviewed-on: https://go-review.googlesource.com/13887 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Rahul Chaudhry authored
From Android release M (Marshmallow), hard linking files is blocked and an attempt to call link() on a file will return EACCES. - https://code.google.com/p/android-developer-preview/issues/detail?id=3150 Change-Id: Ifdadaa31e3d5ee330553f45db6c001897dc955be Reviewed-on: https://go-review.googlesource.com/17339Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Chris Broadfoot authored
Change-Id: I6bee207db7485f96a499f51b2d1346c35e086d41 Reviewed-on: https://go-review.googlesource.com/17337Reviewed-by: Russ Cox <rsc@golang.org>
-
Chris Broadfoot authored
Change-Id: Ib6a9e131113523e6b1e5b7604480028b9ffbfa93 Reviewed-on: https://go-review.googlesource.com/17178Reviewed-by: Andrew Gerrand <adg@golang.org>
-
- 02 Dec, 2015 17 commits
-
-
Alexandre Cesaro authored
Add the test index so it is easier to find which test case failed. Change-Id: Ic04682651b26b137355950ff0c51bdbdb1d85a9c Reviewed-on: https://go-review.googlesource.com/17351Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Rahul Chaudhry authored
Also, enable test misc/cgo/testcshared for android/arm64. c/17245 and c/17246 provide the missing pieces for making this test work. "androidtest.bash" now passes on a Nexus 9 (volantis) device running Android build "LMY48T". Change-Id: Icb9fd2d17d97e0f04cb18d0cd91640c80fbd3fb4 Reviewed-on: https://go-review.googlesource.com/17333Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Rahul Chaudhry authored
On android, runtime.tls_g is a normal variable. TLS offset is computed in x_cgo_inittls. Change-Id: I18bc9a736d5fb2a89d0f798956c754e3c10d10e2 Reviewed-on: https://go-review.googlesource.com/17246Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Rahul Chaudhry authored
On android, runtime.tls_g is a normal variable. TLS offset is computed in x_cgo_inittls. Change-Id: I64cfd3543040776dcdf73cad8dba54fc6aaf6f35 Reviewed-on: https://go-review.googlesource.com/17245Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Michael Hudson-Doyle authored
runtime.stackBarrier is a strange function: it is only ever "called" by smashing its address into a LR slot on the stack. Calling it like this certainly does not adhere to the rule that r12 is set to the global entry point before calling it and the prologue instrutions that compute r2 from r12 in fact just corrupt r2, which is bad because the function that stackBarrier returns to probably uses r2 to access global data. Fortunately stackBarrier itself does not access any global data and so does not depend on the value of r2, meaning we can ignore the ABI rules and simply skip inserting the prologue instructions into this specific function. Fixes 64bit.go, append.go and fixedbugs/issue13169.go from "cd test; go run run.go -linkshared". Change-Id: I606864133a83935899398e2d42edd08a946aab24 Reviewed-on: https://go-review.googlesource.com/17281Reviewed-by: Austin Clements <austin@google.com>
-
Ian Lance Taylor authored
Fixes #13423. Change-Id: I41bb45790cca36c57a107796f0eca61287acb2a9 Reviewed-on: https://go-review.googlesource.com/17332 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Håvard Haugen authored
Move test for isblank into addmethod so that most of the type checking for methods is also performed for blank methods. Fixes #11366. Change-Id: I13d554723bf96d906d0b3ff390d7b7c87c1a5020 Reviewed-on: https://go-review.googlesource.com/16866Reviewed-by: Robert Griesemer <gri@golang.org>
-
INADA Naoki authored
Long lived connections may make some DB operation difficult. (e.g. retiring load balanced DB server.) So SetConnMaxLifetime closes long lived connections. It can be used to limit maximum idle time, too. Closing idle connections reduces active connections while application is idle and avoids connections are closed by server side (cause errBadConn while querying). fixes #9851 Change-Id: I2e8e824219c1bee7f4b885d38ed96d11b7202b56 Reviewed-on: https://go-review.googlesource.com/6580 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Alexandre Cesaro authored
When the name of an Address contains non-ASCII characters, Address.String() used mime.QEncoding to encode the name. However certain characters are forbidden when an encoded-word is in a phrase context (see RFC 2047 section 5.3) and these characters are not encoded by mime.QEncoding. In this case we now use mime.BEncoding (base64 encoding) so that forbidden characters are also encoded. Fixes #11292 Change-Id: I52db98b41ece439295e97d7e94c8190426f499c2 Reviewed-on: https://go-review.googlesource.com/16012Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
The old code was assuming that a PT_NOTE segment never had more than one note, but there is no such requirement. Fixes #13364. Change-Id: I3f6b3716130bf7af6abe81b8e10571a8c7cd943c Reviewed-on: https://go-review.googlesource.com/17331 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Joe Tsai authored
Commit 7a1fb95d strips non-free license from Mark.Twain-Tom.Sawyer.txt, but forgot to remove it from the compressed version of the file. Update #13216 Change-Id: I60f53275d56ba5baa6898db47b1d41f85e985c00 Reviewed-on: https://go-review.googlesource.com/17264Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Joe Tsai authored
Motivation for change: * Recursive logic is hard to follow, since it tends to apply things in reverse. On the other hand, the tar formats tend to describe meta headers as affecting the next entry. * Recursion also applies changes in the wrong order. Two test files are attached that use multiple headers. The previous Go behavior differs from what GNU and BSD tar do. Change-Id: Ic1557256fc1363c5cb26570e5d0b9f65a9e57341 Reviewed-on: https://go-review.googlesource.com/14624 Run-TryBot: Joe Tsai <joetsai@digital-static.net> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
This mirrors the same behavior and API from the server code to the client side: if TLSNextProto is nil, HTTP/2 is on by default for both. If it's non-nil, the user was trying to do something fancy and step out of their way. Updates #6891 Change-Id: Ia31808b71f336a8d5b44b985591d72113429e1d4 Reviewed-on: https://go-review.googlesource.com/17300Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
The existing code has partial support for -07 (just the hours of a time zone offset). Complete the support, add support for Z07, and add a few tests. Fixes #13426. Change-Id: Ic6377bbf3e65b4bb761b9779f7e80c07ce4f57e8 Reviewed-on: https://go-review.googlesource.com/17260Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Joe Tsai authored
Motivations for this change: * It allows these functions to be used outside of Reader/Writer. * It allows these functions to be more easily unit tested. Change-Id: Iebe2b70bdb8744371c9ffa87c24316cbbf025b59 Reviewed-on: https://go-review.googlesource.com/15113Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Joe Tsai <joetsai@digital-static.net> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Ingo Oeser authored
Fixes #12492 Change-Id: I8bb512027639301e2f2c41aab84e6d06ae88b137 Reviewed-on: https://go-review.googlesource.com/14312Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Benjamin Prosnitz authored
Fixes #13090 Change-Id: I5612d792dabdff89bd0cec57dc2cacf9be7ebf64 Reviewed-on: https://go-review.googlesource.com/16341 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 01 Dec, 2015 5 commits
-
-
Russ Cox authored
Fixes #13011. Change-Id: Ia4c67880fca83f4298ff6bb1b217ec26c8c83427 Reviewed-on: https://go-review.googlesource.com/17231Reviewed-by: David Crawshaw <crawshaw@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
It's not a group: must handle the inside as a sequence of literal chars, not a single literal string. That is, \Qab\E+ is the same as ab+, not (ab)+. Fixes #11187. Change-Id: I5406d05ccf7efff3a7f15395bdb0cfb2bd23a8ed Reviewed-on: https://go-review.googlesource.com/17233Reviewed-by: David Crawshaw <crawshaw@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Carlos Cirello authored
Change-Id: I5be18b68602a7ebb740cf05924236ce17e386e55 Reviewed-on: https://go-review.googlesource.com/17295 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
Fixes #13108. Change-Id: I474cc2a3b7ced1c9eb978fc815f9c6bae9fb3ecc Reviewed-on: https://go-review.googlesource.com/17235Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Blake Gentry authored
If we try to reuse a connection that the server is in the process of closing, we may end up successfully writing out our request (or a portion of our request) only to find a connection error when we try to read from (or finish writing to) the socket. This manifests as an EOF returned from the Transport's RoundTrip. The issue, among others, is described in #4677. This change follows some of the Chromium guidelines for retrying idempotent requests only when the connection has been already been used successfully and no header data has yet been received for the response. As part of this change, an unexported error was defined for errMissingHost, which was previously defined inline. errMissingHost is the only non-network error returned from a Request's Write() method. Additionally, this breaks TestLinuxSendfile because its test server explicitly triggers the type of scenario this change is meant to retry on. Because that test server stops accepting conns on the test listener before the retry, the test would time out. To fix this, the test was altered to use a non-idempotent test type (POST). Change-Id: I1ca630b944f0ed7ec1d3d46056a50fb959481a16 Reviewed-on: https://go-review.googlesource.com/3210Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-