- 21 Jul, 2015 9 commits
-
-
Ian Lance Taylor authored
That test will install cmd/pack for linux_386; we don't want to change GOROOT in short mode. Change-Id: I4b00c578a99779a13c558208bfd4115f8f0513fa Reviewed-on: https://go-review.googlesource.com/12481 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ingo Krabbe authored
Change-Id: I87fa25214fbf24469148a63f4e1e61e261105c16 Reviewed-on: https://go-review.googlesource.com/12470 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Fixes #10607. Change-Id: Ib294cf65b07103b60f62b86b21ff2d07b25136fe Reviewed-on: https://go-review.googlesource.com/12242Reviewed-by:
Russ Cox <rsc@golang.org>
-
Brad Fitzpatrick authored
Change-Id: I2f855b9ad1676b3c4efedd764ce99e21c104a4ec Reviewed-on: https://go-review.googlesource.com/12446Reviewed-by:
Rob Pike <r@golang.org>
-
Paul Marks authored
Change-Id: Ie02426b2b726170d858de96fdd8c51bfdf20d7dc Reviewed-on: https://go-review.googlesource.com/12376Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #11752 Change-Id: If4196b4bbba4f1485608bfafa98fa54781177273 Reviewed-on: https://go-review.googlesource.com/12325Reviewed-by:
Andrew Gerrand <adg@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #11781 Change-Id: Idc46a6a4fb5bf1c4d394eadf2d860d7ef75c8ccf Reviewed-on: https://go-review.googlesource.com/12390Reviewed-by:
-
Alex Brainman authored
Fixes #11147 Change-Id: Ib31160946a53f6f9b11daea211ff04d186b51b3f Reviewed-on: https://go-review.googlesource.com/12067Reviewed-by:
-
Matthew Dempsky authored
Fixes #11762. Change-Id: I0c7797a2dfdbbcf137bb287f854037a4a697c6e4 Reviewed-on: https://go-review.googlesource.com/12443Reviewed-by:
Robert Griesemer <gri@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com>
-
- 20 Jul, 2015 10 commits
-
-
Brad Fitzpatrick authored
Change-Id: If1c12b43ef467c3ef2cbbaaba1bda4ea98032c7e Reviewed-on: https://go-review.googlesource.com/12430Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I805bb7ba40c8ed579c4ca796e408995586d219b3 Reviewed-on: https://go-review.googlesource.com/12434Reviewed-by:
-
Robert Griesemer authored
Fixes #11800. Change-Id: I5eb178331f4ae80821f188e19c0c6fadeb330278 Reviewed-on: https://go-review.googlesource.com/12433Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Ian Lance Taylor authored
The cmd/go tests run too long on a Raspberry Pi. I've cut times as much as I can see without more serious steps like not running tests. Fixes #11779. Change-Id: Ice5da052902decea2e6ac32d0f2ce084c39ea1ab Reviewed-on: https://go-review.googlesource.com/12368 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
The errors package is smaller and builds faster. Update #11779. Change-Id: Iaf2d43734ec4b0aa325590eb5d38522306b608cb Reviewed-on: https://go-review.googlesource.com/12366Reviewed-by:
-
Ian Lance Taylor authored
Speed up the test suite by building the errors package rather than the strings package in some cases where the specific package we are building doesn't matter. The errors package is smaller, and doesn't have any assembler code. Also make a couple of tests run in parallel. Update #11779. Change-Id: I62e47f8655f9d85bf93c70ae6e6121276d96aee0 Reviewed-on: https://go-review.googlesource.com/12365 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
It changes GOROOT, so we shouldn't run it in short mode. Also, it's fairly slow. Update #11779. Change-Id: I3d3344954cf9b2ac70070c878a67cb65ac8fd85c Reviewed-on: https://go-review.googlesource.com/12364 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
On my laptop reduces time required for test from 22 seconds to 0.14 seconds. Update #11779. Change-Id: I715d85bd9c6f7683c6915eedd2539813aa5efc58 Reviewed-on: https://go-review.googlesource.com/12363Reviewed-by:
-
Michael Hudson-Doyle authored
This is mostly Russ's https://golang.org/cl/12145 but with some extra fixes to account for the fact that function declarations without implementations now break shared libraries, and including my test case. Fixes #11480. Change-Id: Iabdc2934a0378e5025e4e7affadb535eaef2c8f1 Reviewed-on: https://go-review.googlesource.com/12340Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I6a8bb853a538c80d95589321d3226784bc017eef Reviewed-on: https://go-review.googlesource.com/12327Reviewed-by:
-
- 19 Jul, 2015 1 commit
-
-
Austin Clements authored
The runtime.GC documentation was rewritten in df2809f0 to make it clear that it blocks until GC is complete, but the re-rewrite in ed9a4c91 and e28a6792 lost this property when clarifying that it may also block the entire program and not just the caller. Try to arrive at wording that conveys both of these properties. Change-Id: I1e255322aa28a21a548556ecf2a44d8d8ac524ef Reviewed-on: https://go-review.googlesource.com/12392Reviewed-by:
-
- 18 Jul, 2015 9 commits
-
-
Ian Lance Taylor authored
The findmoduledatap function will not return nil in ordinary use, but check for nil to try to avoid crashing when we are already crashing. Update #11783. Change-Id: If7b1adb51efab13b4c1a37b6f3c9ad22641a0b56 Reviewed-on: https://go-review.googlesource.com/12391 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Dmitry Vyukov authored
Fixes #11766 Fixes #11769 Fixes #11767 Fixes #11770 Change-Id: I441382af58f60deb46dcdd70076763b2c47738d4 Reviewed-on: https://go-review.googlesource.com/12378Reviewed-by:
-
Silvan Jegen authored
The default value for error is nil so there is no need to assign this value here. Change-Id: I4714ef7607996ccbf91b704390e1d1d39ee3847b Reviewed-on: https://go-review.googlesource.com/12355Reviewed-by:
-
Ian Lance Taylor authored
Update #11771. Change-Id: I3bb3262619765d3ca79652817e17e8f260f41907 Reviewed-on: https://go-review.googlesource.com/12379Reviewed-by:
-
Mikio Hara authored
This change adds site-local unicast classification for users still using the deprecated addresses internally. Change-Id: If50870c6d4a85fe471c002b161eec59efcebe2f4 Reviewed-on: https://go-review.googlesource.com/12344 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Old style. Make it compliant with our code review comments document. Also, make WriteString's return parameter named 'n', not 'ret', for consistency. Noticed during another documentation review. Change-Id: Ie88910c5841f8353bc5c0152e2168b497578e15e Reviewed-on: https://go-review.googlesource.com/12324Reviewed-by:
-
Alex Brainman authored
Fixes #11754 Change-Id: Ifa423ca6eea46d1500278db290498724a9559d14 Reviewed-on: https://go-review.googlesource.com/12347Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I720aeb1511e407750617e23c4cba1edcddf745bb Reviewed-on: https://go-review.googlesource.com/12326Reviewed-by:
-
Rob Pike authored
We shouldn't guarantee this behavior, but suggest it's possible. Change-Id: I4c2afb48b99be4d91537306d3337171a13c9990a Reviewed-on: https://go-review.googlesource.com/12346Reviewed-by:
-
- 17 Jul, 2015 11 commits
-
-
Ian Lance Taylor authored
The change https://golang.org/cl/12192 changed the get code to use the list of package imports, not the computed list of dependencies, as the computed list could be out of date if the package changed when using go get -u. Computing the dependency list would skip an import of "C", but that would still be on the package import list. This changes the code to skip "C" when walking the import list. No test--the best test would be to add an import of "C" to github.com/rsc/go-get-issue-9224-cmd for TestGoGetUpdate. Fixes #11738. Change-Id: Id89ddafeade2391d15688bfd142fafd67844a941 Reviewed-on: https://go-review.googlesource.com/12322 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Dave Cheney authored
Updates #10061 CL 12353 updated the documentation for os.Rename to stipulate the function will return errors of type *os.LinkError. This CL adds a test to ensure that the implementations continue to obey this contract. Change-Id: I41beb8c9d8356c737de251fdc6f652caab3ee636 Reviewed-on: https://go-review.googlesource.com/12329Reviewed-by:
-
Rob Pike authored
No code changes. Just make it clear that runtime.GC is not concurrent. Change-Id: I00a99ebd26402817c665c9a128978cef19f037be Reviewed-on: https://go-review.googlesource.com/12345Reviewed-by:
Dave Cheney <dave@cheney.net> Reviewed-by:
-
Paolo Martini authored
The document `doc/go_spec.html` uses "preceeding" instead of the word "preceding" in one place. Fixed another occurrence in `src/go/types/typexpr.go`. Change-Id: Ic67f62026b5c9d002c5c5632299f14ecac8b02ae Reviewed-on: https://go-review.googlesource.com/12354Reviewed-by:
-
Hyang-Ah (Hana) Kim authored
Change-Id: I69ed001bca4987e08b46a8288f6feae2aca6a142 Reviewed-on: https://go-review.googlesource.com/12380Reviewed-by:
-
David Crawshaw authored
Change-Id: I6e6d38ae347b4f5a33dff609b89785a038bc384c Reviewed-on: https://go-review.googlesource.com/12304Reviewed-by:
-
Austin Clements authored
An out-of-date comment snuck in to cc8f5441. Remove it. Change-Id: I5bc7c17e737d1cabe57b88de06d7579c60ca28ff Reviewed-on: https://go-review.googlesource.com/12328Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Jeff R. Allen authored
Rename should document that it returns *LinkError, like Create and Stat do. Fixes #10061 Change-Id: I7bfe8b0267f6c4a57dd6b26cba44928714711724 Reviewed-on: https://go-review.googlesource.com/12353Reviewed-by:
-
Mikio Hara authored
Change-Id: I0d940810b493249bc092cd38bdb434f7fa67cafb Reviewed-on: https://go-review.googlesource.com/12341Reviewed-by:
-
Austin Clements authored
This fixes a race between 1) sweeping and freeing an unmarked large span and 2) reusing that span and allocating from it. This race arises because mSpan_Sweep returns spans for large objects to the heap *before* heapBitsSweepSpan clears the mark bit on the object in the span. Specifically, the following sequence of events can lead to an incorrectly zeroed bitmap byte, which causes the garbage collector to not trace any pointers in that object (the pointer bits for the first four words are cleared, and the scan bits are also cleared, so it looks like a no-scan object). 1) P0 calls mSpan_Sweep on a large span S0 with an unmarked object on it. 2) mSpan_Sweep calls heapBitsSweepSpan, which invokes the callback for the one (unmarked) object on the span. 3) The callback calls mHeap_Free, which makes span S0 available for allocation, but this is too early. 4) P1 grabs this S0 from the heap to use for allocation. 5) P1 allocates an object on this span and writes that object's type bits to the bitmap. 6) P0 returns from the callback to heapBitsSweepSpan. heapBitsSweepSpan clears the byte containing the mark, even though this span is now owned by P1 and this byte contains important bitmap information. This fixes this problem by simply delaying the mHeap_Free until after the heapBitsSweepSpan. I think the overall logic of mSpan_Sweep could be simplified now, but this seems like the minimal change. Fixes #11617. Change-Id: I6b1382c7e7cc35f81984467c0772fe9848b7522a Reviewed-on: https://go-review.googlesource.com/12320 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Rob Pike authored
Adjusts for the move from golang.org/x/tools/go/types and .../go/exact to go/types and go/constant in the main repository. Change-Id: I0da7248c540939e3e9b09c915b0a296937f1be73 Reviewed-on: https://go-review.googlesource.com/12284Reviewed-by:
-
