- 29 Feb, 2012 27 commits
-
-
Mikio Hara authored
go test -short # like in the build; no external stuff go test # long tests, + external go test -external=false # long tests, no external R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5696079
-
Anthony Martin authored
The two string comparison optimizations were missing the implicit cast from ideal bool. Fixes #3119. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5696071
-
Russ Cox authored
The strikes against it are: 1. It does not take path boundaries into account. 2. It assumes that Windows==case-insensitive file system and non-Windows==case-sensitive file system, neither of which is always true. 3. Comparing ToLower against ToLower is not a correct implementation of a case-insensitive string comparison. 4. If it returns true on Windows you still don't know how long the matching prefix is in bytes, so you can't compute what the suffix is. R=golang-dev, r, dsymonds, r CC=golang-dev https://golang.org/cl/5712045
-
Brad Fitzpatrick authored
In -test.short mode, skip measuring the upper bound of time sleeps. The API only guarantees minimum bounds on sleeps, anyway, so this isn't a bug we're ignoring as much as it is simply observing bad builder virtualization and/or loaded machines. We keep the test in full mode where developers will presumably be running on a lightly-loaded, native, fast machine. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5713044
-
Russ Cox authored
When we first wrote the method set definition, we had long discussions about whether method sets applied to all types or just named types, and we (or at least I) concluded that it didn't matter: the two were equivalent points of view, because the only way to introduce a new method was to write a method function, which requires a named receiver type. However, the addition of embedded types changed this. Embedding can introduce a method without writing an explicit method function, as in: var x struct { sync.Mutex } var px *struct { sync.Mutex } var _, _ sync.Locker = &x, px The edits in this CL make clear that both &x and px satisfy sync.Locker. Today, gccgo already works this way; 6g does not. R=golang-dev, gri, iant, r CC=golang-dev https://golang.org/cl/5702062
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5711044
-
Russ Cox authored
R=golang-dev, r, bradfitz, gustavo CC=golang-dev https://golang.org/cl/5712044
-
Russ Cox authored
They are broken and hard to make work. They have never worked: if you import "/tmp/x" from "/home/rsc/p.c" then the compiler rewrites this into import "/home/rsc/tmp/x", which is clearly wrong. Also we just disallowed the : character in import paths, so import "c:/foo" is already not allowed. Finally, in order to support absolute paths well in a build tool we'd have to provide a mechanism to instruct the compiler to resolve absolute imports by looking in some other tree (where the binaries live) and provide a mapping from absolute path to location in that tree. This CL avoids adding that complexity. This is not part of the language spec (and should not be), so no spec change is needed. If we need to make them work later, we can. R=ken2 CC=golang-dev https://golang.org/cl/5712043
-
Russ Cox authored
In the current TOC it sticks out quite a bit. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5705053
-
Brad Fitzpatrick authored
Might fix issue 3050 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5708066
-
Shenghou Ma authored
R=rsc, bsiegert CC=golang-dev https://golang.org/cl/5709060
-
Robert Griesemer authored
Fix for minor inconsistency. R=golang-dev, iant CC=golang-dev https://golang.org/cl/5709058
-
Shenghou Ma authored
R=golang-dev, r, ality, r CC=golang-dev https://golang.org/cl/5709053
-
Brad Fitzpatrick authored
Part of diagnosing issue 3050. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5707056
-
Brad Fitzpatrick authored
Fixes #2919 I believe. (gets as far as sending a CONNECT request to my little dummy logging proxy that doesn't actually support CONNECT now.) Untested with a real CONNECT-supporting proxy, though. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5708055
-
Brad Fitzpatrick authored
It's still racy in that it mutates req.Body, though. *shrug* R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5709054
-
Robert Griesemer authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5706065
-
Robert Hencke authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/5707062
-
Robert Griesemer authored
This CL mostly deletes code. Using existing position information is just as good to determine if a new section is needed; no need to track exact multi- line information. Eliminates the need to carry around a multiLine parameter with practically every function. Applied gofmt -w src misc resulting in only a minor change to godoc.go. In return, a couple of test cases are now formatted better. Not Go1-required, but nice-to-have as it will simplify fixes going forward. R=rsc CC=golang-dev https://golang.org/cl/5706055
-
Luuk van Dijk authored
Don't try to print obviously corrupt slices or interfaces. Doesn't actually solve 3047 or 2818, but seems a good idea anyway. R=rsc, bsiegert CC=golang-dev https://golang.org/cl/5708061
-
Mikio Hara authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5707058
-
Rob Pike authored
Updates #1599. R=golang-dev, adg, dsymonds CC=golang-dev https://golang.org/cl/5704052
-
Andrew Gerrand authored
Now available at the Go Wiki: http://code.google.com/p/go-wiki/wiki/GoForCPPProgrammers Fixes #2913. R=golang-dev, r CC=golang-dev https://golang.org/cl/5705049
-
Robert Griesemer authored
Fixes #1612. R=r, rsc, iant, ken, remyoudompheng, ken, r CC=golang-dev https://golang.org/cl/5700068
-
Ian Lance Taylor authored
Minor cleanups to look more like current Go. R=golang-dev, r CC=golang-dev https://golang.org/cl/5707053
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5706054
-
Brad Fitzpatrick authored
Don't try to do an SSL negotiation with a *bytes.Buffer. Fixes #3135 R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5709050
-
- 28 Feb, 2012 13 commits
-
-
Mikio Hara authored
We should use DialUnix or ListenPacket for unixgram networks because Dial doesn't take a local UnixAddr. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5706043
-
Stefan Nilsson authored
Change #foo to div#foo to avoid selecting headings with anchor foo, such as <h1 id="foo">. (A more extensive change would be to use class selectors for styling. Perhaps this is better, since id:s should be unique within a document according to http://www.w3.org/TR/CSS2/selector.html#id-selectors) R=golang-dev, gri, adg CC=golang-dev https://golang.org/cl/5702044
-
Russ Cox authored
Only copy+paste here. Will make next code review's diffs a bit smaller. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5704050
-
Russ Cox authored
Work around profiling kernel bug with signal masks. Still broken on 64-bit Snow Leopard kernel, but I think we can ignore that one and let people upgrade to Lion. Add new trivial tools addr2line and objdump to take the place of the GNU tools of the same name, since those are not installed on OS X. Adapt pprof to invoke 'go tool addr2line' and 'go tool objdump' if the system tools do not exist. Clean up disassembly of base register on amd64. Fixes #2008. R=golang-dev, bradfitz, mikioh.mikioh, r, iant CC=golang-dev https://golang.org/cl/5697066
-
Rémy Oudompheng authored
R=golang-dev, minux.ma, rsc CC=golang-dev, remy https://golang.org/cl/5702050
-
Rob Pike authored
except for hiding one type that is only used internally. Fixes #2944. R=golang-dev, rsc, kevlar CC=golang-dev https://golang.org/cl/5707044
-
Shenghou Ma authored
If stdout and stderr are indeed the same file (not a tty), which is often the case, fully-buffered stdout will make it harder to see progresses, for example, ./make.bash 2>&1 | tee log R=r, rsc CC=golang-dev https://golang.org/cl/5700070
-
Mikkel Krautz authored
This is a band-aid until we can use weak imports with cgo. Fixes #3131. R=minux.ma, rsc CC=golang-dev https://golang.org/cl/5700083
-
Shenghou Ma authored
R=golang-dev, rsc, adg, r, r CC=golang-dev https://golang.org/cl/5693060
-
Robert Griesemer authored
When debugging ASTs, it's useful to also see the comments on occasion. Usage: gotype -ast -comments file.go R=golang-dev, r CC=golang-dev https://golang.org/cl/5703043
-
Andrew Gerrand authored
R=golang-dev CC=golang-dev https://golang.org/cl/5702043
-
Rob Pike authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5694100
-
Rob Pike authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5696087
-