Commits · 743c2d0f48ce54c4a885561cd6c21d2245d705c9 · go / golang

19 Jan, 2012 40 commits

net: fix broken setDefaultSockopts · 743c2d0f
Mikio Hara authored Jan 19, 2012
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5536068
```
743c2d0f

crypto/hmac: Deprecate hmac.NewMD5, hmac.NewSHA1 and hmac.NewSHA256 · 8d66a416

Luit van Drongelen authored Jan 19, 2012

Remove NewMD5, NewSHA1 and NewSHA256 in favor of using New and
explicitly importing the used hash-function. This way when using, for
example, HMAC with RIPEMD there's no md5, sha1 and sha256 linked in
through the hmac package.

A gofix rule is included, and applied to the standard library (3 files
altered).

This change is the result of a discussion at
https://golang.org/cl/5550043/ to pull the discussion about
deprecating these functions out of that issue.

R=golang-dev, agl
CC=golang-dev, r, rsc
https://golang.org/cl/5556058

8d66a416

gc: don't emit pkgpath for error type. · ee09a8cd
David Symonds authored Jan 19, 2012
```
Fixes #2660.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5557060
```
ee09a8cd

net/http: log handler panic before closing HTTP connection · bb7eca17

Brad Fitzpatrick authored Jan 19, 2012

Fix originally from rogpeppe in 5414048 but was rolled
back due to test breakage.

This CL makes the test more robust to order of operations.

Fixes #2480 again.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5536072

bb7eca17

os/exec: trivial allocation removal in LookPath · 01a0d39a
Gustavo Niemeyer authored Jan 19, 2012
```
R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/5549043
```
01a0d39a
encoding/xml: marshal/unmarshal xml.Name in field · ca3e6d13
Gustavo Niemeyer authored Jan 19, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5542052
```
ca3e6d13
doc: update out-of-date comments about runtime/cgo · fec7aa95
Shenghou Ma authored Jan 19, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5532100
```
fec7aa95

go/parser: expressions may have comments · 7b07310a

Robert Griesemer authored Jan 19, 2012

Thanks to 0xE2.0x9A.0x9B for the patch suggestion.

Fixes #2739.

R=r
CC=golang-dev
https://golang.org/cl/5536071

7b07310a

text/template/parse: use human error prints · c837e612

Rob Pike authored Jan 19, 2012

The previous version of all the node.String methods printed the parse
tree and was useful for developing the parse tree code. Now that that's done,
we might as well print the nodes using the standard template syntax.
It's much easier to read and makes error reporting look more natural.

Helps issue 2644.

R=rsc, n13m3y3r
CC=golang-dev
https://golang.org/cl/5553066

c837e612

runtime: madvise and SysUnused for Darwin · c354f93b

Dave Cheney authored Jan 19, 2012

SysUnused is a direct call to madvise MADV_FREE.

R=sebastien.paolacci, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/5531073

c354f93b

godoc: support canonical Paths in HTML metadata · 8bbe5ccb

Andrew Gerrand authored Jan 19, 2012

Redirect to the canonical path when the old path is accessed.

R=gri
CC=golang-dev
https://golang.org/cl/5536061

8bbe5ccb

os: add ModeSticky · 5a1322a7
Evan Shaw authored Jan 19, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5539063
```
5a1322a7

testing: do not recover example's panic · d888ab80

Shenghou Ma authored Jan 19, 2012

        So as to give out stack trace for panic in examples.
        This behavior also matches the tests'.
        Fixes #2691.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5554061

d888ab80

pkg: Add & fix Copyright of "hand generated" files · e5c1f387
Olivier Duperray authored Jan 19, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5554064
```
e5c1f387
exp/sql: rename NullableString to NullString and allow its use as a parameter · bc0139b4
Brad Fitzpatrick authored Jan 19, 2012
```
Prep for Issue 2699

R=rsc
CC=golang-dev
https://golang.org/cl/5536045
```
bc0139b4
go/doc, godoc: don't shadow receiver · 9e5f62ac
Robert Griesemer authored Jan 19, 2012
```
Fixes #2737.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5553062
```
9e5f62ac
net/http: the documentation should call NewRequest with the right signature. · 2a6b4e12
Christoph Hack authored Jan 19, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5554063
```
2a6b4e12

crypto/x509: remove explicit uses of rsa. · a99e35b6

Adam Langley authored Jan 19, 2012

(Sending to r because of the API change.)

Over time we might want to add support for other key types.

While I was in the code, I also made the use of RawSubject the same
between Subject and Issuer when creating certificates.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5554049

a99e35b6

crypto/elliptic: add constant-time P224. · 247799ce

Adam Langley authored Jan 19, 2012

(Sending to r because of the API change.)

This change alters the API for crypto/elliptic to permit different
implementations in the future. This will allow us to add faster,
constant-time implementations of the standard curves without any more
API changes.

As a demonstration, it also adds a constant-time implementation of
P224. Since it's only 32-bit, it's actually only about 40% the speed
of the generic code on a 64-bit system.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5528088

247799ce

math/rand: decrease test duration in short mode · f2f00593

Dmitriy Vyukov authored Jan 19, 2012

TestNonStandardNormalValues runs 1.5s,
the change reduces it to 0.2s in short mode.
The problem is with slow machines, emulators and dynamic tools.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5540065

f2f00593

godoc: add anchors to cmd documentation headings · 3358a506

Andrew Gerrand authored Jan 19, 2012

Also, disable server-side generation of TOC for commands as they would
only ever show Overview. The JS does a better job (for now).

Fixes #2732.

R=gri, dsymonds
CC=golang-dev
https://golang.org/cl/5558046

3358a506

html: in foreign content, check for HTML integration points in breakout · b4829c1d

Nigel Tao authored Jan 19, 2012

elements.

Pass tests10.dat, test 33:
<!DOCTYPE html><svg><desc><svg><ul>a

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|       <svg desc>
|         <svg svg>
|         <ul>
|           "a"

Also pass test 34:
<!DOCTYPE html><p><svg><desc><p>

R=andybalholm, dsymonds
CC=golang-dev
https://golang.org/cl/5536048

b4829c1d

encoding/json: fix comments, tweak tests for tag names · d4fe9c6a
Mikio Hara authored Jan 19, 2012
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5558047
```
d4fe9c6a

regexp: add SubexpNames · 21d3721e

Russ Cox authored Jan 19, 2012

Fixes #2440.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5559043

21d3721e

syscall: fix plan9 build · e3e93b0f
Mikio Hara authored Jan 19, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5532097
```
e3e93b0f

godoc: remove "need more packages?" link · e547393f

Andrew Gerrand authored Jan 19, 2012

Its need will be addressed in another way by the redesign.

Fixes #2719.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5536062

e547393f

doc/codewalk: update urlpoll to use time.Duration. · 1de49311
Stefan Nilsson authored Jan 19, 2012
```
R=adg
CC=golang-dev
https://golang.org/cl/5545061
```
1de49311
A+C: add Stefan Nilsson's gmail account · 885cbc3b
Andrew Gerrand authored Jan 19, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5541064
```
885cbc3b
go/doc: collect imports · c109705c
Robert Griesemer authored Jan 19, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/5556051
```
c109705c
cmd/go: skip _obj directories in package scans · f47807a5
Brad Fitzpatrick authored Jan 19, 2012
```
Fixes #2693

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5557057
```
f47807a5
net: fix plan9 build · b58b5ba9
Mikio Hara authored Jan 19, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5554058
```
b58b5ba9

net: fix comments · 2356e438

Mikio Hara authored Jan 19, 2012

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5557059

2356e438

net/http: update the Client docs a bit · f44304ee
Brad Fitzpatrick authored Jan 19, 2012
```
R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/5557058
```
f44304ee
syscall: add Unix method to TimeSpec, TimeVal · 7d418aee
Brad Fitzpatrick authored Jan 19, 2012
```
Fixes #2534

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://golang.org/cl/5554057
```
7d418aee
encoding/json: allow / and % in tag names · b39c883e
Brad Fitzpatrick authored Jan 19, 2012
```
Fixes #2718

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5532095
```
b39c883e
path: added examples · 0d8c6b4f
Sanjay Menakuru authored Jan 19, 2012
```
R=rsc, adg
CC=golang-dev
https://golang.org/cl/5503089
```
0d8c6b4f

image: add PixOffset methods; use them in image/draw and image/tiff. · af08cfa4

Nigel Tao authored Jan 19, 2012

image/draw benchmarks show <1% change for the fast paths.
The slow paths got worse by 1-4%, but they're the slow paths.
I don't care so much about them, and presumably compiler improvements
could claw it back.

IIUC 6g's inlining is enabled by default now.

benchmark                        old ns/op    new ns/op    delta
draw.BenchmarkFillOver             2988384      2999624   +0.38%
draw.BenchmarkFillSrc               153141       153262   +0.08%
draw.BenchmarkCopyOver             2155756      2170831   +0.70%
draw.BenchmarkCopySrc                72591        72646   +0.08%
draw.BenchmarkNRGBAOver            2487372      2491576   +0.17%
draw.BenchmarkNRGBASrc             1361306      1409180   +3.52%
draw.BenchmarkYCbCr                2540712      2562359   +0.85%
draw.BenchmarkGlyphOver            1004879      1023308   +1.83%
draw.BenchmarkRGBA                 8746670      8844455   +1.12%
draw.BenchmarkGenericOver         31860960     32512960   +2.05%
draw.BenchmarkGenericMaskOver     16369060     16435720   +0.41%
draw.BenchmarkGenericSrc          13128540     13127810   -0.01%
draw.BenchmarkGenericMaskSrc      30059300     28883210   -3.91%

R=r, gri
CC=golang-dev, rsc
https://golang.org/cl/5536059

af08cfa4

net: use NewTimer, not NewTicker, in fd_windows.go · 98af3880

Brad Fitzpatrick authored Jan 19, 2012

It works with NewTicker too, but is potentially a bit less efficient,
and reads wrong.

This is what happens when you TBR Windows changes, I guess.

R=golang-dev, gri, iant
CC=golang-dev
https://golang.org/cl/5536060

98af3880

godoc: specify HTML page metadata with a JSON blob · 7cb21a79

Andrew Gerrand authored Jan 19, 2012

This allows HTML pages to specify arbitrary data in a header:

<!--{
        "Title": "The page title",
        ...
}-->

replacing the old style comments:

<!-- title The page title -->

R=gri, rsc, r, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5532093

7cb21a79

net: change SetTimeout to SetDeadline · b71883e9

Brad Fitzpatrick authored Jan 19, 2012

Previously, a timeout (in int64 nanoseconds) applied to a granularity
even smaller than one operation:  a 100 byte read with a 1 second timeout
could take 100 seconds, if the bytes all arrived on the network 1 second
apart.  This was confusing.

Rather than making the timeout granularity be per-Read/Write,
this CL makes callers set an absolute deadline (in time.Time)
after which operations will fail.  This makes it possible to
set deadlines at higher levels, without knowing exactly how
many read/write operations will happen in e.g. reading an HTTP
request.

Fixes #2723

R=r, rsc, dave
CC=golang-dev
https://golang.org/cl/5555048

b71883e9