Commits · 7483c6ee3c688d078fe00d375d968ce99077759e · go / golang

03 Mar, 2011 4 commits

image: add a decoding test for common file formats. · 7483c6ee

Nigel Tao authored Mar 03, 2011

The test image was converted from doc/video-001.png using the
convert command line tool (ImageMagick 6.5.7-8) at -quality 100.

R=r, nigeltao_gnome
CC=golang-dev
https://golang.org/cl/4259047

7483c6ee

doc: remove reference to bug count from install.html · 3fea5bad
Andrew Gerrand authored Mar 03, 2011
```
Fixes #1574.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4240066
```
3fea5bad
gobuilder: add -package flag to build external packages · 34f2f683
Andrew Gerrand authored Mar 03, 2011
```
Also add -v for verbose logging.

R=rsc, gri, r, r2
CC=golang-dev
https://golang.org/cl/4172056
```
34f2f683

unsafe: fix the documentation · 68add46a

Rob Pike authored Mar 03, 2011

Reflection is about Pointer, not uintptr.
Also clarify that Reflect and Unreflect are indirect.

R=rsc
CC=golang-dev
https://golang.org/cl/4254052

68add46a

02 Mar, 2011 11 commits

gc: fix init of packages named main · daffc2d2

Gustavo Niemeyer authored Mar 02, 2011

This change removes the special case which existed
for handling the initalization of the main package,
so that other modules named 'main' get properly
initialized when imported.

Note that gotest of main packages will break in most
cases without this.

R=rsc
CC=golang-dev
https://golang.org/cl/4190050

daffc2d2

runtime: fix unused variable warning · ff1d89d6
Dave Cheney authored Mar 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4188043
```
ff1d89d6
xml: fix typo in test. · 1a6b1dd0
Yasuhiro Matsumoto authored Mar 02, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4218042
```
1a6b1dd0

goinstall: protect against malicious filenames. · c1fdb6f1

Roger Peppe authored Mar 02, 2011

It was possible to make package run arbitrary
commands when installing if its filenames contained
make metacharacters.

R=rsc, niemeyer
CC=golang-dev
https://golang.org/cl/4248041

c1fdb6f1

build: simplify clean.bash · 49a4d7dc
Dave Cheney authored Mar 02, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4257045
```
49a4d7dc
fix build · f104a198
Russ Cox authored Mar 02, 2011
```
TBR=rog
CC=golang-dev
https://golang.org/cl/4259046
```
f104a198
build: fix race condition building enam.o · 9a8c0790
Dave Cheney authored Mar 02, 2011
```
R=golang-dev, rsc
CC=albert.strasheim, golang-dev
https://golang.org/cl/4240055
```
9a8c0790

cgo: put temporary source files in _obj. · 9704d4ec

Roger Peppe authored Mar 02, 2011

Fixes #1572.
Initially I tried changing things so all object
files get put in _obj, but it's too much - everything
needs changing. Perhaps some other time.

R=rsc
CC=golang-dev
https://golang.org/cl/4237050

9704d4ec

fmt: allow recursive calls to Fscan etc. · 81bfbe93

Roger Peppe authored Mar 02, 2011

Add a new Read method to ScanState so that it
satisfies the io.Reader interface; rename
Getrune and Ungetrune to ReadRune and UnreadRune.
Make sure ReadRune does not read past width restrictions;
remove now-unnecessary Width method from ScanState.
Also make the documentation a little clearer as to
how ReadRune and UnreadRune are used.

R=r, r2
CC=golang-dev
https://golang.org/cl/4240056

81bfbe93

runtime: record goroutine creation pc and display in traceback · 324cc3d0

Russ Cox authored Mar 02, 2011

package main

func main() {
        go func() { *(*int)(nil) = 0 }()
        select{}
}

panic: runtime error: invalid memory address or nil pointer dereference

[signal 0xb code=0x1 addr=0x0 pc=0x1c96]

runtime.panic+0xac /Users/rsc/g/go/src/pkg/runtime/proc.c:1083
        runtime.panic(0x11bf0, 0xf8400011f0)
runtime.panicstring+0xa3 /Users/rsc/g/go/src/pkg/runtime/runtime.c:116
        runtime.panicstring(0x29a57, 0x0)
runtime.sigpanic+0x144 /Users/rsc/g/go/src/pkg/runtime/darwin/thread.c:470
        runtime.sigpanic()
main._func_001+0x16 /Users/rsc/g/go/src/pkg/runtime/x.go:188
        main._func_001()
runtime.goexit /Users/rsc/g/go/src/pkg/runtime/proc.c:150
        runtime.goexit()
----- goroutine created by -----
main.main+0x3d /Users/rsc/g/go/src/pkg/runtime/x.go:4

goroutine 1 [4]:
runtime.gosched+0x77 /Users/rsc/g/go/src/pkg/runtime/proc.c:598
        runtime.gosched()
runtime.block+0x27 /Users/rsc/g/go/src/pkg/runtime/chan.c:680
        runtime.block()
main.main+0x44 /Users/rsc/g/go/src/pkg/runtime/x.go:5
        main.main()
runtime.mainstart+0xf /Users/rsc/g/go/src/pkg/runtime/amd64/asm.s:77
        runtime.mainstart()
runtime.goexit /Users/rsc/g/go/src/pkg/runtime/proc.c:150
        runtime.goexit()
----- goroutine created by -----
_rt0_amd64+0x8e /Users/rsc/g/go/src/pkg/runtime/amd64/asm.s:64

Fixes #1563.

R=r
CC=golang-dev
https://golang.org/cl/4243046

324cc3d0

http: initialize request Header for the transport · 9733f96b
Brad Fitzpatrick authored Mar 02, 2011
```
Fixes #1558

R=rsc, r, bradfitzwork
CC=golang-dev
https://golang.org/cl/4260042
```
9733f96b

01 Mar, 2011 9 commits

http: give ParseHTTPVersion a real example. · 1d258a55
David Symonds authored Mar 01, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4239050
```
1d258a55

http: expose Client's Transport · 60f19378

Brad Fitzpatrick authored Mar 01, 2011

This is again an intentionally minimal change.

The plan is to keep Client's zero value be a usable
client, with optional fields being added over time
(e.g. cookie manager, redirect policy, auth)

R=rsc
CC=golang-dev
https://golang.org/cl/4239044

60f19378

docs: make "runtime" a word only as a name for the package. · 966bf713

Rob Pike authored Mar 01, 2011

Computer people have an agglutinating streak that I like to resist.
As a time of execution: run time.
As an adjective: run-time.
As a noun: run-time support/code/library.

Signed,
Mr. Pedant.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4252048

966bf713

fmt: delete debugging print that crept in to test. · a77744f4

Rob Pike authored Mar 01, 2011

(you'd never see it, but ouch.)
Spotted by Florian Weimer.

R=rsc
CC=golang-dev
https://golang.org/cl/4259044

a77744f4

fmt: make %#p suppress leading 0x · 2b9ab227
Rob Pike authored Mar 01, 2011
```
Fixes bug 1567.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4245048
```
2b9ab227
http: export parseHTTPVersion. · 7eaecb89
David Symonds authored Mar 01, 2011
```
R=rsc, adg
CC=golang-dev
https://golang.org/cl/4244045
```
7eaecb89
doc: add FAQ about large binaries and stack vs heap allocation · 4b0ecd3f
Andrew Gerrand authored Mar 01, 2011
```
doc: add internationalization to roadmap

R=rsc, r, r2
CC=golang-dev
https://golang.org/cl/4251047
```
4b0ecd3f

goyacc: clarify it's package, not binary, that has · 41a23ca0

Rob Pike authored Mar 01, 2011

conflict and explain that you could put the grammars
in separate packages instead.

I could be talked into rolling back the previous change
and just making a doc change instead, but I'm content
to let it stand.

R=rsc
CC=golang-dev
https://golang.org/cl/4240053

41a23ca0

goyacc: provide -p flag to set prefix for names. · bb0e7bda

Rob Pike authored Mar 01, 2011

This should allow multiple goyacc grammars to be
compiled into the same binary. There's a chance it
Fixes #1562.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4256044

bb0e7bda

28 Feb, 2011 7 commits

build: convert src/cmd to use make directly and simplify src/make.bash · 432b4f30
Dave Cheney authored Feb 28, 2011
```
R=adg, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/4221047
```
432b4f30
gc: bug325 / issue 1566 · 7da86983
Russ Cox authored Feb 28, 2011
```
Fixes #1566.

R=ken2
CC=golang-dev
https://golang.org/cl/4259041
```
7da86983

build: move $GOBIN ahead of /bin, /usr/bin in build $PATH · a3ef1982

Russ Cox authored Feb 28, 2011

Otherwise if there is an installed /usr/bin/6g the build
will use that one instead of the one it builds.

R=r
CC=golang-dev
https://golang.org/cl/4249045

a3ef1982

xml: permit nested directives · b00f7310

Chris Dollin authored Feb 28, 2011

Return <!DOCTYPE ...> with nested directives as one big token.

Fixes #1549.

R=niemeyer, rsc
CC=golang-dev
https://golang.org/cl/4216050

b00f7310

template: document the delimiters better · b2efedbf
Rob Pike authored Feb 28, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4248047
```
b2efedbf
syscall: regenerate zerrors_freebsd_amd64.go · dd51f353
Mikio Hara authored Feb 28, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4248043
```
dd51f353

runtime: idle goroutine · 582fd17e

Russ Cox authored Feb 28, 2011

This functionality might be used in environments
where programs are limited to a single thread,
to simulate a select-driven network server.  It is
not exposed via the standard runtime API.

R=r, r2
CC=golang-dev
https://golang.org/cl/4254041

582fd17e

26 Feb, 2011 1 commit

compress/lzw: don't use a closure in NewReader, which avoids having · fdbbb066

Nigel Tao authored Feb 26, 2011

to move some variables from the stack to the heap.

Sorted benchmark runs on my 2007-era Mac Mini (GOARCH=amd64, GOOS=linux):

Before:
lzw.BenchmarkDecoder        2000        878176 ns/op
lzw.BenchmarkDecoder        2000        878415 ns/op
lzw.BenchmarkDecoder        2000        880352 ns/op
lzw.BenchmarkDecoder        2000        898445 ns/op
lzw.BenchmarkDecoder        2000        901728 ns/op

After:
lzw.BenchmarkDecoder        2000        859065 ns/op
lzw.BenchmarkDecoder        2000        859402 ns/op
lzw.BenchmarkDecoder        2000        860035 ns/op
lzw.BenchmarkDecoder        2000        860555 ns/op
lzw.BenchmarkDecoder        2000        861109 ns/op

The ratio of before/after median times is 1.024.

The runtime.MemStats.Mallocs delta per loop drops from 109 to 104.

R=r, r2, dfc
CC=golang-dev
https://golang.org/cl/4253043

fdbbb066

25 Feb, 2011 8 commits

compress/lzw: fix the stupidity of allocating and zeroing a new buffer · 5b1d47d1

Nigel Tao authored Feb 25, 2011

on each loop iteration, yielding a 20x performance improvement.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4240044

5b1d47d1

crypto/openpgp: fix test prints · 54f00407
Rob Pike authored Feb 25, 2011
```
R=agl, agl1
CC=golang-dev
https://golang.org/cl/4255041
```
54f00407

runtime: omit breakpoint during terminal panic · d1cd8294