- 14 Nov, 2015 9 commits
-
-
Ian Lance Taylor authored
Change the linker to use a copy of the C compiler support library, libgcc.a, when doing internal linking. This will be used to satisfy any undefined symbols referenced by host objects. Change the dist tool to copy the support library into a new directory tree under GOROOT/pkg/libgcc. This ensures that libgcc is available even when building Go programs on a system that has no C compiler. The C compiler is required when building the Go installation in the first place, but is not required thereafter. Change the go tool to not link libgcc into cgo objects. Correct the linker handling of a weak symbol in an ELF input object to not always create a new symbol, but to use an existing symbol if there is one; this is necessary on freebsd-amd64, where libgcc contains a weak definition of compilerrt_abort_impl. Fixes #9510. Change-Id: I1ab28182263238d9bcaf6a42804e5da2a87d8778 Reviewed-on: https://go-review.googlesource.com/16741Reviewed-by:
Russ Cox <rsc@golang.org>
-
Brad Fitzpatrick authored
benchmark old ns/op new ns/op delta BenchmarkTLS-4 8571 7938 -7.39% benchmark old MB/s new MB/s speedup BenchmarkTLS-4 119.46 128.98 1.08x benchmark old allocs new allocs delta BenchmarkTLS-4 8 0 -100.00% benchmark old bytes new bytes delta BenchmarkTLS-4 128 0 -100.00% On: func BenchmarkTLS(b *testing.B) { b.ReportAllocs() b.SetBytes(1024) ts := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { io.Copy(ioutil.Discard, r.Body) })) defer ts.Close() buf := make([]byte, 1024) for i := range buf { buf[i] = byte(i) } c, err := tls.Dial("tcp", ts.Listener.Addr().String(), &tls.Config{ InsecureSkipVerify: true, }) if err != nil { b.Fatal(err) } defer c.Close() clen := int64(b.N) * 1024 if _, err := c.Write([]byte( "POST / HTTP/1.1\r\nHost: foo\r\nContent-Length: " + fmt.Sprint(clen) + "\r\n\r\n")); err != nil { b.Fatal(err) } b.ResetTimer() for i := 0; i < b.N; i++ { if _, err := c.Write(buf); err != nil { b.Fatal(err) } } } Change-Id: I206e7e2118b97148f9751b740d8470895634d3f5 Reviewed-on: https://go-review.googlesource.com/16828Reviewed-by:Adam Langley <agl@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Fixes #13248. TBR: iant Change-Id: Ic8b10704f945e6daef04bb38a00e249854b4ef19 Reviewed-on: https://go-review.googlesource.com/16930Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Russ Cox authored
Fixes #11380. Change-Id: I0a284ad2a46826ce82486479ea4e79f0f470292f Reviewed-on: https://go-review.googlesource.com/16635Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
Comment changes only. Change-Id: Ib365b3cd16af9995cb0a2cce48fbe35d73899438 Reviewed-on: https://go-review.googlesource.com/16898 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Chris Manghane <cmang@golang.org>
-
Robert Griesemer authored
Factored out functionality of dotname (was inlined in 3 places). Change-Id: Ica782737c8decbb757465830b25ba87faa9115a4 Reviewed-on: https://go-review.googlesource.com/16897 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Inlined fntype, othertype, recvchantype, ptrtype into ntype and simplified callers. Minor cleanups elsewhere (better names). Change-Id: I54924969996641a802de00c078b4cd0eabfda8c1 Reviewed-on: https://go-review.googlesource.com/16894 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Inlined non_dcl_stmt in stmt since it was called only from there. Change-Id: I616c41332cfd86bbf3493d0ce7b1256384215220 Reviewed-on: https://go-review.googlesource.com/16893 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
- better error messages - better error recovery by advancing to "follow" token after error - make sure that we make progress after all errors - minor cleanups Change-Id: Ie43b8b02799618d70dc8fc227fab3e4e9e0d8e3a Reviewed-on: https://go-review.googlesource.com/16892 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
-
- 13 Nov, 2015 24 commits
-
-
Matthew Dempsky authored
These now live in runtime/internal/sys. Change-Id: I270597142516512bfc1395419e51d8083ba1663f Reviewed-on: https://go-review.googlesource.com/16891 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Marcel van Lohuizen authored
Exported methods of unexported embedded structs get added correctly to the pool. Behavior is unchanged before and after https://golang.org/cl/14085. Change-Id: I2b4053bab02ff045f0a4577b8114808a60aae27e Reviewed-on: https://go-review.googlesource.com/16305Reviewed-by:
-
Brad Fitzpatrick authored
Steve Newman (Google CLA) was missing from the CONTRIBUTORS file, presumably because his old commits (made prior to Go being open source) in SVN/perforce were imported into hg/git later as "devnull@localhost", which probably didn't match anything, and we didn't start tracking CLA contributions prior to the Go open source release. As a fun historical note, the initial HTTP client from Steve: https://github.com/golang/go/commit/f315fb3 Change-Id: I2b8da4564d99820504788ecc41495a62391078d5 Reviewed-on: https://go-review.googlesource.com/16864Reviewed-by:
-
Robert Griesemer authored
This is a translation of the yacc-based parser with adjustements to make the grammar work for a recursive-descent parser followed by cleanups and simplifications. The yacc actions were mostly literally copied for correctness with better temporary names. A few of the syntax tests were adjusted for slightly different error messages (it is very difficult to match the yacc-based error messages in all cases, and sometimes the new parser could produce better errors). The new parser is enabled by default. To switch back to the yacc-based parser, set -oldparser. To hardwire the switch back, uncomment "oldparser = 1" in lex.go. - passes all.bash - ~18% reduced parse time per file on average for make.bash - ~3% reduced compile time for building cmd/compile Change-Id: Icb5651bb9d8b9f66261762d2c94a03793050d4ce Reviewed-on: https://go-review.googlesource.com/16665 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Fix the output of build -n when adding to an existing archive with the gc toolchain by observing that we are, now, always doing that. When using the gc toolchain the archive is now always created by the Go compiler, and never by the pack command. No test because we have not historically tested build -n output. Fixes #13118. Change-Id: I3a5c43cf45169fa6c9581e4741309c77d2b6e58b Reviewed-on: https://go-review.googlesource.com/16761Reviewed-by:
Matthew Dempsky <mdempsky@google.com> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Brad Fitzpatrick authored
Add Alberto Bertogli (individual CLA) Add Alexander Demakin (individual CLA) Add Angelo Bulfone (individual CLA) Add Anthony Canino (individual CLA) Add Arnout Engelen (individual CLA) Add Cedric Staub (corporate CLA for Square, Inc.) Add Dan Caddigan (individual CLA) Add Dan Jacques (corporate CLA for Google Inc.) Add Daniel Skinner (individual CLA) Add David Howden (individual CLA) Add Dmitry Yakunin (individual CLA) Add Emmanuel Odeke (individual CLA) Add Eric Koleda (corporate CLA for Google Inc.) Add Erik Dubbelboer (individual CLA) Add Evan Broder (corporate CLA for Stripe, Inc.) Add Ford Hurley (individual CLA) Add Francisco Claude (individual CLA) Add Gaurish Sharma (individual CLA) Add Hsin-Ho Yeh (individual CLA) Add Ian Gudger (individual CLA) Add Ilya Tocar (corporate CLA for Intel Corporation) Add John Jenkins (individual CLA) Add Kenny Grant (individual CLA) Add Kevin Malachowski (corporate CLA for Google Inc.) Add Kim Shrier (corporate CLA for RackTop Systems Inc.) Add Klaus Post (individual CLA) Add Lewin Bormann (individual CLA) Add Manu S Ajith (individual CLA) Add Matt Drollette (individual CLA) Add Meng Zhuo (individual CLA) Add Mhd Sulhan (individual CLA) Add Mohit Agarwal (individual CLA) Add Nathan Otterness (individual CLA) Add Nathan VanBenschoten (individual CLA) Add Paul Hankin (corporate CLA for Google Inc.) Add Paul Meyer (individual CLA) Add Pavel Paulau (individual CLA) Add Ralph Corderoy (individual CLA) Add Rob Norman (individual CLA) Add Seth Hoenig (individual CLA) Add Spencer Nelson (individual CLA) Add Steve Phillips (individual CLA) Add Thorben Krueger (individual CLA) Add Tormod Erevik Lea (individual CLA) Add Will Chan (corporate CLA for Google Inc.) Add Yao Zhang (individual CLA) Add Yasuharu Goto (individual CLA) Add Yuki Yugui Sonoda (corporate CLA for Google Inc.) Updates #12042 Change-Id: Ia5f8e184fdbe8b135b2c29bb75f20bf72042abae Reviewed-on: https://go-review.googlesource.com/16825Reviewed-by:
-
David Crawshaw authored
Revert "cmd/internal/obj/arm64, cmd/link: use two instructions rather than three for loads from memory" This reverts commit 3a9bc571. Breaks darwin/arm64. Change-Id: Ib958beacabca48020a6a47332fbdec99d994060b Reviewed-on: https://go-review.googlesource.com/16906Reviewed-by:
Michael Hudson-Doyle <michael.hudson@canonical.com>
-
Brad Fitzpatrick authored
Fixes #12078 Change-Id: If09c927fae639ec4ed3894a2b393a87c1e677803 Reviewed-on: https://go-review.googlesource.com/16829 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Brad Fitzpatrick authored
Fixes #12078 Change-Id: Ia8738123b07ca29be4a0cf400ee143729c8b5b3c Reviewed-on: https://go-review.googlesource.com/16860Reviewed-by:
-
Shenghou Ma authored
Change-Id: If9dc08d6c29bf60b63d75d973033897ad8bf8cc4 Reviewed-on: https://go-review.googlesource.com/16905Reviewed-by:
-
Shenghou Ma authored
Change-Id: I4903014f2883d3f52a75a3500dc9e01a5cad8611 Reviewed-on: https://go-review.googlesource.com/16904 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Joe Tsai authored
The gzip package is asymmetrical in the way it handles headers. In Writer, the Header is written on the first call to Write, Flush, or Close. In Reader, the Header is read on calls to NewReader or Reset as opposed to after the first Read. Thus, we document this difference. Fixes #13211 Change-Id: I5f87beff036e5e2fd68a02a15fdb7137e9ca4c37 Reviewed-on: https://go-review.googlesource.com/16838Reviewed-by:
-
Shenghou Ma authored
Fixes #12540. Change-Id: I7893fdc023145b0aca4b4c7df7e08e47edcf5bba Reviewed-on: https://go-review.googlesource.com/16902 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Allows removing fields that aren't relevant to a particular OS or changing their types to match the underlying OS system calls they'll be used for. Change-Id: I5cea89ee77b4e7b985bff41337e561887c3272ff Reviewed-on: https://go-review.googlesource.com/16176Reviewed-by:
-
Shenghou Ma authored
so that GO_TEST_TIMEOUT_SCALE can be applied too. It's for the mips64 builder, which is so slow that the go1 benchmark can't finish startup within 10 minutes. Change-Id: I1b824eb0649460101b294fb442da784e872403e7 Reviewed-on: https://go-review.googlesource.com/16901Reviewed-by:
-
Matt Layher authored
Replaces PID in PaxHeaders with 0. Sorts PAX header keys before writing them to the archive. Fixes #12358 Change-Id: If239f89c85f1c9d9895a253fb06a47ad44960124 Reviewed-on: https://go-review.googlesource.com/13975Reviewed-by:
Joe Tsai <joetsai@digital-static.net>
-
Matthew Dempsky authored
We're allocating TLS storage for m0 anyway, so might as well use it. Change-Id: I7dc20bbea5320c8ab8a367f18a9540706751e771 Reviewed-on: https://go-review.googlesource.com/16890 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Yasuhiro Matsumoto authored
Fixes #13198 The output of netsh is encoded with ANSI encoding. So doesn't match with UTF-8 strings. Write output as UTF-8 using powershell. Change-Id: I6c7e93c590ed407f24ae847601d71df9523e028c Reviewed-on: https://go-review.googlesource.com/16756 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Shenghou Ma authored
It doesn't seem to help on modern processors and it makes Go impossible to run on Pentium MMX (which is the documented minimum hardware requirement.) Old is with prefetch, new is w/o. Both are compiled with GO386=sse2. Benchmarking is done on Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz. name old time/op new time/op delta BinaryTree17-4 2.89s ± 2% 2.87s ± 0% ~ (p=0.061 n=11+10) Fannkuch11-4 3.65s ± 0% 3.65s ± 0% ~ (p=0.365 n=11+11) FmtFprintfEmpty-4 52.1ns ± 0% 52.1ns ± 0% ~ (p=0.065 n=10+9) FmtFprintfString-4 168ns ± 0% 167ns ± 0% -0.48% (p=0.000 n=8+10) FmtFprintfInt-4 167ns ± 0% 167ns ± 1% ~ (p=0.591 n=9+10) FmtFprintfIntInt-4 295ns ± 0% 292ns ± 0% -0.99% (p=0.000 n=9+10) FmtFprintfPrefixedInt-4 327ns ± 0% 326ns ± 0% -0.24% (p=0.007 n=10+10) FmtFprintfFloat-4 431ns ± 0% 431ns ± 0% -0.07% (p=0.000 n=10+11) FmtManyArgs-4 1.13µs ± 0% 1.13µs ± 0% -0.37% (p=0.009 n=11+11) GobDecode-4 9.36ms ± 1% 9.33ms ± 0% -0.31% (p=0.006 n=11+10) GobEncode-4 7.38ms ± 1% 7.38ms ± 1% ~ (p=0.797 n=11+11) Gzip-4 394ms ± 0% 395ms ± 1% ~ (p=0.519 n=11+11) Gunzip-4 65.4ms ± 0% 65.4ms ± 0% ~ (p=0.739 n=10+10) HTTPClientServer-4 52.4µs ± 1% 52.5µs ± 1% ~ (p=0.748 n=11+11) JSONEncode-4 19.0ms ± 0% 19.0ms ± 0% ~ (p=0.780 n=9+10) JSONDecode-4 59.6ms ± 0% 59.6ms ± 0% ~ (p=0.720 n=9+10) Mandelbrot200-4 4.09ms ± 0% 4.09ms ± 0% ~ (p=0.295 n=11+9) GoParse-4 3.45ms ± 1% 3.43ms ± 1% -0.35% (p=0.040 n=11+11) RegexpMatchEasy0_32-4 101ns ± 1% 101ns ± 1% ~ (p=1.000 n=11+11) RegexpMatchEasy0_1K-4 796ns ± 0% 796ns ± 0% ~ (p=0.954 n=10+8) RegexpMatchEasy1_32-4 110ns ± 0% 110ns ± 1% ~ (p=0.289 n=9+11) RegexpMatchEasy1_1K-4 991ns ± 0% 991ns ± 0% ~ (p=0.784 n=10+8) RegexpMatchMedium_32-4 131ns ± 0% 130ns ± 0% -0.42% (p=0.004 n=11+9) RegexpMatchMedium_1K-4 41.9µs ± 1% 41.6µs ± 0% ~ (p=0.067 n=11+9) RegexpMatchHard_32-4 2.34µs ± 0% 2.34µs ± 0% ~ (p=0.208 n=11+11) RegexpMatchHard_1K-4 70.9µs ± 0% 71.0µs ± 0% ~ (p=0.968 n=9+10) Revcomp-4 819ms ± 0% 818ms ± 0% ~ (p=0.251 n=10+11) Template-4 73.9ms ± 0% 73.8ms ± 0% -0.25% (p=0.013 n=10+11) TimeParse-4 414ns ± 0% 414ns ± 0% ~ (p=0.809 n=11+10) TimeFormat-4 485ns ± 0% 485ns ± 0% ~ (p=0.404 n=11+7) name old speed new speed delta GobDecode-4 82.0MB/s ± 1% 82.3MB/s ± 0% +0.31% (p=0.007 n=11+10) GobEncode-4 104MB/s ± 1% 104MB/s ± 1% ~ (p=0.797 n=11+11) Gzip-4 49.2MB/s ± 0% 49.1MB/s ± 1% ~ (p=0.507 n=11+11) Gunzip-4 297MB/s ± 0% 297MB/s ± 0% ~ (p=0.670 n=10+10) JSONEncode-4 102MB/s ± 0% 102MB/s ± 0% ~ (p=0.794 n=9+10) JSONDecode-4 32.6MB/s ± 0% 32.6MB/s ± 0% ~ (p=0.334 n=9+9) GoParse-4 16.8MB/s ± 1% 16.9MB/s ± 1% ~ (p=0.052 n=11+11) RegexpMatchEasy0_32-4 314MB/s ± 0% 314MB/s ± 1% ~ (p=0.618 n=11+11) RegexpMatchEasy0_1K-4 1.29GB/s ± 0% 1.29GB/s ± 0% ~ (p=0.315 n=10+10) RegexpMatchEasy1_32-4 290MB/s ± 1% 290MB/s ± 1% ~ (p=0.667 n=10+11) RegexpMatchEasy1_1K-4 1.03GB/s ± 0% 1.03GB/s ± 0% ~ (p=0.829 n=10+8) RegexpMatchMedium_32-4 7.63MB/s ± 0% 7.65MB/s ± 0% ~ (p=0.142 n=11+11) RegexpMatchMedium_1K-4 24.4MB/s ± 1% 24.6MB/s ± 0% ~ (p=0.063 n=11+9) RegexpMatchHard_32-4 13.7MB/s ± 0% 13.7MB/s ± 0% ~ (p=0.302 n=11+11) RegexpMatchHard_1K-4 14.4MB/s ± 0% 14.4MB/s ± 0% ~ (p=0.784 n=9+10) Revcomp-4 310MB/s ± 0% 311MB/s ± 0% ~ (p=0.243 n=10+11) Template-4 26.2MB/s ± 0% 26.3MB/s ± 0% +0.24% (p=0.009 n=10+11) Update #12970. Change-Id: Id185080687a60c229a5cb2e5220e7ca1b53910e2 Reviewed-on: https://go-review.googlesource.com/15999Reviewed-by:
Austin Clements <austin@google.com> Reviewed-by:
Dmitry Vyukov <dvyukov@google.com>
-
Shenghou Ma authored
Fixes #12391. Change-Id: I31211cd711c035151785c3083571594d15c7d93e Reviewed-on: https://go-review.googlesource.com/16873Reviewed-by:
-
Michael Hudson-Doyle authored
Change-Id: I4d079d29408e5344701056c88882cfd3b3857478 Reviewed-on: https://go-review.googlesource.com/15973Reviewed-by:
-
Michael Hudson-Doyle authored
Change-Id: I3980d82c7df95e69522c3d2c90311f89c6fef0e1 Reviewed-on: https://go-review.googlesource.com/15972Reviewed-by:
-
Michael Hudson-Doyle authored
Change-Id: Ie79f72786b1d7154f1910e717a0faf354b913b89 Reviewed-on: https://go-review.googlesource.com/15970Reviewed-by:
-
Michael Hudson-Doyle authored
Change-Id: I79c60241df6c785f35371e70c777a7bd6e93571c Reviewed-on: https://go-review.googlesource.com/15968Reviewed-by:
-
- 12 Nov, 2015 7 commits
-
-
Michael Hudson-Doyle authored
Change-Id: Ifba76413b8aa78a221385bf505b92a3a5fbc3d24 Reviewed-on: https://go-review.googlesource.com/16713Reviewed-by:
-
Michael Hudson-Doyle authored
This requires changing the tls access code to match the patterns documented in the ABI documentation or the system linker will "optimize" it into ridiculousness. With this change, -buildmode=pie works, although as it is tested in testshared, the tests are not run yet. Change-Id: I1efa6687af0a5b8db3385b10f6542a49056b2eb3 Reviewed-on: https://go-review.googlesource.com/15971Reviewed-by:
-
Michael Hudson-Doyle authored
Change-Id: I0a8448c2b69f5cfa6f099d772f5eb3412f853045 Reviewed-on: https://go-review.googlesource.com/15969Reviewed-by:
-
Michael Hudson-Doyle authored
The PowerPC ISA does not have a PC-relative load instruction, which poses obvious challenges when generating position-independent code. The way the ELFv2 ABI addresses this is to specify that r2 points to a per "module" (shared library or executable) TOC pointer. Maintaining this pointer requires cooperation between codegen and the system linker: * Non-leaf functions leave space on the stack at r1+24 to save the TOC pointer. * A call to a function that *might* have to go via a PLT stub must be followed by a nop instruction that the system linker can replace with "ld r1, 24(r1)" to restore the TOC pointer (only when dynamically linking Go code). * When calling a function via a function pointer, the address of the function must be in r12, and the first couple of instructions (the "global entry point") of the called function use this to derive the address of the TOC for the module it is in. * When calling a function that is implemented in the same module, the system linker adjusts the call to skip over the instructions mentioned above (the "local entry point"), assuming that r2 is already correctly set. So this changeset adds the global entry point instructions, sets the metadata so the system linker knows where the local entry point is, inserts code to save the TOC pointer at 24(r1), adds a nop after any call not known to be local and copes with the odd non-local code transfer in the runtime (e.g. the stuff around jmpdefer). It does not actually compile PIC yet. Change-Id: I7522e22bdfd2f891745a900c60254fe9e372c854 Reviewed-on: https://go-review.googlesource.com/15967Reviewed-by:
-
Matthew Dempsky authored
darwin/386, freebsd/386, and linux/386 use a setldt system call to setup each M's thread-local storage area, and they need access to the M's id for this. The current code copies m.id into m.tls[0] (and this logic has been cargo culted to OSes like NetBSD and OpenBSD, which don't even need m.id to configure TLS), and then the 386 assembly loads m.tls[0]... but since the assembly code already has a pointer to the M, it might as well just load m.id directly. Change-Id: I1a7278f1ec8ebda8d1de3aa3a61993070e3a8cdf Reviewed-on: https://go-review.googlesource.com/16881 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Michael Hudson-Doyle authored
The larger stack frames causes the nosplit stack to overflow so the next change increases the stackguard. Change-Id: Ib2b4f24f0649eb1d13e3a58d265f13d1b6cc9bf9 Reviewed-on: https://go-review.googlesource.com/15964Reviewed-by:
-
Michael Hudson-Doyle authored
Larger stack frames mean nosplit functions use more stack and so the limit needs to increase. The change to test/nosplit.go is a bit ugly but I can't really think of a way to make it nicer. Change-Id: I2616b58015f0b62abbd62951575fcd0d2d8643c2 Reviewed-on: https://go-review.googlesource.com/16504Reviewed-by:
-
