1. 13 Jul, 2016 2 commits
  2. 12 Jul, 2016 4 commits
  3. 11 Jul, 2016 5 commits
  4. 08 Jul, 2016 5 commits
  5. 07 Jul, 2016 3 commits
  6. 06 Jul, 2016 3 commits
  7. 05 Jul, 2016 1 commit
    • Emmanuel Odeke's avatar
      encoding/gob: document Encode, EncodeValue nil pointer panics · 5a9d5c37
      Emmanuel Odeke authored
      Fixes #16258.
      
      Docs for Encode and EncodeValue do not mention that
      nil pointers are not permitted hence we panic,
      because Gobs encode values yet nil pointers have no value
      to encode. It moves a comment that was internal to EncodeValue
      to the top level to make it clearer to users what to expect
      when they pass in nil pointers.
      Supplements test TestTopLevelNilPointer.
      
      Change-Id: Ie54f609fde4b791605960e088456047eb9aa8738
      Reviewed-on: https://go-review.googlesource.com/24740Reviewed-by: 's avatarAndrew Gerrand <adg@golang.org>
      Run-TryBot: Andrew Gerrand <adg@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      5a9d5c37
  8. 04 Jul, 2016 2 commits
  9. 03 Jul, 2016 1 commit
  10. 02 Jul, 2016 1 commit
  11. 01 Jul, 2016 2 commits
  12. 30 Jun, 2016 8 commits
    • Brad Fitzpatrick's avatar
      net/http: update bundled http2 · b5aae1a2
      Brad Fitzpatrick authored
      Updates x/net/http2 to git rev b400c2e for https://golang.org/cl/24214,
      "http2: add additional blacklisted ciphersuites"
      
      Both TLS_RSA_WITH_AES_128_GCM_SHA256 & TLS_RSA_WITH_AES_256_GCM_SHA384
      are now blacklisted, per http://httpwg.org/specs/rfc7540.html#BadCipherSuites
      
      Change-Id: I8b9a7f4dc3c152d0675e196523ddd36111744984
      Reviewed-on: https://go-review.googlesource.com/24684Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      b5aae1a2
    • Alan Donovan's avatar
      cmd/vet: lostcancel: treat naked return as a use of named results · 08086e62
      Alan Donovan authored
      + test.
      
      Fixes #16230
      
      Change-Id: Idac995437146a9df9e73f094d2a31abc25b1fa62
      Reviewed-on: https://go-review.googlesource.com/24681Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      08086e62
    • Brad Fitzpatrick's avatar
      all: be consistent about spelling of cancelation · 7ea62121
      Brad Fitzpatrick authored
      We had ~30 one way, and these four new occurrences the other way.
      
      Updates #11626
      
      Change-Id: Ic6403dc4905874916ae292ff739d33482ed8e5bf
      Reviewed-on: https://go-review.googlesource.com/24683Reviewed-by: 's avatarRob Pike <r@golang.org>
      7ea62121
    • Alan Donovan's avatar
      context: cancel the context in ExampleWithTimeout, with explanation · fc12bb26
      Alan Donovan authored
      Fixes #16230
      
      Change-Id: Ibb10234a6c3ab8bd0cfd93c2ebe8cfa66f80f6b0
      Reviewed-on: https://go-review.googlesource.com/24682Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      fc12bb26
    • Austin Clements's avatar
      runtime/internal/sys: implement Ctz and Bswap in assembly for 386 · 9c8809f8
      Austin Clements authored
      Ctz is a hot-spot in the Go 1.7 memory manager. In SSA it's
      implemented as an intrinsic that compiles to a few instructions, but
      on the old backend (all architectures other than amd64), it's
      implemented as a fairly complex Go function. As a result, switching to
      bitmap-based allocation was a significant hit to allocation-heavy
      workloads like BinaryTree17 on non-SSA platforms.
      
      For unknown reasons, this hit 386 particularly hard. We can regain a
      lot of the lost performance by implementing Ctz in assembly on the
      386. This isn't as good as an intrinsic, since it still generates a
      function call and prevents useful inlining, but it's much better than
      the pure Go implementation:
      
      name                      old time/op    new time/op    delta
      BinaryTree17-12              3.59s ± 1%     3.06s ± 1%  -14.74%  (p=0.000 n=19+20)
      Fannkuch11-12                3.72s ± 1%     3.64s ± 1%   -2.09%  (p=0.000 n=17+19)
      FmtFprintfEmpty-12          52.3ns ± 3%    52.3ns ± 3%     ~     (p=0.829 n=20+19)
      FmtFprintfString-12          156ns ± 1%     148ns ± 3%   -5.20%  (p=0.000 n=18+19)
      FmtFprintfInt-12             137ns ± 1%     136ns ± 1%   -0.56%  (p=0.000 n=19+13)
      FmtFprintfIntInt-12          227ns ± 2%     225ns ± 2%   -0.93%  (p=0.000 n=19+17)
      FmtFprintfPrefixedInt-12     210ns ± 1%     208ns ± 1%   -0.91%  (p=0.000 n=19+17)
      FmtFprintfFloat-12           375ns ± 1%     371ns ± 1%   -1.06%  (p=0.000 n=19+18)
      FmtManyArgs-12               995ns ± 2%     978ns ± 1%   -1.63%  (p=0.000 n=17+17)
      GobDecode-12                9.33ms ± 1%    9.19ms ± 0%   -1.59%  (p=0.000 n=20+17)
      GobEncode-12                7.73ms ± 1%    7.73ms ± 1%     ~     (p=0.771 n=19+20)
      Gzip-12                      375ms ± 1%     374ms ± 1%     ~     (p=0.141 n=20+18)
      Gunzip-12                   61.8ms ± 1%    61.8ms ± 1%     ~     (p=0.602 n=20+20)
      HTTPClientServer-12         87.7µs ± 2%    86.9µs ± 3%   -0.87%  (p=0.024 n=19+20)
      JSONEncode-12               20.2ms ± 1%    20.4ms ± 0%   +0.53%  (p=0.000 n=18+19)
      JSONDecode-12               65.3ms ± 0%    65.4ms ± 1%     ~     (p=0.385 n=16+19)
      Mandelbrot200-12            4.11ms ± 1%    4.12ms ± 0%   +0.29%  (p=0.020 n=19+19)
      GoParse-12                  3.75ms ± 1%    3.61ms ± 2%   -3.90%  (p=0.000 n=20+20)
      RegexpMatchEasy0_32-12       104ns ± 0%     103ns ± 0%   -0.96%  (p=0.000 n=13+16)
      RegexpMatchEasy0_1K-12       805ns ± 1%     803ns ± 1%     ~     (p=0.189 n=18+18)
      RegexpMatchEasy1_32-12       111ns ± 0%     111ns ± 3%     ~     (p=1.000 n=14+19)
      RegexpMatchEasy1_1K-12      1.00µs ± 1%    1.00µs ± 1%   +0.50%  (p=0.003 n=19+19)
      RegexpMatchMedium_32-12      133ns ± 2%     133ns ± 2%     ~     (p=0.218 n=20+20)
      RegexpMatchMedium_1K-12     41.2µs ± 1%    42.2µs ± 1%   +2.52%  (p=0.000 n=18+16)
      RegexpMatchHard_32-12       2.35µs ± 1%    2.38µs ± 1%   +1.53%  (p=0.000 n=18+18)
      RegexpMatchHard_1K-12       70.9µs ± 2%    72.0µs ± 1%   +1.42%  (p=0.000 n=19+17)
      Revcomp-12                   1.06s ± 0%     1.05s ± 0%   -1.36%  (p=0.000 n=20+18)
      Template-12                 86.2ms ± 1%    84.6ms ± 0%   -1.89%  (p=0.000 n=20+18)
      TimeParse-12                 425ns ± 2%     428ns ± 1%   +0.77%  (p=0.000 n=18+19)
      TimeFormat-12                517ns ± 1%     519ns ± 1%   +0.43%  (p=0.001 n=20+19)
      [Geo mean]                  74.3µs         73.5µs        -1.05%
      
      Prior to this commit, BinaryTree17-12 on 386 was 33% slower than at
      the go1.6 tag. With this commit, it's 13% slower.
      
      On arm and arm64, BinaryTree17-12 is only ~5% slower than it was at
      go1.6. It may be worth implementing Ctz for them as well.
      
      I consider this change low risk, since the functions it replaces are
      simple, very well specified, and well tested.
      
      For #16117.
      
      Change-Id: Ic39d851d5aca91330134596effd2dab9689ba066
      Reviewed-on: https://go-review.googlesource.com/24640Reviewed-by: 's avatarRick Hudson <rlh@golang.org>
      Reviewed-by: 's avatarKeith Randall <khr@golang.org>
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      9c8809f8
    • Ian Lance Taylor's avatar
      os/exec: start checking for context cancelation in Start · 95483f26
      Ian Lance Taylor authored
      Previously we started checking for context cancelation in Wait, but
      that meant that when using StdoutPipe context cancelation never took
      effect.
      
      Fixes #16222.
      
      Change-Id: I89cd26d3499a6080bf1a07718ce38d825561899e
      Reviewed-on: https://go-review.googlesource.com/24650Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      95483f26
    • Ian Lance Taylor's avatar
      syscall: accept more variants of id output when testing as root · 6c136493
      Ian Lance Taylor authored
      This should fix the report at #16224, and also fixes running the test as
      root on my Ubuntu Trusty system.
      
      Fixes #16224.
      
      Change-Id: I4e3b5527aa63366afb33a7e30efab088d34fb302
      Reviewed-on: https://go-review.googlesource.com/24670
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      6c136493
    • Brad Fitzpatrick's avatar
      net/http: update bundled http2 · e0c8af09
      Brad Fitzpatrick authored
      Updates x/net/http2 to git rev 8e573f40 for https://golang.org/cl/24600,
      "http2: merge multiple GOAWAY frames' contents into error message"
      
      Fixes #14627 (more)
      
      Change-Id: I5231607c2c9e0d854ad6199ded43c59e59f62f52
      Reviewed-on: https://go-review.googlesource.com/24612
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: 's avatarAndrew Gerrand <adg@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      e0c8af09
  13. 29 Jun, 2016 3 commits
    • Brad Fitzpatrick's avatar
      net/http: be consistent about spelling of HTTP/1.x · 51b08d51
      Brad Fitzpatrick authored
      There was only one use of "HTTP/1.n" compared to "HTTP/1.x":
      
      h2_bundle.go://   "Just as in HTTP/1.x, header field names are strings of ASCII
      httputil/dump.go:// DumpRequest returns the given request in its HTTP/1.x wire
      httputil/dump.go:// intact. HTTP/2 requests are dumped in HTTP/1.x form, not in their
      response.go:// Write writes r to w in the HTTP/1.x server response format,
      server.go:      // Request.Body. For HTTP/1.x requests, handlers should read any
      server.go:// The default HTTP/1.x and HTTP/2 ResponseWriter implementations
      server.go:// The default ResponseWriter for HTTP/1.x connections supports
      server.go:// http1ServerSupportsRequest reports whether Go's HTTP/1.x server
      server.go:      // about HTTP/1.x Handlers concurrently reading and writing, like
      server.go:      // HTTP/1.x from here on.
      transport.go:   return fmt.Errorf("net/http: HTTP/1.x transport connection broken: %v", err)
      
      Be consistent.
      
      Change-Id: I93c4c873e500f51af2b4762055e22f5487a625ac
      Reviewed-on: https://go-review.googlesource.com/24610Reviewed-by: 's avatarAndrew Gerrand <adg@golang.org>
      51b08d51
    • Nick Harper's avatar
      crypto/ecdsa: Update documentation for Sign · cc6f5f6c
      Nick Harper authored
      Change-Id: I2b7a81cb809d109f10d5f0db957c614f466d6bfd
      Reviewed-on: https://go-review.googlesource.com/24582Reviewed-by: 's avatarAdam Langley <agl@golang.org>
      cc6f5f6c
    • Tom Bergan's avatar
      crypto/tls: Use the same buffer size in the client and server in the TLS throughput benchmark · ad82f2cf
      Tom Bergan authored
      I believe it's necessary to use a buffer size smaller than 64KB because
      (at least some versions of) Window using a TCP receive window less than
      64KB. Currently the client and server use buffer sizes of 16KB and 32KB,
      respectively (the server uses io.Copy, which defaults to 32KB internally).
      Since the server has been using 32KB, it should be safe for the client to
      do so as well.
      
      Fixes #15899
      
      Change-Id: I36d44b29f2a5022c03fc086213d3c1adf153e983
      Reviewed-on: https://go-review.googlesource.com/24581Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      ad82f2cf