Commits · 782464aea540e9ebf720509ce627d192d84d92a7 · go / golang

06 Oct, 2012 5 commits

runtime: fix a panic when growing zero-width-element slices. · 782464ae
Rémy Oudompheng authored Oct 06, 2012
```
Fixes #4197.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6611056
```
782464ae

pprof: add goroutine blocking profiling · 4cc7bf32

Dmitriy Vyukov authored Oct 06, 2012

The profiler collects goroutine blocking information similar to Google Perf Tools.
You may see an example of the profile (converted to svg) attached to
http://code.google.com/p/go/issues/detail?id=3946
The public API changes are:
+pkg runtime, func BlockProfile([]BlockProfileRecord) (int, bool)
+pkg runtime, func SetBlockProfileRate(int)
+pkg runtime, method (*BlockProfileRecord) Stack() []uintptr
+pkg runtime, type BlockProfileRecord struct
+pkg runtime, type BlockProfileRecord struct, Count int64
+pkg runtime, type BlockProfileRecord struct, Cycles int64
+pkg runtime, type BlockProfileRecord struct, embedded StackRecord

R=rsc, dave, minux.ma, r
CC=gobot, golang-dev, r, remyoudompheng
https://golang.org/cl/6443115

4cc7bf32

test: Add rundir, rundircmpout and errorcheckdir commands to testlib and run.go · ebb0e5db

Daniel Morsing authored Oct 06, 2012

rundir will compile each file in the directory in lexicographic order, link the last file as the main package and run the resulting program. rundircmpout is an related command, that will compare the output of the program to an corresponding .out file

errorcheckdir will compile each file in a directory in lexicographic order, running errorcheck on each file as it compiles. All compilations are assumed to be successful except for the last file. However, If a -0 flag is present on the command, the last compilation will also be assumed successful

This CL also includes a small refactoring of run.go. It was getting unwieldy and the meaning of the run commands was hidden behind argument line formatting.

Fixes #4058.

R=rsc, minux.ma, remyoudompheng, iant
CC=golang-dev
https://golang.org/cl/6554071

ebb0e5db

cmd/cc: map C int to int32 in Go defs · 16bea49e
Jan Ziak authored Oct 06, 2012
```
R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6621052
```
16bea49e

cmd/5g: avoid temporary during constant OINDEX · ed0c5dd1

Dave Cheney authored Oct 06, 2012

func addr(s[]int) *int {
	return &s[2]
}

--- prog list "addr" ---
0000 (/home/dfc/src/addr.go:5) TEXT     addr+0(SB),$0-16
0001 (/home/dfc/src/addr.go:6) MOVW     $s+0(FP),R0
0002 (/home/dfc/src/addr.go:6) MOVW     4(R0),R1
0003 (/home/dfc/src/addr.go:6) MOVW     $2,R2
0004 (/home/dfc/src/addr.go:6) CMP      R2,R1,
0005 (/home/dfc/src/addr.go:6) BHI      ,7(APC)
0006 (/home/dfc/src/addr.go:6) BL       ,runtime.panicindex+0(SB)
0007 (/home/dfc/src/addr.go:6) MOVW     0(R0),R0
0008 (/home/dfc/src/addr.go:6) MOVW     $8,R1
0009 (/home/dfc/src/addr.go:6) ADD      R1,R0
0010 (/home/dfc/src/addr.go:6) MOVW     R0,.noname+12(FP)
0011 (/home/dfc/src/addr.go:6) RET      ,

becomes

--- prog list "addr" ---
0000 (/home/dfc/src/addr.go:5) TEXT     addr+0(SB),$0-16
0001 (/home/dfc/src/addr.go:6) MOVW     $s+0(FP),R0
0002 (/home/dfc/src/addr.go:6) MOVW     4(R0),R1
0003 (/home/dfc/src/addr.go:6) MOVW     $2,R2
0004 (/home/dfc/src/addr.go:6) CMP      R2,R1,
0005 (/home/dfc/src/addr.go:6) BHI      ,7(APC)
0006 (/home/dfc/src/addr.go:6) BL       ,runtime.panicindex+0(SB)
0007 (/home/dfc/src/addr.go:6) MOVW     0(R0),R0
0008 (/home/dfc/src/addr.go:6) ADD      $8,R0
0009 (/home/dfc/src/addr.go:6) MOVW     R0,.noname+12(FP)
0010 (/home/dfc/src/addr.go:6) RET      ,

R=rsc, remyoudompheng, minux.ma
CC=golang-dev
https://golang.org/cl/6590056

ed0c5dd1

05 Oct, 2012 8 commits

cmd/5g: fix out of registers in nested calls, add compiler torture test. · 3a4e156a
Rémy Oudompheng authored Oct 05, 2012
```
R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev, remy
https://golang.org/cl/6586072
```
3a4e156a

crypto/sha256, crypto/sha512: 1.3x speedup · b459afe8

Dmitry Chestnykh authored Oct 05, 2012

SHA-256:

benchmark          old ns/op    new ns/op    delta
BenchmarkHash1K        21686        16912  -22.01%
BenchmarkHash8K       173216       135020  -22.05%

benchmark           old MB/s     new MB/s  speedup
BenchmarkHash1K        47.22        60.55    1.28x
BenchmarkHash8K        47.29        60.67    1.28x

SHA-512:

benchmark          old ns/op    new ns/op    delta
BenchmarkHash1K        14323        11163  -22.06%
BenchmarkHash8K       114120        88693  -22.28%

benchmark           old MB/s     new MB/s  speedup
BenchmarkHash1K        71.49        91.73    1.28x
BenchmarkHash8K        71.78        92.36    1.29x

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/6584071

b459afe8

runtime: mask SSE exceptions on plan9/amd64 · 23599ca2

Akshat Kumar authored Oct 05, 2012

The Go run-time assumes that all SSE floating-point exceptions
are masked so that Go programs are not broken by such invalid
operations. By default, the 64-bit version of the Plan 9 kernel
masks only some SSE floating-point exceptions. Here, we mask
them all on a per-thread basis.

R=rsc, rminnich, minux.ma
CC=golang-dev
https://golang.org/cl/6592056

23599ca2

doc/codewalk: make it work with jQuery 1.8.2 · 4077819f

Shenghou Ma authored Oct 05, 2012

    so that it could work with the bundled jQuery.

R=adg
CC=golang-dev
https://golang.org/cl/6592073

4077819f

go/printer: don't forget the .0 in 1.0 · 1f6fba2d

Robert Griesemer authored Oct 05, 2012

(use floating-point rather then integer constant division)

gofmt -w src misc

Fixes #3965.

R=r, bsiegert, 0xjnml
CC=bradfitz, golang-dev
https://golang.org/cl/6610051

1f6fba2d

go/printer: parenthesize literal function types in conversions · 1065c6f6
Robert Griesemer authored Oct 05, 2012
```
Also: gofmt -w src misc

R=r
CC=golang-dev, iant
https://golang.org/cl/6591071
```
1065c6f6

go/parser: unify parsing of const and var declarations · 6c740e76

Robert Griesemer authored Oct 05, 2012

The AST representation is already identical. Making the
code (nearly) identical in the parser reduces code size
and ensures that the ast.ValueSpec nodes have the same
values (specifically, iota). This in turn permits the
sharing of much of the respective code in the typechecker.

While at it: type functions work now, so use them.

R=r
CC=golang-dev
https://golang.org/cl/6624047

6c740e76

net/mail: make address parsing (more) public · 9f807fcc

Graham Miller authored Oct 05, 2012

Code for parsing email addresses was already partially part of the public API with "func (Header) AddressList". This CL adds a trivial implementation for two public methods to parse address and lists from a string. With tests.

R=dsymonds
CC=golang-dev
https://golang.org/cl/5676067

9f807fcc

04 Oct, 2012 8 commits
- crypto/x509: add DecryptBlock function for loading password protected keys · 70ab57ea
  Jeff Wendling authored Oct 04, 2012
```
Adds a DecryptBlock function which takes a password and a *pem.Block and
returns the decrypted DER bytes suitable for passing into other crypto/x509
functions.

R=golang-dev, agl, leterip
CC=golang-dev
https://golang.org/cl/6555052
```
  70ab57ea
- lib/godoc/godoc.html: try Google hosted jQuery first, fallback to locally hosted one · 593a6285
  Shenghou Ma authored Oct 04, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6593078
```
  593a6285
- godoc: make examples editable and runnable in playground · 3fd5e0be
  Andrew Gerrand authored Oct 04, 2012
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/6523045
```
  3fd5e0be
- godoc: add jQuery to Go repository, rewrite godocs.js to use jQuery · 65dbe678
  Andrew Gerrand authored Oct 04, 2012
```
For golang.org I intend to rewrite the jquery link in godoc.html
to point to the Google-hosted jquery.js.

R=dsymonds, minux.ma
CC=golang-dev
https://golang.org/cl/6589071
```
  65dbe678
- cmd/go: add support for -test.benchmem · 7e2e4a73
  Shenghou Ma authored Oct 04, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6587074
```
  7e2e4a73
- src/run.bat: add new flag for api tool · dfa139aa
  Rob Pike authored Oct 04, 2012
```
Fixes build.
Makes me annoyed.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6591074
```
  dfa139aa
- cmd/api: add exception file · d87d4889
  Rob Pike authored Oct 04, 2012
```
Fixes build.

R=golang-dev, adg, bradfitz, dsymonds, dave
CC=golang-dev
https://golang.org/cl/6586074
```
  d87d4889
- godoc: show contents in correct order, expand sections on click · e7f45314
  Andrew Gerrand authored Oct 04, 2012
```
R=dsymonds
CC=gobot, golang-dev
https://golang.org/cl/6588079
```
  e7f45314
03 Oct, 2012 9 commits

go/doc: add nil to list of predeclared constants · ce6acefc
Andrew Gerrand authored Oct 03, 2012
```
R=gri
CC=gobot, golang-dev
https://golang.org/cl/6601054
```
ce6acefc
go/doc: rewrite whole file examples for playground · 81ae666f
Andrew Gerrand authored Oct 03, 2012
```
R=gri
CC=gobot, golang-dev
https://golang.org/cl/6592061
```
81ae666f

go spec: conversion types starting with "func" must be parenthesized · 3188ffc9

Robert Griesemer authored Oct 03, 2012

Also: Be explicit what operator means with respect to conversion types.

The parenthesis requirement is a language change. At the moment,
literal function types in conversions that cannot possibly be
followed by a '(' don't need parentheses. For instance:

        func(int)int(x)  ->  same as (func(int)int)(x)
        func()()(x)      ->  same as (func())(x)

but:

        func(int)(x)	 ->  could be func(int)x {...}

Fixes #4109.

R=rsc, r, iant, ken, iant
CC=golang-dev
https://golang.org/cl/6584065

3188ffc9

misc/dashboard: set charset utf-8 on build log downloads · 256daf2c
Brad Fitzpatrick authored Oct 03, 2012
```
Fixes #4187

R=golang-dev, dave, minux.ma
CC=golang-dev
https://golang.org/cl/6587071
```
256daf2c
godoc: move Examples above Index and make them both collapsable · 516306f6
Andrew Gerrand authored Oct 03, 2012
```
R=golang-dev, dsymonds, bradfitz, r
CC=golang-dev
https://golang.org/cl/6591066
```
516306f6
testing: update package docs to use ResetTimer() instead of StopTimer/StartTimer() · 727e5ce9
Shenghou Ma authored Oct 03, 2012
```
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/6591051
```
727e5ce9

text/template: better error messages during execution, · 7f4b4c0c

Rob Pike authored Oct 03, 2012

They now show the correct name, the byte offset on the line, and context for the failed evaluation.
Before:
        template: three:7: error calling index: index out of range: 5
After:
        template: top:7:20: executing "three" at <index "hi" $>: error calling index: index out of range: 5
Here top is the template that was parsed to create the set, and the error appears with the action
starting at byte 20 of line 7 of "top", inside the template called "three", evaluating the expression
<index "hi" $>.

Also fix a bug in index: it didn't work on strings. Ouch.

Also fix bug in error for index: was showing type of index not slice.
The real previous error was:
        template: three:7: error calling index: can't index item of type int
The html/template package's errors can be improved by building on this;
I'll do that in a separate pass.

Extends the API for text/template/parse but only by addition of a field and method. The
old API still works.

Fixes #3188.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6576058

7f4b4c0c

go/ast: track position of <- for channel types · 1659aef3

Robert Griesemer authored Oct 03, 2012

This is a backward-compatible API change.

Without the correct <- position information,
certain channel types have incorrect position
information.

R=iant, iant
CC=golang-dev
https://golang.org/cl/6585063

1659aef3

os/user : use username as fullname if all else fails (on windows) · 5f7f9062
Shivakumar GN authored Oct 03, 2012
```
Fixes #4113.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6545054
```
5f7f9062

02 Oct, 2012 4 commits

go/parser: correctly parse <-chan T(x) as <-(chan T)(x) · 05dc3bf5
Robert Griesemer authored Oct 02, 2012
```
Fixes #4110.

R=iant
CC=golang-dev
https://golang.org/cl/6597069
```
05dc3bf5

codereview.py: suggest installing Mercurial from official website · 10ea3254

Robert Hencke authored Oct 02, 2012

Continuation of https://golang.org/cl/6499053/

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6584059

10ea3254

cmd/8g: do not take the address of string/slice for &s[i] · 2de064b6

Rémy Oudompheng authored Oct 02, 2012

A similar change was made in 6g recently.

LEALs in cmd/go: 31440 before, 27867 after.

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    7065794000   6723617000   -4.84%
BenchmarkFannkuch11      7767395000   7477945000   -3.73%
BenchmarkGobDecode         34708140     34857820   +0.43%
BenchmarkGobEncode         10998780     10960060   -0.35%
BenchmarkGzip            1603630000   1471052000   -8.27%
BenchmarkGunzip           242573900    240650400   -0.79%
BenchmarkJSONEncode       120842200    117966100   -2.38%
BenchmarkJSONDecode       247254900    249103100   +0.75%
BenchmarkMandelbrot200     29237330     29241790   +0.02%
BenchmarkParse              8111320      8096865   -0.18%
BenchmarkRevcomp         2595780000   2694153000   +3.79%
BenchmarkTemplate         276679600    264497000   -4.40%

benchmark                              old ns/op    new ns/op    delta
BenchmarkAppendFloatDecimal                  429          416   -3.03%
BenchmarkAppendFloat                         780          740   -5.13%
BenchmarkAppendFloatExp                      746          700   -6.17%
BenchmarkAppendFloatNegExp                   752          694   -7.71%
BenchmarkAppendFloatBig                     1228         1108   -9.77%
BenchmarkAppendFloat32Integer                457          416   -8.97%
BenchmarkAppendFloat32ExactFraction          662          631   -4.68%
BenchmarkAppendFloat32Point                  771          735   -4.67%
BenchmarkAppendFloat32Exp                    722          672   -6.93%
BenchmarkAppendFloat32NegExp                 724          659   -8.98%
BenchmarkAppendFloat64Fixed1                 429          400   -6.76%
BenchmarkAppendFloat64Fixed2                 463          442   -4.54%

Update #1914.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/6574043

2de064b6

race: gc changes · 041fc8bf

Dmitriy Vyukov authored Oct 02, 2012

This is the first part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044
This change makes gc compiler instrument memory accesses when supplied with -b flag.

R=rsc, nigeltao, lvd
CC=golang-dev
https://golang.org/cl/6497074

041fc8bf

01 Oct, 2012 6 commits

go/doc: strip example output comment from synthesized main function · cf513387
Andrew Gerrand authored Oct 01, 2012
```
R=gri
CC=gobot, golang-dev
https://golang.org/cl/6524047
```
cf513387

cmd/5g: avoid temporary during constant binary op · 7b36acc4

Dave Cheney authored Oct 01, 2012

This CL is an attempt to backport the abop code generation from 6g. This improves the generation of the range offset if the increment can be encoded directly via Operand2 shift encoding.

0023 (/home/dfc/src/range.go:7) BGE     ,29(APC)
0024 (/home/dfc/src/range.go:7) MOVW    0(R3),R5
0025 (/home/dfc/src/range.go:7) MOVW    $4,R1
0026 (/home/dfc/src/range.go:7) ADD     R1,R3,R3
0027 (/home/dfc/src/range.go:8) ADD     R5,R4,R4
0028 (/home/dfc/src/range.go:7) B       ,17(APC)

becomes

0023 (/home/dfc/src/range.go:7) BGE     ,28(APC)
0024 (/home/dfc/src/range.go:7) MOVW    0(R3),R0
0025 (/home/dfc/src/range.go:7) ADD     $4,R3,R3
0026 (/home/dfc/src/range.go:8) ADD     R0,R4,R4
0027 (/home/dfc/src/range.go:7) B       ,17(APC)

Benchmarks are unimpressive

dfc@qnap:~/go/test/bench/go1$ ~/go/misc/benchcmp {old,new}.txt
benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    2147483647   2147483647   +0.93%
BenchmarkFannkuch11      2147483647   2147483647   -2.52%
BenchmarkGobDecode        196135200    195842000   -0.15%
BenchmarkGobEncode         78581650     76734450   -2.35%
BenchmarkGzip            2147483647   2147483647   -0.47%
BenchmarkGunzip          1087243000   1070254000   -1.56%
BenchmarkJSONEncode      1107558000   1146077000   +3.48%
BenchmarkJSONDecode      2147483647   2147483647   -0.07%
BenchmarkMandelbrot200   2147483647   2147483647   -0.77%
BenchmarkParse             74328550     71653400   -3.60%
BenchmarkRevcomp          111123900    109325950   -1.62%
BenchmarkTemplate        2147483647   2147483647   -0.82%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode             3.91         3.92    1.00x
BenchmarkGobEncode             9.77        10.00    1.02x
BenchmarkGzip                  3.65         3.66    1.00x
BenchmarkGunzip               17.85        18.13    1.02x
BenchmarkJSONEncode            1.75         1.69    0.97x
BenchmarkJSONDecode            0.83         0.83    1.00x
BenchmarkParse                 0.78         0.81    1.04x
BenchmarkRevcomp              22.87        23.25    1.02x
BenchmarkTemplate              0.84         0.85    1.01x

R=remyoudompheng, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6564067

7b36acc4

archive/tar: fix inconsistent namespace usage in example · b9e423ef

Jeremy Jackins authored Oct 01, 2012

This fixes some example code in the tar package documentation, which
first refers to tar.NewWriter and then to Header, which is inconsistent
because NewWriter and Header are both in the tar namespace.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6595050

b9e423ef

math/big: avoid some allocation in Exp · 9070d575

Adam Langley authored Oct 01, 2012

benchmark                        old ns/op    new ns/op    delta
BenchmarkRSA1024Decrypt             745686       644964  -13.51%
BenchmarkRSA2048Decrypt            5517318      5049200   -8.48%
Benchmark3PrimeRSA2048Decrypt      3767386      3288048  -12.72%

R=gri
CC=gobot, golang-dev
https://golang.org/cl/6566043

9070d575

cmd/godoc: clearer comments in FormatSelections · 5a03cd56
Robert Griesemer authored Oct 01, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6561073
```
5a03cd56
A+C: add Jeff Wendling (Individual CLA) · 3f7fb918
Adam Langley authored Oct 01, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6596050
```
3f7fb918