Skip to content

G
golang
Switch branch/tag
  1. 02 Nov, 2011 9 commits
  3. 01 Nov, 2011 11 commits
  5. 31 Oct, 2011 13 commits
  7. 29 Oct, 2011 1 commit
    • Dave Cheney's avatar
      exp/ssh: fix length header leaking into channel data streams. · 0f6b80c6
      Dave Cheney authored 
      The payload of a data message is defined as an SSH string type,
which uses the first four bytes to encode its length. When channelData
and channelExtendedData were added I defined Payload as []byte to
be able to use it directly without a string to []byte conversion. This
resulted in the length data leaking into the payload data.

This CL fixes the bug, and restores agl's original fast path code.

Additionally, a bug whereby s.lock was not released if a packet arrived
for an invalid channel has been fixed.

Finally, as they were no longer used, I have removed
the channelData and channelExtedendData structs.

R=agl, rsc
CC=golang-dev
https://golang.org/cl/5330053
      0f6b80c6
  9. 28 Oct, 2011 6 commits
    • Andrew Balholm's avatar
      html: adjust bookmark in "adoption agency" algorithm · 604e10c3
      Andrew Balholm authored 
      In the adoption agency algorithm, the formatting element is sometimes
removed from the list of active formatting elements and reinserted at a later index.
In that case, the bookmark showing where it is to be reinserted needs to be moved,
so that its position relative to its neighbors remains the same
(and also so that it doesn't become out of bounds).

Pass tests1.dat, test 70:
<DIV> abc <B> def <I> ghi <P> jkl </B>

| <html>
|   <head>
|   <body>
|     <div>
|       " abc "
|       <b>
|         " def "
|         <i>
|           " ghi "
|       <i>
|         <p>
|           <b>
|             " jkl "

Also pass tests through test 76:
<test attribute---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------->

R=nigeltao
CC=golang-dev
https://golang.org/cl/5322052
      604e10c3
    • Andrew Balholm's avatar
      html: don't run "adoption agency" on elements that aren't in scope. · 03f163c7
      Andrew Balholm authored 
      Pass tests1.dat, test 55:
<!DOCTYPE html><font><table></font></table></font>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <font>
|       <table>

Also pass tests through test 69:
<DIV> abc <B> def <I> ghi <P> jkl

R=nigeltao
CC=golang-dev
https://golang.org/cl/5309074
      03f163c7
    • Russ Cox's avatar
      fmt: handle os.Error values · 0e81e508
      Russ Cox authored 
      Handling os.Error is no different than handling fmt.Stringer
here, so the code is redundant now, but it will be necessary
once error goes in.

Adding it now will make gofix fix it.

R=r
CC=golang-dev
https://golang.org/cl/5331045
      0e81e508
    • Russ Cox's avatar
      template: do not use error as stringer · 853c8463
      Russ Cox authored 
      R=r
CC=golang-dev
https://golang.org/cl/5305069
      853c8463
    • Russ Cox's avatar
      gob: split uses of gobError, remove unnecessary embedding · c0a0fd6c
      Russ Cox authored 
      Will make gofix for error run more smoothly.
The overloading of gobError appears to be unintentional.

R=r
CC=golang-dev
https://golang.org/cl/5308060
      c0a0fd6c
    • Russ Cox's avatar
      strconv: use better errors than os.EINVAL, os.ERANGE · c1178aae
      Russ Cox authored 
      R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5327052
      c1178aae