Skip to content

G
golang
Switch branch/tag
  1. 27 Sep, 2011 4 commits
  3. 26 Sep, 2011 17 commits
  5. 25 Sep, 2011 2 commits
  7. 24 Sep, 2011 2 commits
  9. 23 Sep, 2011 9 commits
  11. 22 Sep, 2011 6 commits
    • Paul Sbarra's avatar
      vim: Send GoFmt errors to a location list · 3dc3fa0d
      Paul Sbarra authored 
      R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5043046
      3dc3fa0d
    • Andrew Gerrand's avatar
      doc: link to image blog post · 76d82dbc
      Andrew Gerrand authored 
      R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5086048
      76d82dbc
    • Andrew Gerrand's avatar
      tag weekly.2011-09-21 · 5c1f2bcf
      Andrew Gerrand authored 
      R=dsymonds
CC=golang-dev
https://golang.org/cl/5086049
      5c1f2bcf
    • Andrew Gerrand's avatar
      weekly.2011-09-21 · e4ac43b7
      Andrew Gerrand authored 
      R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5075050
      e4ac43b7
    • Mike Samuel's avatar
      exp/template/html: elide comments in template source. · 35819729
      Mike Samuel authored 
      When templates are stored in external files, developers often embed
comments to explain&|disable code.

  <!-- Oblique reference to project code name here -->
  {{if .C}}...{{else}}<!-- commented out default -->{{end}}

This unnecessarily increases the size of shipped HTML and can leak
information.

This change elides all comments of the following types:
1. <!-- ... --> comments found in source.
2. /*...*/ and // comments found in <script> elements.
3. /*...*/ and // comments found in <style> elements.

It does not elide /*...*/ or // comments found in HTML attributes:
4. <button onclick="/*...*/">
5. <div style="/*...*/">

I can find no examples of comments in attributes in Closure Templates
code and doing so would require keeping track of character positions
post decode in

  <button onclick="/&#42;...*/">

To prevent token joining, /*comments*/ are JS and CSS comments are
replaced with a whitespace char.
HTML comments are not, but to prevent token joining we could try to
detect cases like
   <<!---->b>
   </<!---->b>
which has a well defined meaning in HTML but will cause a validator
to barf.  This is difficult, and this is a very minor case.
I have punted for now, but if we need to address this case, the best
way would be to normalize '<' in stateText to '&lt;' consistently.

The whitespace to replace a JS /*comment*/ with depends on whether
there is an embedded line terminator since
    break/*
    */foo
    ...
is equivalent to
    break;
    foo
    ...
while
    break/**/foo
    ...
is equivalent to
    break foo;
    ...

Comment eliding can interfere with IE conditional comments.
http://en.wikipedia.org/wiki/Conditional_comment

<!--[if IE 6]>
<p>You are using Internet Explorer 6.</p>
<![endif]-->

/*@cc_on
  document.write("You are using IE4 or higher");
@*/

I have not encountered these in production template code, and
the typed content change in CL 4962067 provides an escape-hatch
if conditional comments are needed.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4999042
      35819729
    • David Symonds's avatar
      A&C: Add Paul Sbarra. · 7eab0c2b
      David Symonds authored 
      R=golang-dev, adg
CC=golang-dev, sbarra.paul
https://golang.org/cl/5044045
      7eab0c2b