Commits · 7d1c5328ed2b0082acdc0b47e6565e4b254e9f8c · go / golang

17 Feb, 2012 34 commits

math/rand: Intn etc. should panic if their argument is <= 0. · 7d1c5328

Rob Pike authored Feb 17, 2012

I am making a unilateral decision here. I could also settle for returning 0,
as long it's documented, but I argue that it's equivalent to an index
out of bounds.

Fixes #2892.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5676079

7d1c5328

os: fix existential typo · 566e0fe7
Anthony Martin authored Feb 17, 2012
```
R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/5675081
```
566e0fe7
go/doc: move Example code from go/ast to go/doc. · b6e2d6b7
Robert Griesemer authored Feb 17, 2012
```
Fixes #3048.

R=rsc
CC=golang-dev
https://golang.org/cl/5672081
```
b6e2d6b7
cmd/gc: fix comparison of struct with _ field · c4c92ebe
Russ Cox authored Feb 17, 2012
```
Fixes #2989.

R=ken2
CC=golang-dev
https://golang.org/cl/5674091
```
c4c92ebe
runtime: remove use of ?: · ce020ffa
Gustavo Niemeyer authored Feb 17, 2012
```
Fixes #3061.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5656089
```
ce020ffa
godoc: don't print spurious suggestion when running "go doc foo" · 6cdf0a1e
Robert Griesemer authored Feb 17, 2012
```
Fixes #3041.

R=rsc
CC=golang-dev
https://golang.org/cl/5671087
```
6cdf0a1e
go/parser: example for ParseFile use · f7ce57b1
Robert Griesemer authored Feb 17, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/5675074
```
f7ce57b1
go/scanner: replace comment with example · ac6357b4
Robert Griesemer authored Feb 17, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/5676074
```
ac6357b4

misc/dist/windows: distro builder updates · 4f5ffe56

Joe Poirier authored Feb 17, 2012

files moved from misc/windows, bash packager file replaced with Windows batch file

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5677074

4f5ffe56

cmd/dist: make dir check in defaulttarg() more robust · 710d0540

Shenghou Ma authored Feb 17, 2012

1, strip last path separator from $GOROOT
   The user might define GOROOT=/path/to/go/, but then the dir
   check in defaulttarg() will always complain the current dir
   is not within $GOROOT/src/.
2, resolve symlinks in the default goroot
   Or if getcwd() returns a fully-resolved path, the check in
   defaulttarg() will always fail.

R=rsc
CC=golang-dev
https://golang.org/cl/5649073

710d0540

8a, 8l: add EMMS instruction · fc444eba
Evan Shaw authored Feb 17, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5673081
```
fc444eba
.hgignore: add src/cmd/dist/dist.dSYM · a2bdb5c0
Shenghou Ma authored Feb 17, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5677076
```
a2bdb5c0
doc: clarify gccgo support for segmented stacks · ebc40077
Ian Lance Taylor authored Feb 17, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5671081
```
ebc40077
sync: say that Cond.Wait can not return spuriously · 76eb911a
Dmitriy Vyukov authored Feb 17, 2012
```
R=golang-dev, r, rsc, remyoudompheng, r
CC=golang-dev
https://golang.org/cl/5674086
```
76eb911a

net/rpc: fix spurious panic in test · 649f771b

Dmitriy Vyukov authored Feb 17, 2012

The panic happens if -benchtime flag is specified:
go test -bench=EndToEndAsyncHTTP -benchtime=120

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5677075

649f771b

runtime: silence warnings · b8f46564
Alex Brainman authored Feb 17, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5656084
```
b8f46564
faq: add entry about nil interfaces vs. nil pointers · 1e0f97ac
Rob Pike authored Feb 17, 2012
```
Fixes #2778.

R=bradfitz, rsc, iant, adg
CC=golang-dev
https://golang.org/cl/5672078
```
1e0f97ac

test: use testlib (final 61) · 57eb06fe

Russ Cox authored Feb 17, 2012

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5671080

57eb06fe

test: use testlib (fourth 100) · d2cc9884

Russ Cox authored Feb 17, 2012

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5673079

d2cc9884

test: use testlib (third 100) · 8080384a

Russ Cox authored Feb 17, 2012

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5656083

8080384a

test: use testlib (second 100) · 2b1c9b4b

Russ Cox authored Feb 17, 2012

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev
CC=golang-dev
https://golang.org/cl/5673078

2b1c9b4b

test: use testlib (first 100) · 0b477ef1

Russ Cox authored Feb 17, 2012

X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5656082

0b477ef1

test: add testlib · a0c13b9d

Russ Cox authored Feb 17, 2012

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5676077

a0c13b9d

net/url: API · b27bd42a

Russ Cox authored Feb 17, 2012

Convert cryptotype to general go1rename fix.
Add os.Exec -> syscall.Exec fix along with new
URL fixes.

Fixes #2946.

R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/5672072

b27bd42a

net/url: spell the package name correctly. · d8e715ca
David Symonds authored Feb 17, 2012
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5676076
```
d8e715ca
fix: walk ast.Ellipsis values. · a52027a4
Nigel Tao authored Feb 17, 2012
```
Fixes #2583.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5671078
```
a52027a4
runtime: Permit default behaviour of SIGTSTP, SIGTTIN, SIGTTOU. · 3d8ebefb
David Symonds authored Feb 17, 2012
```
Fixes #3037.

R=rsc, minux.ma, r, rsc
CC=golang-dev
https://golang.org/cl/5674072
```
3d8ebefb

os: add a simple example to the package doc. · efb28b2a

Rob Pike authored Feb 17, 2012

Shows error handling and slices for Read and Write.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5676075

efb28b2a

log/syslog: disable on Windows · a4d124d7

Russ Cox authored Feb 17, 2012

We want to be able to implement good Windows support
after Go 1.  Right now Windows tries to use Unix domain
sockets, and I'd rather just have it not be available.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5671076

a4d124d7

net: package doc overview / examples · 008e64da
Brad Fitzpatrick authored Feb 17, 2012
```
Fixes #2774

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5673076
```
008e64da

net, os, syscall: delete os.EPLAN9 · 03d4c7c7

Mikio Hara authored Feb 17, 2012

Also fixes plan9 cross-build.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5675073

03d4c7c7

debug/dwarf: address TODO in doc comment for New · a15f59ef
Rob Pike authored Feb 17, 2012
```
Fixes #2844.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5675072
```
a15f59ef
doc: provide example filepath.Walk for go1 · 91672686
Mike Rosset authored Feb 17, 2012
```
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5674067
```
91672686
net/textproto: delete spurious quote · 785ee50c
Rob Pike authored Feb 17, 2012
```
Sigh.

R=golang-dev, gri, nigeltao
CC=golang-dev
https://golang.org/cl/5675071
```
785ee50c

16 Feb, 2012 6 commits

net/textproto: add Conn to doc comment · c49edc61

Rob Pike authored Feb 16, 2012

This revolutionary transfiguration undergirding the code base
Fixes #2945.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5676072

c49edc61

os: delete os.EINVAL and so on · 56069f03

Rob Pike authored Feb 16, 2012

The set of errors forwarded by the os package varied with system and
was therefore non-portable.
Three helpers added for portable error checking: IsExist, IsNotExist, and IsPermission.
One or two more may need to come, but let's keep the set very small to discourage
thinking about errors that way.

R=mikioh.mikioh, gustavo, r, rsc
CC=golang-dev
https://golang.org/cl/5672047

56069f03

path/filepath: fix test on darwin · c560a074

Rob Pike authored Feb 16, 2012

/tmp being itself a symlink causes problems for the test, so use / as the absolute path.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5675070

c560a074

cmd/gc: correctly typecheck expression lists in returns. · 1d3ca923

Rémy Oudompheng authored Feb 16, 2012

Invalid return statements were accidentally compiling or
triggering internal errors.
Fixes #3044.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/5673074

1d3ca923

go/parser: imaginary constants and ! may start an expression · f43d2b7f
Robert Griesemer authored Feb 16, 2012
```
Complete list of tokens that can start a top-level expression.

R=rsc
CC=golang-dev
https://golang.org/cl/5671074
```
f43d2b7f
go spec: struct comparison only compares non-blank fields · 3908467b
Robert Griesemer authored Feb 16, 2012
```
Fixes #3031.

R=golang-dev, rsc, r, iant
CC=golang-dev
https://golang.org/cl/5676054
```
3908467b