- 13 Dec, 2018 13 commits
-
-
Richard Musiol authored
The name "Callback" does not fit to all use cases of js.Callback. This commit changes its name to Func. Accordingly NewCallback gets renamed to FuncOf, which matches ValueOf and TypedArrayOf. The package syscall/js is currently exempt from Go's compatibility promise and js.Callback is already affected by a breaking change in this release cycle. See #28711 for details. Fixes #28711 Change-Id: I2c380970c3822bed6a3893909672c15d0cbe9da3 Reviewed-on: https://go-review.googlesource.com/c/153559 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Joel Sing authored
Update sigcontext and siginfo structs to match those currently in use by OpenBSD armv7. Also correct the offset of the fault address field in the siginfo struct, which moved due to the switch to EABI. Change-Id: Icdd95222346239fcc04b95ae0fcefae09b7aa044 Reviewed-on: https://go-review.googlesource.com/c/154077Reviewed-by:
-
Andrew Bonventre authored
Change-Id: I5112be3b0f80ef1d9dad234b1f233e598465a409 Reviewed-on: https://go-review.googlesource.com/c/153824Reviewed-by:
-
Elias Naur authored
The getdirentries syscall is considered private API on iOS and is rejected by the App Store submission checks. Replace it with the fdopendir/readdir_r/closedir syscalls. Fixes #28984 Change-Id: I73341b124310e9cb34834a95f946769f337ec5b7 Reviewed-on: https://go-review.googlesource.com/c/153338Reviewed-by:
Keith Randall <khr@golang.org>
-
Mark Pulford authored
mkdir(2) inherits the parent directory group on *BSD (including Darwin), and it may inherit on other platforms if the parent directory is SetGID. This can cause TestRespectSetgidDir SetGID to fail when the process does not have have permission for the inherited group on the new temporary directory. Fixes #29160 Change-Id: Iac05511e501dfe307a753f801223b1049cc0947d Reviewed-on: https://go-review.googlesource.com/c/153357Reviewed-by:
Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Lynn Boger authored
This increases the time to wait from 1 to 2 seconds in the TestAtomicStop testcase. When running with gccgo on ppc64 & ppc64le on a loaded systems these testcases can intermittently fail with the current value. Updates #29046 Change-Id: If420274dd65926d933a3024903b5c757c300bd60 Reviewed-on: https://go-review.googlesource.com/c/153826 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
This is a minor follow-up on https://golang.org/cl/153059. TBR=iant Updates #6794. Change-Id: I03657dafc572959d46a03f86bbeb280825bc969d Reviewed-on: https://go-review.googlesource.com/c/153845Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Brian Kessler authored
This change implements Payne-Hanek range reduction by Pi/4 to properly calculate trigonometric functions of huge arguments. The implementation is based on: "ARGUMENT REDUCTION FOR HUGE ARGUMENTS: Good to the Last Bit" K. C. Ng et al, March 24, 1992 The major difference with the reference is that the simulated multi-precision calculation of x*B is implemented using 64-bit integer arithmetic rather than floating point to ease extraction of the relevant bits of 4/Pi. The assembly implementations for 386 were removed since the trigonometric instructions only use a 66-bit representation of Pi internally for reduction. It is not possible to use these instructions and maintain accuracy without a prior accurate reduction in software as recommended by Intel. Fixes #6794 Change-Id: I31bf1369e0578891d738c5473447fe9b10560196 Reviewed-on: https://go-review.googlesource.com/c/153059Reviewed-by:
-
Jordan Rhee authored
Updates #26148 Change-Id: Ide1fe821cc061a08488df9d40878131f37f894c9 Reviewed-on: https://go-review.googlesource.com/c/153844 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Joel Sing authored
Update golang.org/x/sys/unix to revision b05ddf57801d2239d6ab0ee35f9d981e0420f4ac. Changes exist in upstream golang.org/x/sys/unix, which allow for code to work and tests to pass on openbsd/arm. Change-Id: Iecc8598681a23cb0466f94c914f0e605a6fc64d7 Reviewed-on: https://go-review.googlesource.com/c/153838Reviewed-by:
-
Joel Sing authored
The OpenBSD armv7 port requires 64-bit alignment for cmsgs. Rework the cmsg alignment code to facilitate this. Change-Id: I52cf55a8a4cda46c6ef35b0f694862b842028b42 Reviewed-on: https://go-review.googlesource.com/c/153837 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
dupoxy authored
Change-Id: I6b0d470bdedb92844943c8e5823e214d6a7471cf GitHub-Last-Rev: 4a135000ba9c23a588b960e5b2989710cc71e3e2 GitHub-Pull-Request: golang/go#29199 Reviewed-on: https://go-review.googlesource.com/c/153840Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I2ff29aa9909be3062fcd5f65af261f5d8c46fbc1 Reviewed-on: https://go-review.googlesource.com/c/153843Reviewed-by:
-
- 12 Dec, 2018 21 commits
-
-
Muhammad Falak R Wani authored
Context.BuildTags is not set when you read go/build.Default.BuildTags. It's only used by (*BuildTags).Import, etc. Fixes: #27320 Change-Id: I97e5f1923c410b48f70be8c15938a7e04a178e3f Reviewed-on: https://go-review.googlesource.com/c/131975Reviewed-by:
-
Jordan Rhee authored
TestCPUProfileLabel was failing on windows/arm because the link register was not being passed to sigprof(). The link register is required to generate a correct traceback. With this change, all tests in runtime.pprof are now passing. Updates #26148 Change-Id: Ia693b34278dc08a98023751ff1a922d9eee8fdd6 Reviewed-on: https://go-review.googlesource.com/c/153839 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Allow GOCACHE=off only for operations that never actually write anything to the cache (in which case the GOCACHE setting should not matter at all). Fixes #29127 Change-Id: I733d02cd2fbcf3671f5adcfb73522865d131e360 Reviewed-on: https://go-review.googlesource.com/c/153462 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Jay Conrod <jayconrod@google.com>
-
Than McIntosh authored
The changes added in https://golang.org/cl/151997 to fix problems when reading older export data introduced the ability to add "fixups" to handle references to a type whose definition has not yet been finalized. It turns out we need to allow for fixups even for more recent export data (V2 and V3); this patch removes a version guard for the fixup generation logic. Fixes #29198. Change-Id: I82136ac45b53e4a59c05ff0879ac6bb545d0ff31 Reviewed-on: https://go-review.googlesource.com/c/153821 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Hana Kim authored
It's similar to what cmd/go/internal/web package does when cfg.BuildV is set. The web2 package is what cmd/go/internal/modfetch uses, so this change allows us to trace web requests go get command in module mode sends for modfetch. Change-Id: If387efd8a8698c816bf267d1e6c6766fd357c298 Reviewed-on: https://go-review.googlesource.com/c/153640 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by:
-
Andrew Bonventre authored
golang.org/cl/147117 increased the number of arguments permitted by Proc.Call on Windows, but the doc comment was never updated. Change-Id: Iea5eb9e0aafbc1025d5fcb8665d028b2254c183a Reviewed-on: https://go-review.googlesource.com/c/153825Reviewed-by:
Channing Kimble-Brown <ckimblebrown@google.com> Reviewed-by:
Andrew Bonventre <andybons@golang.org>
-
Bryan C. Mills authored
Tested manually. Before: $ go mod init golang.org/issue/scratch go: creating new go.mod: module golang.org/issue/scratch $ go1.11.2 mod download github.com/rogpeppe/test2@latest go: finding github.com/rogpeppe/test2 v0.0.11 $ find $GOPATH -name goodbye /tmp/tmp.Y8a8UzX3zD/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/goodbye $ cat $(find $GOPATH -name goodbye) hello After: $ go mod init golang.org/issue/scratch go: creating new go.mod: module golang.org/issue/scratch $ go mod download github.com/rogpeppe/test2@latest go: finding github.com/rogpeppe/test2 v0.0.11 $ find $GOPATH -name goodbye $ find $GOPATH -name hello /tmp/tmp.Zo0jhfLaRs/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/hello A proper regression test would require one of: • a new entry in the vcs-test server (feasible but tedious, and not easily updated by open-source contributors), or • a way to set up an HTTPS proxy in a script_test, or • a way to explicitly populate the module cache from the contents of a local repository (#28835). Fixes #27093 Updates #28835 Change-Id: I72702a7e791f8815965f0f87c82a30df4d6f0151 Reviewed-on: https://go-review.googlesource.com/c/153819 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
This change encodes the current behavior in mod_clean_cache.txt. A fix for that behavior will probably have to wait for 1.13. Updates #28680 Change-Id: I216b5a783971309cc75187502bddccc58c3a9c35 Reviewed-on: https://go-review.googlesource.com/c/153818 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Fixes #27868 Change-Id: I6c2d221c4325a2f44625e797a82735d812ee0ec1 Reviewed-on: https://go-review.googlesource.com/c/153817 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Keith Randall authored
By combining the load+op, we may force the op to happen earlier in the store chain. That might force the SymAddr operation earlier, and in particular earlier than its corresponding VarDef. That leads to an invalid schedule, so avoid that. This is kind of a hack to work around the issue presented. I think the underlying problem, that LEAQ is not directly ordered with respect to its vardef, is the real problem. The benefit of this CL is that it fixes the immediate issue, is small, and obviously won't break anything. A real fix for this issue is much more invasive. The go binary is unchanged in size. This situation just doesn't occur very often. Fixes #28445 Change-Id: I13a765e13f075d5b6808a355ef3c43cdd7cd47b6 Reviewed-on: https://go-review.googlesource.com/c/153641 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Julie Qiu authored
Change-Id: I81ffe7ee88354efeabb24f091db66c7c4892876c Reviewed-on: https://go-review.googlesource.com/c/152919Reviewed-by:
-
Julie Qiu authored
Updates #25982 Change-Id: I5a284e3844e944f9bfae31fa65b242060d4139c7 Reviewed-on: https://go-review.googlesource.com/c/150777 Run-TryBot: Julie Qiu <julie@golang.org> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Leigh McCulloch authored
Both the encoding/xml and encoding/json packages support custom marshalers for JSON and XML, as well as the basic encoding.TextMarshaler and encoding.TextUnmarshaler interfaces, but the docs and examples for these are missing. There are docs for how to use encoding.TextMarshaler and encoding.TextUnmarshaler in encoding/json, but not encoding/xml. There are no examples for how to use them with either json or xml. This commit includes docs for encoding/xml and examples for both encoding/json and encoding/xml. There is an example using custom marshalers MarshalJSON and UnmarshalJSON in encoding/json, but not MarshalXML and UnmarshalXML in encoding/json. These docs are more so necessary for encoding/xml because the complexities of XML documents is significantly greater than JSON documents which more often leads to the need for custom marshaling. The encoding/json package includes an example of how to write a custom marshaler, and this commit includes the same example for the xml package. All examples are mirrored off the existing custom marshaler example in encoding/json. Fixes #6859 Change-Id: Ic93abc27c0b4d5e48dea6ede4e20b1bedca4ab39 Reviewed-on: https://go-review.googlesource.com/c/76350 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Chase authored
This change avoids creating zero length location lists by repairing an overly aggressive change in CL146718 and by explicitly checking for and filtering out any zero-length lists that are detected (building compiler+runtime creates a single one). Updates #28486. Change-Id: I01c571fee2376474c7f3038e801bd58fd9e0b820 Reviewed-on: https://go-review.googlesource.com/c/150097 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Heschi Kreinick <heschi@google.com>
-
Robert Griesemer authored
For now, this CL adds as a first benchmark the formatting of a 10,000 element array literal. It is easy to add additional test cases as we see fit. name time/op Format/array1-10000-4 26.7ms ± 7% name speed Format/array1-10000-4 2.43MB/s ± 6% name alloc/op Format/array1-10000-4 5.52MB ± 0% name allocs/op Format/array1-10000-4 119k ± 0% Updates #26528. Change-Id: Ic8ec8f70160d122b877740412d4d4406f5f4b345 Reviewed-on: https://go-review.googlesource.com/c/153642Reviewed-by:
-
Joel Sing authored
This test is currently too flakey on openbsd/arm - ignore failures for the time being. Change-Id: Ia334d188f505167e691177ebe2c7a2df54bf556a Reviewed-on: https://go-review.googlesource.com/c/153579Reviewed-by:
-
Joel Sing authored
Regenerate ztypes for openbsd/arm - most of the changes relate to the OpenBSD armv7 port switching to EABI in September 2016. Also use signed char when generating openbsd/arm ztypes, to avoid inconsistencies between architectures impacting MI code. Change-Id: I9d2e19c1ac045922e270896861c830f94fc59c10 Reviewed-on: https://go-review.googlesource.com/c/153578 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Otherwise we can fail to remove a unreadable empty directory. Fixes #29178 Change-Id: I43d5c89fce57a86626abe2a1c2bbf145716e087b Reviewed-on: https://go-review.googlesource.com/c/153720 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Jordan Rhee authored
Use smaller heap on Windows/ARM, which generally does not have page file enabled and therefore has limited virtual address space. Updates #26148 Signed-off-by:
Jordan Rhee <jordanrh@microsoft.com> Change-Id: I4030be24a10fab7b9b659e3736b7e83f10710bfa Reviewed-on: https://go-review.googlesource.com/c/153719 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by:
-
Jordan Rhee authored
Fix profiling handler to get the correct g for the m being profiled. Store a pointer to the TLS slot holding g in the thread's m. This enables the profiling handler to get the current g for the thread, even if the thread is executing external code or system code. Updates #26148 Signed-off-by:
-
Ian Lance Taylor authored
Take advantage of the new /*line*/ comments. Fixes #26745 Change-Id: I8098642e0f11f7418fe81b9a08dbe07671f930fe Reviewed-on: https://go-review.googlesource.com/c/151598 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 11 Dec, 2018 6 commits
-
-
Bryan C. Mills authored
Use the actual loader result in findModule instead of making assumptions about nesting in the build list. As a side-effect, this produces much clearer error messages for packages that (for one reason or another) failed to load. Adjust the package and module path outside a module to "command-line-arguments". That string already appears in the output of a number of (module-mode and GOPATH-mode) commands for file arguments, and as far as I can tell operation outside a module is currently the only case in which the module path of a package is not actually a prefix of the import path. Fixes #28011 Fixes #27099 Fixes #28943 Updates #27102 Updates #28459 Updates #27063 Change-Id: I61d5556df7b1b7d1efdaffa892f0e3e95b612d87 Reviewed-on: https://go-review.googlesource.com/c/153459 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
cmd/go/internal/modfetch/codehost: return VCSError for unimplemented functions and malformed responses Updates #28943 Updates #26092 Change-Id: I07af2731ef5af046b9f7c7280ccb3976cdf41ca4 Reviewed-on: https://go-review.googlesource.com/c/153458 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Keith Randall authored
When functions are inlined, for instructions in the inlined body, does -S print the location of the call, or the location of the body? Right now, we do the former. I'd like to do the latter by default, it makes much more sense when reading disassembly. With mid-stack inlining enabled in more cases, this quandry will come up more often. The original behavior is still available with -S=2. Some tests use this mode (so they can find assembly generated by a particular source line). This helped me with understanding what the compiler was doing while fixing #29007. Change-Id: Id14a3a41e1b18901e7c5e460aa4caf6d940ed064 Reviewed-on: https://go-review.googlesource.com/c/153241Reviewed-by:
David Chase <drchase@google.com>
-
Bryan C. Mills authored
[root] reports whether the current effective user ID is 0. Updates #29127 Change-Id: I9ef42f1271ea669689011e7ceff4d918c0cecb6b Reviewed-on: https://go-review.googlesource.com/c/153637 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Clément Chigot authored
This commit adds support to read XCOFF files and AIX big archives in go/internal/gccgoimporter. Fixes: #29113 Change-Id: Id84d40358ff98fae5a576d1ebdd65980896365b9 Reviewed-on: https://go-review.googlesource.com/c/152720 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Change-Id: I5d4f65553f6c368d101be59aae9440f5ec9573b7 Reviewed-on: https://go-review.googlesource.com/c/153461 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
