- 28 Mar, 2013 9 commits
-
-
Brad Fitzpatrick authored
Removes another per-request allocation. Also makes the code more readable, IMO. And more testable. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAliveLite 10539 10324 -2.04% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAliveLite 20 19 -5.00% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAliveLite 1609 1559 -3.11% R=golang-dev, gri CC=golang-dev https://golang.org/cl/8118044
-
Brad Fitzpatrick authored
We already depend on strings in this file, so use it. Plus strings.Index will be faster than a manual loop once issue 3751 is finished. R=golang-dev, khr CC=golang-dev https://golang.org/cl/8116043
-
Robert Griesemer authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8113043
-
Brad Fitzpatrick authored
A chunkWriter and a response are 1:1. Make them contiguous in memory and save an allocation. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAliveLite 10715 10539 -1.64% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAliveLite 21 20 -4.76% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAliveLite 1626 1609 -1.05% R=golang-dev, gri CC=golang-dev https://golang.org/cl/8114043
-
Brad Fitzpatrick authored
benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAliveLite 11031 10689 -3.10% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAliveLite 23 21 -8.70% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAliveLite 1668 1626 -2.52% R=golang-dev, gri CC=golang-dev https://golang.org/cl/8110044
-
Robert Griesemer authored
- removed gratuitous empty lines that creeped into command line output - changed comment color to a dark green so that links don't visually melt into them - removed some TODOs - updated doc.go R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8108044
-
Brad Fitzpatrick authored
Add more tests around the various orders handlers can access and flush response headers. Also clarify the documentation on fields of response and chunkWriter. While there, remove an allocation (a header clone) for simple handlers. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAliveLite 15245 14966 -1.83% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAliveLite 24 23 -4.17% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAliveLite 1717 1668 -2.85% R=golang-dev, gri CC=golang-dev https://golang.org/cl/8101043
-
Ian Lance Taylor authored
R=golang-dev, daniel.morsing CC=golang-dev https://golang.org/cl/8070043
-
Robert Griesemer authored
Fixes regression introduced by CL 7860049. R=golang-dev, kamil.kisiel, dave CC=golang-dev https://golang.org/cl/8069044
-
- 27 Mar, 2013 22 commits
-
-
Rob Pike authored
Analogous to the one for .go files, it's for .s only and is protected by the verbose flag. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8030046
-
Rob Pike authored
R=golang-dev, alberto.garcia.hierro CC=golang-dev https://golang.org/cl/7861046
-
Rob Pike authored
This is a totally mechanical change. Errors are reported for the beginning of the statement, not the end, so the errchk markers need to be on the opening brace, not the closing one. It seems this test was never run. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7746050
-
Rob Pike authored
They should be build-tagged for vet_test not ignore, and not have a Go package clause. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8016047
-
Brad Fitzpatrick authored
Motivated by garbage profiling in HTTP benchmarks. This changes means new empty maps are just one small allocation (the HMap) instead the HMap + the relatively larger h->buckets allocation. This helps maps which remain empty throughout their life. benchmark old ns/op new ns/op delta BenchmarkNewEmptyMap 196 107 -45.41% benchmark old allocs new allocs delta BenchmarkNewEmptyMap 2 1 -50.00% benchmark old bytes new bytes delta BenchmarkNewEmptyMap 195 50 -74.36% R=khr, golang-dev, r CC=golang-dev https://golang.org/cl/7722046
-
Ian Lance Taylor authored
On OpenBSD don't mark runtime.{g,m} as STT_TLS symbols. R=golang-dev, dave CC=golang-dev https://golang.org/cl/7867046
-
Rob Pike authored
R=golang-dev, remyoudompheng, iant CC=golang-dev https://golang.org/cl/8038048
-
Robert Griesemer authored
Fixes #5077. R=r CC=golang-dev https://golang.org/cl/8021044
-
Ian Lance Taylor authored
Don't generate TLS sections on OpenBSD. R=golang-dev, r CC=golang-dev https://golang.org/cl/8059043
-
Ian Lance Taylor authored
Avoid generating TLS relocations on OpenBSD. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7641055
-
Rémy Oudompheng authored
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/8051044
-
Brad Fitzpatrick authored
There was another bufio.Writer not being reused, found with GOGC=off and -test.memprofile. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnWithKeepAlive 18270 16046 -12.17% benchmark old allocs new allocs delta BenchmarkServerFakeConnWithKeepAlive 38 36 -5.26% benchmark old bytes new bytes delta BenchmarkServerFakeConnWithKeepAlive 4598 2488 -45.89% Update #5100 R=golang-dev, gri CC=golang-dev https://golang.org/cl/8038047
-
Brad Fitzpatrick authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/8046043
-
Ian Lance Taylor authored
This CL was written by rsc. I just tweaked 8l. This CL adds TLS relocation to the ELF .o file we write during external linking, so that the host linker (gcc) can decide the final location of m and g. Similar relocations are not necessary on OS X because we use an alternate program start-time mechanism to acquire thread-local storage. Similar relocations are not necessary on ARM or Plan 9 or Windows because external linking mode is not yet supported on those systems. On almost all ELF systems, the references we use are like %fs:-0x4 or %gs:-0x4, which we write in 6a/8a as -0x4(FS) or -0x4(GS). On Linux/ELF, however, Xen's lack of support for this mode forced us long ago to use a two-instruction sequence: first we load %gs:0x0 into a register r, and then we use -0x4(r). (The ELF program loader arranges that %gs:0x0 contains a regular pointer to that same memory location.) In order to relocate those -0x4(r) references, the linker must know where they are. This CL adds the equivalent notation -0x4(r)(GS*1) for this purpose: it assembles to the same encoding as -0x4(r) but the (GS*1) indicates to the linker that this is one of those thread-local references that needs relocation. Thanks to Elias Naur for reminding me about this missing piece and also for writing the test. R=r CC=golang-dev https://golang.org/cl/7891047
-
Rémy Oudompheng authored
Fixes race builder. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8055045
-
Rémy Oudompheng authored
The remaining issues are about runtime and sync package instrumentation. Update #4228 R=dvyukov, bradfitz CC=golang-dev https://golang.org/cl/8041043
-
Jonathan Rudenberg authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7635049
-
Brad Fitzpatrick authored
And make it have more useful output on failure. Update #5005 R=golang-dev, r CC=golang-dev https://golang.org/cl/8016046
-
Anthony Martin authored
Since fp->symsz includes the size of the header in the new symbol table format, we were reading past the end and decoding a few garbage symbols from data in the pc/line table. R=rsc, r CC=golang-dev https://golang.org/cl/7993043
-
Brad Fitzpatrick authored
Seems to have been omitted before. R=golang-dev, dave CC=golang-dev https://golang.org/cl/7749049
-
Robert Griesemer authored
- convert all formatters that require a *token.FileSet to consistenly use a *PageInfo as first argument instead - adjust templates correspondingly - fix outstanding bug from previous CL 8005044 Going forward, with this change the affected functions have access to the full page "context" (PageInfo), not just the respective file set. This will permit better context-dependent formatting in the future. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7860049
-
Rob Pike authored
The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7917044
-
- 26 Mar, 2013 9 commits
-
-
Rémy Oudompheng authored
A HMUL node appears in some constant divisions, but to observe a false negative in race detector the divisor must be suitably chosen to make sure the only memory access is done for HMUL. R=dvyukov CC=golang-dev https://golang.org/cl/7935045
-
Dave Cheney authored
Always use /home/you for $HOME in examples. Trivial enough that someone else can integrate this change if they are editing go1.1.html R=r CC=golang-dev https://golang.org/cl/8025043
-
Ian Lance Taylor authored
For Go 1.1, stop checking the rlimit, because it broke now that mheap is allocated using SysAlloc. See issue 5049. R=r CC=golang-dev https://golang.org/cl/7741050
-
Robert Griesemer authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/8005044
-
Russ Cox authored
ArrayOf will remain unexported (and therefore unused) for Go 1.1. Fixes #4375. R=0xe2.0x9a.0x9b, r, iant CC=golang-dev https://golang.org/cl/7716048
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7835049
-
Carl Shapiro authored
The arm gentraceback mishandled frame linkage values pointing to the assembly return function. This function is special as its frame size is zero and it contains only one instruction. These conditions would preserve the frame pointer and result in an off by one error when unwinding the caller. Fixes #5124 R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8023043
-
Robert Griesemer authored
The changes are almost completely self-contained in the new file linkify.go. The other changes are minimal and should not disturb the currently working godoc, in anticipation of Go 1.1. To disable the feature in case of problems, set -links=false. Fixes #2063. R=adg, r CC=golang-dev https://golang.org/cl/7883044
-
Rob Pike authored
Aids godoc. R=golang-dev, gri, bradfitz CC=golang-dev https://golang.org/cl/7992044
-