- 26 Mar, 2015 8 commits
-
-
Rob Pike authored
People will still not look at it, but at least we will have a stronger defense. Change-Id: Ieea6a3d42d06e1067e424e35b87dbcb01c9523cb Reviewed-on: https://go-review.googlesource.com/7859Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
This avoids hanging when a Go program uses a FUSE filesystem and the dup system call has to close a file descriptor. When dup uses RawSyscall then the goroutine calling dup will occupy a scheduler slot (a p structure) during the call, and may block waiting for some other goroutine to respond to the close call on the FUSE filesystem. Changing to Syscall avoids the problem. This makes Dup a tiny bit slower but is quite unlikely to make a difference for any real programs. Fixes #10202. Change-Id: If6490a8f9b3c9cfed6acbfb4bfd1eaeac62ced17 Reviewed-on: https://go-review.googlesource.com/8095Reviewed-by:
Rob Pike <r@golang.org>
-
Austin Clements authored
Currently, Darwin's siginfo type uses *byte for the si_addr field. This results in unwanted write barriers in set_sigaddr. It's also pointless since it never points to anything real and the get/set methods return/take uintXX and cast it from/to the pointer. All other arches use a uint type for this field. Change Darwin to match. This simplifies the get/set methods and eliminates the unwanted write barriers. Change-Id: Ifdb5646d35e1f2f6808b87a3d59745ec9718add1 Reviewed-on: https://go-review.googlesource.com/8086Reviewed-by:
Austin Clements <austin@google.com>
-
Austin Clements authored
sighandler may run during a stop-the-world without a P, so it's not allowed to have write barriers. Fix the G write to disable the write barrier (this is safe because the G is reachable from allgs) and mark the function nowritebarrier. Change-Id: I907f05d3829e24eeb15fa4d020598af36710e87e Reviewed-on: https://go-review.googlesource.com/8020Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Ian Lance Taylor authored
This is mostly straightforward but it does introduce an odd change to Fchflags and adds the Mlock related functions. These changes look correct to me but I don't know why they weren't in the original file. Change-Id: I1a01e075566d327a78b77e7354c9fb85b6ad1f22 Reviewed-on: https://go-review.googlesource.com/8062Reviewed-by:
Minux Ma <minux@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
David Crawshaw authored
Also invert it, which means it no longer needs to cross the cgo package boundary. Change-Id: I393cd073bda02b591a55d6bc6b8bb94970ea71cd Reviewed-on: https://go-review.googlesource.com/8082Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Rob Pike authored
Change-Id: I6d129ef56baa2c0c5e0b278cfa67fc22f3bf18ac Reviewed-on: https://go-review.googlesource.com/8052Reviewed-by:
Rob Pike <r@golang.org>
-
Rob Pike authored
Without some hook like this, it's impossible to get a $ into the generate command, which is necessary if you're trying to do some shell scripting or regular expressions. We could use backslash escaping but that's already tricky enough because the strings are processed as Go strings. Using $ like this means we need no more mechanism, just a predefined variable. We may need to revisit this but I hope we can avoid new quoting rules. Change-Id: Ieb478c8cc767a866765282472239ed3c1e5669a8 Reviewed-on: https://go-review.googlesource.com/8091Reviewed-by:
Dave Cheney <dave@cheney.net> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 25 Mar, 2015 10 commits
-
-
Dave Cheney authored
Update #10007 Implement runtime.cmpstring and bytes.Compare in asm for arm. benchmark old ns/op new ns/op delta BenchmarkCompareBytesEqual 254 91.4 -64.02% BenchmarkCompareBytesToNil 41.5 37.6 -9.40% BenchmarkCompareBytesEmpty 40.7 37.6 -7.62% BenchmarkCompareBytesIdentical 255 96.3 -62.24% BenchmarkCompareBytesSameLength 125 60.9 -51.28% BenchmarkCompareBytesDifferentLength 133 60.9 -54.21% BenchmarkCompareBytesBigUnaligned 17985879 5669706 -68.48% BenchmarkCompareBytesBig 17097634 4926798 -71.18% BenchmarkCompareBytesBigIdentical 16861941 4389206 -73.97% benchmark old MB/s new MB/s speedup BenchmarkCompareBytesBigUnaligned 58.30 184.95 3.17x BenchmarkCompareBytesBig 61.33 212.83 3.47x BenchmarkCompareBytesBigIdentical 62.19 238.90 3.84x This is a collaboration between Josh Bleecher Snyder and myself. Change-Id: Ib3944b8c410d0e12135c2ba9459bfe131df48edd Reviewed-on: https://go-review.googlesource.com/8010Reviewed-by:
Keith Randall <khr@golang.org>
-
Nigel Tao authored
The image/draw benchmark: benchmark old ns/op new ns/op delta BenchmarkYCbCr 1198605 978647 -18.35% Change-Id: Iacfc21e6f641ecb05adc00b3aec0048f1f43d265 Reviewed-on: https://go-review.googlesource.com/7952Reviewed-by:
Rob Pike <r@golang.org>
-
David Crawshaw authored
The clever partial timer I added interacts badly with iOS app launch timeout termination. A fixed timeout will be easier to debug. Change-Id: I6eb4ee5f1431539f00fa707e8cde6f3cf86983fc Reviewed-on: https://go-review.googlesource.com/8083Reviewed-by:
Hyang-Ah Hana Kim <hyangah@gmail.com>
-
David Crawshaw authored
Split out from cl/8024 for clarity and improved approach. Rarely, "stop reason = breakpoint" does not appear in the lldb stop text. However the program is ready to proceed. To be a little more robust about those cases, we wait for two seconds, and if that text doesn't appear but a prompt does we continue and hope for the best. Worst case, this results in a harder to read failure message. Change-Id: Ib20aa92564cdccefd2b7260417c647cd44122b66 Reviewed-on: https://go-review.googlesource.com/8080Reviewed-by:
Hyang-Ah Hana Kim <hyangah@gmail.com>
-
Matt Bostock authored
Commit 604fa4d5 made TLS 1.0 the default minimum version. This commit amends a comment to reflect that. This is where the default is used in the absence of an explicit version being set: https://github.com/golang/go/blob/edadffa2f3464c48a234f3cf2fc092a03f91824f/src/crypto/tls/common.go#L391-L393 Change-Id: I8f1117ecdddc85bb1cc76a6834026505a380b793 Reviewed-on: https://go-review.googlesource.com/5525Reviewed-by:
Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
Minux Ma <minux@golang.org> Reviewed-by:
Adam Langley <agl@golang.org>
-
Alex Brainman authored
We do not use SEH to handle Windows exception anymore. Change-Id: I0ac807a0fed7a5b4c745454246764c524460472b Reviewed-on: https://go-review.googlesource.com/8071Reviewed-by:
Minux Ma <minux@golang.org>
-
Shenghou Ma authored
Change-Id: Ib7374dc87fa4d4ad5854155049e511a1ff51ca97 Reviewed-on: https://go-review.googlesource.com/8081Reviewed-by:
Minux Ma <minux@golang.org>
-
Shenghou Ma authored
The SecureRandom named service was removed in https://codereview.chromium.org/550523002. And the new syscall was introduced in https://codereview.chromium.org/537543003. Accepting this will remove the support for older version of sel_ldr. I've confirmed that both pepper_40 and current pepper_canary have this syscall. After this change, we need sel_ldr from pepper_39 or above to work. Fixes #9261 Change-Id: I096973593aa302ade61f259a3a71ebc7c1a57913 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/1755Reviewed-by:
Russ Cox <rsc@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Hyang-Ah (Hana) Kim authored
lsof is used to inspect the open file desciptors in exec_test.go. In order to limit the output of lsof to the tested process, the tests use lsof with the -p option, but the version of lsof in android seems to ignore it. This change adds a post-processing step to filter out irrelevant entries. Fixes golang/go#10206. Change-Id: Ia789b8f5e1e9b95c7b55deac92d0d1fbf3ee74fb Reviewed-on: https://go-review.googlesource.com/8025Reviewed-by:
David Crawshaw <crawshaw@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Mikio Hara authored
Package socktest provides utilities for socket testing. This package allows test cases in the net package to simulate complicated network conditions such as that a destination address is resolvable/discoverable but is not routable/reachable at network layer. Those conditions are required for testing functionality of timeout, multiple address families. Change-Id: Idbe32bcc3319b41b0cecac3d058014a93e13288b Reviewed-on: https://go-review.googlesource.com/6090Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 24 Mar, 2015 22 commits
-
-
Shenghou Ma authored
One full round of make.bash is saved with this change. Change-Id: I8ad1442e9e1255b9abe14dbfec4c903d897d6015 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7976Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Shenghou Ma authored
Change-Id: I3de78f321c99f8f850a304f7d34c85d0fe254c0e Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7975 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net> Reviewed-by:
Rob Pike <r@golang.org>
-
Shenghou Ma authored
Fixes #10227. Change-Id: I64d5522e76da5a717e3c4169405e5ef35d6c262e Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7974Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Alexandre Cesaro authored
RFC 2045 says: An "=" followed by two hexadecimal digits, one or both of which are lowercase letters in "abcdef", is formally illegal. A robust implementation might choose to recognize them as the corresponding uppercase letters. https://tools.ietf.org/html/rfc2045#page-22 Change-Id: Ibb4b1e4b8bf4fa65ff895ba486a931d90308bf70 Reviewed-on: https://go-review.googlesource.com/7891Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Dave Cheney authored
Adjust Thearch.FREG_MIN/MAX when using non sse2 mode in 8g. Also, gc.Use_sse is treated as a bool, so make it a bool. Change-Id: I840411605344bb31c32f492b3e6729166c084f0c Reviewed-on: https://go-review.googlesource.com/7993Reviewed-by:
Aram Hăvărneanu <aram@mgk.ro> Reviewed-by:
Rob Pike <r@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net> Run-TryBot: Dave Cheney <dave@cheney.net>
-
Robert Griesemer authored
- handle exponent over- and underflow - handle denormalized numbers - added test cases Change-Id: I1bbb9904b0c104f54696944e1f57559881f6eeeb Reviewed-on: https://go-review.googlesource.com/7982Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Brad Fitzpatrick authored
Change-Id: Id1edbed38c94e7c1c13a0200c44edf2b9ae5f087 Reviewed-on: https://go-review.googlesource.com/8040Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Aram Hăvărneanu authored
Also fixes a long-existing problem in the fork/exec path. Change-Id: Idec40b1cee0cfb1625fe107db3eafdc0d71798f2 Reviewed-on: https://go-review.googlesource.com/8030Reviewed-by:
Minux Ma <minux@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Shenghou Ma authored
REGRT1 and REGRT2 are also reserved on arm64 for runtime (duffzero and duffcopy). Change-Id: If098527a7f29d16f94bdcec05fd55950b9076e35 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7977Reviewed-by:
Aram Hăvărneanu <aram@mgk.ro> Reviewed-by:
Dave Cheney <dave@cheney.net> Reviewed-by:
Rob Pike <r@golang.org>
-
Shenghou Ma authored
Fixes newly introduced test on linux/arm64 because linux/arm64 doesn't have the getpgrp syscall. Getpgid(0) is documented to be equivalent to Getpgrp. Change-Id: I8f30f4f8de8c32fe04a29c9c4a9330d4e4e6b46d Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/8022Reviewed-by:
Aram Hăvărneanu <aram@mgk.ro> Reviewed-by:
Rob Pike <r@golang.org>
-
David Crawshaw authored
Previously the extra m needed for cgo callbacks was created on the first callback. This works for cgo, however the cgocallback mechanism is also borrowed by badsignal which can run before any cgo calls are made. Now we initialize the extra M at runtime startup before any signal handlers are registered, so badsignal cannot be called until the extra M is ready. Updates #10207. Change-Id: Iddda2c80db6dc52d8b60e2b269670fbaa704c7b3 Reviewed-on: https://go-review.googlesource.com/7978Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
Change-Id: I5bfeeef53665b1ef79ec0e4a6ae0eb4aa3e95603 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/8021Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Rick Hudson authored
There are calls to stdcall when the GC thinks the world is stopped and stdcall write a *g for the CPU profiler. This produces a write barrier but the GC is not prepared to deal with write barriers when it thinks the world is stopped. Since the g is on allg it does not need a write barrier to keep it alive so eliminate the write barrier. Change-Id: I937633409a66553d7d292d87d7d58caba1fad0b6 Reviewed-on: https://go-review.googlesource.com/7979Reviewed-by:
Austin Clements <austin@google.com> Run-TryBot: Rick Hudson <rlh@golang.org>
-
Alex Brainman authored
The test is a simple reproduction of issue 9356. Update #8948. Update #9356. Change-Id: Ia77bc36d12ed0c3c4a8b1214cade8be181c9ad55 Reviewed-on: https://go-review.googlesource.com/7618Reviewed-by:
Minux Ma <minux@golang.org>
-
Shenghou Ma authored
Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e33 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7537
-
Shenghou Ma authored
Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e32 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7536Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Fixes #4069. Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e31 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7535Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Shenghou Ma authored
Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e30 Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7534Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Signed-off-by:
Shenghou Ma <minux@golang.org> Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e2f Reviewed-on: https://go-review.googlesource.com/7284Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Shenghou Ma authored
Update #4069: this CL fixes the issue on windows/386. Signed-off-by:
Shenghou Ma <minux@golang.org> Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e2e Reviewed-on: https://go-review.googlesource.com/7283Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
windows/386 also wants underscore prefix for external names. This CL is in preparation of external linking support. Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e2d Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7282Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Shenghou Ma authored
When external linking, we must link to implib provided by mingw, so we must use properly decorated names for stdcalls. Because the feature is only used in the runtime, I've designed a new decoration scheme so that we can use the same decorated name for both 386 and amd64. A stdcall function named FooEx from bar16.dll which takes 3 parameters will be imported like this: //go:cgo_import_dynamic runtime._FooEx FooEx%3 "bar16.dll" Depending on the size of uintptr, the linker will later transform it to _FooEx@12 or _FooEx@24. This is in prepration for the next CL that adds external linking support for windows/386. Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e2c Signed-off-by:
Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/7163Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-