Commits · 86a659cad03b98d1921d72e3cf459bcd189ae0ec · go / golang

13 Jul, 2011 15 commits

runtime: fix data race during Itab hash update/lookup · 86a659ca

Dmitriy Vyukov authored Jul 13, 2011

The data race is on newly published Itab nodes, which are
both unsafely published and unsafely acquired. It can
break on IA-32/Intel64 due to compiler optimizations
(most likely not an issue as of now) and on ARM due to
hardware memory access reorderings.

R=rsc
CC=golang-dev
https://golang.org/cl/4673055

86a659ca

docs: fix wrong it's -> its · dcdaeebd
Brad Fitzpatrick authored Jul 13, 2011
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4702046
```
dcdaeebd
exp/regexp/syntax: add Prog.NumCap · e3a77347
Sam Thorogood authored Jul 13, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/4662083
```
e3a77347

exp/eval, exp/ogle: remove packages eval and ogle · 4c986d86

Robert Griesemer authored Jul 13, 2011

An externally maintained version of exp/eval can
be found at: https://bitbucket.org/binet/go-eval/ .

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/4695047

4c986d86

gob: register more slice types · 050d839d

Bobby Powers authored Jul 13, 2011

Without explicitly registering slice types, gob fails to encode
map[string]interface{} instances where the value is a slice,
failing with a message such as:

  gob: type not registered for interface: []string

Fixes #2065.

R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/4672056

050d839d

html: update section references in comments to the latest HTML5 spec. · d360e021
Nigel Tao authored Jul 13, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4699048
```
d360e021
C+A: Bobby Powers <bobbypowers@gmail.com> · 9415cd1d
Rob Pike authored Jul 13, 2011
```
R=golang-dev, dsymonds
CC=bobbypowers, golang-dev
https://golang.org/cl/4695050
```
9415cd1d

exp/template: doc and API changes suggested by rsc. · 7aa1a1a6

Rob Pike authored Jul 13, 2011

- template invocation is by string constant only.
- NewSet is gone.
- no global Funcs
- writer is now first arg to Execute

R=rsc, r
CC=golang-dev
https://golang.org/cl/4700043

7aa1a1a6

exp/template: add Set.AddSet and Set.Union. · 2e9388e3

Rob Pike authored Jul 13, 2011

Document and test that Set.Parse can be called multiple times.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4703044

2e9388e3

exp/template: allow variables as template names. · 41efecf5

Rob Pike authored Jul 13, 2011

Just an oversight it wasn't already there.
Thanks to islandberry@live.com for pointing out the omission.

R=golang-dev, dsymonds
CC=golang-dev, islandberry
https://golang.org/cl/4703043

41efecf5

go_tutorial: change the way it's generated. · c1c8d46d

Rob Pike authored Jul 13, 2011

No longer do we generate HTML from it; instead the input
file is already in HTML but has template invocations to
extract programs from other files.
Delete htmlgen, which is no longer needed.
Add tmpltohtml, which runs the templating code.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/4699041

c1c8d46d

5l, 6l, 8l: Add a PT_LOAD PHDR entry for the PHDR. · f1df07bf

David Anderson authored Jul 13, 2011

Per the TIS ELF spec, if a PHDR entry is present in the
program header table, it must be part of the memory image of
the program. Failure to do this makes elflint complain, and
causes some tools that manipulate ELF to crash.

R=iant, rsc
CC=dave, golang-dev
https://golang.org/cl/4650067

f1df07bf

csv: fix spelling errors in comments · 75780f99
Robert Griesemer authored Jul 13, 2011
```
Fixes #2066.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4699045
```
75780f99
tag release.r58.1: adds OS X Lion support · 7318664c
Russ Cox authored Jul 13, 2011
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/4702043
```
7318664c

runtime: replace runtime.mcpy with runtime.memmove · fe9991e8

Quan Yong Zhai authored Jul 13, 2011

faster string operations, and more

tested on linux/386

runtime_test.BenchmarkSliceToString                    642          532  -17.13%
runtime_test.BenchmarkStringToSlice                    636          528  -16.98%
runtime_test.BenchmarkConcatString                    1109          897  -19.12%

R=r, iant, rsc
CC=golang-dev
https://golang.org/cl/4674042

fe9991e8

12 Jul, 2011 24 commits

doc: gofix io2010 demo programs · ba91dac3
Andrew Gerrand authored Jul 12, 2011
```
R=golang-dev, gri, r, agl
CC=golang-dev
https://golang.org/cl/4696046
```
ba91dac3
debug/pe: fixes ImportedSymbols for Win64. · f340b3de
Wei Guangjing authored Jul 12, 2011
```
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/4639086
```
f340b3de
gc: make size of struct{} and [0]byte 0 bytes · 67edf9cb
Robert Hencke authored Jul 12, 2011
```
Fixes #1949.

R=iant, rsc
CC=golang-dev
https://golang.org/cl/4634124
```
67edf9cb

runtime: eliminate false sharing during stack growth · 86e7323b

Dmitriy Vyukov authored Jul 12, 2011

Remove static variable from runtime·oldstack().
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows (with CL 4657091 applied):
benchmark                                        old ns/op    new ns/op    delta
BenchmarkStackGrowth                               1183.00      1180.00   -0.25%
BenchmarkStackGrowth-2                             1249.00      1211.00   -3.04%
BenchmarkStackGrowth-4                              954.00       805.00  -15.62%
BenchmarkStackGrowth-8                              701.00       683.00   -2.57%
BenchmarkStackGrowth-16                             465.00       415.00  -10.75%

R=rsc
CC=golang-dev
https://golang.org/cl/4693042

86e7323b

runtime: fix comment (lost in shuffle) · 88e0c051
Russ Cox authored Jul 12, 2011
```
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/4710041
```
88e0c051

runtime: eliminate contention during stack allocation · c9152a85

Dmitriy Vyukov authored Jul 12, 2011

Standard-sized stack frames use plain malloc/free
instead of centralized lock-protected FixAlloc.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark                                        old ns/op    new ns/op    delta
BenchmarkStackGrowth                               1045.00       949.00   -9.19%
BenchmarkStackGrowth-2                             3450.00       800.00  -76.81%
BenchmarkStackGrowth-4                             5076.00       513.00  -89.89%
BenchmarkStackGrowth-8                             7805.00       471.00  -93.97%
BenchmarkStackGrowth-16                           11751.00       321.00  -97.27%

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4657091

c9152a85

sync: improve RWMutex performance · daaf29cf

Dmitriy Vyukov authored Jul 12, 2011

The new implementation features wait-free
fast path for readers which significantly improves
performance/scalability on read-mostly workloads.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark old ns/op new ns/op delta
BenchmarkRWMutexUncontended 179.00 96.60 -46.03%
BenchmarkRWMutexUncontended-2 89.10 49.10 -44.89%
BenchmarkRWMutexUncontended-4 44.70 24.70 -44.74%
BenchmarkRWMutexUncontended-8 23.30 12.90 -44.64%
BenchmarkRWMutexUncontended-16 16.80 8.75 -47.92%
BenchmarkRWMutexWrite100 79.60 26.80 -66.33%
BenchmarkRWMutexWrite100-2 305.00 33.00 -89.18%
BenchmarkRWMutexWrite100-4 245.00 113.00 -53.88%
BenchmarkRWMutexWrite100-8 330.00 147.00 -55.45%
BenchmarkRWMutexWrite100-16 371.00 152.00 -59.03%
BenchmarkRWMutexWrite10 78.30 29.80 -61.94%
BenchmarkRWMutexWrite10-2 348.00 165.00 -52.59%
BenchmarkRWMutexWrite10-4 447.00 199.00 -55.48%
BenchmarkRWMutexWrite10-8 564.00 180.00 -68.09%
BenchmarkRWMutexWrite10-16 492.00 192.00 -60.98%
BenchmarkRWMutexWorkWrite100 1077.00 1037.00 -3.71%
BenchmarkRWMutexWorkWrite100-2 659.00 596.00 -9.56%
BenchmarkRWMutexWorkWrite100-4 509.00 361.00 -29.08%
BenchmarkRWMutexWorkWrite100-8 603.00 351.00 -41.79%
BenchmarkRWMutexWorkWrite100-16 750.00 607.00 -19.07%
BenchmarkRWMutexWorkWrite10 990.00 951.00 -3.94%
BenchmarkRWMutexWorkWrite10-2 1119.00 1070.00 -4.38%
BenchmarkRWMutexWorkWrite10-4 1300.00 1199.00 -7.77%
BenchmarkRWMutexWorkWrite10-8 1424.00 1291.00 -9.34%
BenchmarkRWMutexWorkWrite10-16 1981.00 1786.00 -9.84%

R=rsc
CC=golang-dev
https://golang.org/cl/4671051

daaf29cf

effective go: tweak the words about semicolons, parens in control structures, · 4c631295
Rob Pike authored Jul 12, 2011
```
and make and new.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4699043
```
4c631295

hash/crc32: add SSE4.2 support · 9f4c288c

Adam Langley authored Jul 12, 2011

Using the CRC32 instruction speeds up the Castagnoli computation by
about 20x on a modern Intel CPU.

R=rsc
CC=golang-dev
https://golang.org/cl/4650072

9f4c288c

go/build: include processing of .c files for cgo packages · 0f8678a7
Alex Brainman authored Jul 12, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4696041
```
0f8678a7

image: remove superfluous if condition. · 851ded96

Nigel Tao authored Jul 12, 2011

DrawMask already returns early if r.Empty().

R=r
CC=golang-dev
https://golang.org/cl/4703041

851ded96

image: re-organize draw.go. · caaa6764

Nigel Tao authored Jul 12, 2011

There are no behavioral changes, only some copy-and-pastes.

Before, drawFillOver was next to drawCopyOver.

After, drawFillOver is next to drawFillSrc, which is more similar to
drawFillOver than drawCopyOver is.

Similarly, drawCopyOver is now next to drawCopySrc, etc.

R=r
CC=golang-dev
https://golang.org/cl/4695045

caaa6764

image: change Pix from []FooColor to []uint8. · 8bd50895

Nigel Tao authored Jul 12, 2011

Some benchmark numbers below. The image/draw fast-paths show dramatic
improvement, the generic slow-paths show a smaller slow-down.

BEFORE
png.BenchmarkEncodePaletted      200       8203800 ns/op      37.45 MB/s
png.BenchmarkEncodeRGBOpaque         100      26940440 ns/op      45.61 MB/s
png.BenchmarkEncodeRGBA       20      73821000 ns/op      16.65 MB/s
jpeg.BenchmarkEncodeRGBOpaque         50      35598640 ns/op      34.52 MB/s
draw.BenchmarkFillOver	     500	   4024226 ns/op
draw.BenchmarkFillSrc	   10000	    152736 ns/op
draw.BenchmarkCopyOver	     500	   3452824 ns/op
draw.BenchmarkCopySrc	   50000	     73218 ns/op
draw.BenchmarkNRGBAOver	     500	   3941234 ns/op
draw.BenchmarkNRGBASrc	    1000	   2484400 ns/op
draw.BenchmarkYCbCr	    1000	   2609005 ns/op
draw.BenchmarkGlyphOver	    2000	   1169575 ns/op
draw.BenchmarkRGBA	     200	   9031390 ns/op
draw.BenchmarkGenericOver	      50	  34636620 ns/op
draw.BenchmarkGenericMaskOver	     100	  16561150 ns/op
draw.BenchmarkGenericSrc	     100	  13873760 ns/op
draw.BenchmarkGenericMaskSrc	     100	  25198860 ns/op

AFTER
png.BenchmarkEncodePaletted      200       8206600 ns/op      37.43 MB/s
png.BenchmarkEncodeRGBOpaque         100      26129530 ns/op      47.03 MB/s
png.BenchmarkEncodeRGBA       20      75776750 ns/op      16.22 MB/s
jpeg.BenchmarkEncodeRGBOpaque         50      37192940 ns/op      33.04 MB/s
draw.BenchmarkFillOver	     500	   3008134 ns/op
draw.BenchmarkFillSrc	   10000	    154214 ns/op
draw.BenchmarkCopyOver	    1000	   2169988 ns/op
draw.BenchmarkCopySrc	   50000	     73095 ns/op
draw.BenchmarkNRGBAOver	    1000	   2491079 ns/op
draw.BenchmarkNRGBASrc	    2000	   1361244 ns/op
draw.BenchmarkYCbCr	    1000	   2554269 ns/op
draw.BenchmarkGlyphOver	    2000	   1042225 ns/op
draw.BenchmarkRGBA	     100	  10233340 ns/op
draw.BenchmarkGenericOver	      50	  38421560 ns/op
draw.BenchmarkGenericMaskOver	     100	  17521190 ns/op
draw.BenchmarkGenericSrc	     100	  16351200 ns/op
draw.BenchmarkGenericMaskSrc	     100	  26538190 ns/op

R=r
CC=golang-dev
https://golang.org/cl/4675076

8bd50895

image/draw: add benchmarks. · 6ec6f1ef
Nigel Tao authored Jul 12, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4695043
```
6ec6f1ef
doc: document r58.1 · 1002e82f
Russ Cox authored Jul 12, 2011
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/4700041
```
1002e82f

runtime: eliminate false sharing on runtime.goidgen · 013ad89c

Dmitriy Vyukov authored Jul 12, 2011

runtime.goidgen can be quite frequently modified and
shares cache line with the following variables,
it leads to false sharing.
50c6b0 b nfname
50c6b4 b nfunc
50c6b8 b nfunc$17
50c6bc b nhist$17
50c6c0 B runtime.checking
50c6c4 B runtime.gcwaiting
50c6c8 B runtime.goidgen
50c6cc B runtime.gomaxprocs
50c6d0 B runtime.panicking
50c6d4 B strconv.IntSize
50c6d8 B src/pkg/runtime/_xtest_.ss
50c6e0 B src/pkg/runtime/_xtest_.stop
50c6e8 b addrfree
50c6f0 b addrmem
50c6f8 b argv

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4673054

013ad89c

runtime: eliminate false sharing on random number generators · 909f3187

Dmitriy Vyukov authored Jul 12, 2011

Use machine-local random number generator instead of
racy global ones.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4674049

909f3187

runtime: fix data race on runtime·maxstring · f9f21aa1

Dmitriy Vyukov authored Jul 12, 2011

The data race can lead to erroneous output of
"[invalid string]" instead of a string.

R=golang-dev
CC=golang-dev
https://golang.org/cl/4678049

f9f21aa1

6l: change default output name to 6.out.exe on windows · 8ed9fc60
Alex Brainman authored Jul 12, 2011
```
R=golang-dev, vcc.163
CC=golang-dev
https://golang.org/cl/4670049
```
8ed9fc60
http: support for periodic flushing in ReverseProxy · ce3c3953
Brad Fitzpatrick authored Jul 12, 2011
```
Fixes #2012

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4662091
```
ce3c3953

exp/template: make numbers adhere to Go's rules for ideal constants. · 7c477418

Rob Pike authored Jul 12, 2011

Without further type informatnion, 1.0 is a float and an integer
must fit in an int.

R=rsc
CC=golang-dev
https://golang.org/cl/4696042

7c477418

go/build: make Nuke comment say what it does · 05c89edc
Alex Brainman authored Jul 12, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4697041
```
05c89edc
codereview: fix for Mercurial 1.9 · 87d71a38
Andrew Gerrand authored Jul 12, 2011
```
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4686049
```
87d71a38
doc: don't specify make target for working on windwos. · 34bac8bc
Yasuhiro Matsumoto authored Jul 12, 2011
```
makehtml does not work on windows.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/4675041
```
34bac8bc

11 Jul, 2011 1 commit

undo CL 4675045 / 0e11e08951f7 · b4f0e8ff

Andrew Gerrand authored Jul 11, 2011

Breaks Mercurial 1.8.3.

««« original CL description
codereview: fix for Mercurial 1.9

Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4685055

b4f0e8ff