- 02 May, 2014 3 commits
-
-
Dmitriy Vyukov authored
If slice append is the only place where a program allocates, then it will consume all available memory w/o triggering GC. This was demonstrated in the issue. Fixes #7922. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews, iant, khr https://golang.org/cl/91010048
-
Dmitriy Vyukov authored
The monotonic clock patch changed all runtime times to abstract monotonic time. As the result user-visible MemStats.LastGC become monotonic time as well. Restore Unix time for LastGC. This is the simplest way to expose time.now to runtime that I found. Another option would be to change time.now to C called int64 runtime.unixnanotime() and then express time.now in terms of it. But this would require to introduce 2 64-bit divisions into time.now. Another option would be to change time.now to C called void runtime.unixnanotime1(struct {int64 sec, int32 nsec} *now) and then express both time.now and runtime.unixnanotime in terms of it. Fixes #7852. LGTM=minux.ma, iant R=minux.ma, rsc, iant CC=golang-codereviews https://golang.org/cl/93720045
-
Russ Cox authored
If systems actually read that much, using 2GB-1 will result in misaligned subsequent reads. Use 1GB instead, which will certainly keep reads aligned and which is plenty large enough. Update #7812. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/94070044
-
- 01 May, 2014 4 commits
-
-
Robert Hencke authored
LGTM=dsymonds, adg, crawshaw, r, bradfitz, campoy, nigeltao, sameer, iant, robsc, djd, michael.j.fromberger, gmlewis, adonovan, rsc R=golang-codereviews, dsymonds, adg, crawshaw, r, nigeltao, sameer, iant, robsc, djd, michael.j.fromberger, gmlewis, adonovan, rsc CC=golang-codereviews https://golang.org/cl/98880043
-
Brad Fitzpatrick authored
Fixes #7918 LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/91980043
-
Andrew Gerrand authored
This change allows us to give an hg tag such as "go1.3beta1" to revisions in the main branch without breaking the build. This is helpful for community members who want to build the beta from source. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/90190044
-
Keith Randall authored
The backing memory for >1 word interfaces was being scanned conservatively. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/94000043
-
- 30 Apr, 2014 5 commits
-
-
Michael Fraenkel authored
go test may call builder.init() multiple times which will create a new work directory. The cleanup needs to hoist the current work directory. Fixes #7904. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/95900044
-
Ian Lance Taylor authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/90950044
-
Rui Ueyama authored
Not only ChST but also MeST (America/Metlakatla) is a zone name containing a lower case letter. LGTM=robert.hencke, r R=golang-codereviews, robert.hencke, bradfitz, r CC=golang-codereviews https://golang.org/cl/99910043
-
Mikio Hara authored
LGTM=aram R=golang-codereviews, aram CC=golang-codereviews https://golang.org/cl/99890045
-
Robert Hencke authored
Fixes #7412. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/92850043
-
- 29 Apr, 2014 6 commits
-
-
Shenghou Ma authored
FreeBSD 10 is fully supported. LGTM=r R=golang-codereviews, bradfitz, r CC=dave, golang-codereviews https://golang.org/cl/99810044
-
Shenghou Ma authored
Some system doesn't have libc.a available. While we're at here, also export GOROOT in run.bash, so that one doesn't need to set GOROOT to run run.bash. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/99870043
-
Robert Hencke authored
LGTM=ruiu, bradfitz R=golang-codereviews, bradfitz, ruiu CC=golang-codereviews https://golang.org/cl/91840044
-
Ian Lance Taylor authored
For gccgo we rename exported functions so that the compiler will make them visible. This CL adds a #define so that C functions that #include "cgo_export.h" can use the expected names of the function. The test for this is the existing issue6833 test in misc/cgo/test. Without this CL it fails when using -compiler=gccgo. LGTM=minux.ma, rsc R=golang-codereviews, gobot, rsc, minux.ma CC=golang-codereviews https://golang.org/cl/91830046
-
Shenghou Ma authored
This should make Go build without setting CC and CXX on newer FreeBSDs. LGTM=iant R=golang-codereviews, dave, gobot, iant CC=golang-codereviews https://golang.org/cl/89230045
-
Mikio Hara authored
This CL tries to fill the gap between Linux and other Unix-like systems in the same way UDPConn and UnixConn already did. Fixes #7887. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/97810043
-
- 28 Apr, 2014 9 commits
-
-
Shenghou Ma authored
Fixes #7828. LGTM=robert.hencke, iant, bradfitz R=golang-codereviews, robert.hencke, iant, bradfitz CC=golang-codereviews https://golang.org/cl/97780045
-
Shenghou Ma authored
The vi bundled with OS X has a weird bug in that if you turn off filetype in .vimrc when it's not turned on, even a clean exit of vi will return 1 which breaks almost everything. While we're at it, add hint to change $GOROOT to its actual value in .vimrc. Fixes #7865. LGTM=robert.hencke, dsymonds R=golang-codereviews, robert.hencke, gobot, dsymonds CC=golang-codereviews https://golang.org/cl/96800046
-
Keith Randall authored
Use a real type for Gs instead of scanning them conservatively. Zero the schedlink pointer when it is dead. Update #7820 LGTM=rsc R=rsc, dvyukov CC=golang-codereviews https://golang.org/cl/89360043
-
Keith Randall authored
LGTM=rsc R=golang-codereviews, adonovan, rsc CC=golang-codereviews https://golang.org/cl/90440043
-
Robert Hencke authored
Oddly, 404s with the trailing slash. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/90790045
-
Robert Hencke authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/98740046
-
Mikio Hara authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/90810045
-
Mikio Hara authored
Update #7645 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/98790044
-
Robert Hencke authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/98740045
-
- 27 Apr, 2014 8 commits
-
-
Brad Fitzpatrick authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/91770050
-
Mikio Hara authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/91860043
-
Ian Lance Taylor authored
For the gc compiler the Go function Issue7695 is defined in runtime.c, but there is no way to do that for gccgo, because there is no way to get the correct pkgpath. The test is not important for gccgo in any case. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/93870044
-
Peter Collingbourne authored
Previously we used strndup(3) to implement C.CString for gccgo. This is wrong because strndup assumes the string to be null terminated, and stops at the first null terminator. Instead, use malloc and memmove to create a copy of the string, as we do in the gc implementation. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/96790047
-
Brad Fitzpatrick authored
A very smart developer at Gophercon just asked me to help debug a problem and I was horrified to learn that he was using httputil's ClientConn. I forgot ClientConn and ServerConn were even included in Go 1! They should've been deleted. Scare people away from using them. The net/http package does not use them and they're unused, unmaintained and untouched in 4+ years. LGTM=r R=r, adg CC=golang-codereviews https://golang.org/cl/92790043
-
Robert Obryk authored
Remove an RUnlock of syscall.ForkLock with no matching RLock. Holding ForkLock in netFD.dup is unnecessary: dupCloseOnExecOld locks and unlocks the lock on its own and dupCloseOnExec doesn't need the ForkLock to be held. LGTM=iant R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/99800044
-
Rui Ueyama authored
Previously Read wouldn't return once its internal input buffer is filled with non-data bytes. Fixes #7875. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/90820043
-
Robert Hencke authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/96850043
-
- 26 Apr, 2014 4 commits
-
-
Brad Fitzpatrick authored
Fixes #7812 LGTM=josharian, iant R=rsc, iant, adg, ruiu, minux.ma, josharian CC=golang-codereviews https://golang.org/cl/89900044
-
Jonathan Allie authored
Fixes #7741. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/96830044
-
Rob Pike authored
The instructions in this document are useful but not reliable. Explain the situation up top. Fixes #7471. LGTM=josharian, iant R=golang-codereviews, josharian, iant CC=golang-codereviews https://golang.org/cl/96830045
-
Robert Hencke authored
(from the discussions on CL 89650044) LGTM=minux.ma, iant R=iant, minux.ma CC=golang-codereviews https://golang.org/cl/97770043
-
- 25 Apr, 2014 1 commit
-
-
Brad Fitzpatrick authored
Fixes #7869 LGTM=dsymonds R=golang-codereviews CC=adg, dsymonds, golang-codereviews, rsc https://golang.org/cl/91770048
-