Commits · 8d6bc666fb86a45f2f426009b05fc07d3fb1cefc · go / golang

02 Oct, 2013 6 commits

cmd/gc: qualified embedded fields with owner package. · 8d6bc666
Rémy Oudompheng authored Oct 02, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/14188044
```
8d6bc666

crypto/tls: Update reference to the TLS 1.2 RFC. · 4d7c6355

Frithjof Schulze authored Oct 02, 2013

Ticket 13740047 updated the documented TLS version to 1.2.
This also updates the RFC refered to.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/14029043

4d7c6355

runtime: do not scan stack by frames during garbage collection · c3dadca9

Russ Cox authored Oct 02, 2013

Walking the stack by frames is ~3x more expensive
than not, and since it didn't end up being precise,
there is not enough benefit to outweigh the cost.

This is the conservative choice: this CL makes the
stack scanning behavior the same as it was in Go 1.1.

Add benchmarks to package runtime so that we have
them when we re-enable this feature during the
Go 1.3 development.

benchmark                     old ns/op    new ns/op    delta
BenchmarkGoroutineSelect        3194909      1272092  -60.18%
BenchmarkGoroutineBlocking      3120282       866366  -72.23%
BenchmarkGoroutineForRange      3256179       939902  -71.13%
BenchmarkGoroutineIdle          2005571       482982  -75.92%

The Go 1 benchmarks, just to add more data.
As far as I can tell the changes are mainly noise.

benchmark                         old ns/op    new ns/op    delta
BenchmarkBinaryTree17            4409403046   4414734932   +0.12%
BenchmarkFannkuch11              3407708965   3378306120   -0.86%
BenchmarkFmtFprintfEmpty                100           99   -0.60%
BenchmarkFmtFprintfString               242          239   -1.24%
BenchmarkFmtFprintfInt                  204          206   +0.98%
BenchmarkFmtFprintfIntInt               320          316   -1.25%
BenchmarkFmtFprintfPrefixedInt          295          299   +1.36%
BenchmarkFmtFprintfFloat                442          435   -1.58%
BenchmarkFmtManyArgs                   1246         1216   -2.41%
BenchmarkGobDecode                 10186951     10051210   -1.33%
BenchmarkGobEncode                 16504381     16445650   -0.36%
BenchmarkGzip                     447030885    447056865   +0.01%
BenchmarkGunzip                   111056154    111696305   +0.58%
BenchmarkHTTPClientServer             89973        93040   +3.41%
BenchmarkJSONEncode                28174182     27933893   -0.85%
BenchmarkJSONDecode               106353777    110443817   +3.85%
BenchmarkMandelbrot200              4822289      4806083   -0.34%
BenchmarkGoParse                    6102436      6142734   +0.66%
BenchmarkRegexpMatchEasy0_32            133          132   -0.75%
BenchmarkRegexpMatchEasy0_1K            372          373   +0.27%
BenchmarkRegexpMatchEasy1_32            113          111   -1.77%
BenchmarkRegexpMatchEasy1_1K            964          940   -2.49%
BenchmarkRegexpMatchMedium_32           202          205   +1.49%
BenchmarkRegexpMatchMedium_1K         68862        68858   -0.01%
BenchmarkRegexpMatchHard_32            3480         3407   -2.10%
BenchmarkRegexpMatchHard_1K          108255       112614   +4.03%
BenchmarkRevcomp                  751393035    743929976   -0.99%
BenchmarkTemplate                 139637041    135402220   -3.03%
BenchmarkTimeParse                      479          475   -0.84%
BenchmarkTimeFormat                     460          466   +1.30%

benchmark                          old MB/s     new MB/s  speedup
BenchmarkGobDecode                    75.34        76.36    1.01x
BenchmarkGobEncode                    46.50        46.67    1.00x
BenchmarkGzip                         43.41        43.41    1.00x
BenchmarkGunzip                      174.73       173.73    0.99x
BenchmarkJSONEncode                   68.87        69.47    1.01x
BenchmarkJSONDecode                   18.25        17.57    0.96x
BenchmarkGoParse                       9.49         9.43    0.99x
BenchmarkRegexpMatchEasy0_32         239.58       241.74    1.01x
BenchmarkRegexpMatchEasy0_1K        2749.74      2738.00    1.00x
BenchmarkRegexpMatchEasy1_32         282.49       286.32    1.01x
BenchmarkRegexpMatchEasy1_1K        1062.00      1088.96    1.03x
BenchmarkRegexpMatchMedium_32          4.93         4.86    0.99x
BenchmarkRegexpMatchMedium_1K         14.87        14.87    1.00x
BenchmarkRegexpMatchHard_32            9.19         9.39    1.02x
BenchmarkRegexpMatchHard_1K            9.46         9.09    0.96x
BenchmarkRevcomp                     338.26       341.65    1.01x
BenchmarkTemplate                     13.90        14.33    1.03x

Fixes #6482.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/14257043

c3dadca9

cmd/dist, build: support building statically linked toolchain · 6b188ef5

Shenghou Ma authored Oct 02, 2013

Added a new $GO_DISTFLAGS to make.bash, and while we're here,
added mention $CXX in make.bash (CL 13704044).

Fixes #6448.
Update #3564
We can pass GO_DISTFLAGS=-s from misc/dist to make.bash so that
it will build a statically linked toolchain.
(Note: OS X doesn't have the concept of static linking, so don't
pass GO_DISTFLAGS=-s for OS X builds)

R=adg, rsc, iant
CC=golang-dev
https://golang.org/cl/13887043

6b188ef5

doc: rename @go_nuts to @golang · 57d37b55
Andrew Gerrand authored Oct 02, 2013
```
Yay!

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/14256043
```
57d37b55

cmd/go: use -installsuffix to determine the includes directory list · 57f69710

Dave Day authored Oct 02, 2013

Currently, the directories generaed by includeArgs can have the "_race"
suffix added if invoked with -race flag, but ignores -installsuffix if
set.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/14174043

57f69710

01 Oct, 2013 2 commits

misc/vim: Separate package and package members. · fcee50c4

Yasuhiro Matsumoto authored Oct 01, 2013

This change allow to godoc:
    :Godoc github.com/mattn/go-gtk/gtk
    :Godoc github.com/mattn/go-gtk/gtk NewWindow
    :Godoc encoding/json
    :Godoc encoding/json Marshal

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/14171043

fcee50c4

C: add Dave Day (Google CLA). · ac3d6a56
David Symonds authored Oct 01, 2013
```
R=adg, djd
CC=golang-dev
https://golang.org/cl/14176043
```
ac3d6a56

30 Sep, 2013 2 commits

undo CL 14154043 / 3e485428767e · 7a480a8c

Carl Shapiro authored Sep 30, 2013

««« original CL description
encoding/gob: do not hide pointer argument for the garbage collector

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14154043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/14165043

7a480a8c

encoding/gob: do not hide pointer argument for the garbage collector · 6ffd70e7
Carl Shapiro authored Sep 30, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14154043
```
6ffd70e7

29 Sep, 2013 1 commit

race.bash, race.bat: build a race enabled cmd/cgo before trying to use it · cdb33231

Dave Cheney authored Sep 29, 2013

Fixes #5537.

To avoid `go install -v race std` replacing cmd/cgo with a race enabled version and another package trying to build a cgo enabled package, always build cmd/cgo race enabled before doing the rest of the build.

R=remyoudompheng, rsc, dvyukov, minux.ma
CC=golang-dev
https://golang.org/cl/14071044

cdb33231

28 Sep, 2013 3 commits

test: match gccgo error messages for blank1.go · 4da408f6

Ian Lance Taylor authored Sep 28, 2013

blank1.go:10:9: error: invalid package name _
blank1.go:17:2: error: cannot use _ as value
blank1.go:18:7: error: cannot use _ as value
blank1.go:20:8: error: invalid use of ‘_’

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14088044

4da408f6

test: recognize gccgo error message in index.go · bdafe73c

Ian Lance Taylor authored Sep 28, 2013

When a floating point constant is used as an array/slice
index, gccgo prints "error: index must be integer"; gc prints
"constant 2.1 truncated to integer".

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/14044044

bdafe73c

syscall: Fix one issue detected by vet. · 9bd1f49e
Robin Eklind authored Sep 28, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/14038044
```
9bd1f49e

27 Sep, 2013 5 commits

encoding/json: Tweak documentation for Encoder.Encode. · 48da6754

Kamil Kisiel authored Sep 27, 2013

The documentation for the Encoder type calls it a stream,
not a connection.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/14015044

48da6754

reflect: expose reflect.call argument slice to the garbage collector · 0ab8f2d2

Carl Shapiro authored Sep 27, 2013

The argument slice was kept hidden from the garbage collector
by destroying its referent in an unsafe.Pointer to uintptr
conversion.  This change preserves the unsafe.Pointer referent
and only performs an unsafe.Pointer to uintptr conversions
within expressions that construct new unsafe.Pointer values.

R=golang-dev, khr, rsc
CC=golang-dev
https://golang.org/cl/14008043

0ab8f2d2

misc/vim: "PACKAGE DOCUMENTATION" is not hilighted · d6eada28
Yasuhiro Matsumoto authored Sep 27, 2013
```
R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/14018043
```
d6eada28
misc/vim: godoc is optional. so should point installation instruction. · b1284268
Yasuhiro Matsumoto authored Sep 27, 2013
```
R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/14017043
```
b1284268
all: fix some mistakes found by go tool vet . · fa7791e9
Rob Pike authored Sep 27, 2013
```
R=golang-dev, iant, adg
CC=golang-dev
https://golang.org/cl/14000043
```
fa7791e9

26 Sep, 2013 3 commits

doc: update links to spec and memory model · 1f7c8a9a
Andrew Gerrand authored Sep 26, 2013
```
Fixes #6488.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14004043
```
1f7c8a9a

crypto/tls: don't select TLS 1.2 cipher suites in prior versions. · f752484c

Adam Langley authored Sep 26, 2013

AES-GCM cipher suites are only defined for TLS 1.2, although there's
nothing really version specific about them. However, development
versions of NSS (meaning Firefox and Chrome) have an issue where
they'll advertise TLS 1.2-only cipher suites in a TLS 1.1 ClientHello
but then balk when the server selects one.

This change causes Go clients not to advertise TLS 1.2 cipher suites
unless TLS 1.2 is being used, and prevents servers from selecting them
unless TLS 1.2 has been negotiated.

https://code.google.com/p/chromium/issues/detail?id=297151
https://bugzilla.mozilla.org/show_bug.cgi?id=919677

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13573047

f752484c

runtime, syscall: update freebsd/arm calling convention to match EABI · 649a2a9b

Dave Cheney authored Sep 26, 2013

Fixes #6451.

There is still some breakages unrelated to the syscall change.

[root@beaglebone ~/go/src]# /root/go/pkg/tool/freebsd_arm/go_bootstrap version
go version devel freebsd/arm
a std@beaglebone ~/go/src]# /root/go/pkg/tool/freebsd_arm/go_bootstrap install -
fatal error: mark - finalizer inconsistency

runtime stack:
runtime.throw(0x3e80ac)
        /root/go/src/pkg/runtime/panic.c:464 +0x5c
addfinroots(0x2)
        /root/go/src/pkg/runtime/mgc0.c:1501 +0x74
runtime.walkfintab(0x6c200)
        /root/go/src/pkg/runtime/mfinal.c:216 +0xa0
addroots()
        /root/go/src/pkg/runtime/mgc0.c:1561 +0x188
gc(0x50632f78)
        /root/go/src/pkg/runtime/mgc0.c:2098 +0x19c
mgc(0x306170a0)
        /root/go/src/pkg/runtime/mgc0.c:2049 +0x30
runtime.mcall(0x3e97b0)
        /root/go/src/pkg/runtime/asm_arm.s:165 +0x3c

goroutine 1 [garbage collection]:
runtime.gc(0x0)
        /root/go/src/pkg/runtime/mgc0.c:2020 +0x1a0 fp=0x50632f80
runtime.mallocgc(0x680, 0x1b1971, 0x1)
        /root/go/src/pkg/runtime/malloc.goc:143 +0x210 fp=0x50632fbc
----- stack segment boundary -----
cnew(0x1b1970, 0x640, 0x1)
        /root/go/src/pkg/runtime/malloc.goc:718 +0xc4 fp=0x50626110
runtime.cnewarray(0x1b1970, 0x640)
        /root/go/src/pkg/runtime/malloc.goc:731 +0x3c fp=0x50626120
makeslice1(0x1ac6d0, 0x500, 0x640, 0x50626190)
        /root/go/src/pkg/runtime/slice.c:57 +0x50 fp=0x5062612c
growslice1(0x1ac6d0, 0x30714a00, 0x500, 0x500, 0x501, ...)
        /root/go/src/pkg/runtime/slice.c:113 +0x8c fp=0x50626144
runtime.growslice(0x1ac6d0, 0x30714a00, 0x500, 0x500, 0x1, ...)
        /root/go/src/pkg/runtime/slice.c:80 +0x19c fp=0x50626174
go/build.(*importReader).readByte(0x3070d1b0, 0xb384e)
        /root/go/src/pkg/go/build/read.go:43 +0xbc fp=0x506261b4
go/build.(*importReader).peekByte(0x3070d1b0, 0x3070d101, 0x3070d180)
        /root/go/src/pkg/go/build/read.go:89 +0x210 fp=0x506261d0
go/build.readComments(0x203e2560, 0x306f79a8, 0x306f79a8, 0x203e2560, 0x306f79a8, ...)
        /root/go/src/pkg/go/build/read.go:194 +0x84 fp=0x506261f4
go/build.(*Context).matchFile(0x3e9730, 0x306209c0, 0x13, 0x306c42b4, 0x5, ...)
        /root/go/src/pkg/go/build/build.go:812 +0x74c fp=0x5062629c
go/build.(*Context).Import(0x3e9730, 0x1f95c8, 0x1, 0x30620960, 0x13, ...)
        /root/go/src/pkg/go/build/build.go:580 +0xd64 fp=0x506268dc
go/build.(*Context).ImportDir(0x3e9730, 0x30620960, 0x13, 0x0, 0x24d901, ...)
        /root/go/src/pkg/go/build/build.go:397 +0x5c fp=0x50626904
main.func·021(0x30620960, 0x13, 0x203e2200, 0x30680330, 0x0, ...)
        /root/go/src/cmd/go/main.go:521 +0x2cc fp=0x5062696c
path/filepath.walk(0x30620960, 0x13, 0x203e2200, 0x30680330, 0x50626ae8, ...)
        /root/go/src/pkg/path/filepath/path.go:341 +0x5c fp=0x506269d8
path/filepath.walk(0x3067e720, 0x11, 0x203e2200, 0x30680210, 0x50626ae8, ...)
        /root/go/src/pkg/path/filepath/path.go:359 +0x308 fp=0x50626a44
path/filepath.Walk(0x3067e720, 0x11, 0x50626ae8, 0x1f9728, 0x1)
        /root/go/src/pkg/path/filepath/path.go:380 +0xb4 fp=0x50626a68
main.matchPackages(0xbfffedea, 0x3, 0x1b1190, 0x3067e600, 0x10)
        /root/go/src/cmd/go/main.go:530 +0x2c0 fp=0x50626b1c
main.allPackages(0xbfffedea, 0x3, 0x1fadc8, 0x3, 0x1)
        /root/go/src/cmd/go/main.go:474 +0x34 fp=0x50626b70
main.importPathsNoDotExpansion(0x30620018, 0x1, 0x1, 0x0, 0xffffffff, ...)
        /root/go/src/cmd/go/main.go:305 +0x2f8 fp=0x50626c04
main.importPaths(0x30620018, 0x1, 0x1, 0x3, 0x0, ...)
        /root/go/src/cmd/go/main.go:315 +0x44 fp=0x50626c88
main.packagesAndErrors(0x30620018, 0x1, 0x1, 0x50626d60, 0x90f44, ...)
        /root/go/src/cmd/go/pkg.go:798 +0x1bc fp=0x50626d1c
main.packagesForBuild(0x30620018, 0x1, 0x1, 0x53490, 0x0, ...)
        /root/go/src/cmd/go/pkg.go:818 +0x44 fp=0x50626dac
main.runInstall(0x3e46e0, 0x30620018, 0x1, 0x1)
        /root/go/src/cmd/go/build.go:311 +0x48 fp=0x50626e60
main.main()
        /root/go/src/cmd/go/main.go:161 +0x518 fp=0x50626f8c
runtime.main()
        /root/go/src/pkg/runtime/proc.c:222 +0x100 fp=0x50626fc0
runtime.goexit()
        /root/go/src/pkg/runtime/proc.c:1396 fp=0x50626fc0

goroutine 3 [syscall]:
os/signal.loop()
        /root/go/src/pkg/os/signal/signal_unix.go:21 +0x24
created by os/signal.init·1
        /root/go/src/pkg/os/signal/signal_unix.go:27 +0x48

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/13824044

649a2a9b

25 Sep, 2013 7 commits

cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang · 752960aa
Shenghou Ma authored Sep 25, 2013
```
Fixes #6480.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13925043
```
752960aa
doc: mention the install locations for godoc, cover, and vet · bc0e5155
Andrew Gerrand authored Sep 25, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13893043
```
bc0e5155
doc/go1.2.html: add go/ast.SliceExpr.Slice3 · 4be17b7a
Rob Pike authored Sep 25, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13877044
```
4be17b7a
doc: fix typo in install-source.html · bc5e77fe
Andrew Gerrand authored Sep 25, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13892043
```
bc5e77fe
doc: document installation of go.tools commands · b3caa86f
Andrew Gerrand authored Sep 25, 2013
```
Fixes #5663.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13891043
```
b3caa86f

cmd/cgo: fix so that tests pass again when using gccgo · 935a826a

Ian Lance Taylor authored Sep 25, 2013

Use the symbol prefixes with the prologue functions when using
gccgo.

Use an & when referring to a function declared as a variable.

Fix the malloc prologue function.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13878043

935a826a

html/template: update the Tree field after parsing new templates · e2e9d1d6

Rob Pike authored Sep 25, 2013

After text/template.Parse, all the templates may have changed, so
we need to set them all back to their unescaped state. The code
did this but (mea culpa) forgot to set the Tree field of the html/template
struct.

Since the Tree is reset during escaping, this only matters if an error
arises during escaping and we want to print a message.

Fixes #6459.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13877043

e2e9d1d6

24 Sep, 2013 10 commits

go/ast: add Slice3 field to SliceExpr · 20db0f42

Robert Griesemer authored Sep 24, 2013

If Slice3 is set, the expression is
a 3-index slice expression (2 colons).
Required for type-checking.

Backward-compatible API extension.

R=r, rsc
CC=golang-dev
https://golang.org/cl/13826050

20db0f42

math/big: Fix variable name in documentation for *Int.Bytes and BitLen. · b0ef6aef
Kamil Kisiel authored Sep 24, 2013
```
R=golang-dev, iant, gri
CC=golang-dev
https://golang.org/cl/13869043
```
b0ef6aef
sync/atomic: adjust for new runtime.cas64 prototype · 828a4b93
Russ Cox authored Sep 24, 2013
```
R=golang-dev, minux.ma, josharian
CC=golang-dev
https://golang.org/cl/13859043
```
828a4b93
cmd/cgo: retain Go pointer passed to C call for duration of call · 5639d275
Russ Cox authored Sep 24, 2013
```
Fixes #6397.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://golang.org/cl/13858043
```
5639d275
cmd/dist, cmd/go: embed default C++ compiler into cmd/go · 7616c949
Shenghou Ma authored Sep 24, 2013
```
Fixes #6426.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/13704044
```
7616c949

net: re-enable raw socket tests on windows · b80ef1ab

Alex Brainman authored Sep 24, 2013

Since CL 38bf89161a72 raw socket tests are not executed
on windows builders. This change re-enable them again.
It will attempt to run raw socket tests only if user
is permitted to create raw socket by OS.

Fixes #6392

R=golang-dev
CC=golang-dev, mikioh.mikioh, rsc
https://golang.org/cl/13422044

b80ef1ab

encoding/json: don't cache value addressability when building first encoder · 0f3ea750

Brad Fitzpatrick authored Sep 24, 2013

newTypeEncoder (called once per type and then cached) was
looking at the first value seen of that type's addressability
and caching the encoder decision.  If the first value seen was
addressable and a future one wasn't, it would panic.

Instead, introduce a new wrapper encoder type that checks
CanAddr at runtime.

Fixes #6458

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13839045

0f3ea750

net: ensure that ResolveTCPAddr(addr.String()) reproduces addr · e8bbbe08
Russ Cox authored Sep 24, 2013
```
And same for UDP.

Fixes #6465.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13740048
```
e8bbbe08
net: fix Close of autobind unix listener · 2be62360
Albert Strasheim authored Sep 24, 2013
```
Fixes #6455.

R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/13457058
```
2be62360
reflect: update docs; Interface can return a method value · 2d2ae531
Andrew Gerrand authored Sep 24, 2013
```
Fixes #6460.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13761046
```
2d2ae531

23 Sep, 2013 1 commit

net/http: accept Content-Range for entire file · d9f034dc

Russ Cox authored Sep 23, 2013

Fixes a bug reported privately.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13846043

d9f034dc