Commits · 90f3cb13fb0f37073e02ecd79771deb938ea7f5e · go / golang

20 Jul, 2011 9 commits

runtime: improve performance of sync channels · 90f3cb13

Dmitriy Vyukov authored Jul 20, 2011

1. SudoG always contains a pointer to the element
(thus no variable size, and less copying).
2. chansend/chanrecv allocate SudoG on the stack.
3. Copying of elements and gorotuine notifications
are moved out of critical sections.

benchmark                        old ns/op    new ns/op    delta
BenchmarkSelectUncontended          515.00       514.00   -0.19%
BenchmarkSelectUncontended-2        291.00       281.00   -3.44%
BenchmarkSelectUncontended-4        213.00       189.00  -11.27%
BenchmarkSelectUncontended-8         78.30        79.00   +0.89%
BenchmarkSelectContended            518.00       514.00   -0.77%
BenchmarkSelectContended-2          655.00       631.00   -3.66%
BenchmarkSelectContended-4         1026.00      1051.00   +2.44%
BenchmarkSelectContended-8         2026.00      2128.00   +5.03%
BenchmarkSelectNonblock             175.00       173.00   -1.14%
BenchmarkSelectNonblock-2            85.10        87.70   +3.06%
BenchmarkSelectNonblock-4            60.10        43.30  -27.95%
BenchmarkSelectNonblock-8            37.60        25.50  -32.18%
BenchmarkChanUncontended            109.00       114.00   +4.59%
BenchmarkChanUncontended-2           54.60        57.20   +4.76%
BenchmarkChanUncontended-4           27.40        28.70   +4.74%
BenchmarkChanUncontended-8           14.60        15.10   +3.42%
BenchmarkChanContended              108.00       114.00   +5.56%
BenchmarkChanContended-2            621.00       617.00   -0.64%
BenchmarkChanContended-4            759.00       677.00  -10.80%
BenchmarkChanContended-8           1635.00      1517.00   -7.22%
BenchmarkChanSync                   299.00       256.00  -14.38%
BenchmarkChanSync-2                5055.00      4624.00   -8.53%
BenchmarkChanSync-4                4998.00      4680.00   -6.36%
BenchmarkChanSync-8                5019.00      4760.00   -5.16%
BenchmarkChanProdCons0              316.00       274.00  -13.29%
BenchmarkChanProdCons0-2           1280.00       617.00  -51.80%
BenchmarkChanProdCons0-4           2433.00      1332.00  -45.25%
BenchmarkChanProdCons0-8           3651.00      1934.00  -47.03%
BenchmarkChanProdCons10             153.00       152.00   -0.65%
BenchmarkChanProdCons10-2           626.00       581.00   -7.19%
BenchmarkChanProdCons10-4          1440.00      1323.00   -8.12%
BenchmarkChanProdCons10-8          2036.00      2017.00   -0.93%

R=rsc, ken
CC=golang-dev
https://golang.org/cl/4790042

90f3cb13

ld: remove overlap of ELF sections on dynamic binaries · ba2e3af1

Gustavo Niemeyer authored Jul 20, 2011

The dynamic ELF sections were pointing to the proper data,
but that data was already owned by the rodata and text sections.
Some ELF references explicitly prohibit multiple sections from
owning the same data, and strip behaves accordingly.

The data for these sections was moved out and their ranges are
now owned by their respective sections.  This change makes strip
happy both with and without -s being provided at link time.

A test was added in debug/elf to ensure there are no regressions
on this area in the future.

Fixes #1242.
Fixes #2022.

NOTE: Tested on Linux amd64/386/arm only.

R=rsc
CC=golang-dev
https://golang.org/cl/4808043

ba2e3af1

net/textproto: fix build · 971459e8
Russ Cox authored Jul 20, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4815041
```
971459e8
net/textproto: avoid 1 copy in ReadLine, ReadContinuedLine · 27a3dcd0
Russ Cox authored Jul 20, 2011
```
Fixes #2083.

R=msolo, bradfitz
CC=golang-dev
https://golang.org/cl/4812042
```
27a3dcd0
exp/norm: API for normalization library. · df07b6d1
Marcel van Lohuizen authored Jul 20, 2011
```
R=r, r, mpvl, rsc
CC=golang-dev
https://golang.org/cl/4678041
```
df07b6d1
gobuilder: goinstall with -dashboard=false instead of -log=false · dbba5ccf
Andrew Gerrand authored Jul 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4801043
```
dbba5ccf
tag weekly.2011-07-19 · 40462453
Andrew Gerrand authored Jul 20, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4802043
```
40462453

weekly.2011-07-19 · 50ddb98b

Andrew Gerrand authored Jul 20, 2011

R=golang-dev, nigeltao, dsymonds, r
CC=golang-dev
https://golang.org/cl/4801042

50ddb98b

misc/dashboard: center align build results · 48d1240e
Andrew Gerrand authored Jul 20, 2011
```
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/4806041
```
48d1240e

19 Jul, 2011 16 commits

sync/atomic: delete workaround · 62f618a2

Rob Pike authored Jul 19, 2011

Load seems to work on arm now.

R=dsymonds
CC=golang-dev
https://golang.org/cl/4795042

62f618a2

godoc: implement http.FileSystem for zip files · 8930ce2d
Robert Griesemer authored Jul 19, 2011
```
R=rsc, adg, bradfitz
CC=golang-dev
https://golang.org/cl/4750047
```
8930ce2d

runtime: make goc2c build on Plan 9 · b546f507

Lucio De Re authored Jul 19, 2011

pkg/runtime/Makefile:
. Adjusted so "goc2c.c" is built using the Plan 9 libraries.

pkg/runtime/goc2c.c:
. Added/subtracted #include headers to correspond to Plan 9
  toolkit.
. Changed fprintf(stderr,...)/exit() combinations to
  sysfatal() calls, adjusted the "%u" format to "%ud".
. Added exits(0) at the end of main().
. Made main() a void-returning function and removed the
  "return 0" at the end of it.

Tested on UBUNTU and Plan 9 only.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4626093

b546f507

runtime: faster entersyscall, exitsyscall · 025abd53

Russ Cox authored Jul 19, 2011

Uses atomic memory accesses to avoid the need to acquire
and release schedlock on fast paths.

benchmark                            old ns/op    new ns/op    delta
runtime_test.BenchmarkSyscall               73           31  -56.63%
runtime_test.BenchmarkSyscall-2            538           74  -86.23%
runtime_test.BenchmarkSyscall-3            508          103  -79.72%
runtime_test.BenchmarkSyscall-4            721           97  -86.52%
runtime_test.BenchmarkSyscallWork          920          873   -5.11%
runtime_test.BenchmarkSyscallWork-2        516          481   -6.78%
runtime_test.BenchmarkSyscallWork-3        550          343  -37.64%
runtime_test.BenchmarkSyscallWork-4        632          263  -58.39%

(Intel Core i7 L640 2.13 GHz-based Lenovo X201s)

Reduced a less artificial server benchmark
from 11.5r 12.0u 8.0s to 8.3r 9.1u 1.0s.

R=dvyukov, r, bradfitz, r, iant, iant
CC=golang-dev
https://golang.org/cl/4723042

025abd53

cgo: windows amd64 port · 9f636598
Wei Guangjing authored Jul 19, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4725041
```
9f636598

sync/atomic: fix LoadInt32 on ARM · 0b200b4d

Dmitriy Vyukov authored Jul 19, 2011

R0 is clobbered after cas,
while R1 preserves its value.

R=golang-dev
CC=golang-dev
https://golang.org/cl/4782042

0b200b4d

sync/atomic: attempt to get the arm build green. · 3bbeef52

Rob Pike authored Jul 19, 2011

Disable the LoadInt32 and LoadUint32 tests, since they fail.
These should be fixed but we want to get through the rest of the build
to see if something else unrelated is broken.  The arm build has been
bad for a long time.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4780041

3bbeef52

goinstall, dashboard: Google Code now supports git · a0d3be16
Tarmigan Casebolt authored Jul 19, 2011
```
R=golang-dev, adg, rsc, tarmigan+golang
CC=golang-dev
https://golang.org/cl/4760055
```
a0d3be16

5l: fix arm linker bug introduced by 4742041 · 423ab233

Rob Pike authored Jul 19, 2011

Should fix the arm build.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/4777041

423ab233

doc/talks/io2010: handle the errors · 894222f9
Andrew Gerrand authored Jul 19, 2011
```
R=golang-dev, dsymonds, dsymonds, r
CC=golang-dev
https://golang.org/cl/4771041
```
894222f9
go/build: fixes for windows paths · 42effdf0
Alex Brainman authored Jul 19, 2011
```
R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4746047
```
42effdf0
archive/zip: support functions to get modified time in ns from MS-DOS time · 98f5fc5e
Robert Griesemer authored Jul 19, 2011
```
R=rsc, r, bradfitz, r, adg
CC=golang-dev
https://golang.org/cl/4748056
```
98f5fc5e
exp/wingui: make sure it builds again · 208e6e6d
Alex Brainman authored Jul 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4770041
```
208e6e6d
gif: fix local color map and coordinates · a5a94f5d
Rob Pike authored Jul 19, 2011
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/4759051
```
a5a94f5d
dashboard: list "most installed this week" with rolling count · 7a18fc3b
Andrew Gerrand authored Jul 19, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4631085
```
7a18fc3b
time: typo in documentation · 95117d30
Robert Griesemer authored Jul 19, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4763048
```
95117d30

18 Jul, 2011 15 commits

runtime: fix select pass 3 · 47e6042f
Hector Chu authored Jul 18, 2011
```
Fixes #2075

R=rsc, ken, r
CC=golang-dev
https://golang.org/cl/4748045
```
47e6042f

runtime: track running goroutine count · bd776191

Russ Cox authored Jul 18, 2011

Used to use mcpu+msyscall but that's
problematic for packing into a single
atomic word.  The running goroutine count
(where running == Go code or syscall)
can be maintained separately, always
manipulated under lock.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4767041

bd776191

runtime: add per-M caches for MemStats · 27753ff1

Dmitriy Vyukov authored Jul 18, 2011

Avoid touching centralized state during
memory manager operations.

R=mirtchovski
CC=golang-dev, rsc
https://golang.org/cl/4766042

27753ff1

runtime: add per-M caches for MemStats · 66d5c9b1

Dmitriy Vyukov authored Jul 18, 2011

Avoid touching centralized state during
memory manager opreations.

R=rsc
CC=golang-dev
https://golang.org/cl/4766042

66d5c9b1

debug/proc: Remove. · 257df171

Ian Lance Taylor authored Jul 18, 2011

The package was always GNU/Linux specific, and is no longer
used by anything now that exp/ogle has been removed.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4757049

257df171

sync: add fast paths to WaitGroup · ee6e1a3f

Dmitriy Vyukov authored Jul 18, 2011

benchmark old ns/op new ns/op delta
BenchmarkWaitGroupUncontended 93.50 33.60 -64.06%
BenchmarkWaitGroupUncontended-2 44.30 16.90 -61.85%
BenchmarkWaitGroupUncontended-4 21.80 8.47 -61.15%
BenchmarkWaitGroupUncontended-8 12.10 4.86 -59.83%
BenchmarkWaitGroupUncontended-16 7.38 3.35 -54.61%
BenchmarkWaitGroupAddDone 58.40 33.70 -42.29%
BenchmarkWaitGroupAddDone-2 293.00 85.80 -70.72%
BenchmarkWaitGroupAddDone-4 243.00 51.10 -78.97%
BenchmarkWaitGroupAddDone-8 236.00 52.20 -77.88%
BenchmarkWaitGroupAddDone-16 215.00 43.30 -79.86%
BenchmarkWaitGroupAddDoneWork 826.00 794.00 -3.87%
BenchmarkWaitGroupAddDoneWork-2 450.00 424.00 -5.78%
BenchmarkWaitGroupAddDoneWork-4 277.00 220.00 -20.58%
BenchmarkWaitGroupAddDoneWork-8 440.00 116.00 -73.64%
BenchmarkWaitGroupAddDoneWork-16 569.00 66.50 -88.31%
BenchmarkWaitGroupWait 29.00 8.04 -72.28%
BenchmarkWaitGroupWait-2 74.10 4.15 -94.40%
BenchmarkWaitGroupWait-4 117.00 2.30 -98.03%
BenchmarkWaitGroupWait-8 111.00 1.31 -98.82%
BenchmarkWaitGroupWait-16 104.00 1.27 -98.78%
BenchmarkWaitGroupWaitWork 802.00 792.00 -1.25%
BenchmarkWaitGroupWaitWork-2 411.00 401.00 -2.43%
BenchmarkWaitGroupWaitWork-4 210.00 199.00 -5.24%
BenchmarkWaitGroupWaitWork-8 206.00 105.00 -49.03%
BenchmarkWaitGroupWaitWork-16 334.00 54.40 -83.71%

R=rsc
CC=golang-dev
https://golang.org/cl/4672050

ee6e1a3f

5l: assume Linux binary, not Plan 9 · 92c6061b
Russ Cox authored Jul 18, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4767042
```
92c6061b

http: let FileServer work when path doesn't begin with a slash · 3745716b

Brad Fitzpatrick authored Jul 18, 2011

... as when it's over-stripped with StripPrefix.

R=golang-dev, andybalholm, rsc
CC=golang-dev
https://golang.org/cl/4759052

3745716b

ld: allow seek within write buffer · caa56474

Russ Cox authored Jul 18, 2011

Reduces number of write+seek's from 88516 to 2080
when linking godoc with 6l.

Thanks to Alex Brainman for pointing out the
many small writes.

R=golang-dev, r, alex.brainman, robert.hencke
CC=golang-dev
https://golang.org/cl/4743043

caa56474

syscall: Parse and encode SCM_RIGHTS and SCM_CREDENTIALS. · 870fdd76
Albert Strasheim authored Jul 18, 2011
```
R=rsc, agl, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4667066
```
870fdd76

runtime: fix data race in Plan9 sysalloc · c1f035ba

Dmitriy Vyukov authored Jul 18, 2011

Add mutex to protect brk limit.
Add mstats.sys update.

R=rsc
CC=golang-dev
https://golang.org/cl/4762045

c1f035ba

cgo: add missing semicolon in generated struct · e8689404

Brad Fitzpatrick authored Jul 18, 2011

This affected certain signatures needing padding
like:

//export Foo
func Foo() (int, C.long) { ... }

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4745047

e8689404

gc: fix silent sign truncation in pgen.c · c945d9c8

Dave Cheney authored Jul 18, 2011

Fixes #2076.

R=golang-dev, r, r, dsymonds, lucio.dere
CC=golang-dev
https://golang.org/cl/4744047

c945d9c8

exp/template: dig into empty interfaces so a struct (say) stored in an empty · 9a5bb287

Rob Pike authored Jul 18, 2011

interface field can be unpacked. We don't have type assertions here so we
must be forthright.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4757047

9a5bb287

doc: fix padding on h1 tags · ab55133c

Andrew Gerrand authored Jul 18, 2011

See /doc/codewalk/sharemem/ for an example of how it's broken.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4742044

ab55133c