Commits · 920df48fb1e1b30f5ea86f1a49b599098fa81793 · go / golang

16 Nov, 2011 10 commits

gc: support for building with Plan 9 yacc · 920df48f

Anthony Martin authored Nov 16, 2011

I've modified Plan 9's yacc to work with
the grammar in go.y.  These are the only
changes necessary on the Go side.

R=rsc
CC=golang-dev
https://golang.org/cl/5375104

920df48f

go/ast: remove unused receiver names (cleanup) · d0b9a84a
Robert Griesemer authored Nov 16, 2011
```
R=iant, iant
CC=golang-dev
https://golang.org/cl/5393047
```
d0b9a84a
cov: fix for Plan 9 build · 293059ad
Lucio De Re authored Nov 16, 2011
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5374086
```
293059ad

net/http: fix EOF handling on response body · c9355596

Gustavo Niemeyer authored Nov 16, 2011

http.Response is currently returning 0, nil on EOF.

R=golang-dev, bradfitz, bradfitz
CC=golang-dev
https://golang.org/cl/5394047

c9355596

fcgi: fix server capability discovery · 881f2076

Brad Fitzpatrick authored Nov 16, 2011

The wrong length was being sent, and two parameters
were also transposed. Made the record type be a type
and made the constants typed, to prevent that sort
of bug in the future.

Fixes #2469

R=golang-dev, edsrzf
CC=golang-dev
https://golang.org/cl/5394046

881f2076

html/template: indirect top-level values before printing · f5db4d05

Rob Pike authored Nov 16, 2011

text/template does this (in an entirely different way), so
make html/template do the same. Before this fix, the template
{{.}} given a pointer to a string prints its address instead of its
value.

R=mikesamuel, r
CC=golang-dev
https://golang.org/cl/5370098

f5db4d05

exp/ssh: fix unmarshal test · 00f9b768

Dave Cheney authored Nov 16, 2011

Ensure that empty NameLists always return
a zero length []string, not nil.

In practice NameLists are only used in a few
message types and always consumed by a for
range function so the difference between nil
and []string{} is not significant.

Also, add exp/ssh to pkg/Makefile as suggested
by rsc.

R=rsc, agl
CC=golang-dev
https://golang.org/cl/5400042

00f9b768

html: parse <optgroup> tags · 33075970

Andrew Balholm authored Nov 16, 2011

Pass tests2.dat, test 34:
<!DOCTYPE html><select><option><optgroup>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|       <optgroup>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5393045

33075970

html: parse <caption> elements · 28546ed5

Andrew Balholm authored Nov 16, 2011

Pass tests2.dat, test 33:
<!DOCTYPE html><table><caption>test TEST</caption><td>test

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <caption>
|         "test TEST"
|       <tbody>
|         <tr>
|           <td>
|             "test"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5371099

28546ed5

exp/sql: NumInput() allow -1 to ignore checking. · 5e5c5c27

Yasuhiro Matsumoto authored Nov 16, 2011

Some database driver can't get number of parameters.
For example:
        http://support.microsoft.com/kb/240205/en-us
So, added way to ignore checking number of parameters with return -1.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5376091

5e5c5c27

15 Nov, 2011 19 commits

sql: document that for drivers, io.EOF means no more rows · 5b7827ec

Brad Fitzpatrick authored Nov 15, 2011

This was used in the sql package + tests, but never
documented.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5372107

5b7827ec

net, syscall: add missing copyright notices · 471e43cf
Mikio Hara authored Nov 15, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5375099
```
471e43cf

os: fix comment per CL 5370091 · 3a6744d8

Russ Cox authored Nov 15, 2011

Made the edit in the wrong client before submitting.

TBR=r
CC=golang-dev
https://golang.org/cl/5374091

3a6744d8

os: fix windows build · 86a6995a
Russ Cox authored Nov 15, 2011
```
TBR=brainman
CC=golang-dev
https://golang.org/cl/5373105
```
86a6995a

encoding/json: make BenchmarkSkipValue more consistent · a6106eef

Russ Cox authored Nov 15, 2011

Move scanner allocation out of loop.
It's the only allocation in the test so it dominates
when it triggers a garbage collection.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5369117

a6106eef

misc/emacs: add delete builtin · cb85e8ac
Bobby Powers authored Nov 15, 2011
```
R=golang-dev, mpimenov, gri
CC=golang-dev
https://golang.org/cl/5370101
```
cb85e8ac

testing: print test results to standard output · a3fb1aec

Russ Cox authored Nov 15, 2011

Errors in the code under test go to standard output.
Errors in testing or its usage go to standard error.

R=r
CC=golang-dev
https://golang.org/cl/5374090

a3fb1aec

misc/benchcmp: benchmark comparison script · 3db59611

Russ Cox authored Nov 15, 2011

I've been using this since April and posted it on the
mailing list, but it seems worth having in the repository.
Not sure about the location.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5371100

3db59611

syscall: make windows build again after d3963c0fca78 change · 0d37998a
Alex Brainman authored Nov 15, 2011
```
R=rsc, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5373097
```
0d37998a

allow copy of struct containing unexported fields · d03611f6

Russ Cox authored Nov 15, 2011

An experiment: allow structs to be copied even if they
contain unexported fields.  This gives packages the
ability to return opaque values in their APIs, like reflect
does for reflect.Value but without the kludgy hacks reflect
resorts to.

In general, we trust programmers not to do silly things
like *x = *y on a package's struct pointers, just as we trust
programmers not to do unicode.Letter = unicode.Digit,
but packages that want a harder guarantee can introduce
an extra level of indirection, like in the changes to os.File
in this CL or by using an interface type.

All in one CL so that it can be rolled back more easily if
we decide this is a bad idea.

Originally discussed in March 2011.
https://groups.google.com/group/golang-dev/t/3f5d30938c7c45ef

R=golang-dev, adg, dvyukov, r, bradfitz, jan.mercl, gri
CC=golang-dev
https://golang.org/cl/5372095

d03611f6

strconv: make Ftoa faster · 0ed5e6a2

Russ Cox authored Nov 15, 2011

Make code amenable to escape analysis
so that the decimal values do not escape.

benchmark old ns/op new ns/op delta
strconv_test.BenchmarkAtof64Decimal 229 233 +1.75%
strconv_test.BenchmarkAtof64Float 261 263 +0.77%
strconv_test.BenchmarkAtof64FloatExp 7760 7757 -0.04%
strconv_test.BenchmarkAtof64Big 3086 3053 -1.07%
strconv_test.BenchmarkFtoa64Decimal 6866 2629 -61.71%
strconv_test.BenchmarkFtoa64Float 7211 3064 -57.51%
strconv_test.BenchmarkFtoa64FloatExp 12587 8263 -34.35%
strconv_test.BenchmarkFtoa64Big 7058 2825 -59.97%
json.BenchmarkCodeEncoder 357355200 276528200 -22.62%
json.BenchmarkCodeMarshal 360735200 279646400 -22.48%
json.BenchmarkCodeDecoder 731528600 709460600 -3.02%
json.BenchmarkCodeUnmarshal 754774400 731051200 -3.14%
json.BenchmarkCodeUnmarshalReuse 713379000 704218000 -1.28%
json.BenchmarkSkipValue 51594300 51682600 +0.17%

benchmark old MB/s new MB/s speedup
json.BenchmarkCodeEncoder 5.43 7.02 1.29x
json.BenchmarkCodeMarshal 5.38 6.94 1.29x
json.BenchmarkCodeDecoder 2.65 2.74 1.03x
json.BenchmarkCodeUnmarshal 2.57 2.65 1.03x
json.BenchmarkCodeUnmarshalReuse 2.72 2.76 1.01x
json.BenchmarkSkipValue 38.61 38.55 1.00x

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5369111

0ed5e6a2

runtime: avoid allocation for make([]T, 0) · 94c2536e
Russ Cox authored Nov 15, 2011
```
R=gri, iant, iant
CC=golang-dev
https://golang.org/cl/5375093
```
94c2536e
strconv: add Ftoa benchmarks · 276473cd
Russ Cox authored Nov 15, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5373096
```
276473cd
encoding/json: add marshal/unmarshal benchmark · 552a556a
Russ Cox authored Nov 15, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5387041
```
552a556a

net/http: fix build · 8998673c

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5376099

8998673c

html: auto-close <p> elements when starting <form> element. · b91d8225

Andrew Balholm authored Nov 15, 2011

Pass tests2.dat, test 26:
<!doctypehtml><p><form>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <p>
|     <form>

Also pass tests through test 32:
<!DOCTYPE html><!-- X

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369114

b91d8225

xml: fix build · a619da9f

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5376098

a619da9f

go/build: fix build · 301701d8

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375097

301701d8

html: parse and render <plaintext> elements · 3bd5082f

Andrew Balholm authored Nov 15, 2011

Pass tests2.dat, test 10:
<table><plaintext><td>

| <html>
|   <head>
|   <body>
|     <plaintext>
|       "<td>"
|     <table>

Also pass tests through test 25:
<!doctypehtml><p><dd>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369109

3bd5082f

14 Nov, 2011 11 commits

math/big: replace nat{} -> nat(nil) · f5cf0a48

Robert Griesemer authored Nov 14, 2011

No need for creating a new nat each time.
Per Roger Peppe's suggestion; assuming
nat(nil) produces better code than nat{}.

R=rsc
CC=golang-dev
https://golang.org/cl/5375092

f5cf0a48

cgi: make test code more readable · 4bd15ae1
Brad Fitzpatrick authored Nov 14, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5375089
```
4bd15ae1
reflect: empty slice/map is not DeepEqual to nil · 4e65478c
Russ Cox authored Nov 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5373095
```
4e65478c

fmt: distinguish empty vs nil slice/map in %#v · a7f1e10d

Russ Cox authored Nov 14, 2011

Also update Scanf tests to cope with DeepEqual
distinguishing empty vs nil slice.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375091

a7f1e10d

encoding/json: decode [] as empty slice, not nil slice · 53523f6a

Russ Cox authored Nov 14, 2011

Test was already present, but bug in reflect.DeepEqual hid this bug.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375090

53523f6a

6l, 8l: add missing space in error message · 11fe7cd6
Lucio De Re authored Nov 14, 2011
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5374085
```
11fe7cd6

crypto/tls: fix handshake message test · 1df62ca6

Russ Cox authored Nov 14, 2011

This test breaks when I make reflect.DeepEqual
distinguish empty slices from nil slices.

R=agl
CC=golang-dev
https://golang.org/cl/5369110

1df62ca6

time: fix test hang · ba98a7ee
Dmitriy Vyukov authored Nov 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5374083
```
ba98a7ee
misc/notepadplus: error and rune support · 3811a441
Anthony Starks authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5376048
```
3811a441
misc/bbedit: error and rune support · 23f541aa
Anthony Starks authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5369057
```
23f541aa
kate: add error and rune · 39b25576
Evan Shaw authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5370078
```
39b25576