- 20 Apr, 2014 1 commit
-
-
Jan Ziak authored
Fixes #7783 LGTM=minux.ma R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/89290043
-
- 19 Apr, 2014 2 commits
-
-
David du Colombier authored
Since there is no Runemask constant in UTF-8 enum in 9atom, removing the other constants leads to an empty enum, which is illegal. Thus, we remove enum entirely. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/82660044
-
Alex Brainman authored
Fixes #6973 LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/88820043
-
- 18 Apr, 2014 7 commits
-
-
Mike Andrews authored
following on CL https://golang.org/cl/76810045 and issue 7563, i now see there's another "remove(outfile)" a few dozen lines down that also needs fixing. LGTM=iant R=golang-codereviews, iant CC=0intro, golang-codereviews, r https://golang.org/cl/89030043
-
David du Colombier authored
LGTM=aram, r R=r, aram, bradfitz CC=golang-codereviews, rsc https://golang.org/cl/89130045
-
Rob Pike authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/89370043
-
Lucio De Re authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/89270043
-
David du Colombier authored
LGTM=r R=r CC=golang-codereviews, rsc https://golang.org/cl/86180046
-
Shenghou Ma authored
changed (pwd string) to (dir string), as some think pwd means passwd. Fixes #7811. LGTM=iant R=golang-codereviews, iant, bradfitz CC=golang-codereviews https://golang.org/cl/89100043
-
Shenghou Ma authored
Fixes #7810. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/89050043
-
- 17 Apr, 2014 20 commits
-
-
Brad Fitzpatrick authored
Fixes #5357 LGTM=nigeltao R=nigeltao CC=golang-codereviews https://golang.org/cl/87910050
-
Brad Fitzpatrick authored
Patch from msolo. Just moving it to a CL. The test fails before and passes with the fix. Fixes #7098 LGTM=msolo, rsc R=rsc, iant, msolo CC=golang-codereviews https://golang.org/cl/88900044
-
Russ Cox authored
It is possible to use ./ imports on Windows but it requires some extra command-line work ('go build' does this automatically, but we can't use 'go build' here). Instead, use an ordinary import and -I/-L, which are easier to use. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/89040043
-
Ian Lance Taylor authored
LGTM=rsc, bradfitz R=golang-codereviews, rsc, bradfitz CC=golang-codereviews https://golang.org/cl/88170049
-
Volker Dobler authored
According to RFC 6265 a cookie value may contain neither commas nor spaces but such values are very common in the wild and browsers handle them very well so we'll allow both commas and spaces. Values starting or ending in a comma or a space are sent in the quoted form to prevent missinterpetations. RFC 6265 conforming values are handled as before and semicolons, backslashes and double-quotes are still disallowed. Fixes #7243 LGTM=nigeltao R=nigeltao CC=bradfitz, golang-codereviews https://golang.org/cl/86050045
-
Shenghou Ma authored
The rewrite is due to Rob. LGTM=r, bradfitz, josharian R=golang-codereviews, bradfitz, r, josharian CC=golang-codereviews https://golang.org/cl/87410043
-
Ian Lance Taylor authored
Fixes #7800. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/87790051
-
Shenghou Ma authored
Variables declared with 'var' have no sym->def. Fixes #7794. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/88360043
-
Russ Cox authored
Cgo writes C function declarations pretending every arg is a pointer. If the C function is deferred, it does not inhibit stack copying on split. The stack copying code believes the C declaration, possibly misinterpreting integers as pointers. Probably the right fix for Go 1.3 is to make deferred C functions inhibit stack copying. For Go 1.4 and beyond we probably need to make cgo generate Go code for 6g here, not C code for 6c. Update #7695 LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/83820043
-
Robert Daniel Kortschak authored
Fixes #6364. LGTM=rsc R=golang-codereviews, bradfitz, rsc, gobot CC=golang-codereviews https://golang.org/cl/13512052
-
Shenghou Ma authored
Fixes #7767. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/87420043
-
Jan Ziak authored
Fixes #7675 LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/85040044
-
Anthony Martin authored
Before the switch to liblink, the linkers accepted the -c flag to print the call graph. This change restores the functionality. This came in handy when I was trying to audit the use of SSE instructions inside the Plan 9 note handler. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/73990043
-
Russ Cox authored
https://golang.org/cl/60590044 edited doc.go without editing the file it is generated from. The edit was lost at the next mkdoc.sh. Make the change in help.go and rerun mkdoc.sh. Pointed out in the review of CL 68580043. TBR=iant CC=golang-codereviews https://golang.org/cl/88760043
-
Alex Brainman authored
Fixes #6936 LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/87770048
-
Alex Brainman authored
- output absolute addresses, not relative; - accept negative section numbers. Update #6936 Fixes #7738 LGTM=rsc R=golang-codereviews, bradfitz, ruiu, rsc CC=golang-codereviews https://golang.org/cl/85240046
-
Alex Brainman authored
This information is required by cmd/nm to calculate absolute symbol addresses. Update #6936 Update #7738 LGTM=rsc R=golang-codereviews, bradfitz, gobot, rsc CC=golang-codereviews https://golang.org/cl/87500043
-
Russ Cox authored
The new code is adapted from the Go 1.2 nosplit code, but it does not have the bug reported in issue 7623: g% go run nosplit.go g% go1.2 run nosplit.go BUG rejected incorrectly: main 0 call f; f 120 linker output: # _/tmp/go-test-nosplit021064539 main.main: nosplit stack overflow 120 guaranteed after split check in main.main 112 on entry to main.f -8 after main.f uses 120 g% Fixes #6931. Fixes #7623. LGTM=iant R=golang-codereviews, iant, ality CC=golang-codereviews, r https://golang.org/cl/88190043
-
Brad Fitzpatrick authored
Fixes #7225 LGTM=r R=golang-codereviews, r CC=golang-codereviews, rsc https://golang.org/cl/88710043
-
Rob Pike authored
Fixes #7752. LGTM=bradfitz, ruiu R=golang-codereviews, bradfitz, ruiu CC=golang-codereviews https://golang.org/cl/88690043
-
- 16 Apr, 2014 10 commits
-
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/88670043
-
Ian Lance Taylor authored
The name linkwriteobj is misleading because it implies that the function has something to do with the linker, which it does not. The name is historical: the function performs an operation that was previously performed by the linker, but no longer is. LGTM=rsc R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/88210045
-
Russ Cox authored
Without the leaf bit, the linker cannot record the correct frame size in the symbol table, and then stack traces get mangled. (Only for ARM.) Fixes #7338. Fixes #7347. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/88550043
-
Alan Donovan authored
A //line directive without a filename now denotes the empty filename, not the current directory (the Go 1.2 behaviour) nor the previous //line's filename (the behaviour since CL 86990044). They should never appear (but they do, e.g. due to a bug in godoc). Fixes #7765 LGTM=gri, rsc R=rsc, gri CC=golang-codereviews https://golang.org/cl/88160050
-
Emil Hessman authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/88000047
-
Alan Donovan authored
A //line directive without a filename now denotes the same filename as the previous line (as in C). Previously it denoted the file's directory (!). Fixes #7765 LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/86990044
-
Brad Fitzpatrick authored
Fixes #7733 LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews, nigeltao, r, rsc https://golang.org/cl/88330044
-
Brad Fitzpatrick authored
Fixes #7264 LGTM=dvyukov R=dvyukov CC=golang-codereviews https://golang.org/cl/87970045
-
Russ Cox authored
In large functions with many variables, the register optimizer may give up and choose not to track certain variables at all. In this case, the "nextinnode" information linking together all the words from a given variable will be incomplete, and the result may be that only some of a multiword value is preserved across a call. That confuses the garbage collector, so don't do that. Instead, mark those variables as having their address taken, so that they will be preserved at all calls. It's overkill, but correct. Tested by hand using the 6g -S output to see that it does fix the buggy generated code leading to the issue 7726 failure. There is no automated test because I managed to break the compiler while writing a test (see issue 7727). I will check in a test along with the fix to issue 7727. Fixes #7726. LGTM=khr R=khr, bradfitz, dave CC=golang-codereviews https://golang.org/cl/85200043
-
Rob Pike authored
Update #7056 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/88070045
-