Commits · 94439492077c16876c1243221923f51cb237627c · go / golang

05 Jan, 2012 10 commits

doc: add Slices: usage and internals article · 94439492

Andrew Gerrand authored Jan 05, 2012

Originally published on the Go blog on 5 Jan 2011:
http://blog.golang.org/2011/01/go-slices-usage-and-internals.html

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516046

94439492

goinstall: use correct checkout URL for Google Code svn repos · c2ea4122
Andrew Gerrand authored Jan 05, 2012
```
Fixes #2655.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5510045
```
c2ea4122

doc: trim spaces from code snippets · 5353e1ef

Andrew Gerrand authored Jan 05, 2012

gofmt likes to put lines like
  // STOP OMIT
two blank lines from a closing brace, creating an ugly space inside
<pre> blocks in some of these files. This change resolves this issue.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5520044

5353e1ef

go test: don't try to print package with error message. · 5f5a7eb4

Roger Peppe authored Jan 05, 2012

If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045

5f5a7eb4

math: fix typo in all_test.go · 149d3f06

Charles L. Dorian authored Jan 05, 2012

Logb errors were reported as Ilogb errors.

R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5517045

149d3f06

net: fix incorrect mode on ListenIP, ListenUDP · bab56ecb
Mikio Hara authored Jan 05, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5523044
```
bab56ecb

crypto/tls: Improve TLS Client Authentication · c581ec49

Jeff R. Allen authored Jan 05, 2012

Fix incorrect marshal/unmarshal of certificateRequest.
Add support for configuring client-auth on the server side.
Fix the certificate selection in the client side.
Update generate_cert.go to new time package

Fixes #2521.

R=krautz, agl, bradfitz
CC=golang-dev, mikkel
https://golang.org/cl/5448093

c581ec49

doc/progs: test defer programs · 8f1cb093
Andrew Gerrand authored Jan 05, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5517044
```
8f1cb093
net: update DialIP comments to mention protocols · 2469a817
Andrew Gerrand authored Jan 05, 2012
```
Fixes #2637.

R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5508043
```
2469a817
make.bash: remove old dregs · b682da32
Alex Brainman authored Jan 05, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5522043
```
b682da32

04 Jan, 2012 7 commits

cmd/go: include external test files in the files sent to gofmt, govet, and gofix · 2693232f
Sanjay Menakuru authored Jan 04, 2012
```
Also, add XTestGoFiles to the go command's public api.

Fixes #2649.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502102
```
2693232f
runtime: fix typo in comment · 3f1eb94e
Robert Griesemer authored Jan 04, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5511047
```
3f1eb94e
crypto/tls: update generate_cert.go for new time package · d5e6b8d0
Adam Langley authored Jan 04, 2012
```
Fixes #2635.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5512043
```
d5e6b8d0

exp/ssh: fix two flow control bugs in chanWriter · 424f53fa

Dave Cheney authored Jan 04, 2012

This CL fixes two issues sending data to the remote peer.
The first bug occurs when the size of the buffer passed to
Write is larger than the current window, in this case, w.rwin
can become negative.

The second issue is more problematic than the first as the
amount of data passed to writePacket was not limited to w.rwin.
In this case the remote peer could silently drop the additional
data, or drop the connection.

Credit to Jacek Masiulaniec for the bug report.

R=agl, jacek.masiulaniec
CC=golang-dev
https://golang.org/cl/5511043

424f53fa

unsafe: refer to correct reflect functions · 9d92676f
Andrew Gerrand authored Jan 04, 2012
```
Fixes #2641.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5509043
```
9d92676f
doc: Fix URL to the Xcode web page · dfedd34d
Paul Borman authored Jan 04, 2012
```
R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/5504113
```
dfedd34d

dashboard: increase notification log to 200 lines · 126ee245

Andrew Gerrand authored Jan 04, 2012

The go command lists all packages that were built.
A recent breakage notification included this text:

$ tail -100 < log
ok      errors
ok      exp/ebnf
?       exp/ebnflint [no test files]
ok      exp/gotype
ok      exp/norm
ok      exp/spdy

If the breakage occurred before this point it would
not be visible in the output.

R=golang-dev, gri, kevlar
CC=golang-dev
https://golang.org/cl/5504109

126ee245

03 Jan, 2012 9 commits

html: parse <frameset> inside body · 99fed2be

Andrew Balholm authored Jan 03, 2012

Pass tests6.dat, test 47:
<param><frameset></frameset>

| <html>
|   <head>
|   <frameset>

Also pass remaining tests in tests6.dat.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5489136

99fed2be

cmd/go: include test files in the files sent to gofmt, govet, and gofix · 7ccd505d
Sanjay Menakuru authored Jan 03, 2012
```
Also, add TestGoFiles to the go command's public api.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5505083
```
7ccd505d
A+C: add Sanjay Menakuru · 12d48472
Andrew Gerrand authored Jan 03, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5504110
```
12d48472
encoding/json: don't marshal special float values · c20c0925
Evan Shaw authored Jan 03, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5500084
```
c20c0925
encoding/xml: use strings.Reader in tests. · 38ff98b4
Michael Shields authored Jan 03, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502083
```
38ff98b4

doc/codewalk/functions.xml: Fix broken function examples · c2b87ce0

John DeNero authored Jan 03, 2012

I removed the broken function comparison example and fixed a code highlighting regexp.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501078

c2b87ce0

cmd/go: refer to the right command in the doc description. · a274798d
Christoph Hack authored Jan 03, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501072
```
a274798d

gotest: make _testmain.go conform to gofmt rules · 8e9e75f0

Benny Siegert authored Jan 03, 2012

Otherwise, running "gofmt -d ." after "gotest" gives some
spurious changes.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504101

8e9e75f0

doc/articles: add {{donotedit}} to templates · e4d624b0
Olivier Duperray authored Jan 03, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502088
```
e4d624b0

27 Dec, 2011 2 commits

exp/ssh: various small fixes · 7f20bcbb

Dave Cheney authored Dec 27, 2011

transport.go:
* remove unused nil check.

doc.go:
* improve documentation about supported auth
methods and update Run example.

Thanks Jacek Masiulaniec for both reports.

R=jacek.masiulaniec, agl
CC=golang-dev
https://golang.org/cl/5501075

7f20bcbb

bytes.Buffer: read of 0 bytes at EOF shouldn't be an EOF · 6a88f1c4

Rob Pike authored Dec 27, 2011

This corner case arose doing an RPC with a empty-slice payload. Ouch.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5505073

6a88f1c4

26 Dec, 2011 2 commits

misc/windows: add src/pkg/runtime/z* files to installation script · 83d54024
Alex Brainman authored Dec 26, 2011
```
Fixes #2614.

R=golang-dev, jdpoirier
CC=golang-dev
https://golang.org/cl/5505070
```
83d54024

log/syslog: add Alert method · f71c03af

Vadim Vygonets authored Dec 26, 2011

Alert logs a message using the LOG_ALERT priority.

Fixes #2325.

R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/5504058

f71c03af

25 Dec, 2011 3 commits

flag: change Set method Value interface to return error instead of bool. · 98b90475

David Symonds authored Dec 25, 2011

This yields much better error messages when a bad flag value is given.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5498078

98b90475

testing: use flag.Duration for -timeout flag. · 57c9bb4a
David Symonds authored Dec 25, 2011
```
R=golang-dev, gustavo, r
CC=golang-dev
https://golang.org/cl/5498077
```
57c9bb4a

html: adjust foreign attributes. · d5e45e3a

Nigel Tao authored Dec 25, 2011

Pass tests10.dat, test 22:
<!DOCTYPE html><body xlink:href=foo><svg xlink:href=foo></svg>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     xlink:href="foo"
|     <svg svg>
|       xlink href="foo"

Also pass tests through test 29:
<div><svg><path></svg><path>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5489117

d5e45e3a

24 Dec, 2011 1 commit

html: "in select in table" insertion mode. · b28f0175

Andrew Balholm authored Dec 24, 2011

Pass tests10.dat, test 16:
<!DOCTYPE
html><body><table><tr><td><select><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <tbody>
|         <tr>
|           <td>
|             <select>
|               "foobarbaz"
|     <p>
|       "quux"

Also pass tests through test 21:
<!DOCTYPE html><frameset></frameset><svg><g></g><g></g><p><span>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5505069

b28f0175

23 Dec, 2011 6 commits

exp/norm: fixed two unrelated bugs in normalization library. · cadbd3ea

Marcel van Lohuizen authored Dec 23, 2011

1) incorrect length given for out buffer in String.
2) patchTail bug that could cause characters to be lost
   when crossing into the out-buffer boundary.

Added tests to expose these bugs.  Also slightly improved
performance of Bytes() and String() by sharing the reorderBuffer
across operations.

Fixes #2567.

R=r
CC=golang-dev
https://golang.org/cl/5502069

cadbd3ea

net/rpc: trivial test cleanup · 335c5db7
Robert Hencke authored Dec 23, 2011
```
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498066
```
335c5db7

flag: add Duration flag type. · cf506f6e

David Symonds authored Dec 23, 2011

This works in the expected way: flag.Duration returns a *time.Duration,
and uses time.ParseDuration for parsing the input.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5489113

cf506f6e

time: add ParseDuration. · f298d0ce
David Symonds authored Dec 23, 2011
```
R=rsc, r, r
CC=golang-dev
https://golang.org/cl/5489111
```
f298d0ce
dashboard: fix todo caching nil · e6a322b0
Andrew Gerrand authored Dec 23, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504082
```
e6a322b0
dashboard: cache packages, introduce caching helpers · 5a65cbac
Andrew Gerrand authored Dec 23, 2011
```
R=rsc, gary.burd, adg
CC=golang-dev
https://golang.org/cl/5498067
```
5a65cbac