Commits · 95b40f6ca16d0fefc0996060fd91acdd34aba317 · go / golang

02 Nov, 2010 5 commits

Fix a deadlock bug in the rpc client. The panic will trigger · 95b40f6c

Kai Backman authored Nov 02, 2010

regularly when client connections are flaky (probably another
issue).

(credits to jussi@tinkercad.com for finding the issue)

R=rsc, r
CC=golang-dev, jussi
https://golang.org/cl/2831042

95b40f6c

netchan: fix locking bug. · 59315fbf

Rob Pike authored Nov 02, 2010

There's no need to hold the client mutex when calling encode, since encode itself
uses a mutex to make the writes atomic.  However, we need to keep
the messages ordered, so add a mutex for that purpose alone.
Fixes #1244.

R=rsc
CC=golang-dev
https://golang.org/cl/2833041

59315fbf

go/scanner: removed scanner/internal-only uses of token.Position · 396228a6

Robert Griesemer authored Nov 02, 2010

First step towards a more light-weight implementation of token.Position:
- only use token.Position for reporting token and error position
- use offsets only for scanner control
- no interface changes yet

R=rsc
CC=golang-dev
https://golang.org/cl/2825041

396228a6

Effective Go: append and a few words about ... · 0808b199
Rob Pike authored Nov 02, 2010
```
R=rsc, gri, iant
CC=golang-dev
https://golang.org/cl/2821041
```
0808b199
test/ken/convert.go: add conversion torture test · c3328923
Rob Pike authored Nov 02, 2010
```
(written by ken)

R=ken2
CC=golang-dev
https://golang.org/cl/2823042
```
c3328923

01 Nov, 2010 18 commits
- 8l: pe generation fixes · 8f8f625c
  Alex Brainman authored Nov 01, 2010
```
Restore ability to have different file and
section alignment in generated pe file.

Stop generating .bss pe section, it is
part of .data now.

Some code refactoring.

R=rsc, vcc
CC=golang-dev
https://golang.org/cl/2731041
```
  8f8f625c
- fix build · ce980445
  Robert Griesemer authored Nov 01, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2820041
```
  ce980445
- Use strings.Contains in src/cmd/... · b0afb931
  Brad Fitzpatrick authored Nov 01, 2010
```
R=r
CC=golang-dev, r2, rsc
https://golang.org/cl/2819041
```
  b0afb931
- go/printer: do not remove parens around composite literals starting with a type… · 7996924c
  Robert Griesemer authored Nov 01, 2010
```
go/printer: do not remove parens around composite literals starting with a type name in control clauses
(even when they are nested inside an expression).

Fixes #1243.

R=rsc
CC=golang-dev
https://golang.org/cl/2817041
```
  7996924c
- go/ast: add Inspect function for easy AST inspection w/o a visitor · 9384fdc9
  Robert Griesemer authored Nov 01, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2770044
```
  9384fdc9
- debug/pe, cgo: add windows support · 035696c5
  Wei Guangjing authored Nov 01, 2010
```
R=rsc, mattn
CC=golang-dev
https://golang.org/cl/1976045
```
  035696c5
- strings: Contains · e198a508
  Brad Fitzpatrick authored Nov 01, 2010
```
Tiny helper to avoid strings.Index(s, sub) != -1

R=rsc, r2, r
CC=golang-dev
https://golang.org/cl/2265044
```
  e198a508
- gotest: if the benchmark list is empty, print it in a way that · e8436689
  Rob Pike authored Nov 01, 2010
```
gofmt will leave alone.

R=rsc, bradfitz, bradfitzpatrick
CC=golang-dev
https://golang.org/cl/2816041
```
  e8436689
- syscall: SIO constants for Linux · 6442f38a
  Albert Strasheim authored Nov 01, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2303043
```
  6442f38a
- codereview: fix 'hg sync' and 'hg download' in Python 2.7 · 0e816f59
  Fazlul Shahriar authored Nov 01, 2010
```
Fixes #1218.

R=rsc
CC=golang-dev
https://golang.org/cl/2664041
```
  0e816f59
- testing: add Benchmark to allow benchmarks to be run without gotest. · 270bad39
  Roger Peppe authored Nov 01, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2506042
```
  270bad39
- http server: don't send trailing '0' for chunked encoding when responding with 304 NotModified · 7b4eed7d
  Michael Hoisie authored Nov 01, 2010
```
R=rsc, adg
CC=golang-dev
https://golang.org/cl/2723041
```
  7b4eed7d
- build: fiddle with make variables · 276003ad
  Russ Cox authored Nov 01, 2010
```
Fixes #1234.

R=r, r2
CC=golang-dev
https://golang.org/cl/2735043
```
  276003ad
- libutf: update to Unicode 5.2.0 to match pkg/unicode · 51b15d68
  Anthony Martin authored Nov 01, 2010
```
R=rsc, r, PeterGo, r2
CC=golang-dev
https://golang.org/cl/2753045
```
  51b15d68
- 6a/6l: fix MOVOU encoding · 884dceca
  Evan Shaw authored Nov 01, 2010
```
The andproto field was set incorrectly, causing 6a to encode illegal
instructions.

R=rsc
CC=golang-dev
https://golang.org/cl/2781042
```
  884dceca
- go/scanner: don't accept '\x0g' character escape (bug fix) · 68ac0c1d
  Robert Griesemer authored Nov 01, 2010
```
Added more test cases.

R=rsc
CC=golang-dev
https://golang.org/cl/2804041
```
  68ac0c1d
- gob: documentation. this time for sure. · 6dc4c58f
  Rob Pike authored Nov 01, 2010
```
if the interface value is nil, it sends no value,

R=rsc, adg
CC=golang-dev
https://golang.org/cl/2801042
```
  6dc4c58f
- mkrunetype: install a Makefile and tweak it slightly so it can be built. · fbfb1d9e
  Rob Pike authored Nov 01, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2813041
```
  fbfb1d9e
31 Oct, 2010 4 commits

gob: update documentation about wire format for interfaces. · 41ac2f8a
Rob Pike authored Oct 31, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2814041
```
41ac2f8a

gob: several fixes. · 7f7cb166

Rob Pike authored Oct 31, 2010

1) Be sure to use the eval-time encoder/decoder rather than
the compile-time decoder.  In a few cases the receiver for
the compiling encoder was being pickled incorrectly into a
closure.
(This is the fix for issue 1238).

2) Get the innermost name right when given a pointer to an
unnamed type.

3) Use a count to delineate interface values, making it
possible to ignore values without having a concrete type
to encode into.  This is a protocol change but only for the
new feature, so it shouldn't affect anyone.  The old test
worked because, amazingly, it depended on bug #1.

Fixes #1238.

R=rsc, albert.strasheim
CC=golang-dev
https://golang.org/cl/2806041

7f7cb166

kate: update for append · f62772b1

Evan Shaw authored Oct 31, 2010

R=golang-dev, PeterGo, gri
CC=golang-dev
https://golang.org/cl/2710044

f62772b1

pidigits: Remove TODO, minor improvements · 5bf420f0

Evan Shaw authored Oct 31, 2010

I tried adding a Scale method to big.Int and it didn't make any noticeable
difference, so I'm removing my TODO.

Also got rid of a few obvious allocations that I missed earlier for a modest
improvement (~5%).

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/2711043

5bf420f0

30 Oct, 2010 4 commits
- syscall: fix windows build · a8c4da99
  Alex Brainman authored Oct 30, 2010
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/2713043
```
  a8c4da99
- syscall: fix Stat(path) where path is directory with trailing '/' on windows · 7812b796
  Alex Brainman authored Oct 30, 2010
```
Fixes #1220.

R=rsc, r
CC=golang-dev
https://golang.org/cl/2728043
```
  7812b796
- misc/bbedit: support append, other builtins · edaeb88b
  Anthony Starks authored Oct 30, 2010
```
R=golang-dev, PeterGo, adg
CC=golang-dev
https://golang.org/cl/2791042
```
  edaeb88b
- misc/vim: update list of builtins. · 0451cd19
  David Symonds authored Oct 30, 2010
```
R=adg
CC=golang-dev
https://golang.org/cl/2807041
```
  0451cd19
29 Oct, 2010 7 commits
- gob: clarify the comments about installing the debug/dumper. · c490bb6f
  Rob Pike authored Oct 29, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2789043
```
  c490bb6f
- gob: make the debugging (dumping) code work again. Mostly rewrite it, in fact. · 96b9efe8
  Rob Pike authored Oct 29, 2010
```
It's still not compiled in by default.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/2754043
```
  96b9efe8
- go/scanner: added another test case, clarified some code · 907e998c
  Robert Griesemer authored Oct 29, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2741042
```
  907e998c
- go spec: append is now implemented · 11684680
  Robert Griesemer authored Oct 29, 2010
```
R=r, r2
CC=golang-dev
https://golang.org/cl/2717043
```
  11684680
- ebnf: use append · 7eb5c9a5
  Robert Griesemer authored Oct 29, 2010
```
R=r, rsc
CC=golang-dev
https://golang.org/cl/2799041
```
  7eb5c9a5
- tabwriter: use append · 75855a8f
  Robert Griesemer authored Oct 29, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2798041
```
  75855a8f
- go/doc: use append · 5762cd37
  Robert Griesemer authored Oct 29, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2792041
```
  5762cd37
28 Oct, 2010 2 commits

testing: eliminate testing/regexp · 4e9cc085

Rob Pike authored Oct 28, 2010

Rather than updating the stripped-down regexp implementation embedded
in testing, delete it by passing the one function we need from the package
main file created by gotest.

R=rsc
CC=golang-dev
https://golang.org/cl/2761043

4e9cc085

regexp: eliminate vector in favor of append. · 1f4d54ea
Rob Pike authored Oct 28, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2795041
```
1f4d54ea