Commits · 99f67228608db9c9a587586186ec612feb425e48 · go / golang

21 May, 2013 11 commits

bufio: reuse Writer buffers after Flush · 99f67228

Brad Fitzpatrick authored May 21, 2013

A bufio.Writer.Flush marks the usual end of a Writer's
life. Recycle its internal buffer on those explicit flushes,
but not on normal, as-needed internal flushes.

benchmark               old ns/op    new ns/op    delta
BenchmarkWriterEmpty         1959          727  -62.89%

benchmark              old allocs   new allocs    delta
BenchmarkWriterEmpty            2            1  -50.00%

benchmark               old bytes    new bytes    delta
BenchmarkWriterEmpty         4215           83  -98.03%

R=gri, iant
CC=gobot, golang-dev, voidlogic7
https://golang.org/cl/9459044

99f67228

net/http: don't send Accept-Encoding on HEAD requests · ddda7980

Brad Fitzpatrick authored May 21, 2013

Works around a bug in nginx: http://trac.nginx.org/nginx/ticket/358

Fixes #5522

R=iant
CC=gobot, golang-dev
https://golang.org/cl/9627043

ddda7980

database/sql: remove extra RemoveDep call · 0e101969

Brad Fitzpatrick authored May 21, 2013

This should have been removed in 45c12efb4635. Not a correctness
issue, but unnecessary work.

This CL also adds paranoia checks in removeDep so this doesn't
happen again.

Fixes #5502

R=adg
CC=gobot, golang-dev, google
https://golang.org/cl/9543043

0e101969

time: remove Time.FormatAppend · 509a1173

Brad Fitzpatrick authored May 21, 2013

undo CL 8478044 / 0d28fd55e721

Lack of consensus.

««« original CL description
time: add Time.FormatAppend

This is a version of Time.Format that doesn't require allocation.

Fixes #5192
Update #5195

R=r
CC=gobot, golang-dev
https://golang.org/cl/8478044
»»»

R=r
CC=golang-dev
https://golang.org/cl/9462049

509a1173

cmd/gc: fix confusing error with broken types and defer/go · 6f5af9c0
Daniel Morsing authored May 21, 2013
```
Fixes #5172.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/9614044
```
6f5af9c0
cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin · bea7b518
Shenghou Ma authored May 21, 2013
```
Fixes #5479.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/9416047
```
bea7b518
api: update next.txt · c3294049
Brad Fitzpatrick authored May 21, 2013
```
R=minux.ma
CC=golang-dev
https://golang.org/cl/9459047
```
c3294049
codereview: add khr as a person · 09395daf
Brad Fitzpatrick authored May 21, 2013
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/9459046
```
09395daf

crypto/tls: don't send NPN extension if NextProtos is not set. · 8590e1bd

Adam Langley authored May 21, 2013

This isn't clearly a bug on Go's part, but it triggers a bug in Firefox
which means that crypto/tls and net/http cannot be wired up together
unless NextProtos includes "http/1.1". When net/http sets up the
tls.Config, it does this and so works fine. But anyone setting up the
tls.Config themselves will hit the Firefox bug.

Fixes #5445.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/9539045

8590e1bd

cmd/api: add more platforms · f5d06da0

Shenghou Ma authored May 21, 2013

as OpenBSD lacks 4 errno constants, api/go1.txt is updated so that
api check won't fail.

R=golang-dev, iant, bradfitz, r
CC=golang-dev
https://golang.org/cl/9149045

f5d06da0

net/http: use WriteString directly when possible · c6c439d7

Brad Fitzpatrick authored May 21, 2013

Several places used io.WriteString unnecessarily when the
static type already implemented WriteString. No need to
check for it at runtime.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9608043

c6c439d7

20 May, 2013 14 commits

cmd/gc: clear n->list of OFOR range loop after walk. · fc3bec38

Rémy Oudompheng authored May 20, 2013

It contains the LHS of the range clause and gets
instrumented by racewalk, but it doesn't have any meaning.

Fixes #5446.

R=golang-dev, dvyukov, daniel.morsing, r
CC=golang-dev
https://golang.org/cl/9560044

fc3bec38

cmd/gc: eliminate a useless bounds check in inlined append(). · 4b0eb19a
Rémy Oudompheng authored May 20, 2013
```
R=golang-dev, daniel.morsing, r
CC=golang-dev
https://golang.org/cl/9358043
```
4b0eb19a

spec: removed old or invalid TODOs · 6a3859f4

Robert Griesemer authored May 20, 2013

Several old TODOs are either resolved now (e.g. when is a return
needed), or are from a time the language wasn't frozen (^ for uints
only). Consolidated the others.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9599044

6a3859f4

spec: fix language about "range" clause · bb3a32ef
Robert Griesemer authored May 20, 2013
```
Fixes #5434.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9595044
```
bb3a32ef
misc/dashboard/builder: handle Plan 9 in defaultSuffix() · 523b3bc4
Shenghou Ma authored May 20, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9495045
```
523b3bc4

crypto/x509: provide better error messages for X.509 verify failures. · b419e2b5

Adam Langley authored May 20, 2013

Failures caused by errors like invalid signatures or missing hash
functions cause rather generic, unhelpful error messages because no
trust chain can be constructed: "x509: certificate signed by unknown
authority."

With this change, authority errors may contain the reason why an
arbitary candidate step in the chain was rejected. For example, in the
event of a missing hash function the error looks like:

x509: certificate signed by unknown authority (possibly because of
"crypto/x509: cannot verify signature: algorithm unimplemented" while
trying to verify candidate authority certificate 'Thawte SGC CA')

Fixes 5058.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9104051

b419e2b5

test: do not run the test that relies on precise GC on 32-bits · 910bd157

Dmitriy Vyukov authored May 20, 2013

Currently most of the 32-bit builder are broken.
Fixes #5516.

R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/9573043

910bd157

net/http: simplify transfer body; reduces allocations too · 27f74279

Brad Fitzpatrick authored May 20, 2013

benchmark old ns/op new ns/op delta
BenchmarkServerFakeConnNoKeepAlive 14431 14247 -1.28%
BenchmarkServerFakeConnWithKeepAlive 11618 11357 -2.25%
BenchmarkServerFakeConnWithKeepAliveLite 6735 6427 -4.57%
BenchmarkServerHandlerTypeLen 8842 8740 -1.15%
BenchmarkServerHandlerNoLen 8001 7828 -2.16%
BenchmarkServerHandlerNoType 8270 8227 -0.52%
BenchmarkServerHandlerNoHeader 6148 5920 -3.71%

benchmark old allocs new allocs delta
BenchmarkServerFakeConnNoKeepAlive 30 29 -3.33%
BenchmarkServerFakeConnWithKeepAlive 25 24 -4.00%
BenchmarkServerFakeConnWithKeepAliveLite 10 9 -10.00%
BenchmarkServerHandlerTypeLen 18 17 -5.56%
BenchmarkServerHandlerNoLen 15 14 -6.67%
BenchmarkServerHandlerNoType 16 15 -6.25%
BenchmarkServerHandlerNoHeader 10 9 -10.00%

benchmark old bytes new bytes delta
BenchmarkServerFakeConnNoKeepAlive 2557 2492 -2.54%
BenchmarkServerFakeConnWithKeepAlive 2260 2194 -2.92%
BenchmarkServerFakeConnWithKeepAliveLite 1092 1026 -6.04%
BenchmarkServerHandlerTypeLen 1941 1875 -3.40%
BenchmarkServerHandlerNoLen 1898 1832 -3.48%
BenchmarkServerHandlerNoType 1906 1840 -3.46%
BenchmarkServerHandlerNoHeader 1092 1026 -6.04%

Update #5195

R=golang-dev, daniel.morsing
CC=golang-dev
https://golang.org/cl/9492044

27f74279

syscall: prefer PATH environment variable in bootstrap scripts · b98a4d1a
Mikio Hara authored May 20, 2013
```
R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/9575043
```
b98a4d1a
runtime: integrated network poller for freebsd/amd64,386, openbsd/amd64,386 · c5732c85
Mikio Hara authored May 20, 2013
```
Update #5199

R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/8825043
```
c5732c85
net: move system common global variables into fd_unix.go · 1a948950
Alex Brainman authored May 20, 2013
```
R=golang-dev, bradfitz
CC=dvyukov, golang-dev, mikioh.mikioh
https://golang.org/cl/9495044
```
1a948950
runtime: zeroize g->fnstart to not prevent GC of the closure · 13081942
Dmitriy Vyukov authored May 20, 2013
```
Fixes #5493.

R=golang-dev, minux.ma, iant
CC=golang-dev
https://golang.org/cl/9557043
```
13081942

net/http: fewer allocations in the server path · d4cbc80d

Brad Fitzpatrick authored May 20, 2013

Don't allocate for the Date or Content-Length headers.
A custom Date header formatter replaces use of time.Format.

benchmark old ns/op new ns/op delta
BenchmarkClientServer 67791 64424 -4.97%
BenchmarkClientServerParallel4 62956 58533 -7.03%
BenchmarkClientServerParallel64 62043 54789 -11.69%
BenchmarkServer 254609 229060 -10.03%
BenchmarkServerFakeConnNoKeepAlive 17038 16316 -4.24%
BenchmarkServerFakeConnWithKeepAlive 14184 13226 -6.75%
BenchmarkServerFakeConnWithKeepAliveLite 8591 7532 -12.33%
BenchmarkServerHandlerTypeLen 10750 9961 -7.34%
BenchmarkServerHandlerNoLen 9535 8935 -6.29%
BenchmarkServerHandlerNoType 9858 9362 -5.03%
BenchmarkServerHandlerNoHeader 7754 6856 -11.58%

benchmark old allocs new allocs delta
BenchmarkClientServer 68 66 -2.94%
BenchmarkClientServerParallel4 68 66 -2.94%
BenchmarkClientServerParallel64 68 66 -2.94%
BenchmarkServer 21 19 -9.52%
BenchmarkServerFakeConnNoKeepAlive 32 30 -6.25%
BenchmarkServerFakeConnWithKeepAlive 27 25 -7.41%
BenchmarkServerFakeConnWithKeepAliveLite 12 10 -16.67%
BenchmarkServerHandlerTypeLen 19 18 -5.26%
BenchmarkServerHandlerNoLen 17 15 -11.76%
BenchmarkServerHandlerNoType 17 16 -5.88%
BenchmarkServerHandlerNoHeader 12 10 -16.67%

Update #5195

R=nigeltao
CC=golang-dev
https://golang.org/cl/9432046

d4cbc80d

runtime: change PollDesc.fd from int32 to uintptr · 38abb09a

Alex Brainman authored May 20, 2013

This is in preparation for netpoll windows version.

R=golang-dev, bradfitz
CC=dvyukov, golang-dev, mikioh.mikioh
https://golang.org/cl/9569043

38abb09a

19 May, 2013 2 commits
- runtime: properly set G status after syscall · fee1d1cd
  Dmitriy Vyukov authored May 19, 2013
```
R=golang-dev, r, dave
CC=golang-dev
https://golang.org/cl/9307045
```
  fee1d1cd
- misc/dashboard: add go.tools to list of subrepos · c3dbe5d2
  Dave Cheney authored May 19, 2013
```
R=r, adg, dsymonds
CC=golang-dev
https://golang.org/cl/9535044
```
  c3dbe5d2
18 May, 2013 5 commits

runtime, cmd/gc: clean up function protoypes · 2dc751ac
Anthony Martin authored May 18, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8652043
```
2dc751ac

runtime: mark usleep as NOSPLIT on Plan 9 · 8b85a3d4

Anthony Martin authored May 18, 2013

Usleep is called from lockextra, also marked NOSPLIT.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9258043

8b85a3d4

runtime: fix newproc debugging print · b65271d0
Anthony Martin authored May 18, 2013
```
R=golang-dev, remyoudompheng, r
CC=golang-dev
https://golang.org/cl/9249044
```
b65271d0

compress/flate: faster version of forwardCopy · 28882bbd

Keith Randall authored May 18, 2013

benchmark old ns/op new ns/op delta
BenchmarkDecodeDigitsSpeed1e4 197767 203490 +2.89%
BenchmarkDecodeDigitsSpeed1e5 1873969 1912761 +2.07%
BenchmarkDecodeDigitsSpeed1e6 18922760 19021056 +0.52%
BenchmarkDecodeDigitsDefault1e4 194975 197054 +1.07%
BenchmarkDecodeDigitsDefault1e5 1704262 1719988 +0.92%
BenchmarkDecodeDigitsDefault1e6 16618354 16351957 -1.60%
BenchmarkDecodeDigitsCompress1e4 195281 194626 -0.34%
BenchmarkDecodeDigitsCompress1e5 1694364 1702372 +0.47%
BenchmarkDecodeDigitsCompress1e6 16463347 16492126 +0.17%
BenchmarkDecodeTwainSpeed1e4 200653 200127 -0.26%
BenchmarkDecodeTwainSpeed1e5 1861385 1759632 -5.47%
BenchmarkDecodeTwainSpeed1e6 18255769 17186679 -5.86%
BenchmarkDecodeTwainDefault1e4 189080 185157 -2.07%
BenchmarkDecodeTwainDefault1e5 1559222 1461465 -6.27%
BenchmarkDecodeTwainDefault1e6 14792125 13879051 -6.17%
BenchmarkDecodeTwainCompress1e4 188881 185151 -1.97%
BenchmarkDecodeTwainCompress1e5 1537031 1456945 -5.21%
BenchmarkDecodeTwainCompress1e6 14805972 13405094 -9.46%
BenchmarkPaeth 4 4 -0.89%
BenchmarkDecodeGray 964679 937244 -2.84%
BenchmarkDecodeNRGBAGradient 3753769 3646416 -2.86%
BenchmarkDecodeNRGBAOpaque 3165856 2981300 -5.83%
BenchmarkDecodePaletted 713950 691984 -3.08%
BenchmarkDecodeRGB 3051718 2924260 -4.18%

R=nigeltao, bradfitz
CC=golang-dev, raph
https://golang.org/cl/9425046

28882bbd

cmd/go: Update documentation of go run to match current behaviour. · 70f3b609
Dominik Honnef authored May 18, 2013
```
Fixes #5511.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/9530043
```
70f3b609

17 May, 2013 8 commits

bufio: make Reader buffer transient · b25a53ac

Brad Fitzpatrick authored May 17, 2013

Share garbage between different bufio Readers. When a Reader
has zero buffered data, put its buffer into a pool.

This acknowledges that most bufio.Readers eventually get
read to completion, and their buffers are then no longer
needed.

benchmark               old ns/op    new ns/op    delta
BenchmarkReaderEmpty         2993         1058  -64.65%

benchmark              old allocs   new allocs    delta
BenchmarkReaderEmpty            3            2  -33.33%

benchmark               old bytes    new bytes    delta
BenchmarkReaderEmpty         4278          133  -96.89%

Update #5100

R=r
CC=adg, dvyukov, gobot, golang-dev, rogpeppe
https://golang.org/cl/8819049

b25a53ac

cmd/vet: delete; it now lives in the go.tools subrepo · 249842c8
Rob Pike authored May 17, 2013
```
R=golang-dev, dsymonds, rsc, iant, dave
CC=golang-dev
https://golang.org/cl/9496043
```
249842c8

runtime: faster x86 memmove (a.k.a. built-in copy()) · 60214492

Keith Randall authored May 17, 2013

REP instructions have a high startup cost, so we handle small
sizes with some straightline code.  The REP MOVSx instructions
are really fast for large sizes.  The cutover is approximately
1K.  We implement up to 128/256 because that is the maximum
SSE register load (loading all data into registers before any
stores lets us ignore copy direction).

(on a Sandy Bridge E5-1650 @ 3.20GHz)
benchmark               old ns/op    new ns/op    delta
BenchmarkMemmove0               3            3   +0.86%
BenchmarkMemmove1               5            5   +5.40%
BenchmarkMemmove2              18            8  -56.84%
BenchmarkMemmove3              18            7  -58.45%
BenchmarkMemmove4              36            7  -78.63%
BenchmarkMemmove5              36            8  -77.91%
BenchmarkMemmove6              36            8  -77.76%
BenchmarkMemmove7              36            8  -77.82%
BenchmarkMemmove8              18            8  -56.33%
BenchmarkMemmove9              18            7  -58.34%
BenchmarkMemmove10             18            7  -58.34%
BenchmarkMemmove11             18            7  -58.45%
BenchmarkMemmove12             36            7  -78.51%
BenchmarkMemmove13             36            7  -78.48%
BenchmarkMemmove14             36            7  -78.56%
BenchmarkMemmove15             36            7  -78.56%
BenchmarkMemmove16             18            7  -58.24%
BenchmarkMemmove32             18            8  -54.33%
BenchmarkMemmove64             18            8  -53.37%
BenchmarkMemmove128            20            9  -55.93%
BenchmarkMemmove256            25           11  -55.16%
BenchmarkMemmove512            33           33   -1.19%
BenchmarkMemmove1024           43           44   +2.06%
BenchmarkMemmove2048           61           61   +0.16%
BenchmarkMemmove4096           95           95   +0.00%

R=golang-dev, bradfitz, remyoudompheng, khr, iant, dominik.honnef
CC=golang-dev
https://golang.org/cl/9038048

60214492

misc/cgo/test: deflake TestParallelSleep once more · af1dd56d
Shenghou Ma authored May 17, 2013
```
Fixes #5480.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/9475043
```
af1dd56d
cmd/ld: emit .tbss section when doing dynamic internal linking · a8484753
Shenghou Ma authored May 17, 2013
```
Fixes #5200.

R=iant, dave
CC=golang-dev
https://golang.org/cl/9383043
```
a8484753
os: clarify windows read console code · fad27ec5
Alex Brainman authored May 17, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9458043
```
fad27ec5

runtime: revert 3c2cddfbdaec · c15ca825

Alex Brainman authored May 17, 2013

It appears, syscall.NewCallback still
uses heap to store executable code.

R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/9060046

c15ca825

runtime: do not mark os memory as executable on windows · 28f74608
Alex Brainman authored May 17, 2013
```
R=golang-dev, bradfitz, khr
CC=golang-dev
https://golang.org/cl/9235046
```
28f74608