- 11 Nov, 2016 11 commits
-
-
Richard Gibson authored
The 255-octet limit applies to wire format, not presentation format. Fixes #17549 Change-Id: I2b5181c53fba32fea60178e0d8df9114aa992b55 Reviewed-on: https://go-review.googlesource.com/31722 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Emmanuel Odeke authored
Fixes #16042. Change-Id: I0a28aa004246b7b0ffaaab457e077ad9035363c2 Reviewed-on: https://go-review.googlesource.com/31932Reviewed-by:
-
Hiroshi Ioka authored
Some commands generate binary outputs which are not human readable. In interactive mode, there are no use-cases for such outputs. Instead, the new code writes it to the temporary file on the $CWD and shows the file name. So the user can use any program to display the file outside interactive shell. Fixes #17465 Change-Id: I5c479db26017607f7a28eafbff2385533e5c584e Reviewed-on: https://go-review.googlesource.com/31123Reviewed-by:
-
Ian Lance Taylor authored
It will just cause confusion later as the go tool will say "warning: GOPATH set to GOROOT (%s) has no effect". Better to just leave GOPATH unset and get that warning instead. Change-Id: I78ff9e87fdf4bb0460f4f6d6ee76e1becaa3e7b0 Reviewed-on: https://go-review.googlesource.com/33105 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
Change-Id: I94e0f3e4bccd44a67934ddb4d5fc7da57bb8ac9f Reviewed-on: https://go-review.googlesource.com/33112Reviewed-by:
Rob Pike <r@golang.org>
-
Ian Lance Taylor authored
On some systems the external linker defaults to PIE. On some systems DT_TEXTREL does not work correctly. When both are true we have a bad situation: any Go program built with the default buildmode (exe) that uses external linking will fail to run. Fix this by passing -no-pie to the external linker, if the option is supported. Fixes #17847. Change-Id: I9b5ff97825d8b7f494f96d29c4c04f72b53dbf4e Reviewed-on: https://go-review.googlesource.com/33106 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Brad Fitzpatrick authored
Fixes #16412 Change-Id: Idc65d2a62414a9b1573e6bd9f8601b52985b5dea Reviewed-on: https://go-review.googlesource.com/33110Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
The cgo tool used to simply ignore C type qualifiers. To avoid problems when a C function expected a qualifier that was not present, cgo emitted a cast to void* around all pointer arguments. Unfortunately, that broke code that contains both a function declaration and a macro, when the macro required the argument to have the right type. To fix this problem, don't ignore qualifiers. They are easy enough to handle for the limited set of cases that matter for cgo, in which we don't care about array or function types. Fixes #17537. Change-Id: Ie2988d21db6ee016a3e99b07f53cfb0f1243a020 Reviewed-on: https://go-review.googlesource.com/33097 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Francesc Campoy authored
Whenever GOPATH is not defined in the environment, use $HOME/go as its default value. For Windows systems use %USERPROFILE%/go and $home/go for plan9. The choice of these environment variables is based on what Docker currently does. The os/user package is not used to avoid having a cgo dependency. Updates #17262. Documentation changes forthcoming. Change-Id: I6368fbfbc5afda99d6e64c35c1980076fcf45344 Reviewed-on: https://go-review.googlesource.com/32019 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Also: - update performance improvements for CL 31275. Change-Id: I2f2ec0a42b248643e76df8654e11bf0b01a5d030 Reviewed-on: https://go-review.googlesource.com/33114Reviewed-by:
Robert Griesemer <gri@golang.org>
-
David Crawshaw authored
CL 32355 switched from using the output file as a plugin prefix to the full package path. The linker dead code analysis was not updated. Updates #17821 Change-Id: I13fc45e0264b425d28524ec54c829e2c3e895b0b Reviewed-on: https://go-review.googlesource.com/32916Reviewed-by:
-
- 10 Nov, 2016 25 commits
-
-
Ian Lance Taylor authored
Fixes the build when CGO_ENABLED=0. Change-Id: I7f3c67d61e156e69536558fda0a0a4b429b82bbd Reviewed-on: https://go-review.googlesource.com/33104 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
This reverts the changes from https://golang.org/cl/33018: Instead of writing the result of gofmt to a tmp file and then rename that to the original (which doesn't preserve the original file's perm bits, uid, gid, and possibly other properties because it is hard to do in a platform-independent way - see #17869), use the original code that simply overwrites the processed file if gofmt was able to create a backup first. Upon success, the backup is removed, otherwise it remains. Fixes #17873. For #8984. Change-Id: Ifcf2bf1f84f730e6060f3517d63b45eb16215ae1 Reviewed-on: https://go-review.googlesource.com/33098 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Updates http2 to x/net/http2 git rev 0e2717d for: http2: conditionally log stacks from panics in Server Handlers like net/http https://golang.org/cl/33102 Fixes #17790 Change-Id: Idd3f0c65540398d41b412a33f1d80de3f7f31409 Reviewed-on: https://go-review.googlesource.com/33103Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com>
-
Brad Fitzpatrick authored
This test was only enabled by default today so it hasn't been hardened by build.golang.org. Welcome to the ring, TestClientTimeout. Change-Id: I1967f6c825699f13f6c659dc14d3c3c22b965272 Reviewed-on: https://go-review.googlesource.com/33101Reviewed-by:
-
Brad Fitzpatrick authored
The old Transport example ended up disabling HTTP/2. Use a better example. Fixes #17051 Fixes #17296 Change-Id: I6feca168744131916e8bf56c829b4d4b50e304ee Reviewed-on: https://go-review.googlesource.com/33094Reviewed-by:
-
Brad Fitzpatrick authored
Updates http2 to x/net/http2 git rev 9ef22118 for: http2: fix CloseNotify data race https://golang.org/cl/33013 http2: don't overflow stream IDs in server push https://golang.org/cl/32488 http2: disable server push on receiving a GOAWAY https://golang.org/cl/32887 http2: fix state tracking for pushed streams https://golang.org/cl/32755 Change-Id: Ie7d675857423c102c9ec164d3c943093c749c7cf Reviewed-on: https://go-review.googlesource.com/33100Reviewed-by:
Tom Bergan <tombergan@google.com> Reviewed-by:
-
Brad Fitzpatrick authored
Add an explicit way for Handlers to abort their response to the client and also not spam their error log with stack traces. panic(nil) also worked in the past (for http1 at least), so continue to make that work (and test it). But ErrAbortHandler is more explicit. Updates #17790 (needs http2 updates also) Change-Id: Ib1456905b27e2ae8cf04c0983dc73e314a4a751e Reviewed-on: https://go-review.googlesource.com/33099 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #17721 Change-Id: I19fd81c9909a22b01a4dc9c75f3f0e069c8608ca Reviewed-on: https://go-review.googlesource.com/33095Reviewed-by:
-
Ian Lance Taylor authored
https://docs.oracle.com/cd/E53394_01/html/E54813/chapter6-54839.html#OSLLGchapter6-24: "For 64–bit SPARC Elf64_Rela structures, the r_info field is further broken down into an 8–bit type identifier and a 24–bit type dependent data field. For the existing relocation types, the data field is zero. New relocation types, however, might make use of the data bits. #define ELF64_R_TYPE_ID(info) (((Elf64_Xword)(info)<<56)>>56) " No test for this because the only test would be an invalid object file. Change-Id: I5052ca3bfaf0759e920f9a24a16fd97543b24486 Reviewed-on: https://go-review.googlesource.com/33091Reviewed-by:
Michael Hudson-Doyle <michael.hudson@canonical.com>
-
Brad Fitzpatrick authored
Clean up & document the ProtocolError gunk. Fixes #17558 Change-Id: I5e54c25257907c9cac7433f7a5bdfb176e8c3eee Reviewed-on: https://go-review.googlesource.com/33096Reviewed-by:
-
Ian Lance Taylor authored
Interestingly, this only became a problem when CL 32850 marked TestImportMain as parallel. Before that, "x" was overwritten and remove in a later test, TestGoBuildOutput. The latter test is not marked as parallel, so now it is run first. It is rather fragile for two tests to compete over the same filename, but this change is correct regardless. Change-Id: I1db7929c0bc20a2fd0cc6a02999bef2dca9e0cc0 Reviewed-on: https://go-review.googlesource.com/33092 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Server.TLSNextProto being nil is necessary but not sufficient but http2 being automatically enabled. Fixes #16588 Change-Id: I5b18690582f9b12ef05b58235e1eaa52483be285 Reviewed-on: https://go-review.googlesource.com/33090Reviewed-by:
-
Michael Matloob authored
This change buffers the entire profile and converts in one shot in the profile writer, and could use more memory than necessary to output protocol buffer formatted profiles. It should be possible to convert each chunk in a stream (maybe maintaining some minimal state to output in the end) which could save on memory usage. Fixes #16093 Change-Id: I946c6a2b044ae644c72c8bb2d3bd82c415b1a847 Reviewed-on: https://go-review.googlesource.com/33071 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Emmanuel Odeke authored
Based on Filippo Valsorda's https://golang.org/cl/24230 Fixes #16094 Change-Id: Ie39b0834e220f0a0f4fbfb3bbb271e70837718c3 Reviewed-on: https://go-review.googlesource.com/32478Reviewed-by:
-
Francesc Campoy authored
This check detects the code resp, err := http.Get("http://foo.com") defer resp.Body.Close() if err != nil { ... } For every call to a function on the net/http package or any method on http.Client that returns (*http.Response, error), it checks whether the next line is a defer statement that calls on the response. Fixes #17780. Change-Id: I9d70edcbfa2bad205bf7f45281597d074c795977 Reviewed-on: https://go-review.googlesource.com/32911Reviewed-by: -
Brad Fitzpatrick authored
Add Albert Nigmatzianov (individual CLA) Add Alex Browne (individual CLA) Add Alex Carol (individual CLA) Add Alexander Döring (individual CLA) Add Allan Simon (individual CLA) Add Alok Menghrajani (individual CLA) Add Andreas Auernhammer (individual CLA) Add Andreas Litt (individual CLA) Add Andrew Pogrebnoy (individual CLA) Add Antonio Murdaca (corporate CLA for Red Hat, Inc.) Add Atin Malaviya (individual CLA) Add Billy Lynch (corporate CLA for Google Inc.) Add Blixt (individual CLA) Add Boris Nagaev (corporate CLA for Google Inc.) Add Braden Bassingthwaite (corporate CLA for Vendasta) Add Brian Kennedy (individual CLA) Add Bryan Alexander (individual CLA) Add Carl Johnson (individual CLA) Add Cixtor (individual CLA) Add Cyrill Schumacher (individual CLA) Add Daniel Martí (individual CLA) Add Daria Kolistratova (corporate CLA for Intel Corporation) Add David Hubbard (corporate CLA for Google Inc.) Add David Stainton (individual CLA) Add Deepak Jois (individual CLA) Add Denis Nagorny (corporate CLA for Intel Corporation) Add Dhaivat Pandit (individual CLA) Add Dhananjay Nakrani (corporate CLA for Google Inc.) Add Dmitri Popov (individual CLA) Add Erik Staab (corporate CLA for Google Inc.) Add Ethan Miller (corporate CLA for IBM) Add Faiyaz Ahmed (individual CLA) Add Fedor Indutny (individual CLA) Add Gabriel Russell (individual CLA) Add Gareth Paul Jones (individual CLA) Add Geoffroy Lorieux (individual CLA) Add Gleb Stepanov (individual CLA) Add Henrik Hodne (individual CLA) Add Ivan Babrou (individual CLA) Add Jack Lindamood (corporate CLA for Amazon.com, Inc) Add James Clarke (individual CLA) Add Jamie Beverly (individual CLA) Add Jason Smale (individual CLA) Add Jean-Nicolas Moal (individual CLA) Add Jeroen Bobbeldijk (individual CLA) Add Jim Kingdon (corporate CLA for Bolt) Add Jirka Daněk (individual CLA) Add Jon Chen (corporate CLA for Amazon.com, Inc) Add Joonas Kuorilehto (individual CLA) Add Josh Chorlton (individual CLA) Add Joshua Boelter (corporate CLA for Intel Corporation) Add Justyn Temme (individual CLA) Add Kale Blankenship (individual CLA) Add LE Manh Cuong (individual CLA) Add Luigi Riefolo (individual CLA) Add Manfred Touron (individual CLA) Add Martin Bertschler (individual CLA) Add Martin Hamrle (individual CLA) Add Matthew Denton (individual CLA) Add Matthieu Hauglustaine (individual CLA) Add Michael Darakananda (corporate CLA for Google Inc.) Add Mike Appleby (individual CLA) Add Mike Houston (individual CLA) Add Mike Strosaker (corporate CLA for IBM) Add Miroslav Genov (individual CLA) Add Momchil Velikov (individual CLA) Add Nick Harper (corporate CLA for Google Inc.) Add Oleg Vakheta (individual CLA) Add Parker Moore (individual CLA) Add Prasanna Swaminathan (corporate CLA for MediaMath, Inc) Add Radu Berinde (individual CLA) Add Ramesh Dharan (corporate CLA for Google Inc.) Add Richard Gibson (individual CLA) Add Samuel Tan (corporate CLA for Google Inc.) Add Samuele Pedroni (individual CLA) Add Sarah Adams (corporate CLA for Google Inc.) Add Sean Rees (individual CLA) Add Simon Rawet (individual CLA) Add Sina Siadat (individual CLA) Add Song Gao (individual CLA) Add Suyash (individual CLA) Add Sven Blumenstein (corporate CLA for Google Inc.) Add Syohei YOSHIDA (individual CLA) Add Terrel Shumway (individual CLA) Add Than McIntosh (corporate CLA for Google Inc.) Add Thomas de Zeeuw (individual CLA) Add Tim Henderson (individual CLA) Add Tom Wilkie (corporate CLA for Weaveworks) Add Trey Lawrence (individual CLA) Add Tristan Ooohry (individual CLA) Add Tuo Shan (corporate CLA for Google Inc.) Add Victor Chudnovsky (corporate CLA for Google Inc.) Add Vitor De Mario (individual CLA) Add Vladimir Mihailenco (individual CLA) Add Vladimir Stefanovic (individual CLA) Add Walter Poupore (corporate CLA for Google Inc.) Add Xuyang Kang (individual CLA) Add Zev Goldstein (individual CLA) Updates #12042 Change-Id: I28d63babe225683b88f3f1501e529aed636c9ead Reviewed-on: https://go-review.googlesource.com/33028Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #17678 Change-Id: I01d12a827e6106efed1ec024f736c640b86906b4 Reviewed-on: https://go-review.googlesource.com/33029 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
We add runtime/cgo to the list of import paths for various cases that imply external linking mode, but before this change we did not add for an explicit request of external linking mode. This fixes the case where you are using a non-default buildmode that implies a different compilation option (for example, -buildmode=pie implies -shared) and the runtime/cgo package for that option is stale. No test, as I'm not sure how to write one. It would require forcing a stale runtime/cgo. Change-Id: Id0409c7274ce67fe15d910baf587d3220cb53d83 Reviewed-on: https://go-review.googlesource.com/33070Reviewed-by:
-
Robert Griesemer authored
For details, see the issues. Fixes #11274. Fixes #15137. Change-Id: Ia11e71a054b3195e3007f490418a9c53a7e9cdf1 Reviewed-on: https://go-review.googlesource.com/33016Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Brad Fitzpatrick authored
Fixes #17878 Change-Id: I062ac514239068c58175c9ee7964b3590f956a82 Reviewed-on: https://go-review.googlesource.com/33026 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
An unexported field of a struct is not visible outside of the package that defines it, so the package path is implicitly part of the definition of any struct with an unexported field. Change-Id: I17c6aac822bd0c24188ab8ba1cc406d6b5d82771 Reviewed-on: https://go-review.googlesource.com/32820 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Kevin Burke authored
It was a little tricky to figure out how to go from the documentation to figuring out the best way to implement a Pool, so I thought I'd try to provide a simple example. The implementation is mostly taken from the fmt package. I'm not happy with the verbosity of the calls to WriteString() etc, but I wanted to provide a non-trivial example. Change-Id: Id33a8b6cbf8eb278f71e1f78e20205b436578606 Reviewed-on: https://go-review.googlesource.com/24371Reviewed-by:
-
Robert Griesemer authored
Follow-up on https://golang.org/cl/33018. For #8984. Change-Id: I6655a5537a60d4ea3ee13029a56a75b150f8c8f8 Reviewed-on: https://go-review.googlesource.com/33020Reviewed-by:
-
Robert Griesemer authored
Write output to a temp file first and only upon success rename that file to source file name. Fixes #8984. Change-Id: Ie40e49d2a4eb3c9462fe769ccbf055b4366eceb0 Reviewed-on: https://go-review.googlesource.com/33018Reviewed-by:
-
Robert Griesemer authored
They interfere with gofmt -w across this directory. Follow-up on https://go-review.googlesource.com/32819. For #16339 (comment). Change-Id: I4298b6117d89517d4fe6addce3942d950d821817 Reviewed-on: https://go-review.googlesource.com/33019Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
- 09 Nov, 2016 4 commits
-
-
Brad Fitzpatrick authored
Fixes #17838 Change-Id: Ifafb4542a0ed6f2e29c9a83e30842e2fc18d6546 Reviewed-on: https://go-review.googlesource.com/33015 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Michael Munday <munday@ca.ibm.com>
-
Brad Fitzpatrick authored
Fixes #17092 Change-Id: Ib14e4db13116ebbe4d72c414fb979d27a06d6174 Reviewed-on: https://go-review.googlesource.com/33011 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Quentin Smith authored
We only support unmarshaling into a string or a []byte, but we previously would try (and panic while) setting a slice of a different type. The docs say ",innerxml" is ignored if the type is not string or []byte, so do that for other slices as well. Fixes #15600. Change-Id: Ia64815945a14c3d04a0a45ccf413e38b58a69416 Reviewed-on: https://go-review.googlesource.com/32919 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Michael Munday authored
A Go binary may only have 1 executable memory region if it has been linked using internal linking. This change means that the test will be skipped if this is the case, rather than fail. Fixes #17852. Change-Id: I59459a0f90ae8963aeb9908e5cb9fb64d7d0e0f4 Reviewed-on: https://go-review.googlesource.com/32920 Run-TryBot: Michael Munday <munday@ca.ibm.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Michael Matloob <matloob@golang.org>
-
