Commits · 9c504696f46295c7d2bbad3da7cb4854227a13b7 · go / golang

27 Aug, 2014 1 commit

cmd/gc: fix undefined behaviour warnings in mparith3.c · 9c504696

Dave Cheney authored Aug 27, 2014

Update #8527

Fixes two warnings:

src/cmd/gc/mparith3.c:255:10: runtime error: shift exponent 52 is too large for 32-bit type 'int'
src/cmd/gc/mparith3.c:254:14: runtime error: shift exponent 52 is too large for 32-bit type 'int'

LGTM=rsc
R=r, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/134940044

9c504696

26 Aug, 2014 11 commits

time: use go generate rather than Makefile (windows only) · 1660ece7

Rob Pike authored Aug 26, 2014

Also make genzabbrs.go more self-contained.
Also run it (on Linux; does that matter?) to update the table.

LGTM=rsc
R=rsc, alex.brainman
CC=golang-codereviews
https://golang.org/cl/128350044

1660ece7

unicode: use go generate instead of make to create tables.go · 62be54a8
Rob Pike authored Aug 26, 2014
```
LGTM=mpvl, rsc
R=mpvl, rsc
CC=golang-codereviews
https://golang.org/cl/135820043
```
62be54a8
A+C: Joe Shaw (individual CLA) · cf55da83
Brad Fitzpatrick authored Aug 26, 2014
```
Generated by a+c.

R=gobot
CC=golang-codereviews
https://golang.org/cl/133040043
```
cf55da83
runtime: name hi and lo parts of ret in assembly · e5a06ccd
Josh Bleecher Snyder authored Aug 26, 2014
```
Makes vet happy.

LGTM=bradfitz
R=dvyukov, bradfitz
CC=golang-codereviews
https://golang.org/cl/131320043
```
e5a06ccd

doc/cmd.html: close a tag. · 2511d92f

Oling Cat authored Aug 26, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/130560043

2511d92f

runtime: convert Stack to Go. · 39ffa8be
Rémy Oudompheng authored Aug 26, 2014
```
LGTM=khr
R=khr, josharian
CC=golang-codereviews
https://golang.org/cl/129510043
```
39ffa8be

runtime: convert int64tofloat64, uint64tofloat64 to Go · 0eaea601

Dave Cheney authored Aug 26, 2014

I noticed that 5g doesn't flush the float64 result back to the stack, hence the change in the function signature. I'm wondering if I should also change the signature for the other two functions.

LGTM=rsc
R=minux, josharian, rsc
CC=golang-codereviews
https://golang.org/cl/132990044

0eaea601

runtime,sync: Convert procPin and procUnpin functions to Go. · 90653d78
Sanjay Menakuru authored Aug 26, 2014
```
LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews, khr
https://golang.org/cl/132880043
```
90653d78

net/http: fix data race in test · 32c0dce0

Brad Fitzpatrick authored Aug 26, 2014

I can't reproduce the race, but this should fix it.

Fixes #8483

LGTM=dvyukov
R=dvyukov
CC=golang-codereviews
https://golang.org/cl/126610043

32c0dce0

io: document that Readers and Writers must not retain buffers · 87b45253

Brad Fitzpatrick authored Aug 26, 2014

There are both many callers and many implementations of these
interfaces, so make the contract explicit. Callers generally
assume this, and at least the standard library and other
implementations obey this, but it's never stated explicitly,
making it somewhat risky to assume.

LGTM=gri, rsc
R=golang-codereviews, gri
CC=golang-codereviews, r, rsc
https://golang.org/cl/132150043

87b45253

cmd/go: add missing doc for GOOS and GOARCH · 3c466dfe
ChaiShushan authored Aug 26, 2014
```
LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/133900043
```
3c466dfe

25 Aug, 2014 28 commits

regexp: fix imports in the middle of the license header · 56916fee
Caleb Spare authored Aug 25, 2014
```
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/129620043
```
56916fee

liblink: introduce way to avoid pc-relative addressing · 4516a600

Russ Cox authored Aug 25, 2014

For Solaris. Sigh.

LGTM=dave
R=aram, iant, dave
CC=golang-codereviews
https://golang.org/cl/129540043

4516a600

cmd/gofmt: don't permit -w with stdin · 236cf308

Robert Griesemer authored Aug 25, 2014

Also: use 0x644 file permission if a new file
is created (should not happen anymore, though).

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/126610044

236cf308

unicode/maketables: add -output flag, buffer output, use gofmt · dff17f46

Rob Pike authored Aug 25, 2014

Simplify the invocation (and speed it up substantially) in preparation
for move to go generate.

LGTM=bradfitz, mpvl
R=mpvl, bradfitz, josharian
CC=golang-codereviews
https://golang.org/cl/135790043

dff17f46

strings, bytes: document behavior of Replace when old is empty · 2c121b68
Caleb Spare authored Aug 25, 2014
```
Fixes #8143.

LGTM=r
R=rsc, bradfitz, r
CC=golang-codereviews
https://golang.org/cl/135760043
```
2c121b68

cmd/go: clean up a couple of inconsequential nits in generate · 958a6101

Rob Pike authored Aug 25, 2014

Post-submit glitches caught by reviewers.

LGTM=nightlyone, bradfitz
R=golang-codereviews, nightlyone, bradfitz
CC=golang-codereviews
https://golang.org/cl/126660043

958a6101

runtime: restore scavenger constants · b2c43438

Dmitriy Vyukov authored Aug 25, 2014

Once and for all.
Broken in cl/108640043.
I've messed it before. To test scavenger-related changes
one needs to alter the constants during final testing.
And then it's very easy to submit with the altered constants.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, rsc
https://golang.org/cl/136720044

b2c43438

runtime: restore nacl timens · 21a4bdef

Dmitriy Vyukov authored Aug 25, 2014

Deleted in cl/123700044.
I am not sure whether I need to restore it,
or delete rest of the uses...

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/129580043

21a4bdef

net/http: populate Request.Close in ReadRequest · 6bddb13b
Brad Fitzpatrick authored Aug 25, 2014
```
Fixes #8261

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/126620043
```
6bddb13b

crypto/cipher: add CFB test vectors. · a6cd7334

Adam Langley authored Aug 25, 2014

Fixes #8576.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/136720043

a6cd7334

cmd/gc, runtime: treat slices and strings like pointers in garbage collection · 613383c7

Russ Cox authored Aug 25, 2014

Before, a slice with cap=0 or a string with len=0 might have its
base pointer pointing beyond the actual slice/string data into
the next block. The collector had to ignore slices and strings with
cap=0 in order to avoid misinterpreting the base pointer.

Now, a slice with cap=0 or a string with len=0 still has a base
pointer pointing into the actual slice/string data, no matter what.
The collector can now always scan the pointer, which means
strings and slices are no longer special.

Fixes #8404.

LGTM=khr, josharian
R=josharian, khr, dvyukov
CC=golang-codereviews
https://golang.org/cl/112570044

613383c7

cmd/go: add GOOS and GOARCH to generate · c6f7c176

Rob Pike authored Aug 25, 2014

Fixes test failure in build, probably a good idea anyway.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/131210043

c6f7c176

cmd/go: add simple test for generate's line parser · ba8ddc25
Rob Pike authored Aug 25, 2014
```
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/128710043
```
ba8ddc25

encoding/json: make ,string work when encoding pointer fields · df52d2eb

Brad Fitzpatrick authored Aug 25, 2014

It was respected by unmarshal, but not marshal, so they didn't
round-trip.

Fixes #8582

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/132960043

df52d2eb

runtime: round channel size in allocation instead of using system-specific pad field · 1d2955a2
Russ Cox authored Aug 25, 2014
```
Followup to CL 128700043.

LGTM=bradfitz, dvyukov
R=dvyukov, bradfitz
CC=golang-codereviews
https://golang.org/cl/133850043
```
1d2955a2

runtime: remove dedicated scavenger thread · b83d8bd0

Dmitriy Vyukov authored Aug 25, 2014

A whole thread is too much for background scavenger that sleeps all the time anyway.
We already have sysmon thread that can do this work.
Also remove g->isbackground and simplify enter/exitsyscall.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews, khr, rlh
https://golang.org/cl/108640043

b83d8bd0

runtime: add comment · 4064d5e9

Dmitriy Vyukov authored Aug 25, 2014

Explain why it's safe to allocate chans with flagNoScan.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, khr, rsc
https://golang.org/cl/125510045

4064d5e9

runtime: convert timers to Go · 9601abaf

Dmitriy Vyukov authored Aug 25, 2014

LGTM=rsc
R=golang-codereviews, ruiu, rsc, daniel.morsing
CC=golang-codereviews, khr
https://golang.org/cl/123700044

9601abaf

runtime: convert async semaphores to Go · ebac0e6f

Dmitriy Vyukov authored Aug 25, 2014

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews, khr
https://golang.org/cl/126210046

ebac0e6f

runtime: fix plan9 HeapSys accounting · 846db089
Dmitriy Vyukov authored Aug 25, 2014
```
LGTM=0intro
R=0intro
CC=golang-codereviews
https://golang.org/cl/131190043
```
846db089

runtime: fix chan alignment on 32 bits · 99080c4b

Dmitriy Vyukov authored Aug 25, 2014

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews, khr, rsc
https://golang.org/cl/128700043

99080c4b

cmd/gc: fix order of channel evaluation of receive channels · 20e97677

Russ Cox authored Aug 25, 2014

Normally, an expression of the form x.f or *y can be reordered
with function calls and communications.

Select is stricter than normal: each channel expression is evaluated
in source order. If you have case <-x.f and case <-foo(), then if the
evaluation of x.f causes a panic, foo must not have been called.
(This is in contrast to an expression like x.f + foo().)

Enforce this stricter ordering.

Fixes #8336.

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews, r
https://golang.org/cl/126570043

20e97677

runtime: refactor CPU profiling · f595f834

Dmitriy Vyukov authored Aug 25, 2014

Reduce duration of critical section,
make pcbuf local to function.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, rsc
https://golang.org/cl/102600043

f595f834

runtime: fix block profile for sync semaphores · 7b3677bf

Dmitriy Vyukov authored Aug 25, 2014

Part of cl/128670043 that got lost during submit.

TBR=rsc
R=golang-codereviews
CC=golang-codereviews
https://golang.org/cl/129570043

7b3677bf

runtime: fix block profile for sync semaphores · 8ca564fb

Dmitriy Vyukov authored Aug 25, 2014

And add a test.

LGTM=rsc
R=golang-codereviews
CC=golang-codereviews, khr, rsc
https://golang.org/cl/128670043

8ca564fb

runtime: add fast paths to non-blocking channel operations · f6ceefa2

Dmitriy Vyukov authored Aug 25, 2014

benchmark                      old ns/op     new ns/op     delta
BenchmarkChanNonblocking       27.8          7.80          -71.94%
BenchmarkChanNonblocking-2     79.1          3.94          -95.02%
BenchmarkChanNonblocking-4     71.2          2.04          -97.13%

LGTM=rsc
R=golang-codereviews, rsc, dave
CC=golang-codereviews
https://golang.org/cl/110580043

f6ceefa2

runtime: Loosen conditions in TestMemstat in an attempt to fix the nacl/arm build. · 639dc6c7
Sanjay Menakuru authored Aug 25, 2014
```
LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews, khr
https://golang.org/cl/128680043
```
639dc6c7
runtime: convert NewCallback and NewCallbackCDecl to Go · 38ce5994
Alex Brainman authored Aug 25, 2014
```
LGTM=khr
R=khr, remyoudompheng
CC=golang-codereviews
https://golang.org/cl/132820043
```
38ce5994