- 10 Nov, 2016 4 commits
-
-
Kevin Burke authored
It was a little tricky to figure out how to go from the documentation to figuring out the best way to implement a Pool, so I thought I'd try to provide a simple example. The implementation is mostly taken from the fmt package. I'm not happy with the verbosity of the calls to WriteString() etc, but I wanted to provide a non-trivial example. Change-Id: Id33a8b6cbf8eb278f71e1f78e20205b436578606 Reviewed-on: https://go-review.googlesource.com/24371Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Follow-up on https://golang.org/cl/33018. For #8984. Change-Id: I6655a5537a60d4ea3ee13029a56a75b150f8c8f8 Reviewed-on: https://go-review.googlesource.com/33020Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Robert Griesemer authored
Write output to a temp file first and only upon success rename that file to source file name. Fixes #8984. Change-Id: Ie40e49d2a4eb3c9462fe769ccbf055b4366eceb0 Reviewed-on: https://go-review.googlesource.com/33018Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Robert Griesemer authored
They interfere with gofmt -w across this directory. Follow-up on https://go-review.googlesource.com/32819. For #16339 (comment). Change-Id: I4298b6117d89517d4fe6addce3942d950d821817 Reviewed-on: https://go-review.googlesource.com/33019Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
- 09 Nov, 2016 8 commits
-
-
Brad Fitzpatrick authored
Fixes #17838 Change-Id: Ifafb4542a0ed6f2e29c9a83e30842e2fc18d6546 Reviewed-on: https://go-review.googlesource.com/33015 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Tom Bergan <tombergan@google.com> Reviewed-by:
Michael Munday <munday@ca.ibm.com>
-
Brad Fitzpatrick authored
Fixes #17092 Change-Id: Ib14e4db13116ebbe4d72c414fb979d27a06d6174 Reviewed-on: https://go-review.googlesource.com/33011 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Quentin Smith authored
We only support unmarshaling into a string or a []byte, but we previously would try (and panic while) setting a slice of a different type. The docs say ",innerxml" is ignored if the type is not string or []byte, so do that for other slices as well. Fixes #15600. Change-Id: Ia64815945a14c3d04a0a45ccf413e38b58a69416 Reviewed-on: https://go-review.googlesource.com/32919 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Michael Munday authored
A Go binary may only have 1 executable memory region if it has been linked using internal linking. This change means that the test will be skipped if this is the case, rather than fail. Fixes #17852. Change-Id: I59459a0f90ae8963aeb9908e5cb9fb64d7d0e0f4 Reviewed-on: https://go-review.googlesource.com/32920 Run-TryBot: Michael Munday <munday@ca.ibm.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Michael Matloob <matloob@golang.org>
-
Robert Griesemer authored
- define syntax.Error for cleaner error reporting - abort parsing after first error if no error handler is installed - make sure to always report the first error, if any - document behavior of API calls - while at it: rename ReadXXX -> ParseXXX (clearer) - adjust cmd/compile noder.go accordingly Fixes #17774. Change-Id: I7893eedea454a64acd753e32f7a8bf811ddbb03c Reviewed-on: https://go-review.googlesource.com/32950Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Josh Bleecher Snyder authored
visit is just a func, and there's no formatting verb for it, and it's on an internal-error path. It has been thus many years, unchanged and unexecuted. Change-Id: I4c2e2673ee9996218c24143bcc3be3eb4abdff25 Reviewed-on: https://go-review.googlesource.com/32970 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Martin Möhrmann authored
Change-Id: Ia439c4a3c873ef24f60f8ee54a74f767fdaafd29 Reviewed-on: https://go-review.googlesource.com/32799Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Josh Bleecher Snyder authored
Change-Id: I4febdddfe5be569a8bba0a4cddf52dec7f1be1bf Reviewed-on: https://go-review.googlesource.com/32930 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by:
Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 08 Nov, 2016 17 commits
-
-
Brad Fitzpatrick authored
Notably, don't allocate. Follow-up to https://golang.org/cl/32451 which added long path cleaning. Updates #3358 Change-Id: I89c59cbd660d0a030f31b6acd070fa9f3250683b Reviewed-on: https://go-review.googlesource.com/32886 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Vladimir Stefanovic authored
Only internal linking without cgo is supported for now. Change-Id: I772d2ba496a613c78bee7e93f29e9538e6407bdc Reviewed-on: https://go-review.googlesource.com/31481 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: Ib489dc847787aaab7ba1be96792f885469e346ae Reviewed-on: https://go-review.googlesource.com/31479 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: I632d4aef7295778ba5018d98bcb06a68bcf07ce1 Reviewed-on: https://go-review.googlesource.com/31478 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Michael Matloob authored
This change adds code, originally written by Russ Cox <rsc@golang.org> and open-sourced by Google, that converts from the "legacy" binary pprof profile format to a struct representation of the new protocol buffer pprof profile format. This code reads the entire binary format for conversion to the protobuf format. In a future change, we will update the code to incrementally read and convert segments of the binary format, so that the entire profile does not need to be stored in memory. This change also contains contributions by Daria Kolistratova <daria.kolistratova@intel.com> from the rolled-back change golang.org/cl/30556 adapting the code to be used by the package runtime/pprof. This code also appeared in the change golang.org/cl/32257, which was based on Daria Kolistratova's change, but was also rolled back. Updates #16093 Change-Id: I5c768b1134bc15408d80a3ccc7ed867db9a1c63d Reviewed-on: https://go-review.googlesource.com/32811 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Jaana Burcu Dogan authored
Fixes #17690. Change-Id: Ifd300980aa4c11498ed7c083d08bcdd23f5b307a Reviewed-on: https://go-review.googlesource.com/32423Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Change-Id: I43617e6dfd5b8227a8ef907dc22c00188de87b94 Reviewed-on: https://go-review.googlesource.com/32915Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Updates #16352 Change-Id: I214c87579ef21ced8d0ba94aa170dd7780afec4b Reviewed-on: https://go-review.googlesource.com/32312Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I6a5256a42f895bb93ac56764e91ade1861c00e04 Reviewed-on: https://go-review.googlesource.com/31476 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
Fix another case of a parallel test relying on a global variable (DefaultTransport) implicitly. Use the private Transport already in scope instead. It's closed at the end, instead of randomly via another test. Change-Id: I95e51926177ad19a766cabbb306782ded1bbb59b Reviewed-on: https://go-review.googlesource.com/32913 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Volodymyr Paprotski authored
A paranoid go at constant time implementation of P256 curve. This code relies on z13 SIMD instruction set. For zEC12 and below, the fallback is the existing P256 implementation. To facilitate this fallback mode, I've refactored the code so that implementations can be picked at run-time. Its 'slightly' difficult to grok, but there is ASCII art.. name old time/op new time/op delta BaseMultP256 419µs ± 3% 27µs ± 1% -93.65% (p=0.000 n=10+8) ScalarMultP256 1.05ms ±10% 0.09ms ± 1% -90.94% (p=0.000 n=10+8) Change-Id: Ic1ded898a2ceab055b1c69570c03179c4b85b177 Reviewed-on: https://go-review.googlesource.com/31231 Run-TryBot: Michael Munday <munday@ca.ibm.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Vladimir Stefanovic authored
Implements subset of MIPS32(r1) instruction set. Change-Id: Iba017350f6c2763de05d4d1bc2f123e8eb76d0ff Reviewed-on: https://go-review.googlesource.com/31475 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
Fixes #17606 Change-Id: I040c7621cef265d44b58f16556e6d58660a2245d Reviewed-on: https://go-review.googlesource.com/32889 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Mohit Agarwal authored
Add tmpdir as a parameter to the closure otherwise the subsequent modifications to tmpdir causes only the last subdirectory to be removed. Additionally, add the missing argument for the t.Fatalf call. Change-Id: I3df53f9051f7ea40cf3f846d47d9cefe445e9b9d Reviewed-on: https://go-review.googlesource.com/32892Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Fixes #11944. Change-Id: I424ba93725f22fd599e052eb182f9ba2fca8e8bd Reviewed-on: https://go-review.googlesource.com/32881Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Shenghou Ma authored
Updates #17824. Change-Id: I73cf89c21b418158c7014c3271cd1103a17a5c86 Reviewed-on: https://go-review.googlesource.com/32882Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Shenghou Ma authored
Change-Id: Id3d571666b9275e3fa5cb20762afbd391dbcdeba Reviewed-on: https://go-review.googlesource.com/32883Reviewed-by:
Minux Ma <minux@golang.org>
-
- 07 Nov, 2016 11 commits
-
-
Shenghou Ma authored
// Executable returns the path name for the executable that started // the current process. There is no guarantee that the path is still // pointing to the correct executable. If a symlink was used to start // the process, depending on the operating system, the result might // be the symlink or the path it pointed to. If a stable result is // needed, path/filepath.EvalSymlinks might help. // // Executable returns an absolute path unless an error occurred. // // The main use case is finding resources located relative to an // executable. // // Executable is not supported on nacl or OpenBSD (unless procfs is // mounted.) func Executable() (string, error) { return executable() } Fixes #12773. Change-Id: I469738d905b12f0b633ea4d88954f8859227a88c Reviewed-on: https://go-review.googlesource.com/16551 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Shenghou Ma authored
For os.Executable. Updates #12773. Change-Id: Iff6593514b7453b6c5e1f20079e35cb4992cc74a Reviewed-on: https://go-review.googlesource.com/32877Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Munday authored
Change-Id: Ice8f3b42194852f7ee8f00f004e80014d1ea119b Reviewed-on: https://go-review.googlesource.com/32875Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Quentin Smith authored
This commit also adds a test for pkg-config usage in cgo. Fixes #16455. Change-Id: I95fb6a288a4d19093c4613c93878017d95cbe4a2 Reviewed-on: https://go-review.googlesource.com/32735 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Michael Munday authored
CL 32871 updated the default cipher suites to use AES-GCM in preference to ChaCha20-Poly1305 on platforms which have hardware implementations of AES-GCM. This change makes BenchmarkThroughput use the default cipher suites instead of the test cipher suites to ensure that the recommended (fastest) algorithms are used. Updates #17779. Change-Id: Ib551223e4a00b5ea197d4d73748e1fdd8a47c32d Reviewed-on: https://go-review.googlesource.com/32838 Run-TryBot: Michael Munday <munday@ca.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Adam Langley <agl@golang.org>
-
https://go-review.googlesource.com/32870Robert Griesemer authored
For #17812. Change-Id: I58411aaa0e8b2250a16ddb20c951e39da3d601e8 Reviewed-on: https://go-review.googlesource.com/32872Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Quentin Smith authored
Windows has a limit of 260 characters on normal paths, but it's possible to use longer paths by using "extended-length paths" that begin with `\\?\`. This commit attempts to transparently convert an absolute path to an extended-length path, following the subtly different rules those paths require. It does not attempt to handle relative paths, which continue to be passed to the operating system unmodified. This adds a new test, TestLongPath, to the os package. This test makes sure that it is possible to write a path at least 400 characters long and runs on every platform. It also tests symlinks and hardlinks, though symlinks are not testable with our builder configuration. HasLink is moved to internal/testenv so it can be used by multiple tests. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx has Microsoft's documentation on extended-length paths. Fixes #3358. Fixes #10577. Fixes #17500. Change-Id: I4ff6bb2ef9c9a4468d383d98379f65cf9c448218 Reviewed-on: https://go-review.googlesource.com/32451 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Shenghou Ma authored
Change-Id: Ie21df37016c90cd0479c23ec4845f8195dd90fda Reviewed-on: https://go-review.googlesource.com/16518Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Shenghou Ma authored
Change-Id: Icd77ccbfe6a31117a11effb949b5826950df75a9 Reviewed-on: https://go-review.googlesource.com/16550Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Adam Langley authored
Support for ChaCha20-Poly1305 ciphers was recently added to crypto/tls. These ciphers are preferable in software, but they cannot beat hardware support for AES-GCM, if present. This change moves detection for hardware AES-GCM support into cipher/internal/cipherhw so that it can be used from crypto/tls. Then, when AES-GCM hardware is present, the AES-GCM cipher suites are prioritised by default in crypto/tls. (Some servers, such as Google, respect the client's preference between AES-GCM and ChaCha20-Poly1305.) Fixes #17779. Change-Id: I50de2be486f0b0b8052c4628d3e3205a1d54a646 Reviewed-on: https://go-review.googlesource.com/32871 Run-TryBot: Adam Langley <agl@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Quentin Smith authored
Some multipart data arrives in a stream, where subsequent parts may not be ready yet. Read should return a complete part as soon as possible. Fixes #15431 Change-Id: Ie8c041b853f3e07f0f2a66fbf4bcab5fe9132a7c Reviewed-on: https://go-review.googlesource.com/32032 Run-TryBot: Quentin Smith <quentin@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-