Commits · a0d3be16897ade364d1039fb2c2169ca4f109b58 · go / golang

19 Jul, 2011 9 commits
- goinstall, dashboard: Google Code now supports git · a0d3be16
  Tarmigan Casebolt authored Jul 19, 2011
```
R=golang-dev, adg, rsc, tarmigan+golang
CC=golang-dev
https://golang.org/cl/4760055
```
  a0d3be16
- 5l: fix arm linker bug introduced by 4742041 · 423ab233
  Rob Pike authored Jul 19, 2011
```
Should fix the arm build.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/4777041
```
  423ab233
- doc/talks/io2010: handle the errors · 894222f9
  Andrew Gerrand authored Jul 19, 2011
```
R=golang-dev, dsymonds, dsymonds, r
CC=golang-dev
https://golang.org/cl/4771041
```
  894222f9
- go/build: fixes for windows paths · 42effdf0
  Alex Brainman authored Jul 19, 2011
```
R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4746047
```
  42effdf0
- archive/zip: support functions to get modified time in ns from MS-DOS time · 98f5fc5e
  Robert Griesemer authored Jul 19, 2011
```
R=rsc, r, bradfitz, r, adg
CC=golang-dev
https://golang.org/cl/4748056
```
  98f5fc5e
- exp/wingui: make sure it builds again · 208e6e6d
  Alex Brainman authored Jul 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4770041
```
  208e6e6d
- gif: fix local color map and coordinates · a5a94f5d
  Rob Pike authored Jul 19, 2011
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/4759051
```
  a5a94f5d
- dashboard: list "most installed this week" with rolling count · 7a18fc3b
  Andrew Gerrand authored Jul 19, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4631085
```
  7a18fc3b
- time: typo in documentation · 95117d30
  Robert Griesemer authored Jul 19, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4763048
```
  95117d30
18 Jul, 2011 23 commits

runtime: fix select pass 3 · 47e6042f
Hector Chu authored Jul 18, 2011
```
Fixes #2075

R=rsc, ken, r
CC=golang-dev
https://golang.org/cl/4748045
```
47e6042f

runtime: track running goroutine count · bd776191

Russ Cox authored Jul 18, 2011

Used to use mcpu+msyscall but that's
problematic for packing into a single
atomic word.  The running goroutine count
(where running == Go code or syscall)
can be maintained separately, always
manipulated under lock.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4767041

bd776191

runtime: add per-M caches for MemStats · 27753ff1

Dmitriy Vyukov authored Jul 18, 2011

Avoid touching centralized state during
memory manager operations.

R=mirtchovski
CC=golang-dev, rsc
https://golang.org/cl/4766042

27753ff1

runtime: add per-M caches for MemStats · 66d5c9b1

Dmitriy Vyukov authored Jul 18, 2011

Avoid touching centralized state during
memory manager opreations.

R=rsc
CC=golang-dev
https://golang.org/cl/4766042

66d5c9b1

debug/proc: Remove. · 257df171

Ian Lance Taylor authored Jul 18, 2011

The package was always GNU/Linux specific, and is no longer
used by anything now that exp/ogle has been removed.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4757049

257df171

sync: add fast paths to WaitGroup · ee6e1a3f

Dmitriy Vyukov authored Jul 18, 2011

benchmark old ns/op new ns/op delta
BenchmarkWaitGroupUncontended 93.50 33.60 -64.06%
BenchmarkWaitGroupUncontended-2 44.30 16.90 -61.85%
BenchmarkWaitGroupUncontended-4 21.80 8.47 -61.15%
BenchmarkWaitGroupUncontended-8 12.10 4.86 -59.83%
BenchmarkWaitGroupUncontended-16 7.38 3.35 -54.61%
BenchmarkWaitGroupAddDone 58.40 33.70 -42.29%
BenchmarkWaitGroupAddDone-2 293.00 85.80 -70.72%
BenchmarkWaitGroupAddDone-4 243.00 51.10 -78.97%
BenchmarkWaitGroupAddDone-8 236.00 52.20 -77.88%
BenchmarkWaitGroupAddDone-16 215.00 43.30 -79.86%
BenchmarkWaitGroupAddDoneWork 826.00 794.00 -3.87%
BenchmarkWaitGroupAddDoneWork-2 450.00 424.00 -5.78%
BenchmarkWaitGroupAddDoneWork-4 277.00 220.00 -20.58%
BenchmarkWaitGroupAddDoneWork-8 440.00 116.00 -73.64%
BenchmarkWaitGroupAddDoneWork-16 569.00 66.50 -88.31%
BenchmarkWaitGroupWait 29.00 8.04 -72.28%
BenchmarkWaitGroupWait-2 74.10 4.15 -94.40%
BenchmarkWaitGroupWait-4 117.00 2.30 -98.03%
BenchmarkWaitGroupWait-8 111.00 1.31 -98.82%
BenchmarkWaitGroupWait-16 104.00 1.27 -98.78%
BenchmarkWaitGroupWaitWork 802.00 792.00 -1.25%
BenchmarkWaitGroupWaitWork-2 411.00 401.00 -2.43%
BenchmarkWaitGroupWaitWork-4 210.00 199.00 -5.24%
BenchmarkWaitGroupWaitWork-8 206.00 105.00 -49.03%
BenchmarkWaitGroupWaitWork-16 334.00 54.40 -83.71%

R=rsc
CC=golang-dev
https://golang.org/cl/4672050

ee6e1a3f

5l: assume Linux binary, not Plan 9 · 92c6061b
Russ Cox authored Jul 18, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4767042
```
92c6061b

http: let FileServer work when path doesn't begin with a slash · 3745716b

Brad Fitzpatrick authored Jul 18, 2011

... as when it's over-stripped with StripPrefix.

R=golang-dev, andybalholm, rsc
CC=golang-dev
https://golang.org/cl/4759052

3745716b

ld: allow seek within write buffer · caa56474

Russ Cox authored Jul 18, 2011

Reduces number of write+seek's from 88516 to 2080
when linking godoc with 6l.

Thanks to Alex Brainman for pointing out the
many small writes.

R=golang-dev, r, alex.brainman, robert.hencke
CC=golang-dev
https://golang.org/cl/4743043

caa56474

syscall: Parse and encode SCM_RIGHTS and SCM_CREDENTIALS. · 870fdd76
Albert Strasheim authored Jul 18, 2011
```
R=rsc, agl, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4667066
```
870fdd76

runtime: fix data race in Plan9 sysalloc · c1f035ba

Dmitriy Vyukov authored Jul 18, 2011

Add mutex to protect brk limit.
Add mstats.sys update.

R=rsc
CC=golang-dev
https://golang.org/cl/4762045

c1f035ba

cgo: add missing semicolon in generated struct · e8689404

Brad Fitzpatrick authored Jul 18, 2011

This affected certain signatures needing padding
like:

//export Foo
func Foo() (int, C.long) { ... }

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4745047

e8689404

gc: fix silent sign truncation in pgen.c · c945d9c8

Dave Cheney authored Jul 18, 2011

Fixes #2076.

R=golang-dev, r, r, dsymonds, lucio.dere
CC=golang-dev
https://golang.org/cl/4744047

c945d9c8

exp/template: dig into empty interfaces so a struct (say) stored in an empty · 9a5bb287

Rob Pike authored Jul 18, 2011

interface field can be unpacked. We don't have type assertions here so we
must be forthright.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4757047

9a5bb287

doc: fix padding on h1 tags · ab55133c

Andrew Gerrand authored Jul 18, 2011

See /doc/codewalk/sharemem/ for an example of how it's broken.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4742044

ab55133c

path/filepath: fixes for windows paths · 3c4ca95d

Alex Brainman authored Jul 18, 2011

- Clean and IsAbs to handle paths with drive letter properly.
- Clean to replace / with \.

R=golang-dev, adg
CC=golang-dev, mattn.jp
https://golang.org/cl/4758051

3c4ca95d

runtime: fix panic for make(chan [0]byte). · 95323c59

Nigel Tao authored Jul 18, 2011

I suspect that this was introduced by
http://code.google.com/p/go/source/detail?r=6e4ee32fffd1

R=r
CC=golang-dev
https://golang.org/cl/4764045

95323c59

http: drain the pipe output in TestHandlerPanic to avoid logging deadlock. · a8e0035b
David Symonds authored Jul 18, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4756047
```
a8e0035b
fmt: fix a couple of documentation glitches. · 08e47ebb
Rob Pike authored Jul 18, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4758050
```
08e47ebb

reflect: panic if Method index is out of range for a type. · 50d90451

Rob Pike authored Jul 18, 2011

Makes the code agree with the documentation.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4759050

50d90451

5c: attempt to fix build by silencing warnings about unused variables. · 9d55c282

Rob Pike authored Jul 18, 2011

The story is more complicated; this is just a bandaid.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4755047

9d55c282

gob: minor cleanup · cb051a3a
Quan Yong Zhai authored Jul 18, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4754050
```
cb051a3a

fmt: Scan(&int) was mishandling a lone zero. · f189308f

Rob Pike authored Jul 18, 2011

It took it as an octal base prefix but assumed more digits were coming.
Fixes #2077.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4764044

f189308f

17 Jul, 2011 5 commits

cmd/5l/Makefile: directory prefix nit, "../5l/" is not needed. · 8c5c3c50
Lucio De Re authored Jul 17, 2011
```
R=golang-dev, r
CC=golang-dev, rsc
https://golang.org/cl/4755046
```
8c5c3c50
http: make tests quiet, fixing a test race · 8b33c7b5
Brad Fitzpatrick authored Jul 17, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4754044
```
8b33c7b5

log: more locking · 60752069

Brad Fitzpatrick authored Jul 17, 2011

This didn't actually cause a bug, but looks wrong.

There was a lock but there was more shared mutable state not
guarded by it.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4760047

60752069

exp/templates: variable scope persists until "end". · c705701c

Rob Pike authored Jul 17, 2011

The previous CL doicumented and diagnosed the old situation.
This one changes it to something more traditional: any action
may declare a variable, and the block structure of scopes
applies only to control seequences.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4748047

c705701c

exp/template: allow declaration of variables only inside control structures. · 331840f5

Rob Pike authored Jul 17, 2011

In simple pipelines the declaration has no scope.
Also document the scope.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4761044

331840f5

15 Jul, 2011 3 commits

http: fixes for sniffing · e07c6e6e
Russ Cox authored Jul 15, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4753044
```
e07c6e6e

6a, 6c, 6l: fix for Plan 9 build · 4c6280b0

Lucio De Re authored Jul 15, 2011

6a/a.h:
. Dropped <u.h> and <libc.h>.
. Made definition of EOF conditional.

6a/a.y:
. Added <u.h> and <libc.h>.

6a/lex.c:
. Added <u.h> and <libc.h>.
. Dropped <ctype.h> (now in <u.h>).

6c/gc.h:
. Added varargck pragma for "lD".

6c/swt.c:
. Dropped unused "thestring" argument in Bprint() calls.

6l/Makefile:
. Dropped unneeded directory prefix.

6l/l.h:
. Dropped unneeded directory prefix.
. Added varargck pragma for "I" and "i".

6l/obj.c:
. Dropped unneeded assignment.
. Dropped unreachable goto statement.

6l/pass.c:
. Dropped assignments flagged as unused.

6l/prof.c:
. Replaced "#if 0" with "#ifdef NOTDEF".

6l/span.c:
. Dropped unused incrementation.
. Added USED() as required.
. Dropped unreachable "return" statement.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4747044

4c6280b0

5a, 5c, 5l: fix for Plan 9 build · 5ea4d73b

Lucio De Re authored Jul 15, 2011

5a/a.h:
. Removed <u.h> and <lib.h>.
. Made definition of EOF conditional.

5a/a.y:
. Added <u.h> and <lib.h>.

5a/lex.c:
. Added <u.h> and <lib.h>.
. Dropped <ctype.h> (now in <u.h>).

5c/peep.c:
. Removed unnecessary "return 0" statement.

5c/reg.c:
. Added compilation condition around unused code.

5c/swt.c:
. Removed unused "thestring" argument from Bprint() calls.

5l/asm.c:
. Added USED() statements as required.
. Adjusted a few format specifications.
. Added compilation condition around unused code.

5l/l.h:
. Dropped directory prefix from <../5l/5.out.h>.
. Added varargck pragma for "I" and "i".

5l/obj.c:
. Cascaded consecutive "if" statements.
. Dropped unnecessary incrementation and assignments.

5l/pass.c:
. Dropped unnecessary assignment.

5l/prof.c:
. #if 0 converted to #ifdef NOTDEF.

5l/span.c:
. Dropped unnecessary incrementation and assignments.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4752041

5ea4d73b