- 09 Apr, 2010 3 commits
-
-
Alex Brainman authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/872043
-
Russ Cox authored
R=adg CC=golang-dev https://golang.org/cl/867046
-
Russ Cox authored
tested on linux/amd64, linux/386, linux/arm, darwin/amd64, darwin/386. freebsd untested; will finish in a separate CL. for now all the panics are errorStrings. richer structures can be added as necessary once the mechanism is shaked out. R=r CC=golang-dev https://golang.org/cl/906041
-
- 08 Apr, 2010 6 commits
-
-
Russ Cox authored
when garbage collector sees recovering goroutine Fixes #711. R=r CC=golang-dev https://golang.org/cl/869045
-
Russ Cox authored
Could not take a signal on threads other than the main thread. If you look at the spinning binary with dtrace, you can see a fault happening over and over: $ dtrace -n ' fbt::user_trap:entry /execname=="boot32" && self->count < 10/ { self->count++; printf("%s %x %x %x %x", probefunc, arg1, arg2, arg3, arg4); stack(); tracemem(arg4, 256); }' dtrace: description 'fbt::user_trap:entry ' matched 1 probe CPU ID FUNCTION:NAME 1 17015 user_trap:entry user_trap 0 10 79af0a0 79af0a0 mach_kernel`lo_alltraps+0x12a 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 0: 0e 00 00 00 37 00 00 00 00 00 00 00 1f 00 00 00 ....7........... 10: 1f 00 00 00 a8 33 00 00 00 00 00 01 00 00 00 00 .....3.......... 20: 98 ba dc fe 07 09 00 00 00 00 00 00 98 ba dc fe ................ 30: 06 00 00 00 0d 00 00 00 34 00 00 00 9e 1c 00 00 ........4....... 40: 17 00 00 00 00 02 00 00 ac 30 00 00 1f 00 00 00 .........0...... 50: 00 00 00 00 00 00 00 00 0d 00 00 00 e0 e6 29 00 ..............). 60: 34 00 00 00 00 00 00 00 9e 1c 00 00 00 00 00 00 4............... 70: 17 00 00 00 00 00 00 00 00 02 00 00 00 00 00 00 ................ 80: ac 30 00 00 00 00 00 00 1f 00 00 00 00 00 00 00 .0.............. 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ a0: 48 00 00 00 10 00 00 00 85 00 00 00 a0 f2 29 00 H.............). b0: 69 01 00 02 00 00 00 00 e6 93 04 82 ff 7f 00 00 i............... c0: 2f 00 00 00 00 00 00 00 06 02 00 00 00 00 00 00 /............... d0: 78 ee 42 01 01 00 00 00 1f 00 00 00 00 00 00 00 x.B............. e0: 00 ed 9a 07 00 00 00 00 00 00 00 00 00 00 00 00 ................ f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ ... The memory dump shows a 32-bit exception frame: x86_saved_state32 gs = 0x37 fs = 0 es = 0x1f ds = 0x1f edi = 0x33a8 esi = 0x01000000 ebp = 0 cr2 = 0xfedcba98 ebx = 0x0907 edx = 0 ecx = 0xfedcba98 eax = 0x06 trapno = 0x0d err = 0x34 eip = 0x1c9e cs = 0x17 efl = 0x0200 uesp = 0x30ac ss = 0x1f The cr2 of 0xfedcba98 is the address that the new thread read to cause the fault, but note that the trap is now a GP fault with error code 0x34, meaning it's moved past the cr2 problem and on to an invaild segment selector. The 0x34 is suspiciously similar to the 0x37 in gs, and sure enough, OS X forces gs to have that value in the signal handler, and if your thread hasn't set up that segment (known as USER_CTHREAD), you'll fault on the IRET into the signal handler and never be able to handle a signal. The kernel bug is that it forces segment 0x37 without making sure it is a valid segment. Leopard also forced 0x37 but had the courtesy to set it up first. Since OS X requires us to set up that segment (using the thread_fast_set_cthread_self system call), we might as well use it instead of the more complicated i386_set_ldt call to set up our per-OS thread storage. Also add some more zeros to bsdthread_register for new arguments in Snow Leopard (apparently unnecessary, but being careful). Fixes #510. R=r CC=golang-dev https://golang.org/cl/824046
-
Charles L. Dorian authored
Added Signbit(), revised Copysign() R=rsc CC=golang-dev https://golang.org/cl/822045
-
Russ Cox authored
Avoids spurious wakeups during other sleeping by that goroutine. Fixes #711. R=r CC=golang-dev https://golang.org/cl/902041
-
Rob Pike authored
Fixes #677. R=rsc CC=golang-dev https://golang.org/cl/834046
-
Joe Poirier authored
R=rsc, adg CC=golang-dev https://golang.org/cl/881047
-
- 07 Apr, 2010 5 commits
-
-
Rob Pike authored
R=iant CC=golang-dev https://golang.org/cl/874043
-
Rob Pike authored
R=rsc, iant CC=golang-dev https://golang.org/cl/824045
-
Russ Cox authored
TBR=kaib CC=golang-dev https://golang.org/cl/897041
-
Russ Cox authored
TBR=kaib CC=golang-dev https://golang.org/cl/883046
-
Ken Thompson authored
channel recv data. R=rsc CC=golang-dev https://golang.org/cl/896041
-
- 06 Apr, 2010 18 commits
-
-
Ken Thompson authored
data just read from the channel. this will make it easier to recognize when to garbage collect and finalize. R=rsc CC=golang-dev https://golang.org/cl/882043
-
Russ Cox authored
The cycle is *netFD -> cw chanl *netFD in struct -> same *netFD in channel read buffer. Because channels are finalized, the cycle makes them uncollectable. A better fix is to make channels not finalized anymore, and that will happen, but this is an easy, reasonable workaround until then. Another good fix would be to zero the channel receive buffer entry after the receive. That too will happen. R=r CC=golang-dev https://golang.org/cl/875043
-
Rob Pike authored
R=rsc CC=golang-dev https://golang.org/cl/864044
-
Russ Cox authored
1. Fix bug in GOMAXPROCS when trying to cut number of procs Race could happen on any system but was manifesting only on Xen hosted Linux. 2. Fix recover on ARM, where FP != caller SP. R=r CC=golang-dev https://golang.org/cl/880043
-
Roger Peppe authored
Instead of calling the package scope Lex function, Parse now takes an argument which is used to do the lexing. I reverted to having the generated switch code inside Parse rather than a separate function because the function needs 7 arguments or a context structure, which seems unnecessary. I used yyrun(), not the original $A so that it's possible to run the backquoted code through gofmt. R=rsc, ken2, ken3 CC=golang-dev https://golang.org/cl/879041
-
Kai Backman authored
to float instructions work correctly. R=rsc CC=golang-dev https://golang.org/cl/870044
-
Rob Pike authored
also: add /dev/null to the ls args to repair handling of empty dependency lists. R=rsc CC=golang-dev https://golang.org/cl/883045
-
Giles Lean authored
This is a documentation enhancement only, without any code change. The rationale for documenting this precisely is that Unix programmers who "know" that errno's value is undefined after a successful system call may be surprised otherwise and search to be sure that a zero errno may be relied upon after successful calls. R=r, rsc1, rsc CC=golang-dev https://golang.org/cl/812044
-
Ian Lance Taylor authored
R=rsc, r CC=golang-dev https://golang.org/cl/810043
-
Joe Poirier authored
R=rsc CC=golang-dev https://golang.org/cl/812041
-
Russ Cox authored
R=gri CC=golang-dev https://golang.org/cl/867044
-
Russ Cox authored
log: add test of Caller New regexp in log test is picky and will require some maintenance, but it catches off-by-one mistakes too. Fixes #710. R=gri CC=esko.luontola, golang-dev https://golang.org/cl/887043
-
Russ Cox authored
R=adg CC=golang-dev https://golang.org/cl/813043
-
Kyle Consalus authored
R=rsc CC=golang-dev https://golang.org/cl/881042
-
Charles L. Dorian authored
Complex math function package. Still needs more special case checking. R=rsc CC=golang-dev https://golang.org/cl/874041
-
Russ Cox authored
R=iant CC=golang-dev https://golang.org/cl/862042
-
David Symonds authored
R=adg CC=golang-dev https://golang.org/cl/893041
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/821048
-
- 05 Apr, 2010 6 commits
-
-
Russ Cox authored
R=agl1 CC=golang-dev https://golang.org/cl/851041
-
Russ Cox authored
* correct symbol table size * do not reorder functions in output * traceback * signal handling * use same code for go + defer * handle leaf functions in symbol table R=kaib, dpx CC=golang-dev https://golang.org/cl/884041
-
Andrew Gerrand authored
Adding this question on Russ' recommendation - not sure if there is some detail here I'm missing. The associated discussion was: http://groups.google.com/group/golang-nuts/t/ec6b27e332ed7f77 R=rsc, r CC=golang-dev https://golang.org/cl/887042
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/855044
-
Conrad Meyer authored
R=rsc, rsc1 CC=golang-dev https://golang.org/cl/808041
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/881044
-
- 04 Apr, 2010 1 commit
-
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/844044
-
- 02 Apr, 2010 1 commit
-
-
Robert Griesemer authored
R=rsc CC=golang-dev https://golang.org/cl/829044
-