Commits · a1dbfa6f09d2463f421eaa91ee06e15848df7ba0 · go / golang

17 Nov, 2011 4 commits

Andrew Balholm authored Nov 17, 2011

Pass tests2.dat, test 42:
<isindex test=x name=x>

| <html>
|   <head>
|   <body>
|     <form>
|       <hr>
|       <label>
|         "This is a searchable index. Enter search keywords: "
|         <input>
|           name="isindex"
|           test="x"
|       <hr>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5399049

a1dbfa6f

http: fix serving from CWD with http.ServeFile · 0b1bcf8f

Andrew Gerrand authored Nov 17, 2011

http: make Dir("") equivalent to Dir(".")

Fixes #2471.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5370061

0b1bcf8f

exp/ssh: change test listen address, also exit test if fails · 3ec82f6e
Alex Brainman authored Nov 17, 2011
```
R=golang-dev, rsc
CC=dave, golang-dev
https://golang.org/cl/5364061
```
3ec82f6e

reflect: make Value an opaque struct · a479a455

Russ Cox authored Nov 17, 2011

Making Value opaque means we can drop the interface kludges
in favor of a significantly simpler and faster representation.
v.Kind() will be a prime candidate for inlining too.

On a Thinkpad X201s using -benchtime 10:

benchmark                           old ns/op    new ns/op    delta
json.BenchmarkCodeEncoder           284391780    157415960  -44.65%
json.BenchmarkCodeMarshal           286979140    158992020  -44.60%
json.BenchmarkCodeDecoder           717175800    388288220  -45.86%
json.BenchmarkCodeUnmarshal         734470500    404548520  -44.92%
json.BenchmarkCodeUnmarshalReuse    707172280    385258720  -45.52%
json.BenchmarkSkipValue              24630036     18557062  -24.66%

benchmark                            old MB/s     new MB/s  speedup
json.BenchmarkCodeEncoder                6.82        12.33    1.81x
json.BenchmarkCodeMarshal                6.76        12.20    1.80x
json.BenchmarkCodeDecoder                2.71         5.00    1.85x
json.BenchmarkCodeUnmarshal              2.64         4.80    1.82x
json.BenchmarkCodeUnmarshalReuse         2.74         5.04    1.84x
json.BenchmarkSkipValue                 77.92       103.42    1.33x

I cannot explain why BenchmarkSkipValue gets faster.
Maybe it is one of those code alignment things.

R=iant, r, gri, r
CC=golang-dev
https://golang.org/cl/5373101

a479a455

16 Nov, 2011 16 commits

gofmt: do not stop test.sh after 1 error · 4d27f648

Russ Cox authored Nov 16, 2011

Fix bug377.go to be gofmt-compliant.

R=gri, r, r
CC=golang-dev
https://golang.org/cl/5400045

4d27f648

html: parse </optgroup> and </option> · 3276afd4

Andrew Balholm authored Nov 16, 2011

Pass tests2.dat, test 35:
<!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <select>
|       <optgroup>
|         <option>
|       <option>
|     <option>

Also pass tests through test 41:
<!DOCTYPE html><!-- XXX - XXX - XXX -->

R=nigeltao, rsc
CC=golang-dev
https://golang.org/cl/5395045

3276afd4

exp/ssh: fix test? · 8c6461bc

Russ Cox authored Nov 16, 2011

Fixes use of c after Dial failure (causes crash).
May fix Dial failure by listening to 127.0.0.1:0
instead of 0.0.0.0:0 (tests should only listen on
localhost).

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5395052

8c6461bc

go/printer: make //line formatting idempotent · 7d1d8fe4

Russ Cox authored Nov 16, 2011

Fixes "test.sh" (long test) in src/cmd/gofmt.

R=gri
CC=golang-dev
https://golang.org/cl/5307081

7d1d8fe4

syscall, os, time: fix Plan 9 build · 087a3486
Lucio De Re authored Nov 16, 2011
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5371092
```
087a3486
exp/ssh: add to pkg Makefile · 8fdd6c05
Christopher Wedgwood authored Nov 16, 2011
```
R=rsc, dave
CC=golang-dev
https://golang.org/cl/5399045
```
8fdd6c05

gc: support for building with Plan 9 yacc · 920df48f

Anthony Martin authored Nov 16, 2011

I've modified Plan 9's yacc to work with
the grammar in go.y.  These are the only
changes necessary on the Go side.

R=rsc
CC=golang-dev
https://golang.org/cl/5375104

920df48f

go/ast: remove unused receiver names (cleanup) · d0b9a84a
Robert Griesemer authored Nov 16, 2011
```
R=iant, iant
CC=golang-dev
https://golang.org/cl/5393047
```
d0b9a84a
cov: fix for Plan 9 build · 293059ad
Lucio De Re authored Nov 16, 2011
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5374086
```
293059ad

net/http: fix EOF handling on response body · c9355596

Gustavo Niemeyer authored Nov 16, 2011

http.Response is currently returning 0, nil on EOF.

R=golang-dev, bradfitz, bradfitz
CC=golang-dev
https://golang.org/cl/5394047

c9355596

fcgi: fix server capability discovery · 881f2076

Brad Fitzpatrick authored Nov 16, 2011

The wrong length was being sent, and two parameters
were also transposed. Made the record type be a type
and made the constants typed, to prevent that sort
of bug in the future.

Fixes #2469

R=golang-dev, edsrzf
CC=golang-dev
https://golang.org/cl/5394046

881f2076

html/template: indirect top-level values before printing · f5db4d05

Rob Pike authored Nov 16, 2011

text/template does this (in an entirely different way), so
make html/template do the same. Before this fix, the template
{{.}} given a pointer to a string prints its address instead of its
value.

R=mikesamuel, r
CC=golang-dev
https://golang.org/cl/5370098

f5db4d05

exp/ssh: fix unmarshal test · 00f9b768

Dave Cheney authored Nov 16, 2011

Ensure that empty NameLists always return
a zero length []string, not nil.

In practice NameLists are only used in a few
message types and always consumed by a for
range function so the difference between nil
and []string{} is not significant.

Also, add exp/ssh to pkg/Makefile as suggested
by rsc.

R=rsc, agl
CC=golang-dev
https://golang.org/cl/5400042

00f9b768

html: parse <optgroup> tags · 33075970

Andrew Balholm authored Nov 16, 2011

Pass tests2.dat, test 34:
<!DOCTYPE html><select><option><optgroup>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <select>
|       <option>
|       <optgroup>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5393045

33075970

html: parse <caption> elements · 28546ed5

Andrew Balholm authored Nov 16, 2011

Pass tests2.dat, test 33:
<!DOCTYPE html><table><caption>test TEST</caption><td>test

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <caption>
|         "test TEST"
|       <tbody>
|         <tr>
|           <td>
|             "test"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5371099

28546ed5

exp/sql: NumInput() allow -1 to ignore checking. · 5e5c5c27

Yasuhiro Matsumoto authored Nov 16, 2011

Some database driver can't get number of parameters.
For example:
        http://support.microsoft.com/kb/240205/en-us
So, added way to ignore checking number of parameters with return -1.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5376091

5e5c5c27

15 Nov, 2011 19 commits

sql: document that for drivers, io.EOF means no more rows · 5b7827ec

Brad Fitzpatrick authored Nov 15, 2011

This was used in the sql package + tests, but never
documented.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5372107

5b7827ec

net, syscall: add missing copyright notices · 471e43cf
Mikio Hara authored Nov 15, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5375099
```
471e43cf