Commits · a1f340fa1a26fd29f1369cbc91755e7519813dd0 · go / golang

27 Jul, 2012 3 commits

exp/html: parse CDATA sections in foreign content · a1f340fa

Andrew Balholm authored Jul 27, 2012

Also convert NUL to U+FFFD in comments.

Pass 23 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6446055

a1f340fa

runtime: ignore signal 33 == SIGSETXID on GNU/Linux · b9e051e8

Ian Lance Taylor authored Jul 27, 2012

When a cgo program calls setuid, setgid, etc., the GNU/Linux
pthread library sends signal SIGSETXID to each thread to tell
it to update its UID info.  If Go is permitted to intercept
the default SIGSETXID signal handler, the program will hang.

This patch tells the runtime package to not try to intercept
SIGSETXID on GNU/Linux.  This will be odd if a Go program
wants to try to use that signal, but it means that cgo
programs that call setuid, etc., won't hang.

Fixes #3871.

R=rsc, r, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/6455050

b9e051e8

go/printer: don't crash if ast.FuncType.Params is nil · a7c74d52

Robert Griesemer authored Jul 27, 2012

The go/ast comment for FuncType.Params says that the field may be nil.
Make sure the printer accepts such a value. The go/parser always sets
the field (to provide parenthesis position information), but a program
creating a Go AST from scatch may not.

Added corresponding test case.

Fixes #3870.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6448060

a7c74d52

26 Jul, 2012 4 commits

exp/html: replace NUL bytes in plaintext, raw text, and RCDATA · 55f0c8b2

Andrew Balholm authored Jul 26, 2012

If NUL bytes occur inside certain elements, convert them to U+FFFD
replacement character.

Pass 1 additional test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6452047

55f0c8b2

exp/types: process ast.Fun in checkObj; fix variadic function building · d399b681

Andrew Wilkins authored Jul 26, 2012

Fixed creation of Func's, taking IsVariadic from parameter list rather
than results.

Updated checkObj to process ast.Fun objects.

R=gri
CC=golang-dev
https://golang.org/cl/6402046

d399b681

A+C: added Andrew Wilkins (individual contributor) · fda29b6a
Robert Griesemer authored Jul 26, 2012
```
R=rsc, minux.ma, iant
CC=golang-dev
https://golang.org/cl/6447050
```
fda29b6a
exp/html: don't insert empty text nodes · 899be509
Andrew Balholm authored Jul 26, 2012
```
Pass 1 additional test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6443048
```
899be509

25 Jul, 2012 4 commits

cgo: fix declarations in _cgo_export.c · 24ae7e68

Ian Lance Taylor authored Jul 25, 2012

Declare crosscall2.  Declare the functions passed to it as
returning void, rather than relying on implicit return type.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6432060

24ae7e68

cmd/godoc: delete -path flag · fba47dc3

Dave Cheney authored Jul 25, 2012

Fixes #3453.

R=golang-dev, gri, jeff, bradfitz
CC=golang-dev
https://golang.org/cl/6350086

fba47dc3

testing: allow concurrent use of T and B · 9b141270

Brad Fitzpatrick authored Jul 25, 2012

Notably, allow concurrent logging and failing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6453045

9b141270

exp/html: allow frameset if body contains whitespace · 4d225196

Andrew Balholm authored Jul 25, 2012

If the body of an HTML document contains text, the <frameset> tag is
ignored. But not if the text is only whitespace.

Pass 4 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6442043

4d225196

24 Jul, 2012 2 commits
- encoding/gob: test for type registration name. · 3e980e24
  David Symonds authored Jul 24, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6435044
```
  3e980e24
- net: fix comment · c1f2ec38
  Mikio Hara authored Jul 24, 2012
```
RemoteAddr returns not only UDPAddr but IPAddr.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/6401054
```
  c1f2ec38
23 Jul, 2012 4 commits

text/template: fix bug in map indexing · ce274339

Rob Pike authored Jul 23, 2012

If the key is not present, return value of the type of the element
not the type of the key. Also fix a test that should have caught this case.

Fixes #3850.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6405078

ce274339

encoding/gob: revert 6348067, which broke compatibility · 7b73251d

Rob Pike authored Jul 23, 2012

Add commentary to explain better what's going on, but the
code change is a simple one-line reversal to the previous
form.

R=rsc
CC=golang-dev
https://golang.org/cl/6428072

7b73251d

misc/dashboard/codereview: add admin-only link to force-update a CL. · a8ce9ab4
David Symonds authored Jul 23, 2012
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/6431055
```
a8ce9ab4

exp/html: special handling for entities in attributes · f979528c

Andrew Balholm authored Jul 23, 2012

Don't unescape entities in attributes when they don't end with
a semicolon and they are followed by '=', a letter, or a digit.

Pass 6 more tests from the WebKit test suite, plus one that was
commented out in token_test.go.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6405073

f979528c

22 Jul, 2012 2 commits
- doc: add two I/O talks to "Talks" section · 4087c1b8
  Andrew Gerrand authored Jul 22, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6422056
```
  4087c1b8
- encoding/binary: fix typo: ReadVarint returns an int64, not a uint64. · 614cb3b8
  Patrick Mylund Nielsen authored Jul 22, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6432062
```
  614cb3b8
21 Jul, 2012 2 commits
- net: remove unnecessary newline in testing.Logf from tests · 3a112a81
  Mikio Hara authored Jul 21, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6434043
```
  3a112a81
- net: fix file descriptor leak on FileListener, FileConn and FilePacketConn · d380a977
  Mikio Hara authored Jul 21, 2012
```
R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6430062
```
  d380a977
20 Jul, 2012 2 commits
- cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath · b575a981
  Ian Lance Taylor authored Jul 20, 2012
```
R=golang-dev, r, iant
CC=golang-dev
https://golang.org/cl/6416056
```
  b575a981
- bytes: make Join return a new buffer on len(a) == 1 · c0efcac6
  Gustavo Niemeyer authored Jul 20, 2012
```
Fixes #3844.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6432054
```
  c0efcac6
19 Jul, 2012 3 commits

net: fix typo · 7bf8355d

Mikio Hara authored Jul 19, 2012

R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/6428050

7bf8355d

unicode/utf8: reject out-of-range runes. · fc360f23

Rob Pike authored Jul 19, 2012

Surrogates are still admitted, but I have sent mail to golang-dev on that topic.

Fixes #3785.

R=golang-dev, rogpeppe, iant
CC=golang-dev
https://golang.org/cl/6398049

fc360f23

sync: mention that WaitGroup.Add panics · 55ff3f70
Rob Pike authored Jul 19, 2012
```
Fixes #3839.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6428053
```
55ff3f70

18 Jul, 2012 1 commit

net/http: revert back to (and test) Go 1 CheckRedirect behavior · dfd7f181

Brad Fitzpatrick authored Jul 18, 2012

If a Client's CheckRedirect function returns an error, we
again return both a non-nil *Response and a non-nil error.

Fixes #3795

R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/6429044

dfd7f181

17 Jul, 2012 1 commit
- testing: fix memory blowup when formatting many lines. · dd78f745
  Rémy Oudompheng authored Jul 17, 2012
```
Fixes #3830.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6373047
```
  dd78f745
16 Jul, 2012 4 commits

cmd/vet: provide flags to control which tests to run · f49b7b0a

Rob Pike authored Jul 16, 2012

By default, all are still run, but a particular test can be
selected with the new flags.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6395053

f49b7b0a

faq: add status section · 8de5080f

Rob Pike authored Jul 16, 2012

Fixes #3822.

R=golang-dev, r, dsymonds, minux.ma, adg
CC=golang-dev
https://golang.org/cl/6395043

8de5080f

A+C: Peter Armitage (individual CLA) · 36d78305
Adam Langley authored Jul 16, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6392065
```
36d78305
compress/flate: fix panic when nlit is out of bounds. · da4eef40
Nigel Tao authored Jul 16, 2012
```
Fixes #3815.

R=r
CC=golang-dev
https://golang.org/cl/6352109
```
da4eef40

15 Jul, 2012 1 commit
- os: add missing full stop in comment · e7261978
  Benny Siegert authored Jul 15, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6399047
```
  e7261978
14 Jul, 2012 2 commits

build: revert 61d1d72136f7 (add few tests with GOMAXPROCS=32) · d5c2154c
Dmitriy Vyukov authored Jul 14, 2012
```
Some tests currently fail with GOMAXPROCS>1

R=golang-dev
CC=golang-dev
https://golang.org/cl/6398044
```
d5c2154c

build: add few tests with GOMAXPROCS=32 to run.bash · 8c777066

Dmitriy Vyukov authored Jul 14, 2012

Some class of bugs (data races, runtime bugs) can be found
only with real parallelism.
Note that GOMAXPROCS=32 is somewhat different from go test -cpu=32,
this intentionally uses GOMAXPROCS to stress program bootstrap,
testing code, garbage collections, etc.
Package selection is mostly random.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6346070

8c777066

13 Jul, 2012 5 commits

encoding/gob: disable fuzz tests unless command-line flag is set · bbe60178

Rob Pike authored Jul 13, 2012

They can generate huge amounts of memory, causing failure on
small machines. Also they can be very slow. So slow that one test
was commented out! We uncomment it and use a flag.

Fixes #3742.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6373044

bbe60178

exp/locale/collate: This CL includes the following changes: · 882b6ef4

Marcel van Lohuizen authored Jul 13, 2012

- Changed the representation of colElem to support a few cases
  for some languages not supported by the current format.
- Changed offsets for implicit primary values. This makes the
  values both easier to read and debug (last 4 nibbles are identical to
  implicit primary value) and also results in better packing.
- Fixed bug in weight conversion code that did not pop up yet by
  sheer luck.
Note that tables.go also includes changes to the contraction trie
from CL 6346092.

R=r, mpvl
CC=golang-dev
https://golang.org/cl/6392060

882b6ef4

exp/locale/collate: adjusted contraction trie to support Myanmar (Burmese), · adc19ac5

Marcel van Lohuizen authored Jul 13, 2012

which has a rather large contraction table. The value of the next state
offset now starts after the current block, instead of before.  This is
slightly less efficient (on extra addition per state change), but gives
some extra range for the offsets.
Also introduced constants for final (0) and noIndex (0xFF).
tables.go is updated in a separate CL.

R=r
CC=golang-dev
https://golang.org/cl/6346092

adc19ac5

cmd/gc: reject use of ... with multiple-valued expressions. · 656b192c
Rémy Oudompheng authored Jul 13, 2012
```
Fixes #3334.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6350103
```
656b192c

encoding/gob: reduce decoder memory · 37519d95

Rob Pike authored Jul 13, 2012

Gob decoding reads a whole message into memory and then
copies it into a bytes.Buffer. For large messages this wastes
an entire copy of the message. In this CL, we use a staging
buffer to avoid the large temporary.

Update #2539
RSS drops to 775MB from 1GB.
Active memory drops to 858317048 from 1027878136,
essentially the size of one copy of the input file.

R=dsymonds, nigeltao
CC=golang-dev
https://golang.org/cl/6392057

37519d95