Commits · a3382315269db849edd2df068f78b59168c3b32f · go / golang

15 Nov, 2009 12 commits

gc: five bug fixes, one better error. · a3382315

Russ Cox authored Nov 15, 2009

* check for struct literal assignment to private fields.
* record, fix crash involving parallel map assignment.
* avoid infinite recursion in exportassignok.
* make floating point bounds check precise.
* avoid crash on invalid receiver.

* add context to error about implicit assignment.

Fixes #86.
Fixes #88.
Fixes #158.
Fixes #174.
Fixes #201.
Fixes #204.

R=ken2
https://golang.org/cl/154144

a3382315

http.URLEscape: escape all bytes required by RFC 2396 · a967f57d
Russ Cox authored Nov 15, 2009
```
Fixes #125.

R=r
https://golang.org/cl/154143
```
a967f57d
gotest: show the test file pattern in "no test files" error · 2a6bb2c6
Russ Cox authored Nov 15, 2009
```
Fixes #190.

R=r
https://golang.org/cl/154142
```
2a6bb2c6
fix some typos in the documentation · 029c39f4
Rob Pike authored Nov 15, 2009
```
Fixes #196.

R=rsc
https://golang.org/cl/154152
```
029c39f4
fix bug in bytes.Map and add test cases for Map in both strings and bytes packages. · 27779dd6
Rob Pike authored Nov 15, 2009
```
thanks to ulrik.sverdrup for the test case.

Fixes #191.

R=rsc
CC=golang-dev
https://golang.org/cl/155056
```
27779dd6
Use // to start comment instead of #. · 13ad5d40
Robert Griesemer authored Nov 15, 2009
```
Fixes #189.

R=r
CC=rsc
https://golang.org/cl/155055
```
13ad5d40
cc: drop redundant strcpy · b18bee94
Russ Cox authored Nov 15, 2009
```
Fixes #192.

R=ken2
https://golang.org/cl/155047
```
b18bee94

cc: eliminate two fixed-size buffers · 139a0537

Russ Cox authored Nov 15, 2009

Fixes bug 168.
Alternative to https://golang.org/cl/152143.

R=ken2
https://golang.org/cl/155042

139a0537

complain if GOARCH != arm. fix build break caused by gomake · 529216fa
Kai Backman authored Nov 15, 2009
```
introduction.

R=rsc
https://golang.org/cl/152109
```
529216fa

crypto/rsa: handle the case of non-coprime blinds. · ad05d291

Adam Langley authored Nov 15, 2009

We are dealing with the multiplicative group ℤ/pqℤ. Multiples of
either p or q are not members of the group since they cannot have an
inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.)

With p and q of typical size (> 512 bits), the probability of a random
blind [1..pq-1] being a multiple of p or q is negligible. However, in
the unit tests, much smaller sizes are used and the event could occur.

This change checks the result of the ext GCD and deals with this case.

It also increases the size of p and q in the unit test as a large
number of the keys selected were p, q = 227,169.

R=rsc
CC=golang-dev
https://golang.org/cl/154141

ad05d291

make arm pass match what's working on real hardware · 8e5854ae
Kai Backman authored Nov 15, 2009
```
R=rsc
https://golang.org/cl/154097
```
8e5854ae
test/interface/receiver.go: expand to do dynamic · 98811f41
Russ Cox authored Nov 15, 2009
```
	versions of static checks in receiver1.go

R=r
https://golang.org/cl/155045
```
98811f41

14 Nov, 2009 13 commits
- Build changes to support work on the BSDs. · 553be842
  Devon H. O'Dell authored Nov 14, 2009
```
This does still contain some FreeBSD-specific bits, but
it's a pain to do partial diffs.

R=rsc
https://golang.org/cl/152138
```
  553be842
- Adding myself to AUTHORS/CONTRIBUTORS for Go. · 96bcdff6
  Devon H. O'Dell authored Nov 14, 2009
```
R=rsc
https://golang.org/cl/155041
```
  96bcdff6
- encoding/binary: implemented the Write function · a54684f8
  Môshe van der Sterre authored Nov 14, 2009
```
The ByteOrder.Put* methods are already available, this change uses
them to implement the Write function.

R=golang-dev, agl1, rsc, r
https://golang.org/cl/152141
```
  a54684f8
- Adding my name to CONTRIBUTORS and AUTHORS · a09997c3
  Môshe van der Sterre authored Nov 14, 2009
```
As Adam Langley mentioned, this should go in with
https://golang.org/cl/152141

R=rsc
CC=agl1
https://golang.org/cl/154138
```
  a09997c3
- gc: do not try to constant-evaluate (interface{})("bar") · 4b13d1b9
  Russ Cox authored Nov 14, 2009
```
Fixes #183.

R=ken
https://golang.org/cl/154139
```
  4b13d1b9
- move evaluation of null-matching instructions one iteration earlier. · 0263103a
  Rob Pike authored Nov 14, 2009
```
performance hit of about 20% but more intuitive results for submatches.
we need a good regexp package at some point.

Fixes #110.

R=rsc
CC=golang-dev
https://golang.org/cl/152131
```
  0263103a
- xml: Fixed CDATA parsing. · bad9738b
  Abhinav Gupta authored Nov 14, 2009
```
    Fixes #128.

R=r, rsc
https://golang.org/cl/154126
```
  bad9738b
- Added self to AUTHORS and CONTRIBUTORS. · 14a4ece9
  Abhinav Gupta authored Nov 14, 2009
```
R=rsc
https://golang.org/cl/154128
```
  14a4ece9
- typos · 933d1850
  Russ Cox authored Nov 14, 2009
```
Fixes #171.
Fixes #172.

R=agl1
https://golang.org/cl/154136
```
  933d1850
- Created new Conn.Flush() public method so the fd pipeline can be drained arbitrarily by the user. · aebae257
  David Titarenco authored Nov 14, 2009
```
Commented both flush methods so people know what they are looking at.

This is a necessary fix for streaming and long polling HTTP services.
Fixes #93.

R=r, rsc, david.titarenco
https://golang.org/cl/154099
```
  aebae257
- Added self to AUTHORS and CONTRIBUTORS prior to first submission. · 1eef6b0d
  David Titarenco authored Nov 14, 2009
```
R=rsc
https://golang.org/cl/153057
```
  1eef6b0d
- Remove unnecessary int(h) casts in image.go. · 75829b3c
  Nigel Tao authored Nov 14, 2009
```
R=rsc
https://golang.org/cl/154125
```
  75829b3c
- fix typo · 8f478901
  Rob Pike authored Nov 14, 2009
```
R=rsc
https://golang.org/cl/152128
```
  8f478901
13 Nov, 2009 15 commits

Correct indentation for go-mode where a close brace following a semi- · 95be81da
James Aguilar authored Nov 13, 2009
```
colon-less statement would be indented one stop too many.

R=rsc, aclements
CC=aclements
https://golang.org/cl/154096
```
95be81da
Add myself to the contributors file. · a01839fb
James Aguilar authored Nov 13, 2009
```
R=rsc
https://golang.org/cl/152101
```
a01839fb

json: minor comment fix. · a0707223

Adam Langley authored Nov 13, 2009

I screwed up and didn't write one of the code review changes to disk
before submitting.

TBR=rsc

R=rsc
https://golang.org/cl/154122

a0707223

Explain why · f9919ba3

Rob Pike authored Nov 13, 2009

	-flag true
does not work although
	-flag=true
does.

Fixes #139.

R=iant
CC=golang-dev
https://golang.org/cl/154118

f9919ba3

test/run: use bash, not sh. · 662ee870

Russ Cox authored Nov 13, 2009

use bash builtin time instead of
assuming /usr/bin/time exists.

R=r
https://golang.org/cl/152124

662ee870

json: allow one to unmarshal a top-level JSON array. · bccc3370
Adam Langley authored Nov 13, 2009
```
Fixies issue 114.

R=rsc
CC=golang-dev
https://golang.org/cl/154121
```
bccc3370

path.TestWalk: disable error case if root · e7b8f5fa

Russ Cox authored Nov 13, 2009

(chmod 0 doesn't cause errors for root)

Fixes #22.

R=gri
https://golang.org/cl/152120

e7b8f5fa

json: fix addressing of slice indexes that are multiples of 8. · 87bc9b53
Adam Langley authored Nov 13, 2009
```
Fixes #147.

R=rsc
CC=golang-dev
https://golang.org/cl/152123
```
87bc9b53

runtime: warn about SELinux based mmap failures on Linux. · 3f7a3240

Adam Langley authored Nov 13, 2009

SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.

This patch prints a warning on Linux when mmap fails with EACCES.

R=rsc
CC=golang-dev
https://golang.org/cl/152086

3f7a3240

yet another attempt to avoid conflicts with · 593ccd1d
Russ Cox authored Nov 13, 2009
```
<stdio.h>, which we weren't even #including

R=r
https://golang.org/cl/154108
```
593ccd1d
remove dead code from test · 845276ae
Rob Pike authored Nov 13, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/152118
```
845276ae
sudo.bash tries to install acid and db, which don't exist any more · 00093011
Rob Pike authored Nov 13, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/152117
```
00093011
Teach emacs M-x gofmt to save region/restrictions · 6c2ae1a6
Kevin Ballard authored Nov 13, 2009
```
R=agl, agl1
https://golang.org/cl/152078
```
6c2ae1a6
codereview: clpatch tweaks · 780dbdc0
Russ Cox authored Nov 13, 2009
```
R=agl1
https://golang.org/cl/152114
```
780dbdc0

Remove -align flag from gofmt. · 511772c8

Robert Griesemer authored Nov 13, 2009

(Making it work correctly with -spaces is a bit of work and the output
won't make much sense as it is intended as input to tabwriter.)
Fixes #100.

R=rsc
https://golang.org/cl/154102

511772c8