- 08 Feb, 2015 4 commits
-
-
Brad Fitzpatrick authored
Reverts https://golang.org/cl/119530044 (OS X 10.10 Yosemite beta 14A299l workaround), since it was fixed in the final Yosemite release. I verified that the C program http://swtch.com/~rsc/readdirbug.c passes on Yosemite. Adds a new test to the os package too, to verify that reading a regular file as a directory fails. Fixes #9789 (ReadDir: no error if dirname is a file) Change-Id: I75286cef88fbb2ebccf045b479e33c810749dcbc Reviewed-on: https://go-review.googlesource.com/4164Reviewed-by:
Dave Cheney <dave@cheney.net>
-
David Symonds authored
This reverts commit 11d1c05f. See #9296 for details. Change-Id: I89a36351cb007836662f28a611af5616818b95fe Reviewed-on: https://go-review.googlesource.com/1536Reviewed-by:
Minux Ma <minux@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
mattyw authored
Change-Id: If697ab554e6cb5545d99c6b103ed8bc54f69ed48 Reviewed-on: https://go-review.googlesource.com/4161Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Shenghou Ma authored
Fixes build for solaris. Change-Id: Ic6ffab36df9bd68fc38b258f1484a29fa2a0cd39 Reviewed-on: https://go-review.googlesource.com/4180Reviewed-by:
Aram Hăvărneanu <aram@mgk.ro>
-
- 07 Feb, 2015 5 commits
-
-
Brad Fitzpatrick authored
Fixes #9776 Change-Id: I53741fd970244bbfa6874adcb4f1e3d0e7de386b Reviewed-on: https://go-review.googlesource.com/4162Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Brian Smith authored
Before, an array of size 4 would always be allocated even if a tag doesn't have any attributes. Now that array is allocated only if needed. benchmark old allocs new allocs delta BenchmarkUnmarshal 191 176 -8.5% Change-Id: I4d214b228883d0a6e892c0d6eb00dfe2da84c116 Reviewed-on: https://go-review.googlesource.com/4160Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Håvard Haugen authored
Fixes #8780 Change-Id: I09cf01ff9722eed49086992a12774f2de81d16f2 Reviewed-on: https://go-review.googlesource.com/2840Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
David du Colombier authored
warning: src/liblink/list5.c:171 format mismatch lld INT, arg 4 warning: src/liblink/list9.c:175 format mismatch lld INT, arg 4 warning: src/liblink/list6.c:211 format mismatch lld INT, arg 4 warning: src/liblink/list8.c:205 format mismatch lld INT, arg 4 Change-Id: I745ea852d8b58ecbbd32723e2a67aa784a729ff8 Reviewed-on: https://go-review.googlesource.com/4112Reviewed-by:
Minux Ma <minux@golang.org>
-
Brad Fitzpatrick authored
The old C-based dist accepted merged flags (-wp) but the Go-based dist requires -w -p This should get the Windows race builder running properly, along with https://go-review.googlesource.com/#/c/4132/ Update #8640 Change-Id: Ic17bbe9ea6c8b3d3e9b29f94e234d014f2926439 Reviewed-on: https://go-review.googlesource.com/4133Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 06 Feb, 2015 26 commits
-
-
David du Colombier authored
This change is an implementation of the signal runtime and os/signal package on Plan 9. Contrary to Unix, on Plan 9 a signal is called a note and is represented by a string. For this reason, the sigsend and signal_recv functions had to be reimplemented specifically for Plan 9. In order to reuse most of the code and internal interface of the os/signal package, the note strings are mapped to integers. Thanks to Russ Cox for the early review. Change-Id: I95836645efe21942bb1939f43f87fb3c0eaaef1a Reviewed-on: https://go-review.googlesource.com/2164Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Shenghou Ma authored
It turns out -iex argument is not supported by all gdb versions, but as we need to add the auto-load safe path before loading the inferior, test -iex support first and skip the test if it's not available. We should still update our builders though. Change-Id: I355697de51baf12162ba6cb82f389dad93f93dc5 Reviewed-on: https://go-review.googlesource.com/4070Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
On some systems, gdb refuses to load Python plugin from arbitrary paths, so we have to add $GOROOT/src/runtime to auto-load-safe-path in the gdb script test. Change-Id: Icc44baab8d04a65bd21ceac2ab8ddb13c8d083e8 Reviewed-on: https://go-review.googlesource.com/2905Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Josh Bleecher Snyder <josharian@gmail.com>
-
Shenghou Ma authored
Ideally, those methods should return a copy of the Addr, but due to the Go 1 API guarantee, we cannot make that change now: there might exist client code that uses the returned Addr as map index and thus relies on the fact that different invocation of the method returns the same pointer. Changing this behavior will lead to hidden behaviour change in those programs. Update #9654. Change-Id: Iad4235f2ed7789b3a3c8e0993b9718cf0534ea2b Reviewed-on: https://go-review.googlesource.com/3851Reviewed-by:
Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Josh Bleecher Snyder authored
Ordinary switch statements are rewritten into a sequence of if statements. Staticly dead cases were not being eliminated because the rewrite introduced a temporary, which hid the fact that the case was a constant. Stop doing that. This eliminates dead code in the standard library at: runtime/cgocall.go:219 runtime/cgocall.go:269 debug/gosym/pclntab.go:175 debug/macho/file.go:208 math/big/nat.go:635 math/big/nat.go:850 math/big/nat.go:1058 cmd/pprof/internal/commands/commands.go:86 net/sock_bsd.go:19 cmd/go/build.go:2657 cmd/go/env.go:90 Fixes #9608. Change-Id: Ic23a05dfbb1ad91d5f62a6506b35a13e51b33e38 Reviewed-on: https://go-review.googlesource.com/3980Reviewed-by:
Keith Randall <khr@golang.org>
-
Josh Bleecher Snyder authored
eqstring does not need to check the length of the strings. Other architectures were done in a separate commit. While we're here, add a pointer equality check. Change-Id: Id2c8616a03a7da7037c1e9ccd56a549fc952bd98 Reviewed-on: https://go-review.googlesource.com/3956Reviewed-by:
Keith Randall <khr@golang.org>
-
Josh Bleecher Snyder authored
eqstring does not need to check the length of the strings. 6g benchmark old ns/op new ns/op delta BenchmarkCompareStringEqual 7.03 6.14 -12.66% BenchmarkCompareStringIdentical 3.36 3.04 -9.52% 5g benchmark old ns/op new ns/op delta BenchmarkCompareStringEqual 238 232 -2.52% BenchmarkCompareStringIdentical 90.8 80.7 -11.12% The equivalent PPC changes are in a separate commit because I don't have the hardware to test them. Change-Id: I292874324b9bbd9d24f57a390cfff8b550cdd53c Reviewed-on: https://go-review.googlesource.com/3955Reviewed-by:
Keith Randall <khr@golang.org>
-
Robert Griesemer authored
- clarified representation of +/-Inf - only 0 and Inf values can have 0 precision - a zero precision value used as result value takes the max precision of the arguments (to be fine-tuned for setters) - the zero precision approach makes Float zero values possible (they represent +0) - more tests Missing: Filling in the blanks. More tests. Change-Id: Ibb4f97e12e1f356c3085ce80f3464e97b82ac130 Reviewed-on: https://go-review.googlesource.com/4000Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Péter Surányi authored
Only documentation / comment changes. Update references to point to golang.org permalinks or go.googlesource.com/go. References in historical release notes under doc are left as is. Change-Id: Icfc14e4998723e2c2d48f9877a91c5abef6794ea Reviewed-on: https://go-review.googlesource.com/4060Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Change-Id: I40feb9e65615a0f683cfc3f54e0c0cfabcf6a787 Reviewed-on: https://go-review.googlesource.com/4010Reviewed-by:
Minux Ma <minux@golang.org>
-
Mikio Hara authored
And the silence of the git-codereview. Change-Id: If3f7fe2de2ab4c1756f3cef8267199049d468b31 Reviewed-on: https://go-review.googlesource.com/3983Reviewed-by:
Minux Ma <minux@golang.org>
-
Shenghou Ma authored
Fixes #837. Change-Id: I2d601504addbd220b304d32d587144d2a702f753 Reviewed-on: https://go-review.googlesource.com/2127Reviewed-by:
David Crawshaw <crawshaw@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Shenghou Ma authored
cmd/dist: recognize darwin/arm as (host) goos/goarches. also hard code GOARM=7 for darwin/arm. make.bash: don't pass -mmacosx-version-min=10.6 when building for darwin/arm. Change-Id: If0ecd84a5179cd9bb61b801ac1899adc45f12f75 Reviewed-on: https://go-review.googlesource.com/2126Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
On Darwin/ARM, because libSystem doesn't provide functions for __sync_fetch_and_add, and only clang can inline that function, skip the test when building with GCC. Change-Id: Id5e9d8f9bbe1e6bcb2f381f0f66cf68aa95277c7 Reviewed-on: https://go-review.googlesource.com/2125Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Change-Id: I936be12eed95b99d1d20ed16fb785182e1817b33 Reviewed-on: https://go-review.googlesource.com/2124Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
Change-Id: Id6f7fa12084204bc3a200f423c7966ce2a0b63a0 Reviewed-on: https://go-review.googlesource.com/2123Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
Change-Id: I213a8ab0b8c027a7b73567aeefdca73fd10eae28 Reviewed-on: https://go-review.googlesource.com/2122Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
Change-Id: I63110daad2d62ae72ab1f33a40464d76e6205627 Reviewed-on: https://go-review.googlesource.com/2121Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
liblink: - set dummy value for ctxt->tlsoffset. cmd/ld: - always do external linking when using cgo on darwin/arm, as our linker might not generate codesign-compatible binary. cmd/5l: - support generate ARM Mach-O binaries - add machoreloc1() that translate our internal relocation to macho relocations used by external linking. Change-Id: Ic5454aeb87009aaf8f1453ec7fe33e6da55d5f06 Reviewed-on: https://go-review.googlesource.com/3273Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Shenghou Ma authored
Libc on Darwin/ARM has a buggy implementation of ldexp and frexp that could not handle denormal numbers. Also disable VFP runfast (flush-to-zero) mode so that the gc compiler can correctly handle denormal constants used in math and strconv tests. Change-Id: Ie64220b882f414e0b37f406f38181c3586104d46 Reviewed-on: https://go-review.googlesource.com/2119Reviewed-by:
David Crawshaw <crawshaw@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Shenghou Ma authored
In the old code, liblink, cmd/ld and runtime all have code determine whether runtime.tlsg is an actual variable or a placeholder for TLS relocation. This change consolidate them into one: the runtime/tls_arm.s will ultimately determine the type of that variable. Change-Id: I3b3f80791a1db4c2b7318f81a115972cd2237e43 Reviewed-on: https://go-review.googlesource.com/2118Reviewed-by:
David Crawshaw <crawshaw@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Shenghou Ma authored
Fixes #9742. Change-Id: Ifedf7ff9465bc49534b708d414c8e435ee9ce6cd Reviewed-on: https://go-review.googlesource.com/3970Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Rahul Chaudhry authored
The main issue is that the misc/cgo/{stdio,life} tests are silently getting skipped when invoked from run.bash. run.go should ignore any build tags after the first blank line in source file. It already checks for test actions only upto the first blank line. Build tags must be specified in the same block. See http://golang.org/cl/3675 for background. Change-Id: Id8abf000119e3335f7250d8ef34aac7811fc9dff Reviewed-on: https://go-review.googlesource.com/3812Reviewed-by:
Minux Ma <minux@golang.org>
-
Rahul Chaudhry authored
issue9355 generated a file a.[568] in test/ directory and left it there. For tests like these, it is best to chdir to a test specific directory before generating any temporary files, since the tests are running in parallel and might otherwise race with each other for the same files. Change-Id: I58d96256d4d8ee3fda70d81077f19006064a7425 Reviewed-on: https://go-review.googlesource.com/3813Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Andrew Ekstedt authored
PalettedColorModel was renamed to color.Palette over three years ago by https://golang.org/cl/5132048. Change-Id: I0204ade10eabff45620fda2990fed428c65d871e Reviewed-on: https://go-review.googlesource.com/3305Reviewed-by:
Minux Ma <minux@golang.org> Reviewed-by:
Nigel Tao <nigeltao@golang.org>
-
Nigel Tao authored
and empty keys. Also reject malformed (quoted) values. See also https://go-review.googlesource.com/3952 Change-Id: Ice6de33b09f9904b28e410a680a90aa6c8c76fed Reviewed-on: https://go-review.googlesource.com/3953Reviewed-by:
Rob Pike <r@golang.org>
-
- 05 Feb, 2015 5 commits
-
-
Robert Griesemer authored
Change-Id: I7514e643a6a81ca715adbf6f8d19d3b2dd43fe6c Reviewed-on: https://go-review.googlesource.com/3810Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Robert Griesemer authored
Change-Id: Ica419a1215ca33dc1cff1e9e4137f204591e3cee Reviewed-on: https://go-review.googlesource.com/3942Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Robert Griesemer authored
Change-Id: Ia30886569141ca2e0321bea6ee1d5c9e0f79d6f9 Reviewed-on: https://go-review.googlesource.com/3941Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Robert Griesemer authored
Change-Id: I4329c44b829fcd77e4f1a1d45904f0f8a280a595 Reviewed-on: https://go-review.googlesource.com/3940Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Erik Aigner authored
Change-Id: Ida064ff422d077d508ef94f52fc813daa6277a99 Reviewed-on: https://go-review.googlesource.com/3933Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-