- 14 Oct, 2011 20 commits
-
-
Dave Cheney authored
Also, add golden output data for linux/arm. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5256041
-
Chris Farmiloe authored
When xml.Marshal is called on a struct it will happily reflect the information in the "tag" of an XMLName member regardless of the type to give the struct a tag-name in it's XML form. This is backed up by the documentation which says: However xml.Unmarshal *does* care about the XMLName field being of type xml.Name, and currently returns the error "field XMLName does not have type xml.Name" if you have it set to something else. This is firstly inconsistant with xml.Marshal but it also makes it impossible to use xml.Marshal alongside other Marshallers (like json/bson) without poluting the state's namespace with XMLName fields. Inorder to exclude fields from other Marshallers the convention has been started to tag fields as "omitempty"; which will cause the field not to display if it is at it's "zero" state, XMLName cannot have such as zero-state since it is a struct, so it is nicer to use a pointer/bool value for XMLName so it can be easily excluded when I want to Marshal my struct by some other wire format. Attached is the proposed minor change, that simply stops erring if it can't set the name on the XMLName field, which is just optional metadata anyway. Fixes #2265. R=rsc CC=golang-dev https://golang.org/cl/5067044
-
Brad Fitzpatrick authored
Fixes #2146 R=rsc CC=golang-dev https://golang.org/cl/5284041
-
Russ Cox authored
Fixes #2369. R=gri CC=golang-dev https://golang.org/cl/5275048
-
Russ Cox authored
Apparently some versions of bash do the ||exit implicitly when in set -e mode, but others do not. ??? R=gri CC=golang-dev https://golang.org/cl/5285043
-
Jaroslavas Počepko authored
http://code.google.com/p/go/issues/detail?id=1899 R=rsc, alex.brainman, bsiegert, hectorchu, bradfitz CC=golang-dev https://golang.org/cl/4978047
-
Adam Langley authored
We also have functions for dealing with PKCS#1 private keys. This change adds functions for PKIX /public/ keys. Most of the time one won't be parsing them because they usually come in certificates, but marshaling them happens and I've previously copied the code from x509.go for this. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5286042
-
Adam Langley authored
X509 names, like everything else X509, are ludicrously general. This change keeps the raw version of the subject and issuer around for matching. Since certificates use a distinguished encoding, comparing the encoding is the same as comparing the values directly. This came up recently when parsing the NSS built-in certificates which use the raw subject and issuer for matching trust records to certificates. R=bradfitz CC=golang-dev https://golang.org/cl/5275047
-
Adam Langley authored
R=bradfitz CC=golang-dev https://golang.org/cl/5172042
-
Brad Fitzpatrick authored
Fixes #2057 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5269044
-
Luca Greco authored
Firefox Websocket implementation send a "Connection: keep-alive, upgrade" header during the handshake (and as descripted on the last hybi draft the "Connection" header must include, but doesn't need to be equal to, "upgrade": '4. A "Connection" header field that includes the token "Upgrade", treated as an ASCII case-insensitive value.' From: http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#page-23 R=golang-dev, ukai, cw, rsc CC=golang-dev https://golang.org/cl/5233059
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5274045
-
Chris Hundt authored
Adjust goyacc.go to produce code that is gofmt-compliant whenever it is easy to do so. Also changed two lines in cpyact that appeared to be bugs. Also updated units.y to remove a few other errors. After this change, units.go has only two style errors: an extra newline at the top of the file, and yys misaligned in yySymType. R=rsc CC=golang-dev https://golang.org/cl/5265047
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5284043
-
Brad Fitzpatrick authored
This test fails for me on Windows 7 64-bit non-Admin. R=golang-dev, rsc, krautz CC=golang-dev https://golang.org/cl/5276048
-
Mikkel Krautz authored
R=alex.brainman, hectorchu, rsc CC=golang-dev https://golang.org/cl/5263045
-
David Anderson authored
Notably, the "data" argument should be nil if no options are given, or (at least) the cgroup filesystem will refuse to mount. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5147047
-
Alex Brainman authored
R=golang-dev CC=golang-dev https://golang.org/cl/5267044
-
Nigel Tao authored
The relevant spec sections are 13.2.4.38-13.2.4.40. http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#attribute-value-(double-quoted)-state R=andybalholm CC=golang-dev https://golang.org/cl/5262044
-
Mikkel Krautz authored
R=rsc CC=golang-dev https://golang.org/cl/5281044
-
- 13 Oct, 2011 20 commits
-
-
Robert Griesemer authored
R=r, dsymonds CC=golang-dev https://golang.org/cl/5269043
-
Robert Griesemer authored
R=r CC=golang-dev https://golang.org/cl/5277044
-
Nigel Tao authored
Previously, the tokenizer made two passes per token. The first pass established the token boundary. The second pass picked out the tag name and attributes inside that boundary. This was problematic when the two passes disagreed. For example, "<p id=can't><p id=won't>" caused an infinite loop because the first pass skipped everything inside the single quotes, and recognized only one token, but the second pass never got past the first '>'. This change rewrites the tokenizer to use one pass, accumulating the boundary points of token text, tag names, attribute keys and attribute values as it looks for the token endpoint. It should still be reasonably efficient: text, names, keys and values are not lower-cased or unescaped (and converted from []byte to string) until asked for. One of the token_test test cases was fixed to be consistent with html5lib. Three more test cases were temporarily disabled, and will be re-enabled in a follow-up CL. All the parse_test test cases pass. R=andybalholm, gri CC=golang-dev https://golang.org/cl/5244061
-
Russ Cox authored
Also test only specific fixes, not all fixes. This means we don't have to keep updating old test cases to match later changes to the library. I had to adjust some of the reflect test cases, because they were implicitly testing reflect+oserrorstring, not just reflect. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5283042
-
Robert Griesemer authored
This package is only used by gotype at the moment. R=rsc, r CC=golang-dev https://golang.org/cl/5266042
-
Russ Cox authored
Fixes #2353. Fixes #2246. R=golang-dev, r, gri CC=golang-dev https://golang.org/cl/5282042
-
Russ Cox authored
Hard work done by http://mercurial.selenic.com/wiki/CACertificates R=golang-dev, gri CC=golang-dev https://golang.org/cl/5276043
-
Russ Cox authored
Fixes #583. Fixes #1776. Fixes #2001. Fixes #2112. R=golang-dev, bradfitz, r, gri CC=golang-dev https://golang.org/cl/5265044
-
Russ Cox authored
Fixes #693. R=ken2 CC=golang-dev https://golang.org/cl/5265045
-
Russ Cox authored
R=golang-dev, r, gri CC=golang-dev https://golang.org/cl/5240055
-
Mikkel Krautz authored
Fixes #1009. R=adg, rsc CC=golang-dev https://golang.org/cl/5262041
-
Christopher Wedgwood authored
On recent Debian systems the gold 2.20 check triggers though Debian doesn't have version 2.20 but rather has: GNU gold (GNU Binutils for Debian 2.21.52.20110606) 1.11 ^^^^ R=rsc, iant CC=golang-dev https://golang.org/cl/5252055
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/5245056
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5257057
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/5245057
-
Evan Martin authored
This runs godoc and displays its output in a new buffer. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5268041
-
Brad Fitzpatrick authored
Don't imply that the tour isn't browser-based. R=adg CC=golang-dev https://golang.org/cl/5265041
-
Dmitriy Vyukov authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5151043
-
http://golanguage.ru/Dmitriy Vyukov authored
I check it for several months and it always says ERR_NAME_RESOLUTION_FAILED R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5272041
-
Robert Hencke authored
R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/5266041
-