Commits · a47a45ec7741d677ea6582cdeee3419325ac9488 · go / golang

16 Dec, 2009 10 commits

Fix for scanner bug (introduced with most recent change). · a47a45ec
Robert Griesemer authored Dec 16, 2009
```
Fixes #433.

R=rsc
CC=golang-dev
https://golang.org/cl/179072
```
a47a45ec
syscall: RawSyscall must not call exitsyscall · 69bed164
Russ Cox authored Dec 16, 2009
```
Fixes #405.

R=r
CC=golang-dev, hoisie
https://golang.org/cl/180056
```
69bed164

new semicolon rule in effective_go.html. · 163ecdac

Rob Pike authored Dec 16, 2009

eliminate all tab characters while we're here.

R=rsc
CC=golang-dev
https://golang.org/cl/180055

163ecdac

rand: add explicit Int31n to avoid 64-bit divide on 32-bit machines · f64bb56b

Russ Cox authored Dec 16, 2009

    use Int31n in Intn when possible.

Fixes #390.

(using 8g)
Intn1000      50000000         38 ns/op
Int31n1000    50000000         39 ns/op
Int63n1000    20000000        114 ns/op

R=r
CC=golang-dev, skybrian
https://golang.org/cl/180054

f64bb56b

math: faster, easier to inline IsNaN, IsInf · 1e9e7ec4
Russ Cox authored Dec 16, 2009
```
R=r
CC=golang-dev
https://golang.org/cl/180046
```
1e9e7ec4
runtime: return zero value in x, ok = <-c when ok == false · d16bc7a9
Russ Cox authored Dec 16, 2009
```
Fixes #401.

R=ken2
https://golang.org/cl/180053
```
d16bc7a9
gc: fix import name resolution · c715b58d
Russ Cox authored Dec 16, 2009
```
Fixes #403.

R=ken2
https://golang.org/cl/180052
```
c715b58d
Add basic http authentication support. · 8e2608ec
Ivan Krasin authored Dec 16, 2009
```
Fixes #407.

R=rsc, ajstarks
CC=ushakov
https://golang.org/cl/176076
```
8e2608ec

gc: bug fixes. · 5d754bfa

Russ Cox authored Dec 16, 2009

  * better error for lookup of unexported field
  * do not assign "ideal string" type to typed string literal
  * do not confuse methods and fields during interface check

Fixes #410.
Fixes #411.
Fixes #426.

R=ken2
https://golang.org/cl/179069

5d754bfa

gc: allow ... in method lists · 101f499f
Russ Cox authored Dec 16, 2009
```
R=ken2
https://golang.org/cl/179070
```
101f499f

15 Dec, 2009 14 commits

1) Change default gofmt default settings for · 45ca9f7a

Robert Griesemer authored Dec 15, 2009

   parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

5th and last set of files.

R=rsc
CC=golang-dev
https://golang.org/cl/180050

45ca9f7a

1) Change default gofmt default settings for · d65a5cce

Robert Griesemer authored Dec 15, 2009

   parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

4th set of files.

R=rsc
CC=golang-dev
https://golang.org/cl/180049

d65a5cce

1) Change default gofmt default settings for · a3d1045f

Robert Griesemer authored Dec 15, 2009

   parsing and printing to new syntax.

   Use -oldparser to parse the old syntax,
   use -oldprinter to print the old syntax.

2) Change default gofmt formatting settings
   to use tabs for indentation only and to use
   spaces for alignment. This will make the code
   alignment insensitive to an editor's tabwidth.

   Use -spaces=false to use tabs for alignment.

3) Manually changed src/exp/parser/parser_test.go
   so that it doesn't try to parse the parser's
   source files using the old syntax (they have
   new syntax now).

4) gofmt -w src misc test/bench

3rd set of files.

R=rsc
CC=golang-dev
https://golang.org/cl/180048

a3d1045f

1) Change default gofmt default settings for · 5a1d3323

Robert Griesemer authored Dec 15, 2009

                  parsing and printing to new syntax.

                  Use -oldparser to parse the old syntax,
                  use -oldprinter to print the old syntax.

               2) Change default gofmt formatting settings
                  to use tabs for indentation only and to use
                  spaces for alignment. This will make the code
                  alignment insensitive to an editor's tabwidth.

                  Use -spaces=false to use tabs for alignment.

               3) Manually changed src/exp/parser/parser_test.go
                  so that it doesn't try to parse the parser's
                  source files using the old syntax (they have
                  new syntax now).

               4) gofmt -w src misc test/bench

	       1st set of files.

R=rsc
CC=agl, golang-dev, iant, ken2, r
https://golang.org/cl/180047

5a1d3323

update tutorial. · 34356e9a
Rob Pike authored Dec 15, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/179063
```
34356e9a

1) Change default gofmt default settings for · 1c729599

Robert Griesemer authored Dec 15, 2009

                  parsing and printing to new syntax.

                  Use -oldparser to parse the old syntax,
                  use -oldprinter to print the old syntax.

               2) Change default gofmt formatting settings
                  to use tabs for indentation only and to use
                  spaces for alignment. This will make the code
                  alignment insensitive to an editor's tabwidth.

                  Use -spaces=false to use tabs for alignment.

               3) Manually changed src/exp/parser/parser_test.go
                  so that it doesn't try to parse the parser's
                  source files using the old syntax (they have
                  new syntax now).

               4) gofmt -w src misc test/bench

	       2nd set of files.

R=rsc
CC=golang-dev
https://golang.org/cl/179067

1c729599

gc: double-check usage of ... · d122bb21
Russ Cox authored Dec 15, 2009
```
Fixes #423.

R=ken2
https://golang.org/cl/180045
```
d122bb21
gc: var x, ok = m[y] · 0282cc5e
Russ Cox authored Dec 15, 2009
```
Fixes #384.

R=ken2
https://golang.org/cl/179061
```
0282cc5e

Tweak test to work with both 6g and gccgo. · 84e7cb06

Ian Lance Taylor authored Dec 15, 2009

Pull the struct into a single line, since 6g reports the error
on the last line of the struct definition and gccgo reports it
on the first line.

6g:
bug215.go:12: invalid recursive type A

gccgo:
bug215.go:12:6: error: invalid recursive type ‘A’

R=rsc
https://golang.org/cl/180044

84e7cb06

codereview: add golang-dev@googlegroups.com · 82747423

Russ Cox authored Dec 15, 2009

    automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug

R=gri, cw
CC=golang-dev
https://golang.org/cl/174072

82747423

fix TODO: insert semicolons before any sequence of comments · 55ca7a26

Robert Griesemer authored Dec 15, 2009

that introduce the newline (important for correct placement
of comments with gofmt when parsing new syntax)

R=rsc
https://golang.org/cl/179055

55ca7a26

xml: handle unexpected EOF while parsing and fix a bug in name · dec5bb78

Arvindh Rajesh Tamilmani authored Dec 15, 2009

mustgetc reports unexpected EOF as SyntaxError.  using
mustgetc seems to be a better approach than letting the
caller handle unexpected EOF every time.

name: the second if statement should explicitly return
ok==false.

R=rsc
https://golang.org/cl/174083

dec5bb78

runtime: in exitsyscall, avoid confusing garbage collector · 19c18358
Russ Cox authored Dec 15, 2009
```
R=r
CC=golang-dev
https://golang.org/cl/178046
```
19c18358
improved formatting of import declarations and · 31de4d4c
Robert Griesemer authored Dec 15, 2009
```
multi-line expressions with comments

Fixes #414.

R=rsc
https://golang.org/cl/179047
```
31de4d4c

14 Dec, 2009 8 commits

crypto/sha256: new package · 2a52782f
Andy Davis authored Dec 14, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/176062
```
2a52782f
simpler fix for the negative rune problem, spotted seconds after submitting the previous fix. · 0d3f5a84
Rob Pike authored Dec 14, 2009
```
R=rsc
https://golang.org/cl/178044
```
0d3f5a84
generate replacement rune when asked to encode a negative rune value. · a9e8befb
Rob Pike authored Dec 14, 2009
```
Fixes #425.

R=rsc
https://golang.org/cl/178043
```
a9e8befb

archive/tar: bug fixes. · fe0eb17f

Christopher Wedgwood authored Dec 14, 2009

1. If all data is exhausted using Read then a following Next will
   fail as if it saw EOF.  (Test case added.)
2. Seeking isn't always possible (i.e. sockets and pipes).  Fallback
   to read.  (Test case added.)
3. Fix to readHeader (cleaner fix pointed out by rsc).
   (TestReader modified.)
4. When Read has consumed all the data, don't try to read 0 bytes from reader.
   In cases where tr.nb is zero we attempt to read zero bytes and thus
   never see an EOF (this is most easily seen when the 'tar source' is
   something like bytes.Buffer{} as opposed to os.File).
5. If write is used to the point of ErrWriteTooLong, allow additional file entries.
6. Make close work as expected.  That is any further Write or
   WriteHeader attempts will result in ErrWriteAfterClose.
Fixes #419.

R=rsc, dsymonds1
https://golang.org/cl/162062

fe0eb17f

don't show semicolons anymore with godoc · 8793f622
Robert Griesemer authored Dec 14, 2009
```
R=rsc
https://golang.org/cl/174078
```
8793f622

A+C: two more names · 6112e809

Russ Cox authored Dec 14, 2009

	Andy Davis (individual CLA)
	Arvindh Rajesh Tamilmani (individual CLA)

R=r
https://golang.org/cl/176067

6112e809

fix naked < as reported by pwil3058@gmail.com · bbd4cb38
Rob Pike authored Dec 14, 2009
```
R=rsc
CC=pwil3058
https://golang.org/cl/174087
```
bbd4cb38
When the buffer is empty, reset b.off to the beginning of the buffer · d14c8133
Rob Pike authored Dec 14, 2009
```
to avoid growing unnecessarily.

R=rsc
CC=golang-dev
https://golang.org/cl/176071
```
d14c8133

13 Dec, 2009 6 commits
- syscall: fix error return bug for 64-bit return on 32-bit platform · 58578905
  Christopher Wedgwood authored Dec 13, 2009
```
R=dho, rsc
CC=r
https://golang.org/cl/176058
```
  58578905
- 8l: add support for PE output. · 977e19d6
  Hector Chu authored Dec 13, 2009
```
R=rsc
https://golang.org/cl/166080
```
  977e19d6
- clean.bash: stop if $GOROOT is not set · 2ef330eb
  Christopher Wedgwood authored Dec 13, 2009
```
Doing rm -rf /pkg/.. blindly isn't nice.  It could have
unintended consequences.

Secondly set bash to abort on (unexpected) errors.

R=dho, rsc
CC=golang-dev
https://golang.org/cl/176056
```
  2ef330eb
- Ported godefs to Windows. · 31645cc0
  Hector Chu authored Dec 13, 2009
```
R=rsc
https://golang.org/cl/164049
```
  31645cc0
- gc: fix comment · 978c3e96
  Russ Cox authored Dec 13, 2009
```
R=gri
CC=golang-dev
https://golang.org/cl/174077
```
  978c3e96
- Update goyacc to new syntax, still with semicolons. · f6462961
  Rob Pike authored Dec 13, 2009
```
Update units.y too.
Fixes #417.

R=rsc
CC=golang-dev
https://golang.org/cl/176063
```
  f6462961
12 Dec, 2009 2 commits
- more on the optimizer · bedfc2c2
  Ken Thompson authored Dec 12, 2009
```
trying to get alizses
to optimize

R=rsc
https://golang.org/cl/176061
```
  bedfc2c2
- fix bug for large counts: used a one-byte buffer. · 68777771
  Rob Pike authored Dec 12, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/174082
```
  68777771