- 22 Aug, 2013 1 commit
-
-
Andrew Gerrand authored
Fixes #5630. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12884046
-
- 21 Aug, 2013 13 commits
-
-
Rémy Oudompheng authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/13105047
-
Dmitriy Vyukov authored
GC acquires worldsema, which is a goroutine-level semaphore which parks goroutines. g0 can not be parked. Fixes #6193. R=khr, khr CC=golang-dev https://golang.org/cl/12880045
-
Carl Shapiro authored
Update the original change but do not read interface types in the arguments area. Once the arguments area is zeroed as the locals area is we can safely read interface type values there too. ««« original CL description undo CL 12785045 / 71ce80dc4195 This has broken the 32-bit builds. ««« original CL description cmd/gc, runtime: use type information to scan interface values R=golang-dev, rsc, dvyukov CC=golang-dev https://golang.org/cl/12785045 »»» R=khr, golang-dev, khr CC=golang-dev https://golang.org/cl/13010045 »»» R=khr, khr CC=golang-dev https://golang.org/cl/13073045
-
Sokolov Yura authored
This slightly improves performance when a lot of timers are present $ misc/benchcmp ../old_timers_m.txt ../new_timers_m.txt benchmark old ns/op new ns/op delta BenchmarkAfterFunc 6884 6605 -4.05% BenchmarkAfterFunc-2 4473 4144 -7.36% BenchmarkAfterFunc-3 8601 6185 -28.09% BenchmarkAfterFunc-4 9378 8773 -6.45% BenchmarkAfter 7237 7278 +0.57% BenchmarkAfter-2 4638 3923 -15.42% BenchmarkAfter-3 8751 6239 -28.71% BenchmarkAfter-4 9223 8737 -5.27% BenchmarkStop 603 496 -17.74% BenchmarkStop-2 795 577 -27.42% BenchmarkStop-3 982 680 -30.75% BenchmarkStop-4 1164 739 -36.51% BenchmarkSimultaneousAfterFunc 657 593 -9.74% BenchmarkSimultaneousAfterFunc-2 816 757 -7.23% BenchmarkSimultaneousAfterFunc-3 844 830 -1.66% BenchmarkSimultaneousAfterFunc-4 785 771 -1.78% BenchmarkStartStop 238 239 +0.42% BenchmarkStartStop-2 249 234 -6.02% BenchmarkStartStop-3 271 268 -1.11% BenchmarkStartStop-4 293 295 +0.68% R=golang-dev, dvyukov, bradfitz, r CC=golang-dev https://golang.org/cl/13094043
-
Dmitriy Vyukov authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/12780045
-
Dmitriy Vyukov authored
Replace linked list walk with memset. This reduces CPU time taken by 'go install -a std' by ~10%. Before: real user sys 0m23.561s 0m16.625s 0m5.848s 0m23.766s 0m16.624s 0m5.846s 0m23.742s 0m16.621s 0m5.868s after: 0m22.714s 0m14.858s 0m6.138s 0m22.644s 0m14.875s 0m6.120s 0m22.604s 0m14.854s 0m6.081s R=golang-dev, r CC=golang-dev https://golang.org/cl/13084043
-
Elias Naur authored
R=r CC=golang-dev https://golang.org/cl/13019044
-
Todd Wang authored
pointer. An example that triggers the bad behavior on a 64bit machine http://play.golang.org/p/GrNFakAYLN rv1 := reflect.ValueOf(complex128(0)) rt := rv1.Type() rv2 := rv1.Convert(rt) rv3 := reflect.New(rt).Elem() rv3.Set(rv2) Running the code fails with the following: panic: reflect: internal error: storeIword of 16-byte value I've tested on a 64bit machine and verified this fixes the panic. I haven't tested on a 32bit machine so I haven't verified the other cases, but they follow logically. R=golang-dev, r, iant CC=golang-dev https://golang.org/cl/12805045
-
David Symonds authored
R=r, adg CC=golang-dev, toddwang https://golang.org/cl/13149043
-
Rob Pike authored
Update #5000 Should reduce the flakiness a little. Malloc counting is important to general testing but not to the build dashboard, which uses -short. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/12866047
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/12801045
-
Rob Pike authored
Add eq, lt, etc. to allow one to do simple comparisons. It's basic types only (booleans, integers, unsigned integers, floats, complex, string) because that's easy, easy to define, and covers the great majority of useful cases, while leaving open the possibility of a more sweeping definition later. {{if eq .X .Y}}X and Y are equal{{else}}X and Y are unequal{{end}} R=golang-dev, adg CC=golang-dev https://golang.org/cl/13091045
-
Mikio Hara authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/12975044
-
- 20 Aug, 2013 12 commits
-
-
Rob Pike authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/13140043
-
Brad Fitzpatrick authored
Not a user-visible API change. Just a minor garbage win in contrived cases. Also, the package is io/ioutil. R=golang-dev, r CC=golang-dev https://golang.org/cl/12987044
-
Rob Pike authored
This is potentially an API-breaking change, but it is an important bug fix. The CL https://golang.org/cl/7305072/ added stuff to make the tar file look more like a file system internally, including providing an implementation of os.FileInfo for the file headers within the archive. But the code is incorrect because FileInfo.Name is supposed to return the base name only; this implementation returns the full path. A round trip test added in the same shows this in action, as the slashes are preserved as we create a header using the local implementation of FileInfo. The CL here changes the behavior of the tar (and zip) FileInfo to honor the Go spec for that interface. It also clarifies that the FileInfoHeader function, which takes a FileInfo as an argument, will therefore create a header with only the base name of the file recorded, and that subsequent adjustment may be necessary. There may be code out there that depends on the broken behavior. We can call out the risk in the release notes. Fixes #6180. R=golang-dev, dsymonds, adg, bradfitz CC=golang-dev https://golang.org/cl/13118043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/12831044
-
Emil Hessman authored
If xcode-select is available, use it to determine the path to the DVTFoundation.xcplugindata file. Fixes #5997. R=golang-dev, r CC=golang-dev https://golang.org/cl/12741047
-
Mikio Hara authored
Update #5199 Update #6146 R=golang-dev, dvyukov CC=golang-dev https://golang.org/cl/13112044
-
Mikio Hara authored
Fixes #6146. R=golang-dev, r CC=golang-dev https://golang.org/cl/12927048
-
Mikio Hara authored
Update #6146 R=golang-dev, r CC=golang-dev https://golang.org/cl/12927047
-
Brad Fitzpatrick authored
Fixes #5377 R=golang-dev, r CC=golang-dev https://golang.org/cl/12991046
-
Rob Pike authored
The os windows source uses file as the receiver, not f. TBR=golang-dev@googlegroups.com R=adg CC=golang-dev https://golang.org/cl/12922044
-
Rob Pike authored
Some crashed, some didn't. Make a nil receiver always return ErrInvalid rather than crash. Fixes #5824. The program in the bug listing is silent now, at least on my Mac. R=golang-dev, adg CC=golang-dev https://golang.org/cl/13108044
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12926046
-
- 19 Aug, 2013 14 commits
-
-
Alan Donovan authored
(For go.tools/ssa/interp/interp_test, which runs a subset of these tests under this assumption.) R=rsc, r CC=golang-dev https://golang.org/cl/13108043
-
Carl Shapiro authored
This has broken the 32-bit builds. ««« original CL description cmd/gc, runtime: use type information to scan interface values R=golang-dev, rsc, dvyukov CC=golang-dev https://golang.org/cl/12785045 »»» R=khr, golang-dev, khr CC=golang-dev https://golang.org/cl/13010045
-
Rob Pike authored
It's a full answer to the first question; let's let readers know that. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12788048
-
Aaron France authored
When the coverage report file is older than the file we're showing the coverage report for, then we show a simple message to state this fact. R=adonovan, dominik.honnef, bradfitz CC=golang-dev https://golang.org/cl/12919044
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/13073044
-
Keith Randall authored
R=golang-dev, rsc, dvyukov, khr CC=golang-dev https://golang.org/cl/11386044
-
Dmitriy Vyukov authored
Fixes #6167. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/13052043
-
Dmitriy Vyukov authored
In the crash stack trace race cgocall() calls endcgo(), this means that m->racecall is wrong. Indeed this can happen is a goroutine is rescheduled to another M during race call. Disable preemption for race calls. Fixes #6155. R=golang-dev, rsc, cshapiro CC=golang-dev https://golang.org/cl/12866045
-
Carl Shapiro authored
R=golang-dev, rsc, dvyukov CC=golang-dev https://golang.org/cl/12785045
-
Andrew Gerrand authored
Fixes #5665. R=golang-dev, r CC=golang-dev https://golang.org/cl/12807044
-
Rob Pike authored
Before this CL, the import stack was a) not printed and b) overwritten later in the build, destroying the information about the cycle. This CL fixes both. I made time depend on os (os already depends on time) and with this CL the error is: /Users/r/go/src/pkg/fmt/print.go:10:2: import cycle not allowed package code.google.com/p/XXX/YYY: imports fmt imports os imports time imports os Doesn't give line numbers for the actual imports, as requested in the bug, but I don't believe that's important. Fixes #4292. R=golang-dev, adg CC=golang-dev https://golang.org/cl/13100043
-
David Symonds authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/12744048
-
Rob Pike authored
syntax/*: update messages sliceerr3.go: bizarre new error fixed by deleting a space. I could have sworn I ran all.bash before submitting the CL that triggered these. TBR=golang-dev@googlegroups.com R=golang-dev CC=golang-dev https://golang.org/cl/12812044
-
Anthony Martin authored
Fixes #5691. R=golang-dev, bradfitz, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/10255047
-