- 16 Apr, 2013 2 commits
-
-
Shenghou Ma authored
Fixes #5261. R=golang-dev, r CC=golang-dev https://golang.org/cl/8798044
-
Ian Lance Taylor authored
Update #4979. R=dvyukov, r, bradfitz CC=golang-dev https://golang.org/cl/8697045
-
- 15 Apr, 2013 6 commits
-
-
Brad Fitzpatrick authored
From the issue, which describes it as well as I could: database/sql assumes that driver.Stmt.Close does not need the connection. see database/sql/sql.go:1308: This puts the Rows' connection back into the idle pool, and then calls the driver.Stmt.Close method of the Stmt it belongs to. In the postgresql driver implementation (https://github.com/lib/pq), Stmt.Close communicates with the server (on the connection that was just put back into the idle pool). Most of the time, this causes no problems, but if another goroutine makes a query at the right (wrong?) time, chaos results. In any case, traffic is being sent on "free" connections shortly after they are freed, leading to race conditions that kill the driver code. Fixes #5283 R=golang-dev, r CC=golang-dev https://golang.org/cl/8633044
-
Shenghou Ma authored
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/8766043
-
Shenghou Ma authored
R=golang-dev, r, gary.burd, dr.volker.dobler CC=golang-dev https://golang.org/cl/8660046
-
Brad Fitzpatrick authored
Runs forever, stressing the runtime in various ways. It should never terminate. R=golang-dev, r, minux.ma CC=golang-dev https://golang.org/cl/8583047
-
Ian Lance Taylor authored
Update #5106 Update #5273 R=minux.ma, r CC=golang-dev https://golang.org/cl/8715043
-
Joel Sing authored
R=golang-dev, minux.ma, r CC=golang-dev https://golang.org/cl/8569043
-
- 14 Apr, 2013 1 commit
-
-
Brad Fitzpatrick authored
R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/8592044
-
- 13 Apr, 2013 3 commits
-
-
Stefan Nilsson authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/8729045
-
Daniel Morsing authored
They caused internal compiler errors and they're expensive enough that inlining them doesn't make sense. Fixes #5259. R=golang-dev, r, iant, remyoudompheng CC=golang-dev https://golang.org/cl/8636043
-
Robert Griesemer authored
For compliance with gc. See also issue 5265. Not Go1.1 critical, but harmless. R=r CC=golang-dev https://golang.org/cl/8736043
-
- 12 Apr, 2013 9 commits
-
-
Alexei Sholik authored
R=r CC=golang-dev https://golang.org/cl/8650044
-
Carl Shapiro authored
Update #5281 R=golang-dev, r, bradfitz, cshapiro CC=golang-dev https://golang.org/cl/8631047
-
Carl Shapiro authored
Updates #5282 R=golang-dev, r CC=golang-dev https://golang.org/cl/8718045
-
Volker Dobler authored
Debug output from go test -x may contain empty arguments. This CL quotes arguments if needed. E.g. the output of go test -x is now .../6g -o ./_go_.6 -p testmain -complete -D "" -I . -I $WORK ./_testmain.go which is easier to grasp. R=golang-dev, bradfitz, minux.ma, r CC=golang-dev https://golang.org/cl/8633043
-
Volker Dobler authored
Debug output from go test -x may contain empty arguments. This CL quotes arguments if needed. E.g. the output of go test -x is now .../6g -o ./_go_.6 -p testmain -complete -D "" -I . -I $WORK ./_testmain.go which is easier to grasp. R=golang-dev, bradfitz, minux.ma, r CC=golang-dev https://golang.org/cl/8633043
-
Ian Lance Taylor authored
There are tests in run.bash for -linkmode=external. Fixes #5238. R=golang-dev, bradfitz, remyoudompheng, r CC=golang-dev https://golang.org/cl/8716044
-
Ian Lance Taylor authored
R=golang-dev, minux.ma, r CC=golang-dev https://golang.org/cl/8709043
-
Ian Lance Taylor authored
This will let us ask people to rebuild the Go system without precise GC, and then rebuild and retest their program, to see if precise GC is causing whatever problem they are having. R=golang-dev, r CC=golang-dev https://golang.org/cl/8700043
-
Ian Lance Taylor authored
UMTX_OP_WAIT expects that the address points to a uintptr, but the code in lock_futex.c uses a uint32. UMTX_OP_WAIT_UINT is just like UMTX_OP_WAIT, but the address points to a uint32. This almost certainly makes no difference on a little-endian system, but since the kernel supports it we should do the right thing. And, who knows, maybe it matters. R=golang-dev, bradfitz, r, ality CC=golang-dev https://golang.org/cl/8699043
-
- 11 Apr, 2013 7 commits
-
-
Rob Pike authored
Fixes #5258. R=golang-dev, iant, minux.ma CC=golang-dev https://golang.org/cl/8682043
-
Rob Pike authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/8545046
-
Volker Dobler authored
Fixes #5260. R=golang-dev, minux.ma, 0xjnml, r CC=golang-dev https://golang.org/cl/8658043
-
Rob Pike authored
Although one may argue that they should be legal, gc (at least) disallows byte order marks that are not the first code point in the file. Added a sentence to the "Implementation restriction" clause in the "Source code representation" section to document this better. Lifting this restriction (again - the rule has changed at least twice already) would not break any existing programs, should we later decide yet again to fiddle the rules about these little fly specks. R=golang-dev, dsymonds, gri CC=golang-dev https://golang.org/cl/8649043
-
Andrew Wilkins authored
This change removes processing of #cgo directives from cmd/cgo, pushing the onus back on cmd/go to pass all necessary flags. Fixes #5224. See comments for rationale. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/8610044
-
Rob Pike authored
Fixes #5268. R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/8646045
-
Anthony Martin authored
All symbols are currently marked with global scope. The correct behavior was lost when the symbol table format was changed. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/8625043
-
- 10 Apr, 2013 5 commits
-
-
Rob Pike authored
The String method is called whenever the printing operation wants a string, not just for %s and %v. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8638043
-
Robert Griesemer authored
Go1.1 harmless, but not critical. Fixes #5249. R=golang-dev, r CC=golang-dev https://golang.org/cl/8609043
-
Rob Pike authored
If there are no tags, the rules are the same as before. If there is a tagged field, choose it if there is exactly one at the top level of all fields. More tests. The old tests were clearly inadequate, since they all pass as is. The new tests only work with the new code. R=golang-dev, iant CC=golang-dev https://golang.org/cl/8617044
-
Shenghou Ma authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/8622043
-
Rémy Oudompheng authored
Some variables declared in C could end up as undefined symbols in the final binary and have null address. Fixes #5114. Fixes #5227. R=golang-dev, iant, ajstarks, dave, r CC=golang-dev https://golang.org/cl/8602044
-
- 09 Apr, 2013 7 commits
-
-
Rob Pike authored
The old code was incorrect and also broken. It passed the tests by accident. The new algorithm is: 1) Sort the fields in order of names. 2) For all fields with the same name, sort in increasing depth. 3) Choose the single field with shortest depth. If any of the fields of a given name has a tag, do the above using tagged fields of that name only. Fixes #5245. R=iant CC=golang-dev https://golang.org/cl/8583044
-
Brad Fitzpatrick authored
R=r, golang-dev CC=golang-dev https://golang.org/cl/8575043
-
Ian Lance Taylor authored
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/8573043
-
Andrew Gerrand authored
Fixes #5246. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/8558044
-
Andrew Gerrand authored
R=campoy, dsymonds CC=golang-dev https://golang.org/cl/8564043
-
Mikio Hara authored
Makes it possible to return the spent runtime.PollDesc to runtime.pollcache descriptor pool when netFD.connect or syscall.Listen fails. Fixes #5219. R=dvyukov, dave, bradfitz, adg CC=golang-dev https://golang.org/cl/8318044
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/8556044
-