Commits · a7d4c3f43dbcab516b6bbd4723fbff30469898a7 · go / golang

27 Sep, 2012 8 commits

doc: clarify that the displayed tar file name is an example · a7d4c3f4
Andrew Gerrand authored Sep 27, 2012
```
R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6573065
```
a7d4c3f4
doc: fix OS X download links · 020d8515
Andrew Gerrand authored Sep 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6566064
```
020d8515
cmd/[568]g: header cleanup. · 617b7cf1
Rémy Oudompheng authored Sep 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6573059
```
617b7cf1

bufio: Implement io.WriterTo for (*Reader) · e289a2b9

Michael Chaten authored Sep 27, 2012

This is part 1 of 2 for issue 4028

benchmark                       old ns/op    new ns/op    delta
BenchmarkReaderCopyOptimal          33495         9849  -70.60%
BenchmarkReaderCopyUnoptimal        70631        27041  -61.72%
BenchmarkReaderCopyOldImpl          51407        52970   +3.04%

Update #4028

R=dave, nigeltao, rsc, bradfitz, rogpeppe
CC=golang-dev
https://golang.org/cl/6548047

e289a2b9

text/template: fix typo of errorf as error in comment. · 348e31f8
Josh Holland authored Sep 27, 2012
```
R=r, minux.ma
CC=gobot, golang-dev
https://golang.org/cl/6506120
```
348e31f8
CLA: Josh Holland <jrh@joshh.co.uk> individual contributor · 063b0744
Rob Pike authored Sep 27, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6568059
```
063b0744
cmd/api: delete redundant text from deletion message · b46dd48d
Rob Pike authored Sep 27, 2012
```
R=bradfitz, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6543064
```
b46dd48d
lzw: fix Write returning the wrong number of bytes written. · 791ac65b
Nigel Tao authored Sep 27, 2012
```
Fixes #4160.

R=rsc, r
CC=golang-dev
https://golang.org/cl/6564060
```
791ac65b

26 Sep, 2012 19 commits

fmt: allow # and x together for strings · ffea835b

Rob Pike authored Sep 26, 2012

Silly and small but easy to be consistent.
To make it worthwhile, I eliminated an allocation when using
%x on a byte slice.

Fixes #4149.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6574046

ffea835b

net: spread fd over several pollservers. · 7014bc64

Sébastien Paolacci authored Sep 26, 2012

Lighten contention without preventing further improvements on pollservers.
Connections are spread over Min(GOMAXPROCS, NumCPU, 8) pollserver instances.

Median of 10 runs, 4 cores @ 3.4GHz, amd/linux-3.2:

BenchmarkTCPOneShot 171917 ns/op 175194 ns/op 1.91%
BenchmarkTCPOneShot-2 101413 ns/op 109462 ns/op 7.94%
BenchmarkTCPOneShot-4 91796 ns/op 35712 ns/op -61.10%
BenchmarkTCPOneShot-6 90938 ns/op 30607 ns/op -66.34%
BenchmarkTCPOneShot-8 90374 ns/op 29150 ns/op -67.75%
BenchmarkTCPOneShot-16 101089 ns/op 111526 ns/op 10.32%

BenchmarkTCPOneShotTimeout 174986 ns/op 178606 ns/op 2.07%
BenchmarkTCPOneShotTimeout-2 101585 ns/op 110678 ns/op 8.95%
BenchmarkTCPOneShotTimeout-4 91547 ns/op 35931 ns/op -60.75%
BenchmarkTCPOneShotTimeout-6 91496 ns/op 31019 ns/op -66.10%
BenchmarkTCPOneShotTimeout-8 90670 ns/op 29531 ns/op -67.43%
BenchmarkTCPOneShotTimeout-16 101013 ns/op 106026 ns/op 4.96%

BenchmarkTCPPersistent 51731 ns/op 53324 ns/op 3.08%
BenchmarkTCPPersistent-2 32888 ns/op 30678 ns/op -6.72%
BenchmarkTCPPersistent-4 25751 ns/op 15595 ns/op -39.44%
BenchmarkTCPPersistent-6 26737 ns/op 9805 ns/op -63.33%
BenchmarkTCPPersistent-8 26850 ns/op 9730 ns/op -63.76%
BenchmarkTCPPersistent-16 104449 ns/op 102838 ns/op -1.54%

BenchmarkTCPPersistentTimeout 51806 ns/op 53281 ns/op 2.85%
BenchmarkTCPPersistentTimeout-2 32956 ns/op 30895 ns/op -6.25%
BenchmarkTCPPersistentTimeout-4 25994 ns/op 18111 ns/op -30.33%
BenchmarkTCPPersistentTimeout-6 26679 ns/op 9846 ns/op -63.09%
BenchmarkTCPPersistentTimeout-8 26810 ns/op 9727 ns/op -63.72%
BenchmarkTCPPersistentTimeout-16 101652 ns/op 104410 ns/op 2.71%

R=rsc, dvyukov, dave, mikioh.mikioh, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/6496054

7014bc64

cmd/6g, cmd/8g: fix two "out of fixed registers" cases. · 6feb6132

Rémy Oudompheng authored Sep 26, 2012

In two cases, registers were allocated too early resulting
in exhausting of available registers when nesting these
operations.

The case of method calls was due to missing cases in igen,
which only makes calls but doesn't allocate a register for
the result.

The case of 8-bit multiplication was due to a wrong order
in register allocation when Ullman numbers were bigger on the
RHS.

Fixes #3907.
Fixes #4156.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6560054

6feb6132

cmd/gc: Don't calculate second value in range if it is blank. · 7936ab58

Daniel Morsing authored Sep 26, 2012

Low hanging fruit optimization. Will remove an expensive copy if the range variable is an array.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6564052

7936ab58

crypto/x509: add Plan 9 root certificate location · cca48f1a
David du Colombier authored Sep 26, 2012
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/6571056
```
cca48f1a

doc: add important info for would-be go contributors. · 452f40f8

Jonathan Feinberg authored Sep 26, 2012

Link to the "installing from source" docs instead of the "installing" docs.

Remind would-be hacker to switch to the default branch from the release branch.

R=rsc
CC=golang-dev
https://golang.org/cl/6559043

452f40f8

crypto/aes: speed up using AES-NI on amd64 · 948db4e0

Shenghou Ma authored Sep 26, 2012

This CL requires CL 5970055.

benchmark           old ns/op    new ns/op    delta
BenchmarkEncrypt          161           23  -85.71%
BenchmarkDecrypt          158           24  -84.24%
BenchmarkExpand           526           62  -88.21%

benchmark            old MB/s     new MB/s  speedup
BenchmarkEncrypt        99.32       696.19    7.01x
BenchmarkDecrypt       100.93       641.56    6.36x

R=golang-dev, bradfitz, dave, rsc
CC=golang-dev
https://golang.org/cl/6549055

948db4e0

cmd/6a, cmd/6l: add support for AES-NI instrutions and PSHUFD · e039c405

Shenghou Ma authored Sep 26, 2012

This CL adds support for the these 7 new instructions to 6a/6l in
preparation of the upcoming CL for AES-NI accelerated crypto/aes:
AESENC, AESENCLAST, AESDEC, AESDECLAST, AESIMC, AESKEYGENASSIST,
and PSHUFD.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5970055

e039c405

codereview: use subprocess.call() instead of os.spawnvp() for portability · b7331f9b
Shivakumar GN authored Sep 26, 2012
```
Fixes #4121.

R=golang-dev, minux.ma, dave, r
CC=golang-dev
https://golang.org/cl/6555049
```
b7331f9b

spec: permit trailing comma in conversions · 60a6ae8c

Robert Griesemer authored Sep 26, 2012

Also: Adjust prose in Conversions section
to be consistent.

This is a backward-compatible syntax change.
For a discussion see issue 2568.

Fixes #2568.
Fixes #4123.

R=golang-dev, r, iant, rsc
CC=golang-dev
https://golang.org/cl/6572049

60a6ae8c

doc/go1.1: fix metadata json format · 3c9eb5b4
Francisco Souza authored Sep 26, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6570054
```
3c9eb5b4
cmd/go, cmd/ld: fix libgcc order and add __image_base__ symbol for windows · 5490814c
Shenghou Ma authored Sep 26, 2012
```
        Fixes #4063.

R=alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/6543066
```
5490814c

cmd/go: assume that code in $GOROOT is up to date · e80fccb4

Joel Sing authored Sep 26, 2012

Do not check compiler/linker timestamps for packages that are in the
$GOROOT. Avoids trying to rebuild non-writable standard packages when
timestamps have not been retained on the Go binaries.

Fixes #4106.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6533053

e80fccb4

reflect.DeepEqual: rewrite clarification about nil and empty slice. · ded94b72

Rob Pike authored Sep 26, 2012

The previous version was created by an idiot. This time, Rog Peppe
wrote the text. Thanks, Rog.
(== doesn't work on slices in general, so it makes no sense to
talk about in the context of DeepEqual.)

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6566054

ded94b72

net: fix plan 9 build · d6665bc3

Mikio Hara authored Sep 26, 2012

R=golang-dev, lucio.dere, fshahriar
CC=golang-dev
https://golang.org/cl/6562046

d6665bc3

reflect.DeepEqual: document that empty and nil are unequal for slices · 74a7cc9b

Rob Pike authored Sep 26, 2012

Update #4133.
Added a sentence of documentation to call out the behavior.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6572051

74a7cc9b

exp/types/staging: updated gcimporter · 1785bfca

Robert Griesemer authored Sep 26, 2012

Mostly minor changes to match the new
definitions in types.go and const.go.

R=rsc, r
CC=golang-dev
https://golang.org/cl/6506101

1785bfca

exp/types/staging: support for typechecking (most) builtins · ebf56e08

Robert Griesemer authored Sep 26, 2012

This code relies on some functions that are not yet in staging,
but it get's harder to keep all this in sync in a piece-meal
fashion.

R=rsc
CC=golang-dev
https://golang.org/cl/6492124

ebf56e08

exp/types/staging: operands, constants, and error handling · f5483fb8

Robert Griesemer authored Sep 26, 2012

More pieces of the typechecker code:

- Operands are temporary objects representing an expressions's
type and value (for constants). An operand is the equivalent of
an "attribute" in attribute grammars except that it's not stored
but only passed around during type checking.

- Constant operations are implemented in const.go. Constants are
represented as bool (booleans), int64 and *big.Int (integers),
*big.Rat (floats), complex (complex numbers), and string (strings).

- Error reporting is consolidated in errors.go. Only the first
dozen of lines is new code, the rest of the file contains the
exprString and typeString functions formerly in two separate
files (which have been removed).

This is a replacement CL for 6492101 (which was created without
proper use of hg).

R=rsc, r
CC=golang-dev
https://golang.org/cl/6500114

f5483fb8

25 Sep, 2012 8 commits

net/http: use tls host instead of proxy, when checking against a certificate · 1b6d4b5c
Christian Himpel authored Sep 25, 2012
```
Fixes #4152.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6570045
```
1b6d4b5c
syscall: do not use int to test network syscall results (on windows) · 0e6f9271
Alex Brainman authored Sep 25, 2012
```
Fixes #4147.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6569050
```
0e6f9271

cmd/5c: fix dataflag annotation · f2fadfef

Shenghou Ma authored Sep 25, 2012

file        old_size     new_size    base@c1ce95068533
bin/go      14717392     6287824     5918236

this huge size difference is due to GC data for runtime.mheap
(NOPTR dataflag is not obeyed).

R=rsc, dave
CC=golang-dev
https://golang.org/cl/6547051

f2fadfef

test/bench/shootout: new data after 64-bit ints for amd64 · 4391abfb
Rob Pike authored Sep 25, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6564046
```
4391abfb

cmd/dist: new version for string for development branch · 5c4e2570

Russ Cox authored Sep 25, 2012

Remove VERSION, which was forcing version to 'devel'.

Old:
$ go version
go version devel

New:
$ go version
go version devel +0a3866d6cc6b Mon Sep 24 20:08:05 2012 -0400

The date and time (and time zone) is that of the most recent commit,
not the time of the build itself. With some effort we could normalize
the zone, but I don't think it's worth the effort (more C coding,
since Mercurial is unhelpful).

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/6569049

5c4e2570

build: make int 64 bits on amd64 · 10ea6519

Russ Cox authored Sep 25, 2012

The assembly offsets were converted mechanically using
code.google.com/p/rsc/cmd/asmlint. The instruction
changes were done by hand.

Fixes #2188.

R=iant, r, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/6550058

10ea6519

runtime: add types to MSpan · f8c58373
Jan Ziak authored Sep 25, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6554060
```
f8c58373

reflect: add MakeFunc (API CHANGE) · ba4625c6

Russ Cox authored Sep 25, 2012

Fixes #1765.

R=iant, r, daniel.morsing, minux.ma, bradfitz, rogpeppe, remyoudompheng
CC=golang-dev
https://golang.org/cl/6554067

ba4625c6

24 Sep, 2012 5 commits

net: add read, write message methods to IPConn, UDPConn · 4b9e8415

Mikio Hara authored Sep 24, 2012

Both methods allow to access the IP ancillary data through
socket control messages.

This CL is required for CL 6482044; go.net/ipv4: new package.

R=rsc, r, dave
CC=golang-dev
https://golang.org/cl/6426047

4b9e8415

cmd/{5g,6g,8g,6c}: remove unused macro, use %E to print etype. · 33cceb09
Rémy Oudompheng authored Sep 24, 2012
```
R=golang-dev, rsc, dave
CC=golang-dev
https://golang.org/cl/6569044
```
33cceb09

cmd/6g, cmd/8g: add OINDREG, ODOT, ODOTPTR cases to igen. · f4e76d5e

Rémy Oudompheng authored Sep 24, 2012

Apart from reducing the number of LEAL/LEAQ instructions by about
30%, it gives 8g easier registerization in several cases,
for example in strconv. Performance with 6g is not affected.

Before (386):
src/pkg/strconv/decimal.go:22   TEXT  (*decimal).String+0(SB),$240-12
src/pkg/strconv/extfloat.go:540 TEXT  (*extFloat).ShortestDecimal+0(SB),$584-20

After (386):
src/pkg/strconv/decimal.go:22   TEXT  (*decimal).String+0(SB),$196-12
src/pkg/strconv/extfloat.go:540 TEXT  (*extFloat).ShortestDecimal+0(SB),$420-20

Benchmarks with GOARCH=386 (on a Core 2).

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    7110191000   7079644000   -0.43%
BenchmarkFannkuch11      7769274000   7766514000   -0.04%
BenchmarkGobDecode         33454820     34755400   +3.89%
BenchmarkGobEncode         11675710     11007050   -5.73%
BenchmarkGzip            2013519000   1593855000  -20.84%
BenchmarkGunzip           253368200    242667600   -4.22%
BenchmarkJSONEncode       152443900    120763400  -20.78%
BenchmarkJSONDecode       304112800    247461800  -18.63%
BenchmarkMandelbrot200     29245520     29240490   -0.02%
BenchmarkParse              8484105      8088660   -4.66%
BenchmarkRevcomp         2695688000   2841263000   +5.40%
BenchmarkTemplate         363759800    277271200  -23.78%

benchmark                       old ns/op    new ns/op    delta
BenchmarkAtof64Decimal                127          129   +1.57%
BenchmarkAtof64Float                  166          164   -1.20%
BenchmarkAtof64FloatExp               308          300   -2.60%
BenchmarkAtof64Big                    584          571   -2.23%
BenchmarkAppendFloatDecimal           440          430   -2.27%
BenchmarkAppendFloat                  995          776  -22.01%
BenchmarkAppendFloatExp               897          746  -16.83%
BenchmarkAppendFloatNegExp            900          752  -16.44%
BenchmarkAppendFloatBig              1528         1228  -19.63%
BenchmarkAppendFloat32Integer         443          453   +2.26%
BenchmarkAppendFloat32ExactFraction   812          661  -18.60%
BenchmarkAppendFloat32Point          1002          773  -22.85%
BenchmarkAppendFloat32Exp             858          725  -15.50%
BenchmarkAppendFloat32NegExp          848          728  -14.15%
BenchmarkAppendFloat64Fixed1          447          431   -3.58%
BenchmarkAppendFloat64Fixed2          480          462   -3.75%
BenchmarkAppendFloat64Fixed3          461          457   -0.87%
BenchmarkAppendFloat64Fixed4          509          484   -4.91%

Update #1914.

R=rsc, nigeltao
CC=golang-dev, remy
https://golang.org/cl/6494107

f4e76d5e

crypto/tls: support session ticket resumption. · 65c7dc4a

Adam Langley authored Sep 24, 2012

Session resumption saves a round trip and removes the need to perform
the public-key operations of a TLS handshake when both the client and
server support it (which is true of Firefox and Chrome, at least).

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6555051

65c7dc4a

testing: document -test.bench flag · b7cbfe6a
Francesc Campoy authored Sep 24, 2012
```
Fixes #4080.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/6553068
```
b7cbfe6a