1. 18 May, 2016 3 commits
    • Emmanuel Odeke's avatar
      crypto/x509: fix typo in docs for CreateCertificateRequest · ac66bb34
      Emmanuel Odeke authored
      Update the doc for CreateCertificateRequest
      to state that it creates a
        `new certificate request`
      instead of just a
        `new certificate`
      
      Fixes #14649.
      
      Change-Id: Ibbbcf91d74168998990990e78e5272a6cf294d51
      Reviewed-on: https://go-review.googlesource.com/23204Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
      ac66bb34
    • Brad Fitzpatrick's avatar
      net/http: add test confirming a connection reuse case · f962e6e0
      Brad Fitzpatrick authored
      Verify that for a server doing chunked encoding, with the final data
      and EOF arriving together, the client will reuse the connection even
      if it closes the body without seeing an EOF. The server sends at least
      one non-zero chunk and one zero chunk. This verifies that the client's
      bufio reading reads ahead and notes the EOF, so even if the JSON
      decoder doesn't read the EOF itself, as long as somebody sees it, a
      close won't forcible tear down the connection. This was true at least
      of https://golang.org/cl/21291
      
      No code change. Test already passed (even with lots of runs, including
      in race mode with randomized goroutine scheduling).
      
      Updates #15703
      
      Change-Id: I2140b3eec6b099b6b6e54f153fe271becac5d949
      Reviewed-on: https://go-review.googlesource.com/23200
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: 's avatarAndrew Gerrand <adg@golang.org>
      f962e6e0
    • James Chacon's avatar
      runtime: prevent racefini from being invoked more than once · 733162fd
      James Chacon authored
      racefini calls __tsan_fini which is C code and at the end of it
      invoked the standard C library exit(3) call. This has undefined
      behavior if invoked more than once. Specifically in C++ programs
      it caused static destructors to run twice. At least on glibc
      impls it also means the at_exit handlers list (where those are
      stored) also free's a list entry when it completes these. So invoking
      twice results in a double free at exit which trips debug memory
      allocation tracking.
      
      Fix all of this by using an atomic as a boolean barrier around
      calls to racefini being invoked > 1 time.
      
      Fixes #15578
      
      Change-Id: I49222aa9b8ded77160931f46434c61a8379570fc
      Reviewed-on: https://go-review.googlesource.com/22882Reviewed-by: 's avatarDmitry Vyukov <dvyukov@google.com>
      Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      733162fd
  2. 17 May, 2016 6 commits
  3. 16 May, 2016 13 commits
  4. 15 May, 2016 6 commits
  5. 14 May, 2016 8 commits
  6. 13 May, 2016 4 commits