Commits · acf4dd4d56245edea2708dbffb959f8fb18d2506 · go / golang

02 Dec, 2009 23 commits
- change the naming example from Vector to Ring due to loss of vector.New() · acf4dd4d
  Rob Pike authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164082
```
  acf4dd4d
- Add copy to the list of predeclared functions. · ccd02648
  Ian Lance Taylor authored Dec 02, 2009
```
R=gri
https://golang.org/cl/164081
```
  ccd02648
- gofmt: race condition in error reporting and setting exit code · 0aa13c99
  Fazlul Shahriar authored Dec 02, 2009
```
How to reproduce:

	$ mkdir /tmp/foo
	$ cp /dev/null /tmp/foo/bar.go
	$ chmod -r /tmp/foo/bar.go
	$ gofmt /tmp/foo
	open /tmp/foo/bar.go: permission denied
	$ echo $?		# should echo 2
	0
	$

Maybe you need to put a call to time.Sleep at the beginning of report().

R=gri
CC=golang-dev
https://golang.org/cl/164073
```
  0aa13c99
- apply gofmt to json files · d8bc797e
  Robert Griesemer authored Dec 02, 2009
```
R=rsc
https://golang.org/cl/164071
```
  d8bc797e
- fix segfault printing errors. add test case and improve messages. · 114f73f8
  Rob Pike authored Dec 02, 2009
```
Fixes #338.

R=rsc
CC=golang-dev
https://golang.org/cl/163083
```
  114f73f8
- test that arrays work properly. · f6c0eba7
  Rob Pike authored Dec 02, 2009
```
can't mix slices and arrays now; perhaps that should be a TODO

R=rsc
https://golang.org/cl/164079
```
  f6c0eba7
- codereview: move reviewers to cc line after submit, · 69f893a1
  Russ Cox authored Dec 02, 2009
```
  so that the issue stops showing up on the
  per-reviewer dashboard page.

R=r
https://golang.org/cl/164075
```
  69f893a1
- time: another bug in SecondsToUTC. · 9e55d0d0
  Russ Cox authored Dec 02, 2009
```
added random test to look for more.

Fixes #363.

R=r, cw
https://golang.org/cl/163071
```
  9e55d0d0
- Add Shutdown to 32-bit GNU/Linux build. · 952b91e4
  Ian Lance Taylor authored Dec 02, 2009
```
Submitting as a TBR to fix the build.

R=dho, rsc
https://golang.org/cl/164078
```
  952b91e4
- lxml.etree is the wrong location for this alt package · e9a8ab03
  Devon H. O'Dell authored Dec 02, 2009
```
  on my linux machine this is the correct one. lxml.etree
  exists with an ElementTree class, but does not contain
  an .XML method.

R=rsc
https://golang.org/cl/163082
```
  e9a8ab03
- xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3) · 742221d2
  Devon H. O'Dell authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164053
```
  742221d2
- time: fix handling of Jan 1 1601, 1201, 801, ... · 8d652ee8
  Russ Cox authored Dec 02, 2009
```
R=r
CC=hurtonm
https://golang.org/cl/164074
```
  8d652ee8
- net: fix netFD.Close races · eb16346d
  Devon H. O'Dell authored Dec 02, 2009
```
Fixes #271.
Fixes #321.

R=rsc, agl, cw
CC=golang-dev
https://golang.org/cl/163052
```
  eb16346d
- explicitly catch attempt to decode into a value - must be a pointer to see the result. · ff3ea68e
  Rob Pike authored Dec 02, 2009
```
R=rsc
https://golang.org/cl/163070
```
  ff3ea68e
- make io.ReadFile use Stat.Size as a hint for preallocation · f9810f1b
  Rob Pike authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/163069
```
  f9810f1b
- Add syscall.Shutdown to FreeBSD i386/amd64 · 49ebcfbb
  Devon H. O'Dell authored Dec 02, 2009
```
Necessary for 163052

R=rsc
CC=golang-dev
https://golang.org/cl/164068
```
  49ebcfbb
- 8g: Match sgen definition to declaration · 1664e815
  Evan Shaw authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164069
```
  1664e815
- FreeBSD needs #!/usr/bin/env bash (fixes broken build on FreeBSD) · fd7e1a2d
  Devon H. O'Dell authored Dec 02, 2009
```
R=gri
https://golang.org/cl/163067
```
  fd7e1a2d
- syscall: add Shutdown on OS X, add more constants in mkerror.sh · 0b126c1b
  Russ Cox authored Dec 02, 2009
```
R=dho
CC=golang-dev
https://golang.org/cl/163061
```
  0b126c1b
- Add 'copy' as a Go builtin function for Vim syntax highlighter spec. · 42ec02be
  David Symonds authored Dec 02, 2009
```
R=rsc
https://golang.org/cl/163049
```
  42ec02be
- update package unicode to Unicode 5.2 · ceb1fe28
  Rob Pike authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/163062
```
  ceb1fe28
- gob: fix build · 2a54997b
  Russ Cox authored Dec 02, 2009
```
TBR=r
https://golang.org/cl/163064
```
  2a54997b
- Integrated feedback by Ken. · e9192758
  Robert Griesemer authored Dec 02, 2009
```
Easy stuff in this round, more to come.

R=iant, rsc, r, ken2
https://golang.org/cl/163058
```
  e9192758
01 Dec, 2009 12 commits

Explicitly return values where it's shadowing the parameter. · 4f6dbc69

Christopher Wedgwood authored Dec 01, 2009

Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>.

Resolves Issue 360.

R=rsc, dho, agl, agl1
CC=ukai
https://golang.org/cl/163055

4f6dbc69

8g: fix 386 floating point stack bug · e1c347ca
Charles L. Dorian authored Dec 01, 2009
```
Also fixes issue 310 comment 5 error.
Fixes #310.

R=rsc
https://golang.org/cl/163042
```
e1c347ca

more gob bugs · a0f742d3

Rob Pike authored Dec 01, 2009

1) need to send slice and array types (was only sending element types)
2) compatibleType needs to use decoder's type map

R=rsc
CC=golang-dev
https://golang.org/cl/164062

a0f742d3

make test.sh work again · 749da968
Robert Griesemer authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/164059
```
749da968
A/C: add Charles L. Dorian · 20cacd64
Russ Cox authored Dec 01, 2009
```
R=r
https://golang.org/cl/164060
```
20cacd64
Added Sven Almgren to AUTHORS and CONTRIBUTORS · 5dd66f01
Sven Almgren authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/163053
```
5dd66f01
a couple of usage fixups in prof · 67dc2ae3
Rob Pike authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/161050
```
67dc2ae3

gofmt: use os.Stdin instead of opening /dev/stdin · db18ce2f

Fazlul Shahriar authored Dec 01, 2009

Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:

	open /dev/stdin: no such device or address

Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:

	lrwxrwxrwx 1 root root  15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
	lrwx------ 1 fhs  users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]

(This is my first change, and I've signed the individual contributor license agreement.)

R=rsc, gri
CC=golang-dev
https://golang.org/cl/162041

db18ce2f

some godoc cleanup: · 9e450880

Robert Griesemer authored Dec 01, 2009

- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold

R=rsc
https://golang.org/cl/163051

9e450880

Fix typo in spec · 330139e3
Fazlul Shahriar authored Dec 01, 2009
```
R=golang-dev, rsc
https://golang.org/cl/164052
```
330139e3
Syntax coloring and function navigation for BBEdit/TextWrangler · 593ea313
Anthony Starks authored Dec 01, 2009
```
R=rsc
CC=agl1
https://golang.org/cl/154123
```
593ea313
Adding to AUTHORS and CONTRIBUTORS as per http://golang.org/doc/contribute.html#copyright · 1cf5d0d4
Anthony Starks authored Dec 01, 2009
```
R=rsc
https://golang.org/cl/163050
```
1cf5d0d4

30 Nov, 2009 5 commits

change command-line argument to be · 99d0c3d8

Roger Peppe authored Nov 30, 2009

unnamed, not require -n, in line with other
entries.

R=rsc
CC=r
https://golang.org/cl/162061

99d0c3d8

Make tests run on systems missing time utility · 842d69b0
Sergey 'SnakE' Gromov authored Nov 30, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164047
```
842d69b0
Added my name to the AUTHORS and CONTRIBUTORS files. · 5fcb0087
Adrian O'Grady authored Nov 30, 2009
```
R=rsc
https://golang.org/cl/157153
```
5fcb0087

A first stab at porting the XCB X11 protocol bindings to go. · 598f3e28

Tor Andersson authored Nov 30, 2009

The python script needs a checkout of xcb/proto to generate
an xproto.go file, which together with xgb.go provide functions
to access all of the core X11 protocol requests. I have included the
generated file.

Extensions and authentication methods are not implemented.

R=r, rsc, nigeltao_golang
https://golang.org/cl/162053

598f3e28

json: Decode into native Go data structures · 9d50b468

Sergey 'SnakE' Gromov authored Nov 30, 2009

This patch adds an ability to convert JSON-encoded data into
a hierarchy of Go's native data types.

R=rsc
CC=golang-dev
https://golang.org/cl/161060

9d50b468