- 30 Oct, 2012 13 commits
-
-
Nigel Tao authored
benchmark old ns/op new ns/op delta BenchmarkDecodeBaseline 3155638 2783998 -11.78% BenchmarkDecodeProgressive 4008088 3660310 -8.68% R=r, bradfitz CC=golang-dev https://golang.org/cl/6775072
-
Alexey Borzenkov authored
Fixes #4296. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/6815044
-
Rob Pike authored
Keys use ==; values use deep equality. Also remove the word 'member'. Fixes #4258. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6812055
-
Robert Griesemer authored
Remove trailing whitespace in comments. No other changes. R=r CC=golang-dev https://golang.org/cl/6815053
-
Robert Griesemer authored
Also: updated go fix testcases to pass tests. Fixes #4310. R=r CC=golang-dev https://golang.org/cl/6810055
-
Dave Cheney authored
Fixes #4302. R=golang-dev, bradfitz, adg CC=golang-dev https://golang.org/cl/6811048
-
Robert Griesemer authored
R=r CC=golang-dev https://golang.org/cl/6822051
-
Shenghou Ma authored
compiler_rt introduces a weak and hidden symbol compilerrt_abort_impl into our pre-linked _all.o object, we have to handle it. Fixes #4273. R=iant, rsc, r CC=golang-dev https://golang.org/cl/6783050
-
Dave Cheney authored
Occasionally GAE will return a 500 error response, don't treat this as a valid JSON body. R=adg, dsymonds CC=golang-dev https://golang.org/cl/6775066
-
Brad Fitzpatrick authored
Fixes #4303 R=golang-dev, adg CC=golang-dev https://golang.org/cl/6816058
-
Brad Fitzpatrick authored
Feature extraction was tested before, but not the final diffs. This CL breaks function main into a smaller main + testable compareAPI. No functional changes. R=golang-dev, adg CC=golang-dev https://golang.org/cl/6820057
-
Brad Fitzpatrick authored
API change. R=golang-dev, dsymonds, nigeltao, rsc, r CC=golang-dev https://golang.org/cl/6760045
-
Nigel Tao authored
On 6g/linux: benchmark old ns/op new ns/op delta BenchmarkFDCT 4606 4241 -7.92% BenchmarkIDCT 4187 3923 -6.31% BenchmarkDecodeBaseline 3154864 3170224 +0.49% BenchmarkDecodeProgressive 4072812 4017132 -1.37% BenchmarkEncode 39406920 34596760 -12.21% Stack requirements before (from 'go tool 6g -S'): (scan.go:37) TEXT (*decoder).processSOS+0(SB),$1352-32 (writer.go:448) TEXT (*encoder).writeSOS+0(SB),$5344-24 after: (scan.go:37) TEXT (*decoder).processSOS+0(SB),$1064-32 (writer.go:448) TEXT (*encoder).writeSOS+0(SB),$2520-24 Also, in encoder.writeSOS, re-use the yBlock scratch buffer for Cb and Cr. This reduces the stack requirement slightly, but also avoids an unlucky coincidence where a BenchmarkEncode stack split lands between encoder.writeByte and bufio.Writer.WriteByte, which occurs very often during Huffman encoding and is otherwise disasterous for the final benchmark number. FWIW, the yBlock re-use *without* the s/int/int32/ change does not have a noticable effect on the benchmarks. R=r CC=golang-dev, rsc https://golang.org/cl/6823043
-
- 29 Oct, 2012 11 commits
-
-
Roger Peppe authored
"JSON object" means something specific, which isn't the case here. R=golang-dev, r CC=golang-dev https://golang.org/cl/6789044
-
Dmitriy Vyukov authored
Fixes #4306. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6816054
-
Pawel Szczur authored
Fix the problem with no cookie handling when sending other than GET or HEAD request through (*Client) Do(*Request) (*Resposne, error). https://code.google.com/p/go/issues/detail?id=3985 Adds a function (*Client) send(*Request) (*Reponse, error): - sets cookies from CookieJar to request, - sends request - parses a reply cookies and updates CookieJar Fixes #3985 R=bradfitz CC=gobot, golang-dev https://golang.org/cl/6653049
-
Brad Fitzpatrick authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6820049
-
Adam Langley authored
RFC 5280 section 4.1.2.5.1 says so. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6775068
-
Adam Langley authored
Previously we converted a time to UTC *and* serialized the timezone of the original time. With this change, we serialize a UTCTime in the original timezone. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6817048
-
Luuk van Dijk authored
- make sure dclcontext == PAUTO only in function bodies - introduce PDISCARD to discard declarations in bodies of repeated imports - skip printing initializing OAS'es in export mode, assuming they only occur after ODCL's - remove ODCL and the initializing OAS from inl.c:ishairy - fix confused use of ->typecheck in typecheckinl: it's about the ->inl, not about the fn. - debuging aids: print ntype on ONAMEs too and -Emm instead of -Ell. fixes #2812 R=rsc CC=golang-dev https://golang.org/cl/6800043
-
Luuk van Dijk authored
includes step 0: synthesize outparams, from 6600044 includes step 1,2: give outparams loopdepth 0 and verify unchanged results generate esc:$mask tags, but still tie to sink if a param has mask != 0 from 6610054 adds final steps: - have esccall generate n->escretval, a list of nodes the function results flow to - use these in esccall and ORETURN/OAS2FUNC/and f(g()) - only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval R=rsc, bradfitz CC=dave, gobot, golang-dev, iant, rsc https://golang.org/cl/6741044
-
Andrew Radev authored
The "did_ftplugin" lines were ineffective and the "K" mapping was too invasive, which is why it was removed. R=golang-dev, dsymonds, minux.ma CC=golang-dev https://golang.org/cl/6823044
-
David Symonds authored
R=golang-dev, bradfitz CC=andrey.radev, golang-dev https://golang.org/cl/6775067
-
David Symonds authored
Too many people quote entire emails and put their reply at the top ("top posting"), so we shouldn't recognise review commands anywhere in the review text. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6815048
-
- 28 Oct, 2012 2 commits
-
-
Rémy Oudompheng authored
It is essentially identical to the version in 6g. R=dave, minux.ma, rsc CC=golang-dev https://golang.org/cl/6710043
-
Taj Khattra authored
R=golang-dev, fullung, dave, minux.ma CC=golang-dev https://golang.org/cl/6682046
-
- 27 Oct, 2012 1 commit
-
-
Patrick Smith authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6777066
-
- 26 Oct, 2012 6 commits
-
-
Ian Lance Taylor authored
Before this patch the test would close the file descriptor but not the os.File. When the os.File was GC'ed, the finalizer would close the file descriptor again. That would cause problems if the same file descriptor were returned by a later call to open in another test. On my system: > GOGC=30 go test --- FAIL: TestPassFD (0.04 seconds) passfd_test.go:62: FileConn: dup: bad file descriptor FAIL R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6776053
-
Shenghou Ma authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/6762051
-
Dave Cheney authored
setAddr was showing up in profiles due to string concatenation construction the os.File name field. netFD.sysfile's Name() is never used, except in dup() so I believe it is safe to avoid this allocation. R=mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/6742058
-
Dave Cheney authored
Thanks to Minux and Remy for their advice. The EOR optimisation is applied to a few places in the stdlib. // hash/crc32/crc32.go func update(crc uint32, tab *Table, p []byte) uint32 { crc = ^crc for _, v := range p { crc = tab[byte(crc)^v] ^ (crc >> 8) } return ^crc } before: --- prog list "update" --- 0164 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:101) TEXT update+0(SB),$12-24 0165 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:101) MOVW tab+4(FP),R8 0166 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:102) MOVW crc+0(FP),R0 0167 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:102) EOR $-1,R0,R5 0168 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:103) MOVW p+8(FP),R0 0169 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:103) MOVW R0,autotmp_0019+-12(SP) after: --- prog list "update" --- 0164 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:101) TEXT update+0(SB),$12-24 0165 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:101) MOVW tab+4(FP),R8 0166 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:102) MOVW crc+0(FP),R0 0167 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:102) MVN R0,R5 0168 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:103) MOVW p+8(FP),R0 0169 (/home/dfc/go/src/pkg/hash/crc32/crc32.go:103) MOVW R0,autotmp_0019+-12(SP) After 5l has done its work, crc = ^crc 3d710: e59d0014 ldr r0, [sp, #20] 3d714: e3e0b000 mvn fp, #0 3d718: e020500b eor r5, r0, fp becomes crc = ^crc 3d710: e59d0014 ldr r0, [sp, #20] 3d714: e1e05000 mvn r5, r0 The MOVB optimisation has a small impact on the stdlib, in strconv and gzip. // GZIP (RFC 1952) is little-endian, unlike ZLIB (RFC 1950). func put2(p []byte, v uint16) { p[0] = uint8(v >> 0) p[1] = uint8(v >> 8) } before: --- prog list "put2" --- 1369 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:76) TEXT put2+0(SB),$0-16 1370 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:76) MOVHU v+12(FP),R4 1371 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVHU R4,R0 1372 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVHU R0,R0 1373 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVBU R0,R1 1374 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVBU R1,R3 1375 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVW $p+0(FP),R1 after: --- prog list "put2" --- 1369 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:76) TEXT put2+0(SB),$0-16 1370 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:76) MOVHU v+12(FP),R4 1371 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVHU R4,R0 1372 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVBU R0,R1 1373 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVBU R1,R3 1374 (/home/dfc/go/src/pkg/compress/gzip/gzip.go:77) MOVW $p+0(FP),R1 R=remyoudompheng, rsc, minux.ma CC=golang-dev https://golang.org/cl/6674048
-
Rémy Oudompheng authored
Fixes #4282. R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/6759052
-
Dmitriy Vyukov authored
Fixes #4275. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6759053
-
- 25 Oct, 2012 4 commits
-
-
Rémy Oudompheng authored
Used to print: ../test/torture.go:116: internal compiler error: bad width: 0463 (../test/torture.go:116) MOVB ,BX (0, 8) R=nigeltao, rsc CC=golang-dev https://golang.org/cl/6736068
-
Marcel van Lohuizen authored
- Allow secondary values below the default value in second form. This is to support before tags for secondary values, as used by Chinese. - Eliminate collation elements that are guaranteed to be immaterial after a weight increment. R=r CC=golang-dev https://golang.org/cl/6739051
-
Shenghou Ma authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6763043
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6743059
-
- 24 Oct, 2012 3 commits
-
-
Marcel van Lohuizen authored
different indexes for values and index blocks. Fixes many regressions. R=r CC=golang-dev https://golang.org/cl/6737057
-
Marcel van Lohuizen authored
R=r CC=golang-dev https://golang.org/cl/6752043
-
Marcel van Lohuizen authored
R=r CC=golang-dev https://golang.org/cl/6749058
-