Skip to content

G
golang
Switch branch/tag
  1. 09 May, 2014 11 commits
    • ChaiShushan's avatar
      test/bench/shootout: support windows · aed97626
      ChaiShushan authored 
      1. fix executable extension (a.out -> a.exe).
2. fix pthread build error on mingw
3. if depends lib messing, skip the test

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/100210043
      aed97626
    • Ian Lance Taylor's avatar
      encoding/binary: document that Read requires exported struct fields · c00804c5
      Ian Lance Taylor authored 
      Add a test for the current behaviour.

Fixes #7482.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/95160043
      c00804c5
    • Russ Cox's avatar
      cmd/go: accept build flags in clean and list · 0f52fdbf
      Russ Cox authored 
      list has been adding them one at a time haphazardly
(race and tags were there and documented; compiler
was there and undocumented).

clean -i needs -compiler in order to clean the
installed targets for alternate compilers.

Fixes #7302.

While we're here, tweak the language in the 'go get' docs
about build flags.

Fixes #7807.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/99130043
      0f52fdbf
    • Russ Cox's avatar
      math/cmplx: specify which square root Sqrt returns · 2182d578
      Russ Cox authored 
      Fixes #7851.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/93200043
      2182d578
    • Russ Cox's avatar
      cmd/gc: disable link-time copying of un-Go-initialized globals · e5c10503
      Russ Cox authored 
      If you write:

        var x = 3

then the compiler arranges for x to be initialized in the linker
with an actual 3 from the data segment, rather than putting
x in the bss and emitting init-time "x = 3" assignment code.

If you write:

        var y = x
        var x = 3

then the compiler is clever and treats this the same as if
the code said 'y = 3': they both end up in the data segment
with no init-time assignments.

If you write

        var y = x
        var x int

then the compiler was treating this the same as if the
code said 'x = 0', making both x and y zero and avoiding
any init-time assignment.

This copying optimization to avoid init-time assignment of y
is incorrect if 'var x int' doesn't mean 'x = 0' but instead means
'x is initialized in C or assembly code'. The program ends up
with 'y = 0' instead of 'y = the value specified for x in that other code'.

Disable the propagation if there is no initializer for x.

This comes up in some uses of cgo, because cgo generates
Go globals that are initialized in accompanying C files.

Fixes #7665.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/93200044
      e5c10503
    • Russ Cox's avatar
      crypto/aes: fix overrun in assembly encrypt/decrypt · 3e8ed96c
      Russ Cox authored 
      Fixes #7928.

LGTM=bradfitz
R=golang-codereviews
CC=agl, bradfitz, golang-codereviews
https://golang.org/cl/91320043
      3e8ed96c
    • Russ Cox's avatar
      cmd/gc: fix ... escape analysis bug · c99dce2b
      Russ Cox authored 
      If the ... element type contained no pointers,
then the escape analysis did not track the ... itself.
This manifested in an escaping ...byte being treated
as non-escaping.

Fixes #7934.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/100310043
      c99dce2b
    • Josh Bleecher Snyder's avatar
      cmd/gc: don't give credit for NOPs during register allocation · 1848d714
      Josh Bleecher Snyder authored 
      The register allocator decides which variables should be placed into registers by charging for each load/store and crediting for each use, and then selecting an allocation with minimal cost. NOPs will be eliminated, however, so using a variable in a NOP should not generate credit.

Issue 7867 arises from attempted registerization of multi-word variables because they are used in NOPs. By not crediting for that use, they will no longer be considered for registerization.

This fix could theoretically lead to better register allocation, but NOPs are rare relative to other instructions.

Fixes #7867.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/94810044
      1848d714
    • Robert Hencke's avatar
      cmd/go: mark regexp as dependency of testmain · 52961b90
      Robert Hencke authored 
      Fixes #6844.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://golang.org/cl/97840043
      52961b90
    • Russ Cox's avatar
      testing: write profiles on failure · 21e75b32
      Russ Cox authored 
      Fixes #7901.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/90930044
      21e75b32
    • Mikio Hara's avatar
      net: drop flakey TestDialFailPDLeak · f40f0b26
      Mikio Hara authored 
      TestDialFailPDLeak was created for testing runtime-integrated netwrok
poller stuff and used during Go 1.2 development cycle. Unfortunately
it's still flakey because it depends on MemStats of runtime, not
pollcache directly, and MemStats accounts and revises its own stats
occasionally.

For now the codepaths related to runtime-intergrated network poller
are pretty stable, so removing this test case never suffers us.

Fixes #6553.

LGTM=josharian, iant
R=iant, josharian
CC=golang-codereviews
https://golang.org/cl/98080043
      f40f0b26
  3. 08 May, 2014 4 commits
  5. 07 May, 2014 14 commits
  7. 06 May, 2014 3 commits
  9. 05 May, 2014 6 commits
  11. 02 May, 2014 2 commits