Commits · aeeda707ffdcd29efdec510ffe40061384b0dfdf · go / golang

06 Jan, 2014 3 commits

runtime: Fix panic when trying to stop CPU profiling with profiler turned off · aeeda707
Emil Hessman authored Jan 06, 2014
```
Fixes #7063.

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/47950043
```
aeeda707

misc/emacs: fontify type switch correctly · 79653e41

Dominik Honnef authored Jan 06, 2014

Require at least one space after "type" and do not fontify closing
parenthesis of type switch as a type.

R=adonovan
CC=golang-codereviews
https://golang.org/cl/37720050

79653e41

misc/emacs: minor cleanups · 81cab4c3
Dominik Honnef authored Jan 06, 2014
```
R=adonovan
CC=golang-codereviews
https://golang.org/cl/23290044
```
81cab4c3

05 Jan, 2014 1 commit

crypto/sha1, crypto/sha256, crypto/sha512: use copy for partial block · 29fe067b

Joel Sing authored Jan 05, 2014

Use copy rather than a hand rolled loop when moving a partial input
block to the scratch area. This results in a reasonable performance
gain when partial blocks are written.

Benchmarks on Intel(R) Xeon(R) CPU X5650  @ 2.67GHz with Go amd64:

       benchmark               old MB/s     new MB/s  speedup
SHA1   BenchmarkHash8Bytes        18.37        22.80    1.24x
SHA256 BenchmarkHash8Bytes        11.86        13.78    1.16x
SHA512 BenchmarkHash8Bytes         4.51         5.24    1.16x

       benchmark              old ns/op    new ns/op    delta
SHA1   BenchmarkHash8Bytes          435          350  -19.54%
SHA256 BenchmarkHash8Bytes          674          580  -13.95%
SHA512 BenchmarkHash8Bytes         1772         1526  -13.88%

R=agl, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/35840044

29fe067b

04 Jan, 2014 5 commits

container/list: improve test coverage · 48334e3e

Shawn Smith authored Jan 04, 2014

R=golang-codereviews, dave, gobot, bradfitz, gri
CC=golang-codereviews
https://golang.org/cl/46640043

48334e3e

runtime: plan 9 does have /dev/random · c136197c

Jeff Sickel authored Jan 04, 2014

R=golang-codereviews, r, aram
CC=0intro, golang-codereviews, rsc
https://golang.org/cl/43420045

c136197c

spec: s/and/or/ for correctness and parallelism · 82e2db70

Rob Pike authored Jan 04, 2014

No change to the meaning, just bad writing found by
Doug McIlroy.
Let's start the new year off with a bang.

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/47110044

82e2db70

runtime: Fix race detector checks to ignore KindNoPointers bit · f59ea4e5
Keith Randall authored Jan 04, 2014
```
when comparing kinds.

R=dvyukov, dave, khr
CC=golang-codereviews
https://golang.org/cl/41660045
```
f59ea4e5

spec: Fix broken type identity link · 13141315

Emil Hessman authored Jan 04, 2014

Fixes #7003.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/47780043

13141315

03 Jan, 2014 5 commits

os: add tests for operations on nil *File methods · 30ba286c
Dave Cheney authored Jan 03, 2014
```
R=shawn.p.smith, gobot, r
CC=golang-codereviews
https://golang.org/cl/46820043
```
30ba286c

os: return ErrInvalid if receiver is nil. · f2e946f9

Dave Cheney authored Jan 03, 2014

Fixes #7043.

Test coming in https://golang.org/cl/46820043

R=r, bradfitz
CC=golang-codereviews
https://golang.org/cl/38330045

f2e946f9

cmd/gc: silence assignment errors to undefined symbols · f2e94b58
Daniel Morsing authored Jan 03, 2014
```
Fixes #6406.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46900043
```
f2e94b58

encoding/json: Fix missing error when trying to unmarshal null string into int,… · 880442f1

Emil Hessman authored Jan 03, 2014

encoding/json: Fix missing error when trying to unmarshal null string into int, for successive ,string option

Fixes #7046.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/47260043

880442f1

syscall: handle varied path lengths for unix sockets · d1805791

Joel Sing authored Jan 03, 2014

Most BSDs include the trailing NUL character of the socket path in the
length, however some do not (such as NetBSD 6.99). Handle this by only
subtracting the family and length bytes from the returned length, then
scanning the path and removing any terminating NUL bytes.

Fixes #6627.

R=golang-codereviews, mikioh.mikioh
CC=golang-codereviews
https://golang.org/cl/46420044

d1805791

02 Jan, 2014 5 commits

runtime: increase attempt count for map iteration order test. · 8778760a

David Symonds authored Jan 02, 2014

Some builders broke on this test; I'm guessing that was because
this test didn't try hard enough to find a different iteration order.

Update #6719

R=dave
CC=golang-codereviews
https://golang.org/cl/47300043

8778760a

runtime: add a test for randomised map iteration order. · d4c66a35

David Symonds authored Jan 02, 2014

Technically the spec does not guarantee that the iteration order is random,
but it is a property that we have consciously pursued, and so it seems
right to verify that our implementation does indeed randomise.

Update #6719.

R=khr, bradfitz
CC=golang-codereviews
https://golang.org/cl/47010043

d4c66a35

A+C: Pavel Zinovkin (individual CLA) · 3a765be9
Brad Fitzpatrick authored Jan 02, 2014
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/39780047
```
3a765be9
encoding/hex: add Decode error test case · eaff83b9
Shawn Smith authored Jan 02, 2014
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46880043
```
eaff83b9
time: add tests for Duration.Nanoseconds, Duration.Minutes, and Duration.Hours · b38da05a
Shawn Smith authored Jan 02, 2014
```
R=golang-codereviews, rsc, dave
CC=golang-codereviews
https://golang.org/cl/42440043
```
b38da05a

01 Jan, 2014 5 commits
- encoding/json: add tests for InvalidUnmarshalError · 66730120
  Dave Cheney authored Jan 01, 2014
```
R=golang-codereviews, shawn.p.smith
CC=golang-codereviews
https://golang.org/cl/41960047
```
  66730120
- bufio: improve NewReaderSize, Peek, and UnreadByte test coverage · 4d239bce
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/42990045
```
  4d239bce
- encoding/json: improve omitempty test coverage · a39f3b29
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/46250043
```
  a39f3b29
- os: improve Readdir and Readdirnames test coverage · 3c7d2e6a
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46450043
```
  3c7d2e6a
- encoding/hex: add Decode test case with uppercase hex characters · 87327137
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46270043
```
  87327137
31 Dec, 2013 8 commits

debug/elf: add C source for testdata executables · 592416a3

Michael Stapelberg authored Dec 31, 2013

This source file, when compiled with gcc 4.4.3 on Ubuntu lucid,
corresponds instruction for instruction to the binaries in the same
directory.

Shipping this source code file resolves http://bugs.debian.org/716853

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/46780043

592416a3

crypto/sha256: add tests for Size() and BlockSize() · e3040e2b
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46470043
```
e3040e2b

2014: Year of the Gopher. · 8f3fc547

David Symonds authored Dec 31, 2013

R=adg, djd, mpvl, nigeltao
CC=golang-codereviews
https://golang.org/cl/46660043

8f3fc547

crypto/sha1: add tests for Size() and BlockSize() · 0333e80d
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46400044
```
0333e80d
container/ring: add test for Move with empty Ring · a1731ac0
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46630044
```
a1731ac0

net: fix typo · b4571bdf

Mikio Hara authored Dec 31, 2013

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/46600043

b4571bdf

crypto/sha512: add tests for Size() and BlockSize() · dcf562df
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/43550047
```
dcf562df
text/template: don't panic when using AddParseTree with an unparsed template · ff006982
Josh Bleecher Snyder authored Dec 31, 2013
```
Fixes #7032.

R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/43960045
```
ff006982

30 Dec, 2013 6 commits

spec: example shows wrong value for complex constant · 8183ed19

Mihai Borobocea authored Dec 30, 2013

Looks like a typo.
Fixes #7011.

R=golang-codereviews, r, bradfitz
CC=golang-codereviews
https://golang.org/cl/45350043

8183ed19

A+C: Mihai Borobocea (individual CLA) · 206eff71
Brad Fitzpatrick authored Dec 30, 2013
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/46540044
```
206eff71

cmd/6g: inline copies of up to 4 words in length. · 0ea20bc9

Keith Randall authored Dec 30, 2013

This change fixes a serious performance regression
with reflect.Value growing to 4 words instead of 3.
The json benchmark was ~50% slower, with this change
it is ~5% slower (and the binary is 0.5% larger).

Longer term, we probably need to rethink our copy
generation.  Using REP is really expensive time-wise.
But inlining the copy grows the binary.

R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/44990043

0ea20bc9

runtime: use readrange instead of read to check for races · 1cc2ff8f

Keith Randall authored Dec 30, 2013

on map keys and values which are now passed by reference.

R=dvyukov, khr
CC=golang-codereviews
https://golang.org/cl/43490044

1cc2ff8f

reflect: fixed method name in Slice3 error message · 7ff57e2f
Richard Musiol authored Dec 30, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46500043
```
7ff57e2f
reflect: add DeepEqual slice of slice inequality test · 96ee10fb
Shawn Smith authored Dec 30, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46510043
```
96ee10fb

29 Dec, 2013 2 commits
- doc/contribute: golang-dev -> golang-codereviews · 2f5f1939
  Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/46320043
```
  2f5f1939
- reflect: remove length check for arrays in deepValueEqual · c989a0b2
  Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/39910044
```
  c989a0b2