Commits · b08a3164c0a10b608db0e9fafcdc3c9168e3cffe · go / golang

18 Apr, 2013 3 commits

crypto/rand: better panic message for invalid Int argument. · b08a3164

Rémy Oudompheng authored Apr 18, 2013

Also document the panic to be consistent with math/rand.

Fixes #5187.

R=golang-dev, dave, bradfitz, r
CC=golang-dev
https://golang.org/cl/8303043

b08a3164

mime/multipart: don't strip leading space/tab in quoted-printable decoding · 24555c7b

Brad Fitzpatrick authored Apr 18, 2013

Late bug fix, but this is arguably a regression from Go 1.0,
since we added this transparent decoding since then. Without
this fix, Go 1.0 users could decode this correctly, but Go 1.1
users would not be able to.

The newly added test is from the RFC itself.

The updated tests had the wrong "want" values before. They
were there to test \r\n vs \n equivalence (which is
unchanged), not leading whitespace.

The skipWhite decoder struct field was added in the battles of
Issue 4771 in revision b3bb265bfecf. It was just a wrong
strategy, from an earlier round of attempts in
https://golang.org/cl/7300092/

Update #4771
Fixes #5295

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8536045

24555c7b

misc/dashboard/builder: include $USER in build environment. · 67e26fce
David Symonds authored Apr 18, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8821046
```
67e26fce

17 Apr, 2013 4 commits
- doc/go1.1.html, mime/multipart: document quoted-printable decoding · 32f2fd15
  Brad Fitzpatrick authored Apr 17, 2013
```
Fixes #5293

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8840043
```
  32f2fd15
- archive/zip: add docs on type of slashes in paths · b95c4891
  Brad Fitzpatrick authored Apr 17, 2013
```
Fixes #5307

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8676046
```
  b95c4891
- go/token: fix grammar for precedence consts · d00a646e
  Alexei Sholik authored Apr 17, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8662045
```
  d00a646e
- misc/cgo/test: fix a gcc warning · a4196bb6
  Shenghou Ma authored Apr 17, 2013
```
See https://code.google.com/p/go/issues/detail?id=5227#c16.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8833044
```
  a4196bb6
16 Apr, 2013 5 commits
- doc: more doubled words · a9c69520
  Rob Pike authored Apr 16, 2013
```
I wrote a tool.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8695047
```
  a9c69520
- doc/effective_go: another doubled word · f29013d1
  Rob Pike authored Apr 16, 2013
```
It's clear that that should never happen.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8798045
```
  f29013d1
- doc/effective_go.html: fix typo · 86cd1d9e
  Shenghou Ma authored Apr 16, 2013
```
Fixes #5296.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8682044
```
  86cd1d9e
- cmd/dist, make.bash: pass -mmacosx-version-min=10.6 to gcc on Darwin · a5fe79ef
  Shenghou Ma authored Apr 16, 2013
```
Fixes #5261.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8798044
```
  a5fe79ef
- runtime: if span was scavenged, mark it as needing to be zeroed · 9ad236ab
  Ian Lance Taylor authored Apr 16, 2013
```
Update #4979.

R=dvyukov, r, bradfitz
CC=golang-dev
https://golang.org/cl/8697045
```
  9ad236ab
15 Apr, 2013 6 commits

database/sql: close driver Stmt before releasing Conn · 36d3bef8

Brad Fitzpatrick authored Apr 15, 2013

From the issue, which describes it as well as I could:

database/sql assumes that driver.Stmt.Close does not need the
connection.

see database/sql/sql.go:1308:

This puts the Rows' connection back into the idle pool, and
then calls the driver.Stmt.Close method of the Stmt it belongs
to.  In the postgresql driver implementation
(https://github.com/lib/pq), Stmt.Close communicates with the
server (on the connection that was just put back into the idle
pool).  Most of the time, this causes no problems, but if
another goroutine makes a query at the right (wrong?) time,
chaos results.

In any case, traffic is being sent on "free" connections
shortly after they are freed, leading to race conditions that
kill the driver code.

Fixes #5283

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8633044

36d3bef8

doc/reference.html: update list of sub-repositories. · 80de7ab1
Shenghou Ma authored Apr 15, 2013
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/8766043
```
80de7ab1
net/http/cookiejar: mention go.net/publicsuffix. · 83b7b0e2
Shenghou Ma authored Apr 15, 2013
```
R=golang-dev, r, gary.burd, dr.volker.dobler
CC=golang-dev
https://golang.org/cl/8660046
```
83b7b0e2

test/stress: start of a runtime stress program · b3809cae

Brad Fitzpatrick authored Apr 15, 2013

Runs forever, stressing the runtime in various ways.

It should never terminate.

R=golang-dev, r, minux.ma
CC=golang-dev
https://golang.org/cl/8583047

b3809cae

cmd/ld: ignore PE sections that are not code or data · 9ca4a25f
Ian Lance Taylor authored Apr 15, 2013
```
Update #5106
Update #5273

R=minux.ma, r
CC=golang-dev
https://golang.org/cl/8715043
```
9ca4a25f
runtime: fix build on openbsd/386 · 804ef381
Joel Sing authored Apr 15, 2013
```
R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/8569043
```
804ef381

14 Apr, 2013 1 commit
- crypto/ecdsa: doc cleanup · 03640c58
  Brad Fitzpatrick authored Apr 14, 2013
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/8592044
```
  03640c58
13 Apr, 2013 3 commits

doc: fix typo · 0009210b

Stefan Nilsson authored Apr 13, 2013

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/8729045

0009210b

cmd/gc: disable inlining of method values · 7b8e0861

Daniel Morsing authored Apr 13, 2013

They caused internal compiler errors and they're expensive enough that inlining them doesn't make sense.

Fixes #5259.

R=golang-dev, r, iant, remyoudompheng
CC=golang-dev
https://golang.org/cl/8636043

7b8e0861

go/scanner: reject BOMs that are not at the beginning · 968732b6

Robert Griesemer authored Apr 13, 2013

For compliance with gc. See also issue 5265.
Not Go1.1 critical, but harmless.

R=r
CC=golang-dev
https://golang.org/cl/8736043

968732b6

12 Apr, 2013 9 commits

testing/iotest: rephrase DataErrReader's description · d4d06358
Alexei Sholik authored Apr 12, 2013
```
R=r
CC=golang-dev
https://golang.org/cl/8650044
```
d4d06358
test: make goprint.go wait longer for go its routine to execute · 4925f8aa
Carl Shapiro authored Apr 12, 2013
```
Update #5281

R=golang-dev, r, bradfitz, cshapiro
CC=golang-dev
https://golang.org/cl/8631047
```
4925f8aa
test: raise the allocation threshold for chan/select2.go failure · 14cb1a1d
Carl Shapiro authored Apr 12, 2013
```
Updates #5282

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8718045
```
14cb1a1d

cmd/go: quote command line arguments in debug output · 18ff7274

Volker Dobler authored Apr 12, 2013

Debug output from go test -x may contain empty arguments.
This CL quotes arguments if needed. E.g. the output of
go test -x is now
  .../6g -o ./_go_.6 -p testmain -complete -D "" -I . -I $WORK ./_testmain.go
which is easier to grasp.

R=golang-dev, bradfitz, minux.ma, r
CC=golang-dev
https://golang.org/cl/8633043

18ff7274

cmd/go: quote command line arguments in debug output · ce64f736

Volker Dobler authored Apr 12, 2013

Debug output from go test -x may contain empty arguments.
This CL quotes arguments if needed. E.g. the output of
go test -x is now
  .../6g -o ./_go_.6 -p testmain -complete -D "" -I . -I $WORK ./_testmain.go
which is easier to grasp.

R=golang-dev, bradfitz, minux.ma, r
CC=golang-dev
https://golang.org/cl/8633043

ce64f736

cmd/ld: always do external link for -linkmode=external · 69690120

Ian Lance Taylor authored Apr 12, 2013

There are tests in run.bash for -linkmode=external.

Fixes #5238.

R=golang-dev, bradfitz, remyoudompheng, r
CC=golang-dev
https://golang.org/cl/8716044

69690120

cmd/ld: if we fail from an unexpected PE flags value, print it · 813590b1
Ian Lance Taylor authored Apr 12, 2013
```
R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/8709043
```
813590b1

runtime: add a hook to disable precise GC · 709e03f4

Ian Lance Taylor authored Apr 12, 2013

This will let us ask people to rebuild the Go system without
precise GC, and then rebuild and retest their program, to see
if precise GC is causing whatever problem they are having.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8700043

709e03f4

runtime: use UMTX_OP_WAIT_UINT on FreeBSD · 9fe8681d

Ian Lance Taylor authored Apr 12, 2013

UMTX_OP_WAIT expects that the address points to a uintptr, but
the code in lock_futex.c uses a uint32.  UMTX_OP_WAIT_UINT is
just like UMTX_OP_WAIT, but the address points to a uint32.
This almost certainly makes no difference on a little-endian
system, but since the kernel supports it we should do the
right thing.  And, who knows, maybe it matters.

R=golang-dev, bradfitz, r, ality
CC=golang-dev
https://golang.org/cl/8699043

9fe8681d

11 Apr, 2013 7 commits

misc/dist/darwin: add execute bit to preinstall · 1d1142f1
Rob Pike authored Apr 11, 2013
```
Fixes #5258.

R=golang-dev, iant, minux.ma
CC=golang-dev
https://golang.org/cl/8682043
```
1d1142f1
encoding/json: documentation regarding anonymous fields. · 88f9ab89
Rob Pike authored Apr 11, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/8545046
```
88f9ab89
gc: escape unicode BOM in exported string literals · a9f1569e
Volker Dobler authored Apr 11, 2013
```
Fixes #5260.

R=golang-dev, minux.ma, 0xjnml, r
CC=golang-dev
https://golang.org/cl/8658043
```
a9f1569e

spec: add another sentence about BOMs · 548c65a5

Rob Pike authored Apr 11, 2013

Although one may argue that they should be legal, gc (at least)
disallows byte order marks that are not the first code point
in the file. Added a sentence to the "Implementation restriction"
clause in the "Source code representation" section to document
this better.

Lifting this restriction (again - the rule has changed at least
twice already) would not break any existing programs, should
we later decide yet again to fiddle the rules about these little
fly specks.

R=golang-dev, dsymonds, gri
CC=golang-dev
https://golang.org/cl/8649043

548c65a5

cmd/cgo, cmd/go: remove #cgo directive parsing from cmd/cgo · d06be395

Andrew Wilkins authored Apr 11, 2013

This change removes processing of #cgo directives from cmd/cgo,
pushing the onus back on cmd/go to pass all necessary flags.

Fixes #5224. See comments for rationale.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/8610044

d06be395

bufio/Scan: fix error handling at EOF · 082a4a8a

Rob Pike authored Apr 11, 2013

Fixes #5268.

R=golang-dev, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/8646045

082a4a8a

cmd/ld: fix scope of static objects in symbol table · 7ac20853

Anthony Martin authored Apr 11, 2013

All symbols are currently marked with global scope.
The correct behavior was lost when the symbol table
format was changed.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/8625043

7ac20853

10 Apr, 2013 2 commits

fmt: tweak the explanation of Stringer to be more correct and less specific · bb195f67

Rob Pike authored Apr 10, 2013

The String method is called whenever the printing operation wants a string,
not just for %s and %v.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8638043

bb195f67

go/ast: distinguish between methods and functions in filtering · d06313e8
Robert Griesemer authored Apr 10, 2013
```
Go1.1 harmless, but not critical.

Fixes #5249.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8609043
```
d06313e8