Skip to content

G
golang
Switch branch/tag
  1. 17 Oct, 2011 7 commits
  3. 16 Oct, 2011 2 commits
  5. 15 Oct, 2011 5 commits
    • Anthony Martin's avatar
      goyacc: clean up after units · fc61ea3b
      Anthony Martin authored 
      R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5286047
      fc61ea3b
    • Alex Brainman's avatar
      syscall: dll function load and calling changes · 78479163
      Alex Brainman authored 
      New DLL and Proc types to manage and call dll functions. These were
used to simplify syscall tests in runtime package. They were also
used to implement LazyDLL and LazyProc.

LazyProc, like Proc, now have Call function, that just a wrapper for
SyscallN. It is not as efficient as Syscall, but easier to use.

NewLazyDLL now supports non-ascii filenames.

LazyDLL and LazyProc now have Load and Find methods. These can be used
during runtime to discover if some dll functions are not present.

All dll functions now return errors that fit os.Error interface. They
also contain Windows error number.

Some of these changes are suggested by jp.

R=golang-dev, jp, rsc
CC=golang-dev
https://golang.org/cl/5272042
      78479163
    • Andrew Balholm's avatar
      html: improve parsing of comments and "bogus comments" · b770c9e9
      Andrew Balholm authored 
      R=nigeltao
CC=golang-dev
https://golang.org/cl/5279044
      b770c9e9
    • Brad Fitzpatrick's avatar
      http: DoS protection: cap non-Handler Request.Body reads · 5079129d
      Brad Fitzpatrick authored 
      Previously, if an http.Handler didn't fully consume a
Request.Body before returning and the request and the response
from the handler indicated no reason to close the connection,
the server would read an unbounded amount of the request's
unread body to advance past the request message to find the
next request's header. That was a potential DoS.

With this CL there's a threshold under which we read
(currently 256KB) in order to keep the connection in
keep-alive mode, but once we hit that, we instead
switch into a "Connection: close" response and don't
read the request body.

Fixes #2093 (along with number of earlier CLs)

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5268043
      5079129d
    • Anthony Martin's avatar
      http: avoid panic caused by nil URL · b5077f82
      Anthony Martin authored 
      The current code will panic if an invalid
request (one with a nil URL) is passed to
the doFollowingRedirects function.

Also, remove a redundant nil Header check.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5270046
      b5077f82
  7. 14 Oct, 2011 22 commits
  9. 13 Oct, 2011 4 commits
    • Robert Griesemer's avatar
      gotype: move to exp/gotype per Go 1 plan · 812249fe
      Robert Griesemer authored 
      R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5269043
      812249fe
    • Robert Griesemer's avatar
      gotype: fix build (update test) · da7538c2
      Robert Griesemer authored 
      R=r
CC=golang-dev
https://golang.org/cl/5277044
      da7538c2
    • Nigel Tao's avatar
      html: rewrite the tokenizer to be more consistent. · a49b8b98
      Nigel Tao authored 
      Previously, the tokenizer made two passes per token. The first pass
established the token boundary. The second pass picked out the tag name
and attributes inside that boundary. This was problematic when the two
passes disagreed. For example, "<p id=can't><p id=won't>" caused an
infinite loop because the first pass skipped everything inside the
single quotes, and recognized only one token, but the second pass never
got past the first '>'.

This change rewrites the tokenizer to use one pass, accumulating the
boundary points of token text, tag names, attribute keys and attribute
values as it looks for the token endpoint.

It should still be reasonably efficient: text, names, keys and values
are not lower-cased or unescaped (and converted from []byte to string)
until asked for.

One of the token_test test cases was fixed to be consistent with
html5lib. Three more test cases were temporarily disabled, and will be
re-enabled in a follow-up CL. All the parse_test test cases pass.

R=andybalholm, gri
CC=golang-dev
https://golang.org/cl/5244061
      a49b8b98
    • Russ Cox's avatar
      gofix: make fix order explicit · 6198336b
      Russ Cox authored 
      Also test only specific fixes, not all fixes.
This means we don't have to keep updating old
test cases to match later changes to the library.

I had to adjust some of the reflect test cases,
because they were implicitly testing
reflect+oserrorstring, not just reflect.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5283042
      6198336b