Commits · b21611b963ec66b1e56c5d82274ae87f35983a59 · go / golang

13 Aug, 2010 7 commits

fmt/print: give %p priority, analogous to %T · b21611b9
Rob Pike authored Aug 13, 2010
```
Fixes #1024.

R=rsc
CC=golang-dev
https://golang.org/cl/1961042
```
b21611b9
fix bounds check in error recovery · 3efb4c3b
Ken Thompson authored Aug 13, 2010
```
(thanks to avp@mit.edu)

R=rsc
CC=golang-dev
https://golang.org/cl/1998041
```
3efb4c3b

go AST: First step towards augmenting AST with full type information. · 1f9dfa29

Robert Griesemer authored Aug 13, 2010

- change ast.Ident back to contain the name and adjust all dependent code
- identifier object information will be added again through an optional
  typechecker phase (in the works).
- remove tracking of scopes in parser - it's easier to do this in a separate
  phase (in the works)
- in godoc, generate popup info table directly instead of through a formatter
  for simpler data flow (at the expense of a little bit more code)

Runs all tests.

As a result of this change, the currently shown popup information
(const, var, type, func, followed by identifier name) will not be
shown anymore temporarily.

R=rsc
CC=golang-dev
https://golang.org/cl/1994041

1f9dfa29

fmt/print: honor Formatter in Print, Println. · be97fa4c

Rob Pike authored Aug 13, 2010

Rearrange code to clarify handling of %T, Formatter, GoStringer, and Stringer.

R=rsc
CC=golang-dev
https://golang.org/cl/1973043

be97fa4c

runtime: fix another stack split bug · e2bde5cf

Russ Cox authored Aug 13, 2010

Makes godoc --http=:1234 not crash on linux/amd64.

R=r
CC=golang-dev
https://golang.org/cl/1975044

e2bde5cf

os: implement env using native windows api. · 79c62aaa
Alex Brainman authored Aug 13, 2010
```
Fixes #864.

R=rsc
CC=golang-dev
https://golang.org/cl/1975043
```
79c62aaa
delete pkg/once · a621a7ef
Rob Pike authored Aug 13, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1995041
```
a621a7ef

12 Aug, 2010 17 commits

codereview: do not send "Abanoned" mail if this CL has · 7886318c
Russ Cox authored Aug 12, 2010
```
not been mailed out for review.

R=r
CC=golang-dev
https://golang.org/cl/1962046
```
7886318c
partial correction for CL 1983043: fix various godoc-related regexp calls · 10ae88f4
Robert Griesemer authored Aug 12, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1987041
```
10ae88f4
regexp: delete the deprecated methods and tests. · 079a1174
Rob Pike authored Aug 12, 2010
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/1956044
```
079a1174
codereview.py: Fix issues with leading tabulation in the Files: section of CL description. · e8b8aeb0
Ivan Krasin authored Aug 12, 2010
```
R=imkrasin, rsc
CC=golang-dev
https://golang.org/cl/1943042
```
e8b8aeb0

net: make IPv6 String method standards compliant · e41987c8

Mikio Hara authored Aug 12, 2010

draft-ietf-6man-text-addr-representation-07 will introduce
a canonical textual representation format for IPv6 address.

R=rsc
CC=golang-dev
https://golang.org/cl/1856047

e41987c8

update the tree to use the new regexp methods · d31ee536
Rob Pike authored Aug 12, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1983043
```
d31ee536

testing: delete the less useful methods in the testing regexp package · 4fb58832

Rob Pike authored Aug 12, 2010

We can add them back using the new naming scheme should it become important.

R=rsc
CC=golang-dev
https://golang.org/cl/1968042

4fb58832

re-tag release.2010-08-11 · 6e633025
Andrew Gerrand authored Aug 12, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1983042
```
6e633025
tag release.2010-08-11 · 2eff4f95
Andrew Gerrand authored Aug 12, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1951043
```
2eff4f95
release.2010-08-11 · 9e23f2b2
Andrew Gerrand authored Aug 12, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1954044
```
9e23f2b2
6g, 8g: handle slice by sub-word-sized index (uint8, int8, uint16, int16) · 1d77ff5b
Russ Cox authored Aug 12, 2010
```
R=ken2
CC=golang-dev
https://golang.org/cl/1960042
```
1d77ff5b
A+C: Mikio Hara (individual CLA) · 879b5a02
Russ Cox authored Aug 12, 2010
```
R=adg
CC=golang-dev
https://golang.org/cl/1971042
```
879b5a02

gopack: handle long lines in export data · 26dde76c

Russ Cox authored Aug 12, 2010

Also, if the header is bad, exit with a non-zero status.

Other calls to Brdline in the tree, by category:

Reading symbol name from object file:
./cmd/5l/obj.c:486: 		name = Brdline(f, '\0');
./cmd/6l/obj.c:535: 		name = Brdline(f, '\0');
./cmd/8l/obj.c:564: 		name = Brdline(f, '\0');
./libmach/sym.c:292: 		cp = Brdline(bp, '\0');

Reading archive header line (fixed, short):
./cmd/gc/lex.c:287: 	if((a = Brdline(b, '\n')) == nil)
./cmd/gc/lex.c:303: 	if((p = Brdline(b, '\n')) == nil)

Reading object file header line (fixed, short):
./cmd/ld/lib.c:421: 	line = Brdline(f, '\n');

Reading undefined symbol list (unused code):
./cmd/ld/lib.c:773: 	while((l = Brdline(b, '\n')) != nil){

Implementing Brdstr:
./libbio/brdstr.c:36: 		p = Brdline(bp, delim);

The symbol names ones will cause a problem loudly if they
fail: they'll error out with symbol name too long.  This means
that you can't define an enormous struct without giving the
type a name and then stick it in an interface, because the
type's symbol name will be too long for the object file.
Since this will be a loud failure instead of a silent one,
I'm willing to wait until it comes up in practice.

R=r
CC=golang-dev
https://golang.org/cl/1982041

26dde76c

5g, 8g: dead code (already removed from 6g) · 14e0df34
Russ Cox authored Aug 12, 2010
```
R=ken2
CC=golang-dev
https://golang.org/cl/1983041
```
14e0df34

regexp: new regularized methods for matching. · 6610d79e

Rob Pike authored Aug 12, 2010

The previous set was spotty, incomplete, and confusing.
This CL proposes a regular, clean set with clearer names.
It's also complete.  Many existing methods will be deprecated,
but not in this CL.  Ditto for the tests.

R=rsc, gri
CC=golang-dev, rog
https://golang.org/cl/1946041

6610d79e

gofmt: if a semicolon is found unexpectedly, report detailed cause · d7507497

Robert Griesemer authored Aug 12, 2010

go/scanner: return information on semicolon (real or inserted) when
	    found in source
go/parser:  better error message when a semicolon is found unexpectedly

For instance, if an unexpected semicolon is found that was automatically
inserted, the parser error message is now:

    "expected '}', found newline"

Fixes #1006.

R=rsc
CC=golang-dev
https://golang.org/cl/1936044

d7507497

sync.once: document that Do cannot be invoked recursively. · 32a81fa8
Rob Pike authored Aug 12, 2010
```
documentation change only.

R=rsc
CC=golang-dev
https://golang.org/cl/1964043
```
32a81fa8

11 Aug, 2010 5 commits

Small performance improvements to the HTML tokenizer based on your 'TODO's. · 8fcdc6a1
Kyle Consalus authored Aug 11, 2010
```
R=nigeltao_golang
CC=golang-dev
https://golang.org/cl/1941042
```
8fcdc6a1

template: added ParseFile method for template.Template · bca31510

Scott Lawrence authored Aug 11, 2010

Fixes #971.

Parse/ParseFile methods of Template now match template.Parse and .ParseFile methods.
Also made tests being run on Parse and ParseFile be run on Template.ParseFile as well.

R=r
CC=golang-dev
https://golang.org/cl/1741059

bca31510

gc: bug302 · a9a62eef

Russ Cox authored Aug 11, 2010

Fixed by http://code.google.com/p/go/source/detail?r=d1f41e20a90e
This just adds a test and checks the return value of Bprint.

R=ken2
CC=golang-dev
https://golang.org/cl/1949042

a9a62eef

libbio: fix Bprint bug · 9d5da464

Russ Cox authored Aug 11, 2010

Make Bprint work even when the amount of output
exceeds the available buffer space.

R=r
CC=golang-dev
https://golang.org/cl/1968041

9d5da464

exp/draw: fix drawRGBA when x0 > x1 and we have to draw right-to-left. · 753c9b57
Nigel Tao authored Aug 11, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/1940042
```
753c9b57

10 Aug, 2010 11 commits
- rpc: catch errors from ReadResponseBody. · 2bf8741c
  Rob Pike authored Aug 10, 2010
```
Fixes #1014.

R=rsc
CC=golang-dev
https://golang.org/cl/1941041
```
  2bf8741c
- fix build: update exp/draw/draw_test.go · b0d0de59
  Robert Griesemer authored Aug 10, 2010
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/1962041
```
  b0d0de59
- godoc: report Status 404 if a pkg or file is not found · d7543094
  Robert Griesemer authored Aug 10, 2010
```
Fixes #1005.

R=rsc, r
CC=golang-dev
https://golang.org/cl/1935041
```
  d7543094
- asn1: remove superfluous if's, unused function · 9714c220
  Robert Griesemer authored Aug 10, 2010
```
R=adg
CC=golang-dev
https://golang.org/cl/1743059
```
  9714c220
- exp/draw: remove the Color, Point and Rectangle types. · 7d3173fc
  Nigel Tao authored Aug 10, 2010
```
image: introduce Transparent and Opaque.

R=r
CC=golang-dev
https://golang.org/cl/1947042
```
  7d3173fc
- gopack documentation: fixed typo · 4368a787
  Scott Lawrence authored Aug 10, 2010
```
(Removed extraneous "program".)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/1950041
```
  4368a787
- image: fix comment typo. · d4e23b7e
  Nigel Tao authored Aug 10, 2010
```
R=adg
CC=golang-dev
https://golang.org/cl/1952041
```
  d4e23b7e
- image: change image representation from slice-of-slices to linear buffer, · b50a3d95
  Nigel Tao authored Aug 10, 2010
```
stride and rect.

R=r
CC=golang-dev, rog
https://golang.org/cl/1849041
```
  b50a3d95
- First cut of an HTML tokenizer (and eventually a parser). · 56b989f1
  Nigel Tao authored Aug 10, 2010
```
R=r, rsc, gri, rsc1
CC=golang-dev
https://golang.org/cl/1814044
```
  56b989f1
- exp/draw/x11: temporarily workaround compiler bug 1011. · 96d7c8d4
  Nigel Tao authored Aug 10, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/1951041
```
  96d7c8d4
- png: grayscale support. · 90a6c918
  Mathieu Lonjaret authored Aug 10, 2010
```
R=nigeltao_golang, r
CC=golang-dev
https://golang.org/cl/1897049
```
  90a6c918