- 12 Nov, 2015 40 commits
-
-
Shenghou Ma authored
Change-Id: I22216df83898e560cfe6d97344f05e3678c2db99 Reviewed-on: https://go-review.googlesource.com/16872Reviewed-by: Michael Matloob <matloob@golang.org>
-
Michael Matloob authored
Somehow these were left out of the orignial CL. Updates #11647 Change-Id: I058a30eaa25fbb72d60e7fb6bc9ff0a3b54fdb2a Reviewed-on: https://go-review.googlesource.com/16870Reviewed-by: Minux Ma <minux@golang.org>
-
Alberto Bertogli authored
Calling flag.Parse twice can be problematic if other goroutines called flag.Parsed in between: the race detector complains due to the write after read from a different goroutine. This can happen if TestMain calls flag.Parse and launches goroutines that call flag.Parsed, for example if it initializes a server which checks flags. This patch makes testing.M.Run only parse the flags if they have not been parsed already. Change-Id: Id9f8c31c5f90614e3f34c63d1a32cf7e9055d68e Reviewed-on: https://go-review.googlesource.com/16739Reviewed-by: Russ Cox <rsc@golang.org>
-
Austin Clements authored
The heap profile is only guaranteed to be up-to-date after two GC cycles, so force two GCs instead of just one. Updates #13098. Change-Id: I4fb9287b698f4a3b90b8af9fc6a2efb3b082bfe5 Reviewed-on: https://go-review.googlesource.com/16848Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
-
Michael Matloob authored
I made a copy of the per-arch _CacheLineSize definitons when checking in runtime/internal/atomic. Now that runtime/internal/sys is checked in, we can use the definition there. Change-Id: I7242f6b633e4164f033b67ff471416b9d71c64d2 Reviewed-on: https://go-review.googlesource.com/16847Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Austin Clements authored
sigprof tracebacks the stack across systemstack switches to make profile tracebacks more complete. However, it does this even if the user stack is currently being copied, which means it may be in an inconsistent state that will cause the traceback to panic. One specific way this can happen is during stack shrinking. Some goroutine blocks for STW, then enters gchelper, which then assists with root marking. If that root marking happens to pick the original goroutine and its stack needs to be shrunk, it will begin to copy that stack. During this copy, the stack is generally inconsistent and, in particular, the actual locations of the stack barriers and their recorded locations are temporarily out of sync. If a SIGPROF happens during this inconsistency, it will walk the stack all the way back to the blocked goroutine and panic when it fails to unwind the stack barriers. Fix this by disallowing jumping to the user stack during SIGPROF if that user stack is in the process of being copied. Fixes #12932. Change-Id: I9ef694c2c01e3653e292ce22612418dd3daff1b4 Reviewed-on: https://go-review.googlesource.com/16819Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Burcu Dogan authored
This reverts commit bc1f9d20. The current go-get strategy doesn't support cases that servers cannot handle shallow clients. Also, `go get -u` is broken and is not compatible with already go-getted unshallow repos. Fixes #13213. Fixes #13206. Change-Id: Ie89d7603d96d323db64ad82997793fda0972f709 Reviewed-on: https://go-review.googlesource.com/16832Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Michael Matloob authored
The file was automatically placed in the cl by a tool I had built. Since the compiler doesn't hook into the atomic package, it's unnecessary. Change-Id: I631fd876813b381bb12604865b00fc5b268dce84 Reviewed-on: https://go-review.googlesource.com/16844Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
I keep losing this utility, used as part of other tools to auto-update the AUTHORS and CONTRIBUTORS files. Check it in to the repo so I don't lose it, and so others can use it as well. Updates #12042 Change-Id: Ib5886b85799087aaaddcec4c81169e2726322c05 Reviewed-on: https://go-review.googlesource.com/16824Reviewed-by: Russ Cox <rsc@golang.org>
-
Russ Cox authored
Fixes #13214. Change-Id: Id8fbb252b8beadb0b41f839dcd85d6165dea86a3 Reviewed-on: https://go-review.googlesource.com/16845Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Matloob authored
runtime/internal/sys will hold system-, architecture- and config- specific constants. Updates #11647 Change-Id: I6db29c312556087a42e8d2bdd9af40d157c56b54 Reviewed-on: https://go-review.googlesource.com/16817Reviewed-by: Russ Cox <rsc@golang.org>
-
Austin Clements authored
The heapsampling.go test occasionally fails on some architectures because it finds zero heap samples in main.alloc. This happens because the byte and object counts are only updated at a GC. Hence, if a GC happens part way through allocInterleaved, but then doesn't happen after we start calling main.alloc, checkAllocations will see buckets for the lines in main.alloc (which are created eagerly), but the object and byte counts will be zero. Fix this by forcing a GC to update the profile before we collect it. Fixes #13098. Change-Id: Ia7a9918eea6399307f10499dd7abefd4f6d13cf6 Reviewed-on: https://go-review.googlesource.com/16846 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
-
Ian Lance Taylor authored
Correct an error in the last change: it caused runtime/cgo and runtime/race to not depend on runtime. Fixes #13214. Change-Id: Ib48b3b5e9a74567ddfaccb7ab4a897ee2aedc2b8 Reviewed-on: https://go-review.googlesource.com/16837Reviewed-by: Michael Matloob <matloob@golang.org>
-
Ralph Corderoy authored
Explictly list the alternative formats in each file. In AUTHORS, refer to CONTRIBUTORS' definition of multiple email addresses. Indent with four spaces; AUTHORS used a tab, but CONTRIBUTORS used four spaces. s/Rietveld/Gerrit/ Change the tab separating Sebastien Binet from his email address, added in 2010's 18b02f6c. Change-Id: Id52228ae6b62dd88ad8098110c22373bf14e068f Reviewed-on: https://go-review.googlesource.com/16826Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Matthew Dempsky authored
lfstack.go:19: println call ends with newline Change-Id: I2a903eef80a5300e9014999c2f0bc5d40ed5c735 Reviewed-on: https://go-review.googlesource.com/16836 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
-
Matthew Dempsky authored
cgo_ppc64x.go:7: +build comment must appear before package clause and be followed by a blank line Change-Id: Ib6dedddae70cc75dc3f137eb37ea338a64f8b595 Reviewed-on: https://go-review.googlesource.com/16835 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Shenghou Ma authored
Change-Id: I9161c4a7e747d35ad7643b8cf0fe8b66eaea963b Reviewed-on: https://go-review.googlesource.com/16842Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I22ea3352ad0794fc611334c2f2ec5f1e894985ce Reviewed-on: https://go-review.googlesource.com/14460Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Skip fixedbugs/issue10607.go because external linking is not supported yet. Skip nilptr3.go because of issue #9058 (same as ppc64). Change-Id: Ib3dfbd9a03ee4052871cf57c74b3cc5e745e1f80 Reviewed-on: https://go-review.googlesource.com/14461Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Yao Zhang authored
Change-Id: I419f3b8bf1bddffd4a775b0cd7b98f0239fe19cb Reviewed-on: https://go-review.googlesource.com/14458Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
Change-Id: Ib6f168b6a2daf3befbf75b4b95967ff91ac95d12 Reviewed-on: https://go-review.googlesource.com/14456Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
mips64 strace doesn't support sendfile64 and will error out if we specify that with `-e trace='. So we use sendfile for mips64 here. Change-Id: If5e2bb39866ca3a77dcc40e4db338ba486921d89 Reviewed-on: https://go-review.googlesource.com/14455Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Yao Zhang authored
Change-Id: I77c6768fff6f0163b36800307c4d573bb6521fe5 Reviewed-on: https://go-review.googlesource.com/14454Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
Change-Id: I05352749a852095baae2f67fd71ffcf5f727538d Reviewed-on: https://go-review.googlesource.com/14453Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I84ced3734410d3d05f195901f44d33f4ae6036b1 Reviewed-on: https://go-review.googlesource.com/14452Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
Change-Id: I5129a5b9dbbc57d97da723c2fc247bd28f951817 Reviewed-on: https://go-review.googlesource.com/14451Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: Ibe6c345afd4cbae7e2542a350043fbb6b81d5678 Reviewed-on: https://go-review.googlesource.com/14450Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Syscall getdents64 is relatively new in linux/mips64, only since kernel version 3.10. To support older kernel, syscall getdents is used for mips64. Change-Id: I892b05dff7d93e7ddb0d700abd6a5e6d4084ab4c Reviewed-on: https://go-review.googlesource.com/14449Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I574a2b702bb3db596f890ae7b18fb4bc1fd358d5 Reviewed-on: https://go-review.googlesource.com/14448Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Linux/mips64 uses a different signal table. To avoid code copying, signal table is factored out from signal_linux.go to sigtab_linux_generic.go. And a mips64-specific version is added. Change-Id: I842d7a7467c330bf772855fde01aecc77a42316b Reviewed-on: https://go-review.googlesource.com/14993Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
Linux/mips64 has a different sigset type and some different constants. os2_linux.go is renamed to os2_linux_generic.go, and not used in mips64. The corresponding file os2_linux_mips64x.go is added. Change-Id: Ief83845a2779f7fe048d236d3c7da52b627ab533 Reviewed-on: https://go-review.googlesource.com/14992Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Linux/mips64 uses a different type of sigset. To deal with it, related functions in os1_linux.go is refactored to os1_linux_generic.go (used for non-mips64 architectures), and os1_linux_mips64x.go (only used in mips64{,le}), to avoid code copying. Change-Id: I5cadfccd86bfc4b30bf97e12607c3c614903ea4c Reviewed-on: https://go-review.googlesource.com/14991Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Yao Zhang authored
Change-Id: I381c03d957a0dccae5f655f02e92760e5c0e9629 Reviewed-on: https://go-review.googlesource.com/14929Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
files for unsupported architectures are deleted, as it would require changing cmd/dist to recognize their names as build tags (probably need a separated CL). Change-Id: Ifd164b014867d39b4924d1b859fb84317dce4ab0 Reviewed-on: https://go-review.googlesource.com/14928Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I14b537922b97d4bce9e0523d98a822da906348f1 Reviewed-on: https://go-review.googlesource.com/14447Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: Ia496470e48b3c5d39fb9fef99fac356dfb73a949 Reviewed-on: https://go-review.googlesource.com/14927Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I2eaf0658771a0ff788429e2f503d116531166315 Reviewed-on: https://go-review.googlesource.com/16834Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
Change-Id: I9e94027ef66c88007107de2b2b75c3d7cf1352af Reviewed-on: https://go-review.googlesource.com/14467Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
The actual cgo is not supported for now. This is just the cgo command. Change-Id: I25625100ee552971f47e681b7d613cba16a2132f Reviewed-on: https://go-review.googlesource.com/14446Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
-
Yao Zhang authored
It is based on ppc64 compiler. Change-Id: I15a101df05f2919ba5292136957ba0009227d067 Reviewed-on: https://go-review.googlesource.com/14445Reviewed-by: Minux Ma <minux@golang.org>
-