- 31 Jul, 2012 3 commits
-
-
Rémy Oudompheng authored
The receive operator was given incorrect precedence resulting in incorrect deletion of parentheses. Fixes #3843. R=rsc CC=golang-dev, remy https://golang.org/cl/6442049
-
Mikio Hara authored
uuid_t is defined in unistd.h on OS X, unfortunately. R=iant, rsc CC=golang-dev https://golang.org/cl/6455057
-
Mikio Hara authored
R=rsc CC=golang-dev https://golang.org/cl/6398052
-
- 30 Jul, 2012 22 commits
-
-
Shenghou Ma authored
Android NDK's gcc 4.6 generates this relocation for runtime/cgo. R=rsc CC=golang-dev https://golang.org/cl/6450056
-
Shenghou Ma authored
LLVM-based gcc will place all-zero data in a zero-filled section, but our debug/macho can't handle that. Fixes #3821. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6444049
-
Bobby Powers authored
If the X-Forwarded-For header already exists on a request, we should append our client's IP to it after a comma+space instead of overwriting it. Fixes #3846. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6448053
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6448081
-
Han-Wen Nienhuys authored
This syscall was inadvertently exported when fixing Getrlimit/Setrlimit on 32-bit platforms. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6458051
-
Rob Pike authored
The situation only affects diagnostics but is easy to fix. When computing lineNumber, use the position of the last item returned by nextItem rather than the current state of the lexer. This is internal only and does not affect the API. Fixes #3886. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6445061
-
Rob Pike authored
Fixes #3878. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6457054
-
Rémy Oudompheng authored
The compiledir pattern compiles all files xxx.dir/*.go in lexicographic order (which is assumed to coincide with the topological order of dependencies). R=rsc CC=golang-dev, remy https://golang.org/cl/6440048
-
Russ Cox authored
To be filled in by a later CL. I deployed a test version to App Engine to work on setting the values, so there are a few records that have this field set already. That field is breaking the live version, so I have pushed a new copy with this 1-line change to the live version I assumed that appengine/datastore was like every other marshaling and unmarshaling package we have in Go (for example, encoding/gob, encoding/json, encoding/xml, and protobuf) and that if it loaded an unknown field it would just ignore it. Apparently not. Sorry. R=dsymonds TBR=dsymonds CC=golang-dev https://golang.org/cl/6454064
-
Rémy Oudompheng authored
They were previously ignored when deciding order and detecting dependency loops. Fixes #3824. R=rsc, golang-dev CC=golang-dev, remy https://golang.org/cl/6455055
-
Andrew Gerrand authored
R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/6442062
-
David Symonds authored
R=bradfitz CC=gobot, golang-dev, rsc https://golang.org/cl/6457052
-
Russ Cox authored
Also, sort output. R=golang-dev, patrick, dave, iant CC=golang-dev, patrick https://golang.org/cl/6446064
-
David Symonds authored
R=rsc CC=golang-dev https://golang.org/cl/6453063
-
David Symonds authored
R=rsc CC=golang-dev https://golang.org/cl/6457051
-
Brad Fitzpatrick authored
Should probably be fixed in the syscall package, either additional or instead of this CL. Fixes #3842 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6442061
-
David Symonds authored
This is the state when the CL has been submitted by someone other than the CL author, but before the CL author has synched their client. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6458044
-
Daniel Morsing authored
Fixes #3856. R=dsymonds, rsc CC=golang-dev https://golang.org/cl/6455056
-
David Symonds authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6449060
-
David Symonds authored
R=golang-dev, rsc, minux.ma CC=golang-dev https://golang.org/cl/6454062
-
David Symonds authored
A "NOT LGTM" overrules a previous "LGTM" by the same person, and vice versa. "NOT LGTM"s are shown in the same location as LGTMs, colored red. R=rsc CC=golang-dev https://golang.org/cl/6453062
-
Brad Fitzpatrick authored
This fixes a data race (usually just harmlessly updating "GET" to "GET"), but also follows RFC 2616 Sec 5.1.1 which says that the request method is case-sensitive. Fixes #3881 R=golang-dev, rsc, dsymonds CC=golang-dev https://golang.org/cl/6446063
-
- 29 Jul, 2012 6 commits
-
-
Russ Cox authored
This comment was suggested in CL 6456045 but never got applied. R=mikioh, mikioh.mikioh CC=golang-dev https://golang.org/cl/6447056
-
Alexey Borzenkov authored
Darwin kernels have a bug in accept() where error result from an internal call is not checked and socket is accepted instead of ECONNABORTED error. However, such sockets have no sockaddr, which results in EAFNOSUPPORT error from anyToSockaddr, making Go http servers running on Mac OS X easily susceptible to denial of service from simple port scans with nmap. Fixes #3849. R=golang-dev, adg, mikioh.mikioh CC=golang-dev https://golang.org/cl/6456045
-
Benny Siegert authored
Copy over freebsd.c to netbsd.c. Fixes #3823. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6398045
-
David Symonds authored
If a factored import group has a blank line, assume it is dividing separate groups of imports (e.g. standard library vs. site-specific). import ( "bytes" "io" "mycorp/package" ) The most common case is inserting new standard library imports, which are usually (stylistically) the first group, so we should drop "net" in the above example immediately after "io". Since this logic is getting non-trivial, add a test. R=golang-dev, minux.ma, franciscossouza CC=golang-dev https://golang.org/cl/6445043
-
Han-Wen Nienhuys authored
R=golang-dev, minux.ma, r, rsc CC=golang-dev https://golang.org/cl/6353069
-
Andrew Balholm authored
Pass 5 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6452055
-
- 28 Jul, 2012 2 commits
-
-
Ian Lance Taylor authored
Fixes #3874. R=golang-dev, nj, r, minux.ma CC=golang-dev https://golang.org/cl/6446060
-
Marcel van Lohuizen authored
- Allow handles into the trie for different locales. Multiple tables share the same try to allow for reuse of blocks. - Significantly improved memory footprint and reduced allocations of trieNodes. This speeds up generation by about 30% and allows keeping trieNodes around for multiple locales during generation. - Renamed print method to fprint. R=r CC=golang-dev https://golang.org/cl/6408052
-
- 27 Jul, 2012 7 commits
-
-
Rob Pike authored
Fixes #3869. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6448072
-
Shenghou Ma authored
pkg log already appends a linefeed to the log message, so log/syslog doesn't need to append another. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/6441048
-
Alex Brainman authored
R=golang-dev CC=golang-dev https://golang.org/cl/6450058
-
Dmitriy Vyukov authored
Fixes #3860. R=golang-dev, adg CC=golang-dev https://golang.org/cl/6443051
-
Ian Lance Taylor authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6445049
-
Andrew Balholm authored
Also convert NUL to U+FFFD in comments. Pass 23 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6446055
-
Ian Lance Taylor authored
When a cgo program calls setuid, setgid, etc., the GNU/Linux pthread library sends signal SIGSETXID to each thread to tell it to update its UID info. If Go is permitted to intercept the default SIGSETXID signal handler, the program will hang. This patch tells the runtime package to not try to intercept SIGSETXID on GNU/Linux. This will be odd if a Go program wants to try to use that signal, but it means that cgo programs that call setuid, etc., won't hang. Fixes #3871. R=rsc, r, minux.ma, bradfitz CC=golang-dev https://golang.org/cl/6455050
-