- 11 Jun, 2018 1 commit
-
-
Thanabodee Charoenpiriyakij authored
TOKEN_ALL_ACCESS was changed at some stage by Microsoft. Updates #25775 Change-Id: I3e18914207a0020b2ebfb99f4e57aa55f9de813b Reviewed-on: https://go-review.googlesource.com/117635 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
- 10 Jun, 2018 2 commits
-
-
Agniva De Sarker authored
Although not part of http://mimesniff.spec.whatwg.org, for WASM streaming compilation to happen, the response needs to have the application/wasm MIME type as mentioned here: https://webassembly.github.io/spec/web-api/index.html#streaming-modules. And all current browsers prevent streaming compilation from happening if this MIME type is not present in the response. The magic number is mentioned here: https://webassembly.org/docs/binary-encoding Since we are already adding WASM support, it makes sense to support this MIME type. Change-Id: I8dd7b413a8c438a5c23c29d843b42f6da2a20ba4 Reviewed-on: https://go-review.googlesource.com/113396Reviewed-by:
Richard Musiol <neelance@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Caleb Spare authored
Users of this field are better off using Result instead. Fixes #25763. Change-Id: I4391afa6ed3873107628630adc1d409d77fb3f20 Reviewed-on: https://go-review.googlesource.com/117675Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 09 Jun, 2018 2 commits
-
-
Alex Brainman authored
Fixes #24725 Change-Id: I2864b88315ab15be036e8940d0a5884d876698d6 Reviewed-on: https://go-review.googlesource.com/115975 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Mark Rushakoff authored
Change-Id: I90ba0a6e0c6ccdce16938eed09424308a84fc6fb GitHub-Last-Rev: 66b6db1a674e6817209a69a7ccd1846d3b0e1900 GitHub-Pull-Request: golang/go#25801 Reviewed-on: https://go-review.googlesource.com/117575Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 08 Jun, 2018 7 commits
-
-
Ian Lance Taylor authored
The Solaris assembler uses a different syntax for section directives. Fixes https://gcc.gnu.org/PR85429. Change-Id: I1e54dffee3290046dbb68ba4e90ab795c6b72571 Reviewed-on: https://go-review.googlesource.com/109140 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Iskander Sharipov authored
This is extension to https://golang.org/cl/113955 that handled duplicated "unresolved relocation" errors. For platforms with trampoline support, additional error is generated per each undefined symbol. This breaks TestUndefinedRelocErrors test on these platforms. Proposed fix: 1. Changes error text to be identical to normal undefined reloc. If relocation is undefined, jump to it will be unresolved as well. 2. Introduces a map that can be used by all sites that handle this kind of errors which makes it easier to report such errors exactly once. Errors on ppc64 before this change (note first 4 lines): main.defined1: unresolved inter-package jump to main.undefined() main.defined1: unresolved inter-package jump to main.undefined() main.defined2: unresolved inter-package jump to main.undefined() main.defined2: unresolved inter-package jump to main.undefined() main.defined1: relocation target main.undefined not defined main.defined2: relocation target main.undefined not defined runtime.main_main·f: function main is undeclared in the main package After this change: main.defined1: relocation target main.undefined not defined main.defined2: relocation target main.undefined not defined runtime.main_main·f: function main is undeclared in the main package Because of (1), errors output is the same on all platforms now. Fixes #25753 Change-Id: Ic3084202a6fc5d4a6d2d0a93344f012b37fe58ed Reviewed-on: https://go-review.googlesource.com/116676 Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Richard Musiol authored
os.Args is usually never empty and the flag package panics if it is. This commit makes os.Args default to ["js"] for js/wasm. Change-Id: Iba527145686487b052da438fca40159e57e61a81 Reviewed-on: https://go-review.googlesource.com/117475Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
philhofer authored
On 32-bit architectures without native 64-bit atomic instructions, 64-bit atomics are emulated using spinlocks. However, the sigprof handling code expects to be able to perform 64-bit atomic operations in signal handlers. Spinning on an acquired spinlock in a signal handler leads to a livelock. This is issue #20146. The original fix for #20146 did not include arm in the list of architectures that need to work around portability issues in the sigprof handler code. The unit test designed to catch this issue does not fail on arm builds because arm uses striped spinlocks, and thus the livelock takes many minutes to reproduce. This is issue #24260. (This patch doesn't completely fix #24260 on go1.10.2 due to issue #25785, which is probably related to the arm cas kernel helpers. Those have been removed at tip.) With this patch applied, I was able to run the reproducer for issue #24260 for more than 90 minutes without reproducing the livelock. Without this patch, the livelock took as little as 8 minutes to reproduce. Fixes #20146 Updates #24260 Change-Id: I64bf53a14d53c4932367d919ac55e17c99d87484 Reviewed-on: https://go-review.googlesource.com/117057 Run-TryBot: Philip Hofer <phofer@umich.edu> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
David du Colombier authored
CL 116975 added TestCoverHTML. However, this test is failing on Plan 9, because the GNU diff tool is called "ape/diff" instead of "diff" on Plan 9. This change replaces the "diff" command by the "ape/diff" command on Plan 9. Fixes #25795. Change-Id: I15b49868cd09f3f977aa13fffdfc430c882bf757 Reviewed-on: https://go-review.googlesource.com/117415 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
Daniel Martí <mvdan@mvdan.cc> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Keith Randall authored
Turns out it doesn't currently matter, as these ops are always issued together with a BTSL which does clobber flags. So I can't write a test that currently fails. But better to be future-proof. BS{F,R}Q generates flags, so it doesn't need to be marked as clobbering. Change-Id: I70daea154023fd435fac696bf3a384803c647cd3 Reviewed-on: https://go-review.googlesource.com/117375 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by:
Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Symonds authored
Solaris diff doesn't know about -d (a.k.a. --minimal). Change-Id: I86146b4b93e3d0bdea52a0fde59afca20b5bab51 Reviewed-on: https://go-review.googlesource.com/117335Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 07 Jun, 2018 18 commits
-
-
David Symonds authored
This is a refinement of CL 114855, which fixed the empty clause case, but broke some other cases where segment boundaries can coincide for other reasons. Fixes #25767. Change-Id: I2a387c83f9d651c8358f3e11b03f6167af0eb8bf Reviewed-on: https://go-review.googlesource.com/116976 Run-TryBot: David Symonds <dsymonds@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Robert Griesemer authored
This change improves upon cycle detection by taking into account cycles involving constants, variables, _and_ types. All new code (except for the additional tests) is guarded by the useCycleMarking (internal) flag and thus can be disabled on short notice if it introduced new problems. (The intent is to remove this flag shortly after 1.11 is released.) The test suite has been extended with various additional (and mostly esoteric) test cases which now correctly report cycles. A handful of existing test cases now report additional errors, but those are mostly esoteric cases. Overall, this is an improvement over the status quo. Fixes #8699. For #20770. Change-Id: I6086719acd0d5200edca4a3dbe703d053496af31 Reviewed-on: https://go-review.googlesource.com/116815 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Alan Donovan <adonovan@google.com>
-
David Symonds authored
This adds a case for what was fixed in 4fe688c6 to prevent regression; a follow-on change will address #25767. Change-Id: Iced8cc10e2993ef7caf7e9c59ffbc7147d78ddd7 Reviewed-on: https://go-review.googlesource.com/116975 Run-TryBot: David Symonds <dsymonds@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
David Symonds authored
If a package is checked out in the right place, but uses, for instance, an unusual Git remote configuration, don't refuse to update just because cmd/go can't parse it. In most cases, `git pull -ff-only` (or the equivalent in other VCSes) works just fine. Updates #25432. Change-Id: I1952a0e6e03f185f34029b186e1756c9549689e1 Reviewed-on: https://go-review.googlesource.com/113456 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Andrew Gerrand <adg@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Filippo Valsorda authored
Users are sometimes confused why session tickets are not enabled even if SessionTicketsDisabled is false. Change-Id: I3b783d2cf3eed693a3ad6acb40a8003db7e0b648 Reviewed-on: https://go-review.googlesource.com/117255Reviewed-by:
Adam Langley <agl@golang.org>
-
Bryan C. Mills authored
Prior to CL 108156, "go list" exited with code 0 if there were missing binary packages. Restore that behavior to fix the failing TestBinaryOnlyPackages. Fixes golang/go#25784. Change-Id: Iaeca6bcc840f5ac8f2a016cef131f5c59a8261a8 Reviewed-on: https://go-review.googlesource.com/117036Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes #20849 Change-Id: If2a330185aa7e95eb84dccdbc4c7f3e9b970cca1 Reviewed-on: https://go-review.googlesource.com/117056Reviewed-by:
Matti Moell <matti.moell@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Updates #25784 Change-Id: I638eab82b026d3df89da532b5cc3f5c06b02d6c8 Reviewed-on: https://go-review.googlesource.com/117075Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Adam Langley authored
Code has ended up depending on things like RSA's key generation being deterministic given a fixed random Reader. This was never guaranteed and would prevent us from ever changing anything about it. This change makes certain calls randomly (based on the internal fastrand) read an extra byte from the random Reader. This helps to ensure that code does not depend on internal details. I've not added this call in the key generation of ECDSA and DSA because, in those cases, key generation is so obvious that it probably is acceptable to do the obvious thing and not worry about code that depends on that. This does not affect tests that use a Reader of constant bytes (e.g. a zeroReader) because shifting such a stream is a no-op. The stdlib uses this internally (which is fine because it can be atomically updated if the crypto libraries change). It is possible that external tests could be doing the same and would thus break if we ever, say, tweaked the way RSA key generation worked. I feel that addressing that would be more effort than it's worth. Fixes #21915 Change-Id: I84cff2e249acc921ad6eb5527171e02e6d39c530 Reviewed-on: https://go-review.googlesource.com/64451Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
CL 113837 introduced some changes which were not properly gofmt'ed, fix them. Change-Id: I89329063f9c468238051e45380d752e66efdb939 Reviewed-on: https://go-review.googlesource.com/116895 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Zhou Peng authored
Change-Id: Ie355f06e9be93d7f7501f697a94ff83d6d0826a2 Reviewed-on: https://go-review.googlesource.com/114556Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
cch123 authored
Change-Id: Idd88a1d9420545e3e326f8e3b57a38d8c7515555 GitHub-Last-Rev: 59528f552238eb4070cb9a66c1dbfafd6bc3808d GitHub-Pull-Request: golang/go#25779 Reviewed-on: https://go-review.googlesource.com/116935Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
These got lost because I violated the cardinal rule of Gerrit which is never click the Submit button in the web UI. Change-Id: I8ccdfb5d8691960f244941036d33fb5a5a3f0c9a Reviewed-on: https://go-review.googlesource.com/117015Reviewed-by:
Russ Cox <rsc@golang.org>
-
Agniva De Sarker authored
This is needed when we are re-building to the wasm target. Fixes #25774 Change-Id: I5dc47bd7e56c8570b8d2485273ef0d10f2feac6f Reviewed-on: https://go-review.googlesource.com/116915Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
We want package analysis tools to be able to ask cmd/go for cgo-translated files and for the names of files holding export type information, instead of reinventing that logic themselves. Allow them to do so, with the new list -cgo and -export flags. Change-Id: I860df530d8dcc130f1f328413381b5664cc81c3b Reviewed-on: https://go-review.googlesource.com/108156 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
Bryan C. Mills <bcmills@google.com>
-
Tobias Klauser authored
They are unused since CL 114799. Also remove consts _CTL_KERN and _KERN_OSRELEASE previously used by getDarwinVersion. Change-Id: I51b701e8effbe4dd4301b0e6d52e8885469032f4 Reviewed-on: https://go-review.googlesource.com/116955 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
hellozee authored
Removing the colon will make the "Usage" and "Command line flag syntax" in the docs, a header when interpreted by godoc. Fixes #25749 Change-Id: Ifc5572e171db1aaef9775b1d6c86091a8f2528fd GitHub-Last-Rev: 1b579734308cbcb96f17d945b9c7af70e259cb5b GitHub-Pull-Request: golang/go#25750 Reviewed-on: https://go-review.googlesource.com/116555Reviewed-by:
Rob Pike <r@golang.org>
-
212472270 authored
This function was added during the Go 1.11 dev cycle and isn't part of the API compatibility promise yet. In the previous implementation, NewGCMWithNonceAndTagSize was being used as a helper function for NewGCM, NewGCMWithTagSize, and NewGCMWithNonceSize. With the removal of Nonce size from the name and parameters, we needed to add an unexported helper function newGCMWithNonceAndTagSize. Fixes #24977 Change-Id: Ie70f2a192d0556c4f890deb62e68cff6bbbccd33 Reviewed-on: https://go-review.googlesource.com/116435Reviewed-by:
Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 06 Jun, 2018 10 commits
-
-
David Chase authored
This line of the inlining tuning experiment https://go-review.googlesource.com/c/go/+/109918/1/src/cmd/compile/internal/gc/inl.go#347 was incorrectly rewritten in a later patch to use the call cost, not the panic cost, and thus the inlining of panic didn't occur when it should. I discovered this when I realized that tests should have failed, but didn't. Fix is to make the correct change, and also to modify the tests that this causes to fail. One test now asserts the new normal, the other calls "ppanic" instead which is designed to behave like panic but not be inlined. Change-Id: I423bb7f08bd66a70d999826dd9b87027abf34cdf Reviewed-on: https://go-review.googlesource.com/116656 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Keith Randall <khr@golang.org>
-
https://golang.org/cl/116735Robert Griesemer authored
Missed this in the prior submit. For #24182. Change-Id: If8349d39c80b7ff57bc0c857985f9e52241321b8 Reviewed-on: https://go-review.googlesource.com/116775 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Robert Griesemer authored
Such errors are likely spurious and caused by previously reported errors; they don't add valuable information. Simply drop them. Fixes #24182. Change-Id: I0ac48c41647c628aa7636b29eaedfd9d01913762 Reviewed-on: https://go-review.googlesource.com/116735Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Eugene Kalinin authored
Fixes #25330 Change-Id: I41b5b3459ed7808d18112ec02d734e2268099a81 Reviewed-on: https://go-review.googlesource.com/116596Reviewed-by:
Daniel Theophanes <kardianos@gmail.com>
-
Suriyaa Sundararuban authored
Change-Id: I77e31954f6d92f769934843bbba9f990f330f50a Reviewed-on: https://go-review.googlesource.com/116675Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
SecKeychainItemExport is deprecated as of macOS 10.7. The minimum supported version is macOS 10.10, so use SecItemExport instead. While at it also bump macosx-version-min to 10.10 and __MAC_OS_X_VERSION_MAX_ALLOWED to 101300 (for macOS 10.13). Tested on macOS 10.10, 10.11 and 10.12. Updates #23122 Change-Id: Id4cd6a5cea93315791253dc248e40e5615760a6c Reviewed-on: https://go-review.googlesource.com/116396Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Yury Smolsky authored
Every action has a short annotation. The errorCheck function has a comment adapted from errchk script. Removed redundant assigments to tmpDir. Change-Id: Ifdd1284de046a0ce2aad26bd8da8a8e6a7707a8e Reviewed-on: https://go-review.googlesource.com/115856 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Richard Musiol authored
The wasm archtecture was missing a rule to handle OffPtr with a negative offset. This commit makes it so OffPtr always gets lowered to I64AddConst. Fixes #25741 Change-Id: I1d48e2954e3ff31deb8cba9a9bf0cab7c4bab71a Reviewed-on: https://go-review.googlesource.com/116595Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com>
-
Ian Lance Taylor authored
Updates #25284 Change-Id: I8ca382dd85b428ad6899d9277cf7f3ce34e35e9a Reviewed-on: https://go-review.googlesource.com/116416 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Than McIntosh <thanm@google.com>
-
Brad Fitzpatrick authored
Also, add a benchmark variant ("SkipServe") that only benchmarks the ServeMux handler selection path. name old time/op new time/op delta ServeMux_SkipServe-4 74.2µs ± 2% 60.6µs ± 1% -18.31% (p=0.000 n=10+9) name old alloc/op new alloc/op delta ServeMux_SkipServe-4 2.62kB ± 0% 0.00kB ±NaN% -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ServeMux_SkipServe-4 180 ± 0% 0 ±NaN% -100.00% (p=0.000 n=10+10) Updates #25383 Change-Id: Icfbb3b977e309093d032e922d1b4f254df6f5955 Reviewed-on: https://go-review.googlesource.com/116378 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Emmanuel Odeke <emm.odeke@gmail.com>
-