Skip to content

G
golang
Switch branch/tag
  1. 20 May, 2013 11 commits
  3. 19 May, 2013 2 commits
  5. 18 May, 2013 5 commits
  7. 17 May, 2013 8 commits
  9. 16 May, 2013 5 commits
  11. 15 May, 2013 9 commits
    • Robert Hencke's avatar
      reflect: use visit structure for map key in DeepEqual · f7b5a019
      Robert Hencke authored 
      R=golang-dev, bradfitz, jonathan, r
CC=golang-dev
https://golang.org/cl/8730044
      f7b5a019
    • Dmitriy Vyukov's avatar
      runtime: fix GC scanning of slices · c6293d21
      Dmitriy Vyukov authored 
      If a slice points to an array embedded in a struct,
the whole struct can be incorrectly scanned as the slice buffer.
Fixes #5443.

R=cshapiro, iant, r, cshapiro, minux.ma
CC=bradfitz, gobot, golang-dev
https://golang.org/cl/9372044
      c6293d21
    • Rob Pike's avatar
      misc/dashboard/codereview: add cshapiro and mpvl to reviewers list. · 9e643ac2
      Rob Pike authored 
      R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/9104052
      9e643ac2
    • Dmitriy Vyukov's avatar
      runtime: add simple malloc benchmarks · 915784e1
      Dmitriy Vyukov authored 
      Allocs of size 16 can bypass atomic set of the allocated bit, while allocs of size 8 can not.
Allocs with and w/o type info hit different paths inside of malloc.
Current results on linux/amd64:
BenchmarkMalloc8	50000000	        43.6 ns/op
BenchmarkMalloc16	50000000	        46.7 ns/op
BenchmarkMallocTypeInfo8	50000000	        61.3 ns/op
BenchmarkMallocTypeInfo16	50000000	        63.5 ns/op

R=golang-dev, remyoudompheng, minux.ma, bradfitz, iant
CC=golang-dev
https://golang.org/cl/9090045
      915784e1
    • Keith Randall's avatar
      runtime: Optimize aeshash a bit. Use a better predicted branch · ee66972d
      Keith Randall authored 
      for checking for page boundary.  Also avoid boundary check
when >=16 bytes are hashed.

benchmark                        old ns/op    new ns/op    delta
BenchmarkHashStringSpeed                23           22   -0.43%
BenchmarkHashBytesSpeed                 44           42   -3.61%
BenchmarkHashStringArraySpeed           71           68   -4.05%

R=iant, khr
CC=gobot, golang-dev, google
https://golang.org/cl/9123046
      ee66972d
    • Dmitriy Vyukov's avatar
      runtime: transfer whole span from MCentral to MCache · 23ad5631
      Dmitriy Vyukov authored 
      Finer-grained transfers were relevant with per-M caches,
with per-P caches they are not relevant and harmful for performance.
For few small size classes where it makes difference,
it's fine to grab the whole span (4K).

benchmark          old ns/op    new ns/op    delta
BenchmarkMalloc           42           40   -4.45%

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9374043
      23ad5631
    • Adam Langley's avatar
      crypto/rsa: check for minimal PKCS#1 v1.5 padding. · e85e6788
      Adam Langley authored 
      The PKCS#1 spec requires that the PS padding in an RSA message be at
least 8 bytes long. We were not previously checking this. This isn't
important in the most common situation (session key encryption), but
the impact is unclear in other cases.

This change enforces the specified minimum size.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9222045
      e85e6788
    • Adam Langley's avatar
      crypto/tls: ignore empty TLS records. · a1dbfee1
      Adam Langley authored 
      OpenSSL can be configured to send empty records in order to randomise
the CBC IV. This is an early version of 1/n-1 record splitting (that Go
does) and is quite reasonable, but it results in tls.Conn.Read
returning (0, nil).

This change ignores up to 100 consecutive, empty records to avoid
returning (0, nil) to callers.

Fixes 5309.

R=golang-dev, r, minux.ma
CC=golang-dev
https://golang.org/cl/8852044
      a1dbfee1
    • Adam Langley's avatar
      math/big: save some copies in binaryGCD. · 133cdb67
      Adam Langley authored 
      This patch resulted from a bit of quick optimisation in response to a
golang-nuts post. It looks like one could save a couple other copies in
this function, but this addresses the inner loop and is fairly simple.

benchmark                    old ns/op    new ns/op    delta
BenchmarkGCD10x10                 1964         1711  -12.88%
BenchmarkGCD10x100                2019         1736  -14.02%
BenchmarkGCD10x1000               2471         2171  -12.14%
BenchmarkGCD10x10000              6040         5778   -4.34%
BenchmarkGCD10x100000            43204        43025   -0.41%
BenchmarkGCD100x100              11004         8520  -22.57%
BenchmarkGCD100x1000             11820         9446  -20.08%
BenchmarkGCD100x10000            23846        21382  -10.33%
BenchmarkGCD100x100000          133691       131505   -1.64%
BenchmarkGCD1000x1000           120041        95591  -20.37%
BenchmarkGCD1000x10000          136887       113600  -17.01%
BenchmarkGCD1000x100000         295370       273912   -7.26%
BenchmarkGCD10000x10000        2556126      2205198  -13.73%
BenchmarkGCD10000x100000       3159512      2808038  -11.12%
BenchmarkGCD100000x100000    150543094    139986045   -7.01%

R=gri, remyoudompheng
CC=bradfitz, gobot, golang-dev, gri
https://golang.org/cl/9424043
      133cdb67